PMD Results

The following document contains the results of PMD 5.1.2.

Files

info/magnolia/dam/app/assets/action/DirectUploadAction.java

Violation Line
Avoid unused constructor parameters such as 'damAppConfig'. 101

info/magnolia/dam/app/assets/browser/AssetContentClipboard.java

Violation Line
Unnecessary use of fully qualified name 'AssetResource.getResourceNodeFromAsset' due to existing import 'info.magnolia.dam.jcr.AssetNodeTypes.AssetResource' 87
Unnecessary use of fully qualified name 'AssetResource.EXTENSION' due to existing import 'info.magnolia.dam.jcr.AssetNodeTypes.AssetResource' 89
Unnecessary use of fully qualified name 'AssetResource.FILENAME' due to existing import 'info.magnolia.dam.jcr.AssetNodeTypes.AssetResource' 90
Useless parentheses. 91

info/magnolia/dam/app/assets/column/AssetNameColumnFormatter.java

Violation Line
Avoid unused private methods such as 'getIcon(Node)'. 106

info/magnolia/dam/app/assets/editor/AssetDetailSubApp.java

Violation Line
Avoid unused constructor parameters such as 'eventBus'. 75

info/magnolia/dam/app/assets/field/DamWorkbenchField.java

Violation Line
Useless parentheses. 83
Useless parentheses. 84

info/magnolia/dam/app/assets/form/action/SaveAssetFormAction.java

Violation Line
These nested if statements could be combined 9395

info/magnolia/dam/app/commands/ImportAssetZipCommand.java

Violation Line
Avoid unused constructor parameters such as 'damAppConfig'. 70

info/magnolia/dam/app/setup/migration/ChangeDataDmsReferenceToDamMigrationTask.java

Violation Line
An empty statement (semicolon) not part of a loop 119

info/magnolia/dam/app/setup/migration/CleanContentForDamMigrationTask.java

Violation Line
Avoid unused method parameters such as 'node'. 153
Avoid unused method parameters such as 'node'. 202

info/magnolia/dam/app/setup/migration/MoveDataWorkspaceToDamMigrationTask.java

Violation Line
These nested if statements could be combined 252259

info/magnolia/dam/app/setup/migration/MoveUploadedContentToDamMigrationTask.java

Violation Line
Overriding method merely calls super 9698

info/magnolia/dam/app/ui/field/factory/AssetsEnabledRichTextFieldFactory.java

Violation Line
Avoid unused constructor parameters such as 'contentConnector'. 103

info/magnolia/dam/app/ui/field/factory/DamUploadFieldFactory.java

Violation Line
Avoid unused constructor parameters such as 'subAppEventBus'. 84

info/magnolia/dam/app/ui/imageprovider/DamLinkImageProvider.java

Violation Line
Avoid unused private fields such as 'contentConnector'. 63