PMD Results

The following document contains the results of PMD 6.21.0.

Violations By Priority

Priority 3

info/magnolia/dam/app/assets/action/DirectUploadAction.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'damAppConfig'. 101

info/magnolia/dam/app/assets/editor/AssetDetailSubApp.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'eventBus'. 75

info/magnolia/dam/app/assets/form/action/SaveAssetFormAction.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 93–95

info/magnolia/dam/app/commands/ImportAssetZipCommand.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'damAppConfig'. 70

info/magnolia/dam/app/setup/DamAppVersionHandler.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'controlMigratorsRegistry'. 117

info/magnolia/dam/app/ui/field/factory/AssetsEnabledRichTextFieldFactory.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'contentConnector'. 103

info/magnolia/dam/app/ui/field/factory/DamUploadFieldFactory.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'subAppEventBus'. 86

info/magnolia/dam/app/ui/imageprovider/DamLinkImageProvider.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'contentConnector'. 63

Priority 4

info/magnolia/dam/app/assets/browser/AssetContentClipboard.java

Rule Violation Line
UselessParentheses Useless parentheses. 87
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'AssetResource.getResourceNodeFromAsset' due to existing static import 'info.magnolia.dam.jcr.AssetNodeTypes.AssetResource.*' 87
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'AssetResource.EXTENSION' due to existing static import 'info.magnolia.dam.jcr.AssetNodeTypes.AssetResource.*' 89
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'AssetResource.FILENAME' due to existing static import 'info.magnolia.dam.jcr.AssetNodeTypes.AssetResource.*' 90
UselessParentheses Useless parentheses. 91

info/magnolia/dam/app/assets/field/DamWorkbenchField.java

Rule Violation Line
UselessParentheses Useless parentheses. 89
UselessParentheses Useless parentheses. 90

info/magnolia/dam/app/setup/DamAppVersionHandler.java

Rule Violation Line
UselessParentheses Useless parentheses. 486

Files

info/magnolia/dam/app/assets/action/DirectUploadAction.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'damAppConfig'. 3 101

info/magnolia/dam/app/assets/browser/AssetContentClipboard.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 87
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'AssetResource.getResourceNodeFromAsset' due to existing static import 'info.magnolia.dam.jcr.AssetNodeTypes.AssetResource.*' 4 87
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'AssetResource.EXTENSION' due to existing static import 'info.magnolia.dam.jcr.AssetNodeTypes.AssetResource.*' 4 89
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'AssetResource.FILENAME' due to existing static import 'info.magnolia.dam.jcr.AssetNodeTypes.AssetResource.*' 4 90
UselessParentheses Useless parentheses. 4 91

info/magnolia/dam/app/assets/editor/AssetDetailSubApp.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'eventBus'. 3 75

info/magnolia/dam/app/assets/field/DamWorkbenchField.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 89
UselessParentheses Useless parentheses. 4 90

info/magnolia/dam/app/assets/form/action/SaveAssetFormAction.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 93–95

info/magnolia/dam/app/commands/ImportAssetZipCommand.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'damAppConfig'. 3 70

info/magnolia/dam/app/setup/DamAppVersionHandler.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'controlMigratorsRegistry'. 3 117
UselessParentheses Useless parentheses. 4 486

info/magnolia/dam/app/ui/field/factory/AssetsEnabledRichTextFieldFactory.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'contentConnector'. 3 103

info/magnolia/dam/app/ui/field/factory/DamUploadFieldFactory.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'subAppEventBus'. 3 86

info/magnolia/dam/app/ui/imageprovider/DamLinkImageProvider.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'contentConnector'. 3 63