PMD Results
The following document contains the results of PMD 6.21.0.
Violations By Priority
Priority 3
info/magnolia/module/mail/MailConstants.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'PREFIX_USER': the field is declared in an interface type |
41 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'PREFIX_GROUP': the field is declared in an interface type |
43 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'PREFIX_ROLE': the field is declared in an interface type |
45 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'SMTP_SERVER': the field is declared in an interface type |
47 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'SMTP_PORT': the field is declared in an interface type |
49 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'SMTP_USER': the field is declared in an interface type |
51 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'SMTP_PASSWORD': the field is declared in an interface type |
53 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'SMTP_DEFAULT_HOST': the field is declared in an interface type |
55 |
AvoidUsingHardCodedIP |
Do not hard code the IP address |
55 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'SMTP_DEFAULT_PORT': the field is declared in an interface type |
57 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'SMTP_SEND_PARTIAL': the field is declared in an interface type |
59 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'MAIL_TEMPLATE_SIMPLE': the field is declared in an interface type |
61 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'MAIL_TEMPLATE_FREEMARKER': the field is declared in an interface type |
63 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'MAIL_TEMPLATE_MAGNOLIA': the field is declared in an interface type |
65 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'SMTP_SECURITY': the field is declared in an interface type |
67 |
info/magnolia/module/mail/MgnlMailFactory.java
info/magnolia/module/mail/app/main/MailMainView.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'setListener': the method is declared in an interface type |
45 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'setFormViewReduced': the method is declared in an interface type |
47 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'build': the method is declared in an interface type |
52 |
UnnecessaryModifier |
Unnecessary modifier 'public' on interface 'Listener': members of interface types are implicitly public |
57–69 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'save': the method is declared in an interface type |
62 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'reset': the method is declared in an interface type |
67 |
info/magnolia/module/mail/app/verify/MailVerifyView.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'addFormViewReduced': the method is declared in an interface type |
44 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'setListner': the method is declared in an interface type |
46 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'build': the method is declared in an interface type |
51 |
UnnecessaryModifier |
Unnecessary modifier 'public' on interface 'Listener': members of interface types are implicitly public |
56–68 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'sendSimpleMail': the method is declared in an interface type |
61 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'sendTemplateMail': the method is declared in an interface type |
66 |
info/magnolia/module/mail/templates/impl/SimpleEmail.java
info/magnolia/module/mail/util/MailUtil.java
Priority 4
info/magnolia/module/mail/templates/MailAttachment.java
info/magnolia/module/mail/templates/MgnlMultipartEmail.java
info/magnolia/module/mail/util/MailUtil.java
Files
info/magnolia/module/mail/MailConstants.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'PREFIX_USER': the field is declared in an interface type |
3 |
41 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'PREFIX_GROUP': the field is declared in an interface type |
3 |
43 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'PREFIX_ROLE': the field is declared in an interface type |
3 |
45 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'SMTP_SERVER': the field is declared in an interface type |
3 |
47 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'SMTP_PORT': the field is declared in an interface type |
3 |
49 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'SMTP_USER': the field is declared in an interface type |
3 |
51 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'SMTP_PASSWORD': the field is declared in an interface type |
3 |
53 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'SMTP_DEFAULT_HOST': the field is declared in an interface type |
3 |
55 |
AvoidUsingHardCodedIP |
Do not hard code the IP address |
3 |
55 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'SMTP_DEFAULT_PORT': the field is declared in an interface type |
3 |
57 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'SMTP_SEND_PARTIAL': the field is declared in an interface type |
3 |
59 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'MAIL_TEMPLATE_SIMPLE': the field is declared in an interface type |
3 |
61 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'MAIL_TEMPLATE_FREEMARKER': the field is declared in an interface type |
3 |
63 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'MAIL_TEMPLATE_MAGNOLIA': the field is declared in an interface type |
3 |
65 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'SMTP_SECURITY': the field is declared in an interface type |
3 |
67 |
info/magnolia/module/mail/MgnlMailFactory.java
Rule |
Violation |
Priority |
Line |
UnusedFormalParameter |
Avoid unused constructor parameters such as 'moduleRegistry'. |
3 |
78 |
info/magnolia/module/mail/app/main/MailMainView.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'setListener': the method is declared in an interface type |
3 |
45 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'setFormViewReduced': the method is declared in an interface type |
3 |
47 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'build': the method is declared in an interface type |
3 |
52 |
UnnecessaryModifier |
Unnecessary modifier 'public' on interface 'Listener': members of interface types are implicitly public |
3 |
57–69 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'save': the method is declared in an interface type |
3 |
62 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'reset': the method is declared in an interface type |
3 |
67 |
info/magnolia/module/mail/app/verify/MailVerifyView.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'addFormViewReduced': the method is declared in an interface type |
3 |
44 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'setListner': the method is declared in an interface type |
3 |
46 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'build': the method is declared in an interface type |
3 |
51 |
UnnecessaryModifier |
Unnecessary modifier 'public' on interface 'Listener': members of interface types are implicitly public |
3 |
56–68 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'sendSimpleMail': the method is declared in an interface type |
3 |
61 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'sendTemplateMail': the method is declared in an interface type |
3 |
66 |
info/magnolia/module/mail/templates/MailAttachment.java
info/magnolia/module/mail/templates/MgnlMultipartEmail.java
info/magnolia/module/mail/templates/impl/SimpleEmail.java
info/magnolia/module/mail/util/MailUtil.java