PMD Results

The following document contains the results of PMD 6.21.0.

Violations By Priority

Priority 3

info/magnolia/module/resources/ResourceLinker.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'templatingFunctions'. 87
UnusedFormalParameter Avoid unused constructor parameters such as 'aggregationStateProvider'. 87

info/magnolia/module/resources/loaders/ResourceLoader.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStream': the method is declared in an interface type 54
UnnecessaryModifier Unnecessary modifier 'public' on method 'isEnabled': the method is declared in an interface type 59

info/magnolia/module/resources/renderers/ReferenceResourceRenderer.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 118–121

info/magnolia/module/resources/setup/ResourceCleanUpTask.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'nodeStream': resource specifications are implicitly final 385
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'resourceStream': resource specifications are implicitly final 386
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final 397

info/magnolia/module/resources/setup/TemplateMigrationTask.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final 212

Priority 4

info/magnolia/module/resources/ResourceLinker.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.resourceloader.Resource' due to existing import 'info.magnolia.resourceloader.Resource' 175

info/magnolia/module/resources/mapping/URI2ResourcesRepositoryMapping.java

Rule Violation Line
UselessParentheses Useless parentheses. 114

info/magnolia/module/resources/setup/ResourceCleanUpTask.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'JcrResourceOrigin.BINARY_NODE_NAME' due to existing static import 'info.magnolia.resourceloader.jcr.JcrResourceOrigin.*' 361
UselessParentheses Useless parentheses. 361
UselessParentheses Useless parentheses. 367
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'JcrResourceOrigin.BINARY_NODE_NAME' due to existing static import 'info.magnolia.resourceloader.jcr.JcrResourceOrigin.*' 376

Files

info/magnolia/module/resources/ResourceLinker.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'templatingFunctions'. 3 87
UnusedFormalParameter Avoid unused constructor parameters such as 'aggregationStateProvider'. 3 87
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.resourceloader.Resource' due to existing import 'info.magnolia.resourceloader.Resource' 4 175

info/magnolia/module/resources/loaders/ResourceLoader.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStream': the method is declared in an interface type 3 54
UnnecessaryModifier Unnecessary modifier 'public' on method 'isEnabled': the method is declared in an interface type 3 59

info/magnolia/module/resources/mapping/URI2ResourcesRepositoryMapping.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 114

info/magnolia/module/resources/renderers/ReferenceResourceRenderer.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 118–121

info/magnolia/module/resources/setup/ResourceCleanUpTask.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'JcrResourceOrigin.BINARY_NODE_NAME' due to existing static import 'info.magnolia.resourceloader.jcr.JcrResourceOrigin.*' 4 361
UselessParentheses Useless parentheses. 4 361
UselessParentheses Useless parentheses. 4 367
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'JcrResourceOrigin.BINARY_NODE_NAME' due to existing static import 'info.magnolia.resourceloader.jcr.JcrResourceOrigin.*' 4 376
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'nodeStream': resource specifications are implicitly final 3 385
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'resourceStream': resource specifications are implicitly final 3 386
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final 3 397

info/magnolia/module/resources/setup/TemplateMigrationTask.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final 3 212