PMD Results
The following document contains the results of PMD 5.1.2.
Files
info/magnolia/module/templatingkit/ExtendedAggregationState.java
Violation |
Line |
Avoid unused private fields such as 'crossSiteAccess'. |
52 |
info/magnolia/module/templatingkit/badge/LicenseChecker.java
Violation |
Line |
Avoid empty catch blocks |
56–58 |
Avoid empty catch blocks |
66–68 |
info/magnolia/module/templatingkit/categorization/CategorizationSupport.java
Violation |
Line |
Avoid modifiers which are implied by the context |
52 |
Avoid modifiers which are implied by the context |
57 |
info/magnolia/module/templatingkit/dam/RenditionAwareJcrAssetProvider.java
Violation |
Line |
Avoid unused private fields such as 'log'. |
69 |
info/magnolia/module/templatingkit/dam/STKAssetRenderer.java
Violation |
Line |
Unnecessary use of fully qualified name 'MediaType.parse' due to existing import 'com.google.common.net.MediaType' |
161 |
Avoid unused private methods such as 'getBinaryProperty(JcrAsset)'. |
180 |
info/magnolia/module/templatingkit/functions/STKTemplatingFunctions.java
Violation |
Line |
Useless parentheses. |
126 |
info/magnolia/module/templatingkit/imaging/ImagingSupport.java
Violation |
Line |
Avoid modifiers which are implied by the context |
50 |
Avoid modifiers which are implied by the context |
52 |
Avoid modifiers which are implied by the context |
54 |
info/magnolia/module/templatingkit/imaging/Variation.java
Violation |
Line |
Avoid modifiers which are implied by the context |
47 |
Avoid modifiers which are implied by the context |
49 |
Avoid modifiers which are implied by the context |
51 |
info/magnolia/module/templatingkit/imaging/VariationRule.java
Violation |
Line |
Avoid modifiers which are implied by the context |
45 |
info/magnolia/module/templatingkit/imaging/generation/ImageOperationProvidingVariation.java
Violation |
Line |
Avoid empty catch blocks |
101 |
info/magnolia/module/templatingkit/navigation/Link.java
Violation |
Line |
Avoid modifiers which are implied by the context |
43 |
Avoid modifiers which are implied by the context |
44 |
Avoid modifiers which are implied by the context |
45 |
info/magnolia/module/templatingkit/navigation/NavigationItem.java
Violation |
Line |
Avoid unused private fields such as 'log'. |
54 |
info/magnolia/module/templatingkit/navigation/NavigationModel.java
Violation |
Line |
These nested if statements could be combined |
94–96 |
info/magnolia/module/templatingkit/resources/Resource.java
Violation |
Line |
Avoid unused private fields such as 'templatingFunctions'. |
76 |
info/magnolia/module/templatingkit/resources/STKResourceModel.java
Violation |
Line |
Avoid unused private fields such as 'log'. |
56 |
info/magnolia/module/templatingkit/search/SearchResultItem.java
Violation |
Line |
Avoid empty catch blocks |
113–115 |
Useless parentheses. |
279 |
info/magnolia/module/templatingkit/search/SearchResultModel.java
Violation |
Line |
Avoid empty catch blocks |
91–93 |
Useless parentheses. |
127 |
info/magnolia/module/templatingkit/setup/STKModuleVersionHandler.java
Violation |
Line |
Avoid unused private fields such as 'I18N_BASENAME'. |
107 |
info/magnolia/module/templatingkit/setup/ThemeInstallTask.java
Violation |
Line |
Avoid unused constructor parameters such as 'isUpdate'. |
78 |
Unnecessary use of fully qualified name 'info.magnolia.cms.util.ClasspathResourcesUtil.Filter' due to existing import 'info.magnolia.cms.util.ClasspathResourcesUtil' |
131 |
info/magnolia/module/templatingkit/setup/for2_7/ReorderSTKAppsTask.java
Violation |
Line |
Overriding method merely calls super |
66–68 |
info/magnolia/module/templatingkit/sites/Domain.java
Violation |
Line |
Useless parentheses. |
97 |
Useless parentheses. |
98 |
Useless parentheses. |
99 |
Useless parentheses. |
105 |
Useless parentheses. |
105 |
info/magnolia/module/templatingkit/sites/Site.java
Violation |
Line |
Useless parentheses. |
185 |
Useless parentheses. |
186 |
Useless parentheses. |
187 |
info/magnolia/module/templatingkit/sites/SiteManager.java
Violation |
Line |
Avoid modifiers which are implied by the context |
47 |
Avoid modifiers which are implied by the context |
49 |
Avoid modifiers which are implied by the context |
51 |
Avoid modifiers which are implied by the context |
53 |
Avoid modifiers which are implied by the context |
55 |
Avoid modifiers which are implied by the context |
57 |
Avoid modifiers which are implied by the context |
59 |
info/magnolia/module/templatingkit/sites/TemplateAvailability.java
Violation |
Line |
These nested if statements could be combined |
95–97 |
These nested if statements could be combined |
122–124 |
info/magnolia/module/templatingkit/style/CssSelectorBuilder.java
Violation |
Line |
Useless parentheses. |
69 |
info/magnolia/module/templatingkit/style/CssSelectorSupportRenderingModel.java
Violation |
Line |
Avoid modifiers which are implied by the context |
48 |
info/magnolia/module/templatingkit/style/Theme.java
Violation |
Line |
Avoid modifiers which are implied by the context |
68 |
Avoid modifiers which are implied by the context |
70 |
Avoid modifiers which are implied by the context |
72 |
Avoid modifiers which are implied by the context |
74 |
Avoid modifiers which are implied by the context |
76 |
info/magnolia/module/templatingkit/templates/MainAreaIntro.java
Violation |
Line |
Avoid unused private fields such as 'infoBlock'. |
63 |
info/magnolia/module/templatingkit/templates/STKRenderingModel.java
Violation |
Line |
Avoid modifiers which are implied by the context |
54 |
Avoid modifiers which are implied by the context |
56 |
info/magnolia/module/templatingkit/templates/areas/BreadcrumbAreaModel.java
Violation |
Line |
Avoid unused private fields such as 'log'. |
64 |
info/magnolia/module/templatingkit/templates/areas/ContentNavigationAreaModel.java
Violation |
Line |
Avoid unused private fields such as 'log'. |
69 |
info/magnolia/module/templatingkit/templates/areas/FooterAreaModel.java
Violation |
Line |
Avoid unused private fields such as 'log'. |
59 |
info/magnolia/module/templatingkit/templates/areas/SectionHeaderAreaModel.java
Violation |
Line |
Avoid unused private fields such as 'log'. |
60 |
info/magnolia/module/templatingkit/templates/category/TemplateCategoryUtil.java
Violation |
Line |
Using multiple unary operators may be a bug, and/or is confusing. |
181 |
Avoid unused private methods such as 'getWrappedNodesFromQuery(String,String,long)'. |
266 |
info/magnolia/module/templatingkit/templates/components/AbstractItemListModel.java
Violation |
Line |
Avoid empty catch blocks |
118–119 |
info/magnolia/module/templatingkit/templates/components/DownloadLinkModel.java
Violation |
Line |
Avoid unused private methods such as 'getDMSNodeUUID()'. |
102 |
info/magnolia/module/templatingkit/templates/components/InternalLinkModel.java
Violation |
Line |
Avoid empty catch blocks |
83–84 |
info/magnolia/module/templatingkit/templates/components/SiteMapParagraphModel.java
Violation |
Line |
These nested if statements could be combined |
81–83 |
Useless parentheses. |
82 |
info/magnolia/module/templatingkit/templates/pages/STKPage.java
Violation |
Line |
Avoid unused constructor parameters such as 'templateAvailability'. |
82 |
info/magnolia/module/templatingkit/util/STKDateContentUtil.java
Violation |
Line |
These nested if statements could be combined |
144–153 |
info/magnolia/module/templatingkit/util/STKPager.java
Violation |
Line |
Useless parentheses. |
96 |
Useless parentheses. |
106 |
Avoid empty catch blocks |
190–192 |