PMD Results
The following document contains the results of PMD 5.1.2.
Files
info/magnolia/module/templatingkit/badge/LicenseChecker.java
| Violation |
Line |
| Avoid empty catch blocks |
52–54 |
| Avoid empty catch blocks |
61–63 |
info/magnolia/module/templatingkit/dam/RenditionAwareJcrAssetProvider.java
| Violation |
Line |
| Avoid unused private fields such as 'log'. |
69 |
info/magnolia/module/templatingkit/dam/STKAssetRenderer.java
| Violation |
Line |
| Avoid unused private fields such as 'stkTemplatingFunctions'. |
60 |
info/magnolia/module/templatingkit/functions/STKTemplatingFunctions.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'moduleProvider'. |
123 |
| Avoid unused constructor parameters such as 'siteManager'. |
123 |
| Avoid unused constructor parameters such as 'moduleProvider'. |
141 |
| Avoid unused constructor parameters such as 'siteManager'. |
141 |
| Useless parentheses. |
166 |
info/magnolia/module/templatingkit/imaging/Variation.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
41 |
info/magnolia/module/templatingkit/imaging/VariationRule.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
42 |
info/magnolia/module/templatingkit/imaging/generation/ImageOperationProvidingVariation.java
| Violation |
Line |
| Avoid unused private fields such as 'siteProvider'. |
67 |
| Avoid empty catch blocks |
111–112 |
info/magnolia/module/templatingkit/imaging/generation/SimpleResizeVariation.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'siteProvider'. |
71 |
info/magnolia/module/templatingkit/navigation/NavigationModel.java
| Violation |
Line |
| These nested if statements could be combined |
90–92 |
info/magnolia/module/templatingkit/resources/Resource.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'templatingFunctions'. |
61 |
| Avoid unused constructor parameters such as 'uri2RepositoryManager'. |
61 |
info/magnolia/module/templatingkit/search/SearchResultItem.java
| Violation |
Line |
| Avoid empty catch blocks |
103–105 |
| Useless parentheses. |
274 |
info/magnolia/module/templatingkit/search/SearchResultModel.java
| Violation |
Line |
| Avoid empty catch blocks |
99–101 |
| Useless parentheses. |
140 |
info/magnolia/module/templatingkit/setup/STKModuleVersionHandler.java
| Violation |
Line |
| Avoid unused private fields such as 'I18N_BASENAME'. |
121 |
info/magnolia/module/templatingkit/setup/ThemeInstallTask.java
| Violation |
Line |
| Unnecessary use of fully qualified name 'info.magnolia.cms.util.ClasspathResourcesUtil.Filter' due to existing import 'info.magnolia.cms.util.ClasspathResourcesUtil' |
133 |
info/magnolia/module/templatingkit/setup/for2_7/ReorderSTKAppsTask.java
| Violation |
Line |
| Overriding method merely calls super |
66–68 |
info/magnolia/module/templatingkit/sites/TemplateAvailability.java
| Violation |
Line |
| These nested if statements could be combined |
96–98 |
| These nested if statements could be combined |
123–125 |
info/magnolia/module/templatingkit/style/CssFile.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'templatingFunctions'. |
62 |
| Avoid unused constructor parameters such as 'uri2RepositoryManager'. |
62 |
info/magnolia/module/templatingkit/style/CssSelectorBuilder.java
| Violation |
Line |
| Useless parentheses. |
67 |
info/magnolia/module/templatingkit/templates/MainAreaIntro.java
| Violation |
Line |
| Avoid unused private fields such as 'infoBlock'. |
60 |
info/magnolia/module/templatingkit/templates/category/TemplateCategoryUtil.java
| Violation |
Line |
| Using multiple unary operators may be a bug, and/or is confusing. |
149 |
| Avoid unused private methods such as 'getWrappedNodesFromQuery(String,String,long)'. |
223 |
info/magnolia/module/templatingkit/templates/components/AbstractItemListModel.java
| Violation |
Line |
| Avoid empty catch blocks |
111–112 |
info/magnolia/module/templatingkit/templates/components/InternalLinkModel.java
| Violation |
Line |
| Avoid empty catch blocks |
80–81 |
info/magnolia/module/templatingkit/templates/components/SiteMapParagraphModel.java
| Violation |
Line |
| These nested if statements could be combined |
75–77 |
info/magnolia/module/templatingkit/util/STKDateContentUtil.java
| Violation |
Line |
| These nested if statements could be combined |
139–148 |
info/magnolia/module/templatingkit/util/STKPager.java
| Violation |
Line |
| Useless parentheses. |
94 |
| Useless parentheses. |
104 |
| Avoid empty catch blocks |
188–190 |
