magnolia-core Version: 4.4.6 Last Published: Jan 17, 2012

PMD Results

The following document contains the results of PMD 4.2.5.

Files

info/magnolia/cms/beans/config/ConfigLoader.java

ViolationLine
Avoid unused constructor parameters such as 'context'.65 - 82

info/magnolia/cms/beans/config/ObservedManager.java

ViolationLine
Avoid unnecessary return statements117

info/magnolia/cms/core/AbstractContent.java

ViolationLine
Avoid unused private fields such as 'log'.67
An empty statement (semicolon) not part of a loop293
Avoid empty catch blocks367 - 369

info/magnolia/cms/core/AbstractNodeData.java

ViolationLine
Avoid empty catch blocks129 - 131

info/magnolia/cms/core/BinaryNodeData.java

ViolationLine
These nested if statements could be combined75 - 82

info/magnolia/cms/core/DefaultContent.java

ViolationLine
Avoid empty catch blocks303 - 305
Avoid empty catch blocks349 - 351
Avoid empty catch blocks389 - 391
Avoid empty catch blocks566 - 568
Avoid empty catch blocks568 - 570

info/magnolia/cms/core/DefaultHierarchyManager.java

ViolationLine
Avoid empty catch blocks377 - 379
Avoid empty catch blocks463 - 465

info/magnolia/cms/core/MetaData.java

ViolationLine
Avoid empty catch blocks109 - 111

info/magnolia/cms/core/Path.java

ViolationLine
Avoid unused private methods such as 'checkAppRootDir()'.128
Avoid empty catch blocks137 - 139
These nested if statements could be combined315 - 317

info/magnolia/cms/filters/AbstractMgnlFilter.java

ViolationLine
Avoid unused private fields such as 'log'.67

info/magnolia/cms/filters/RepositoryMappingFilter.java

ViolationLine
Avoid unused private fields such as 'log'.60

info/magnolia/cms/i18n/AbstractMessagesImpl.java

ViolationLine
Ensure you override both equals() and hashCode()132

info/magnolia/cms/link/LinkResolverImpl.java

ViolationLine
Avoid unused private fields such as 'log'.50

info/magnolia/cms/link/UUIDLink.java

ViolationLine
These nested if statements could be combined205 - 208
These nested if statements could be combined219 - 222

info/magnolia/cms/security/AbstractUser.java

ViolationLine
Avoid unused private fields such as 'log'.52

info/magnolia/cms/security/DelegatingUserManager.java

ViolationLine
Avoid empty catch blocks110 - 112
Avoid empty catch blocks122 - 124

info/magnolia/cms/security/LogoutFilter.java

ViolationLine
Avoid unused private fields such as 'log'.59
Avoid unused private fields such as 'servletContext'.63

info/magnolia/cms/security/MgnlRole.java

ViolationLine
These nested if statements could be combined97 - 100
These nested if statements could be combined132 - 135

info/magnolia/cms/security/auth/callback/RealmCallback.java

ViolationLine
Avoid unused private fields such as 'log'.54

info/magnolia/cms/security/auth/callback/UserCallback.java

ViolationLine
Avoid unused private fields such as 'log'.55

info/magnolia/cms/security/auth/login/BasicLogin.java

ViolationLine
Avoid unused private fields such as 'log'.50

info/magnolia/cms/security/auth/login/FormLogin.java

ViolationLine
Avoid unused private fields such as 'log'.52

info/magnolia/cms/security/auth/login/LoginFilter.java

ViolationLine
Avoid unused private fields such as 'log'.58

info/magnolia/cms/servlets/ClasspathSpool.java

ViolationLine
Avoid empty catch blocks99 - 101

info/magnolia/cms/util/ClasspathResourcesUtil.java

ViolationLine
Avoid empty catch blocks145 - 147
These nested if statements could be combined255 - 257

info/magnolia/cms/util/ContentUtil.java

ViolationLine
Avoid empty catch blocks455 - 457
Avoid empty catch blocks470 - 472
These nested if statements could be combined545 - 548

info/magnolia/cms/util/InheritanceContentWrapper.java

ViolationLine
Avoid unused private fields such as 'log'.75

info/magnolia/cms/util/LazyInitPrintWriter.java

ViolationLine
Error while parsing /Users/mdivilek/dev/magnolia-4.4.6/magnoliaTAG-4.4.6/magnolia-core/src/main/java/info/magnolia/cms/util/LazyInitPrintWriter.java: Encountered " "(" "( "" at line 48, column 14. Was expecting one of: "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... 0
Error while parsing /Users/mdivilek/dev/magnolia-4.4.6/magnoliaTAG-4.4.6/magnolia-core/src/main/java/info/magnolia/cms/util/LazyInitPrintWriter.java: Encountered " "(" "( "" at line 48, column 14. Was expecting one of: "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... 0
Error while parsing /Users/mdivilek/dev/magnolia-4.4.6/magnoliaTAG-4.4.6/magnolia-core/src/main/java/info/magnolia/cms/util/LazyInitPrintWriter.java: Encountered " "(" "( "" at line 48, column 14. Was expecting one of: "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... 0

info/magnolia/cms/util/NodeDataUtil.java

ViolationLine
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.430
Avoid empty catch blocks546 - 548

info/magnolia/cms/util/RequestFormUtil.java

ViolationLine
Avoid empty catch blocks159 - 161

info/magnolia/cms/util/SearchReplace.java

ViolationLine
Avoid unused local variables such as 'group'.89

info/magnolia/content2bean/impl/CollectionPropertyHidingTransformer.java

ViolationLine
These nested if statements could be combined81 - 85

info/magnolia/content2bean/impl/Content2BeanTransformerImpl.java

ViolationLine
These nested if statements could be combined317 - 322

info/magnolia/content2bean/impl/TypeMappingImpl.java

ViolationLine
These nested if statements could be combined136 - 149
These nested if statements could be combined209 - 211

info/magnolia/context/AbstractContext.java

ViolationLine
Avoid unused private fields such as 'log'.63

info/magnolia/context/SingleJCRSessionSystemContext.java

ViolationLine
Avoid unused private fields such as 'log'.47

info/magnolia/context/SystemRepositoryStrategy.java

ViolationLine
Avoid unused private fields such as 'log'.54
Avoid unused constructor parameters such as 'context'.58 - 59

info/magnolia/freemarker/models/BinaryNodeDataModel.java

ViolationLine
Avoid empty catch blocks72 - 74
Avoid empty catch blocks83 - 85
Avoid empty catch blocks96 - 98
Avoid empty catch blocks123 - 125

info/magnolia/freemarker/models/MagnoliaObjectWrapper.java

ViolationLine
Avoid unused private fields such as 'log'.57

info/magnolia/importexport/PropertiesImportExport.java

ViolationLine
Avoid empty if statements144 - 146

info/magnolia/jackrabbit/ProviderImpl.java

ViolationLine
Avoid empty catch blocks183 - 185
Avoid empty catch blocks479 - 481

info/magnolia/link/Link.java

ViolationLine
Avoid unused private fields such as 'log'.55

info/magnolia/link/LinkFactory.java

ViolationLine
Avoid empty if statements125 - 127

info/magnolia/link/LinkTransformerManager.java

ViolationLine
Avoid unused private fields such as 'log'.51

info/magnolia/module/ModuleManager.java

ViolationLine
These nested if statements could be combined143 - 145

info/magnolia/module/delta/QueryTask.java

ViolationLine
Avoid unused local variables such as 'it'.68

info/magnolia/module/files/MD5CheckingFileExtractorOperation.java

ViolationLine
Avoid empty if statements103 - 105
Avoid empty while statements159 - 160

info/magnolia/setup/for3_5/CheckAndUpdateExistingFilters.java

ViolationLine
Avoid unused private fields such as 'clazz'.200
Avoid unused private fields such as 'priority'.201

info/magnolia/setup/for3_5/ReconfigureCommands.java

ViolationLine
Avoid unused private fields such as 'log'.63
Avoid empty if statements85 - 87

info/magnolia/setup/for3_5/UpdateURI2RepositoryMappings.java

ViolationLine
Avoid unused private fields such as 'mappingsNode'.57
Avoid unused local variables such as 'configHM'.69

info/magnolia/stats/JCRStats.java

ViolationLine
Avoid unused private fields such as 'log'.53

info/magnolia/voting/voters/AbstractBoolVoter.java

ViolationLine
Avoid unused private fields such as 'log'.53

info/magnolia/voting/voters/URIStartsWithVoter.java

ViolationLine
An empty statement (semicolon) not part of a loop53