magnolia-core - PMD Results

magnolia-core Version: 4.5-beta4 Last Published: Jan 12, 2012

Version: 4.5-beta4

Parent Project

magnolia-project

Project Documentation

Project Information
Project Reports
- Checkstyle
- Clirr
- Clover
- CPD Report
- JavaDocs
- JDepend
- PMD Report
- Source Xref
- Surefire Report
- Test Source Xref

PMD Results

The following document contains the results of PMD 4.2.5.

Files

info/magnolia/cms/beans/config/ConfigLoader.java

Violation	Line
Avoid unused constructor parameters such as 'context'.	84 - 106

info/magnolia/cms/beans/config/ObservedManager.java

Violation	Line
Avoid unnecessary return statements	127

info/magnolia/cms/core/AbstractContent.java

Violation	Line
Avoid empty catch blocks	411 - 413

info/magnolia/cms/core/AbstractNodeData.java

Violation	Line
Avoid empty catch blocks	132 - 134
Avoid empty catch blocks	203 - 205

info/magnolia/cms/core/BinaryNodeData.java

Violation	Line
These nested if statements could be combined	75 - 82

info/magnolia/cms/core/DefaultContent.java

Violation	Line
Avoid empty catch blocks	317 - 319
Avoid empty catch blocks	362 - 364
Avoid empty catch blocks	554 - 556
Avoid empty catch blocks	556 - 558
Ensure you override both equals() and hashCode()	691

info/magnolia/cms/core/DefaultHierarchyManager.java

Violation	Line
Avoid unused constructor parameters such as 'ignoredAccessManager'.	94 - 96
Avoid unused constructor parameters such as 'ignoredUserId'.	98 - 100
Avoid unused constructor parameters such as 'ignored'.	105 - 107
Avoid empty catch blocks	411 - 413

info/magnolia/cms/core/MetaData.java

Violation	Line
Avoid unused constructor parameters such as 'ignoredAccessManager'.	108 - 110
Avoid empty catch blocks	123 - 125

info/magnolia/cms/core/Path.java

Violation	Line
These nested if statements could be combined	325 - 327

info/magnolia/cms/core/version/MgnlVersioningNodeWrapper.java

Violation	Line
Avoid empty catch blocks	141 - 143
Avoid empty catch blocks	143 - 145

info/magnolia/cms/filters/AbstractMgnlFilter.java

Violation	Line
Avoid unused private fields such as 'log'.	67

info/magnolia/cms/filters/RepositoryMappingFilter.java

Violation	Line
Avoid unused private fields such as 'log'.	62

info/magnolia/cms/i18n/AbstractMessagesImpl.java

Violation	Line
Ensure you override both equals() and hashCode()	140

info/magnolia/cms/security/DelegatingUserManager.java

Violation	Line
Avoid empty catch blocks	125 - 127
Avoid empty catch blocks	148 - 150

info/magnolia/cms/security/LogoutFilter.java

Violation	Line
Avoid unused private fields such as 'log'.	59
Avoid unused private fields such as 'servletContext'.	63

info/magnolia/cms/security/MgnlGroup.java

Violation	Line
Avoid unused private fields such as 'log'.	48

info/magnolia/cms/security/MgnlRole.java

Violation	Line
Avoid unused private fields such as 'log'.	49
Avoid unused private fields such as 'acls'.	57

info/magnolia/cms/security/MgnlRoleManager.java

Violation	Line
These nested if statements could be combined	118 - 121
These nested if statements could be combined	155 - 158

info/magnolia/cms/security/SecurityCallbackFilter.java

Violation	Line
Avoid unused private fields such as 'log'.	71

info/magnolia/cms/security/SystemUserManager.java

Violation	Line
Avoid unused method parameters such as 'password'.	134 - 161

info/magnolia/cms/security/auth/callback/RealmCallback.java

Violation	Line
Avoid unused private fields such as 'log'.	56

info/magnolia/cms/security/auth/callback/UserCallback.java

Violation	Line
Avoid unused private fields such as 'log'.	55

info/magnolia/cms/security/auth/login/BasicLogin.java

Violation	Line
Avoid unused private fields such as 'log'.	50

info/magnolia/cms/servlets/ClasspathSpool.java

Violation	Line
Avoid empty catch blocks	101 - 103

info/magnolia/cms/servlets/MgnlServletContextListener.java

Violation	Line
Avoid unused private fields such as 'log'.	51

info/magnolia/cms/util/ClasspathResourcesUtil.java

Violation	Line
Avoid empty catch blocks	151 - 153
These nested if statements could be combined	268 - 270

info/magnolia/cms/util/ContentUtil.java

Violation	Line
Avoid empty catch blocks	464 - 466
Avoid empty catch blocks	479 - 481
These nested if statements could be combined	554 - 557

info/magnolia/cms/util/InheritanceContentWrapper.java

Violation	Line
Avoid unused private fields such as 'log'.	75

info/magnolia/cms/util/LazyInitPrintWriter.java

Violation	Line
Error while parsing /Users/mdivilek/dev/beta4release/main-4.5-beta4/magnolia-core/src/main/java/info/magnolia/cms/util/LazyInitPrintWriter.java: Encountered " "(" "( "" at line 48, column 14. Was expecting one of: "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ...	0
Error while parsing /Users/mdivilek/dev/beta4release/main-4.5-beta4/magnolia-core/src/main/java/info/magnolia/cms/util/LazyInitPrintWriter.java: Encountered " "(" "( "" at line 48, column 14. Was expecting one of: "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ...	0
Error while parsing /Users/mdivilek/dev/beta4release/main-4.5-beta4/magnolia-core/src/main/java/info/magnolia/cms/util/LazyInitPrintWriter.java: Encountered " "(" "( "" at line 48, column 14. Was expecting one of: "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ...	0

info/magnolia/cms/util/RequestFormUtil.java

Violation	Line
Avoid empty catch blocks	161 - 163

info/magnolia/cms/util/SearchReplace.java

Violation	Line
Avoid unused local variables such as 'group'.	90

info/magnolia/cms/util/ServletUtils.java

Violation	Line
Avoid empty if statements	175 - 177

info/magnolia/content2bean/impl/CollectionPropertyHidingTransformer.java

Violation	Line
These nested if statements could be combined	98 - 102

info/magnolia/content2bean/impl/Content2BeanTransformerImpl.java

Violation	Line
These nested if statements could be combined	350 - 355

info/magnolia/content2bean/impl/TypeMappingImpl.java

Violation	Line
These nested if statements could be combined	142 - 155
These nested if statements could be combined	259 - 261

info/magnolia/context/SingleJCRSessionSystemContext.java

Violation	Line
Avoid unused private fields such as 'log'.	49

info/magnolia/freemarker/FreemarkerServletContextWrapper.java

Violation	Line
Avoid empty catch blocks	105 - 107
Avoid empty catch blocks	170 - 172

info/magnolia/freemarker/models/BinaryNodeDataModel.java

Violation	Line
Avoid empty catch blocks	76 - 78
Avoid empty catch blocks	88 - 90
Avoid empty catch blocks	102 - 104
Avoid empty catch blocks	130 - 132

info/magnolia/freemarker/models/MagnoliaObjectWrapper.java

Violation	Line
Avoid unused private fields such as 'log'.	59

info/magnolia/importexport/PropertiesImportExport.java

Violation	Line
Avoid empty if statements	143 - 145

info/magnolia/jackrabbit/ProviderImpl.java

Violation	Line
Avoid empty catch blocks	184 - 186
Avoid empty catch blocks	488 - 490

info/magnolia/jcr/util/ContentMap.java

Violation	Line
Avoid empty catch blocks	118 - 120
Avoid empty if statements	202 - 205
Avoid empty catch blocks	242 - 244
Avoid empty catch blocks	255 - 257
Avoid empty catch blocks	269 - 271

info/magnolia/jcr/util/PropertiesImportExport.java

Violation	Line
Avoid empty if statements	161 - 163

info/magnolia/jcr/util/PropertyUtil.java

Violation	Line
Avoid empty catch blocks	165 - 167

info/magnolia/jcr/wrapper/DelegateNodeWrapper.java

Violation	Line
Overriding method merely calls super	587 - 590

info/magnolia/link/Link.java

Violation	Line
Avoid unused private fields such as 'log'.	56

info/magnolia/link/LinkFactory.java

Violation	Line
Avoid empty if statements	125 - 127

info/magnolia/link/LinkTransformerManager.java

Violation	Line
Avoid unused private fields such as 'log'.	51

info/magnolia/module/ModuleManager.java

Violation	Line
These nested if statements could be combined	149 - 151

info/magnolia/module/delta/QueryTask.java

Violation	Line
Avoid unused local variables such as 'it'.	69

info/magnolia/module/files/MD5CheckingFileExtractorOperation.java

Violation	Line
Avoid empty if statements	104 - 106
Avoid empty while statements	162 - 163

info/magnolia/objectfactory/guice/GuicePropertyConfigurer.java

Violation	Line
Avoid empty catch blocks	60 - 63

info/magnolia/setup/for3_5/CheckAndUpdateExistingFilters.java

Violation	Line
Avoid unused private fields such as 'clazz'.	195
Avoid unused private fields such as 'priority'.	196

info/magnolia/setup/for3_5/ReconfigureCommands.java

Violation	Line
Avoid unused private fields such as 'log'.	63
Avoid empty if statements	87 - 89

info/magnolia/setup/for3_5/UpdateURI2RepositoryMappings.java

Violation	Line
Avoid unused private fields such as 'mappingsNode'.	57
Avoid unused local variables such as 'configHM'.	70

info/magnolia/setup/for4_5/UpdateSecurityFilterClientCallbacksConfiguration.java

Violation	Line
Avoid unused method parameters such as 'ctx'.	187 - 201
Avoid unused method parameters such as 'ctx'.	203 - 211

info/magnolia/stats/JCRStats.java

Violation	Line
Avoid unused private fields such as 'log'.	53

info/magnolia/voting/voters/AbstractBoolVoter.java

Violation	Line
Avoid unused private fields such as 'log'.	53