Last Published: 2014-12-23
PMD Results
The following document contains the results of PMD 5.1.2.
Files
info/magnolia/channel/ChannelResolver.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 53 |
info/magnolia/cms/beans/config/ConfigLoader.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'context'. | 84 |
info/magnolia/cms/beans/config/ConfigurationException.java
| Violation | Line |
|---|---|
| Useless parentheses. | 51 |
info/magnolia/cms/beans/config/HostBasedVirtualURIMapping.java
| Violation | Line |
|---|---|
| Useless parentheses. | 171 |
info/magnolia/cms/beans/config/MIMEMapping.java
| Violation | Line |
|---|---|
| Useless parentheses. | 218 |
info/magnolia/cms/beans/config/ObservedManager.java
| Violation | Line |
|---|---|
| Avoid unnecessary return statements | 132 |
info/magnolia/cms/beans/config/RotatingVirtualURIMapping.java
| Violation | Line |
|---|---|
| Useless parentheses. | 114 |
info/magnolia/cms/beans/config/URI2RepositoryMapping.java
| Violation | Line |
|---|---|
| Useless parentheses. | 107 |
info/magnolia/cms/beans/config/VirtualURIMapping.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 62–86 |
info/magnolia/cms/beans/runtime/Document.java
| Violation | Line |
|---|---|
| Useless parentheses. | 214 |
info/magnolia/cms/core/AbstractContent.java
| Violation | Line |
|---|---|
| Useless parentheses. | 344 |
| Useless parentheses. | 349 |
| Avoid empty catch blocks | 410–412 |
info/magnolia/cms/core/AbstractNodeData.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 132–134 |
| Avoid empty catch blocks | 203–205 |
info/magnolia/cms/core/BinaryNodeData.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 77–84 |
info/magnolia/cms/core/Content.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 738 |
| Avoid modifiers which are implied by the context | 746–755 |
| Avoid modifiers which are implied by the context | 753 |
info/magnolia/cms/core/DefaultACLBasedPermissions.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'configuration'. | 106 |
| Useless parentheses. | 116 |
| Useless parentheses. | 116 |
info/magnolia/cms/core/DefaultContent.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 315–317 |
| Avoid empty catch blocks | 360–362 |
| Avoid unused local variables such as 'nodeType'. | 526 |
| Avoid empty catch blocks | 552–554 |
| Avoid empty catch blocks | 554–556 |
| Ensure you override both equals() and hashCode() | 688 |
| Useless parentheses. | 702 |
info/magnolia/cms/core/DefaultHierarchyManager.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'ignoredAccessManager'. | 93 |
| Avoid unused constructor parameters such as 'ignoredUserId'. | 97 |
| Avoid unused constructor parameters such as 'ignored'. | 104 |
| Useless parentheses. | 183 |
| Avoid unused local variables such as 'type'. | 330 |
| Useless parentheses. | 354 |
| Avoid empty catch blocks | 407–409 |
info/magnolia/cms/core/MagnoliaAccessProvider.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'compiledPermissionsClass'. | 82 |
info/magnolia/cms/core/MetaData.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'ignoredAccessManager'. | 108 |
| Avoid empty catch blocks | 123–125 |
| Avoid unused private methods such as 'setJCRProperty(String,Object)'. | 354 |
info/magnolia/cms/core/NodeTypeBasedPermissions.java
| Violation | Line |
|---|---|
| Useless parentheses. | 111 |
| Useless parentheses. | 111 |
info/magnolia/cms/core/Path.java
| Violation | Line |
|---|---|
| Useless parentheses. | 197 |
| Useless parentheses. | 299 |
| Useless parentheses. | 299 |
| Useless parentheses. | 299 |
| Useless parentheses. | 300 |
| Useless parentheses. | 300 |
| Useless parentheses. | 300 |
| Useless parentheses. | 301 |
| Useless parentheses. | 301 |
| Useless parentheses. | 301 |
| These nested if statements could be combined | 325–327 |
| Useless parentheses. | 343 |
| Useless parentheses. | 347 |
| Useless parentheses. | 366 |
info/magnolia/cms/core/SystemProperty.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'getMagnoliaConfigurationProperties()'. | 169 |
info/magnolia/cms/core/search/QueryManagerImpl.java
| Violation | Line |
|---|---|
| Useless parentheses. | 96 |
| Useless parentheses. | 102 |
info/magnolia/cms/core/search/QueryResultImpl.java
| Violation | Line |
|---|---|
| Useless parentheses. | 142 |
info/magnolia/cms/core/version/ContentVersion.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'wrap(Collection)'. | 411 |
| Useless parentheses. | 424 |
| Useless parentheses. | 433 |
info/magnolia/cms/core/version/MgnlVersioningNodeWrapper.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'nodeType'. | 114 |
| Avoid empty catch blocks | 141–143 |
| Avoid empty catch blocks | 143–145 |
info/magnolia/cms/core/version/VersionManager.java
| Violation | Line |
|---|---|
| Useless parentheses. | 97 |
info/magnolia/cms/exchange/ActivationManager.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 66 |
| Avoid modifiers which are implied by the context | 68 |
| Avoid modifiers which are implied by the context | 73 |
info/magnolia/cms/exchange/ExchangeException.java
| Violation | Line |
|---|---|
| Useless parentheses. | 62 |
info/magnolia/cms/exchange/Subscriber.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 61 |
| Avoid modifiers which are implied by the context | 63 |
| Avoid modifiers which are implied by the context | 65 |
| Avoid modifiers which are implied by the context | 67 |
| Avoid modifiers which are implied by the context | 69 |
| Avoid modifiers which are implied by the context | 71 |
| Avoid modifiers which are implied by the context | 73 |
info/magnolia/cms/exchange/Subscription.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 59 |
info/magnolia/cms/exchange/Syndicator.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 67 |
| Avoid modifiers which are implied by the context | 79 |
| Avoid modifiers which are implied by the context | 90 |
| Avoid modifiers which are implied by the context | 101 |
| Avoid modifiers which are implied by the context | 113 |
| Avoid modifiers which are implied by the context | 120 |
| Avoid modifiers which are implied by the context | 128 |
info/magnolia/cms/filters/AbstractMgnlFilter.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 67 |
info/magnolia/cms/filters/AggregatorFilter.java
| Violation | Line |
|---|---|
| Useless parentheses. | 190 |
| Useless parentheses. | 190 |
info/magnolia/cms/filters/CosMultipartRequestFilter.java
| Violation | Line |
|---|---|
| Useless parentheses. | 82 |
info/magnolia/cms/filters/FilterManager.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 53 |
info/magnolia/cms/filters/RepositoryMappingFilter.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 61 |
info/magnolia/cms/filters/WebContainerResources.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 51 |
info/magnolia/cms/i18n/AbstractMessagesImpl.java
| Violation | Line |
|---|---|
| Ensure you override both equals() and hashCode() | 140 |
info/magnolia/cms/i18n/DefaultI18nContentSupport.java
| Violation | Line |
|---|---|
| Useless parentheses. | 73 |
info/magnolia/cms/i18n/I18nContentSupport.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 64 |
| Avoid modifiers which are implied by the context | 66 |
| Avoid modifiers which are implied by the context | 71 |
| Avoid modifiers which are implied by the context | 76 |
| Avoid modifiers which are implied by the context | 81 |
| Avoid modifiers which are implied by the context | 89 |
| Avoid modifiers which are implied by the context | 97 |
| Avoid modifiers which are implied by the context | 102 |
| Avoid modifiers which are implied by the context | 107 |
| Avoid modifiers which are implied by the context | 112 |
| Avoid modifiers which are implied by the context | 117 |
| Avoid modifiers which are implied by the context | 122 |
| Avoid modifiers which are implied by the context | 124 |
info/magnolia/cms/i18n/Messages.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 63 |
| Avoid modifiers which are implied by the context | 69 |
| Avoid modifiers which are implied by the context | 77 |
| Avoid modifiers which are implied by the context | 86 |
| Avoid modifiers which are implied by the context | 92 |
| Avoid modifiers which are implied by the context | 98 |
info/magnolia/cms/security/AccessDeniedException.java
| Violation | Line |
|---|---|
| Useless parentheses. | 57 |
info/magnolia/cms/security/AccessManagerImpl.java
| Violation | Line |
|---|---|
| Useless parentheses. | 88 |
info/magnolia/cms/security/DelegatingUserManager.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 146–148 |
| Avoid empty catch blocks | 169–171 |
| Avoid empty catch blocks | 193–195 |
info/magnolia/cms/security/Digester.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 78 |
info/magnolia/cms/security/ExternalUser.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'userDetails'. | 63 |
info/magnolia/cms/security/Group.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 63 |
| Avoid modifiers which are implied by the context | 69 |
| Avoid modifiers which are implied by the context | 71 |
| Avoid modifiers which are implied by the context | 86 |
| Avoid modifiers which are implied by the context | 91 |
| Avoid modifiers which are implied by the context | 96 |
| Avoid modifiers which are implied by the context | 101 |
info/magnolia/cms/security/GroupManager.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 60 |
| Avoid modifiers which are implied by the context | 65 |
| Avoid modifiers which are implied by the context | 67 |
| Avoid modifiers which are implied by the context | 73 |
| Avoid modifiers which are implied by the context | 79 |
info/magnolia/cms/security/IPSecurityManager.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 53–57 |
info/magnolia/cms/security/IPSecurityManagerImpl.java
| Violation | Line |
|---|---|
| Useless parentheses. | 85 |
info/magnolia/cms/security/Lock.java
| Violation | Line |
|---|---|
| Useless parentheses. | 88 |
info/magnolia/cms/security/LogoutFilter.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 59 |
| Avoid unused private fields such as 'servletContext'. | 63 |
info/magnolia/cms/security/MgnlGroup.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 48 |
info/magnolia/cms/security/MgnlRole.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'acls'. | 57 |
info/magnolia/cms/security/MgnlRoleManager.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 123–126 |
| These nested if statements could be combined | 160–163 |
info/magnolia/cms/security/MgnlUser.java
| Violation | Line |
|---|---|
| Useless parentheses. | 241 |
info/magnolia/cms/security/Realm.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 64 |
| Avoid modifiers which are implied by the context | 102–109 |
info/magnolia/cms/security/RepositoryBackedSecurityManager.java
| Violation | Line |
|---|---|
| Useless parentheses. | 141 |
info/magnolia/cms/security/Role.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 43 |
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 61 |
| Avoid modifiers which are implied by the context | 67 |
info/magnolia/cms/security/RoleManager.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 61 |
| Avoid modifiers which are implied by the context | 66 |
| Avoid modifiers which are implied by the context | 72 |
| Avoid modifiers which are implied by the context | 77 |
info/magnolia/cms/security/SecurityCallbackFilter.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 71 |
| Unnecessary use of fully qualified name 'HttpServletResponse.SC_UNAUTHORIZED' due to existing import 'javax.servlet.http.HttpServletResponse' | 93 |
info/magnolia/cms/security/SecuritySupport.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 69–73 |
info/magnolia/cms/security/SystemUserManager.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'password'. | 171 |
info/magnolia/cms/security/UserManager.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 64 |
| Avoid modifiers which are implied by the context | 71 |
| Avoid modifiers which are implied by the context | 78 |
| Avoid modifiers which are implied by the context | 86 |
| Avoid modifiers which are implied by the context | 92 |
| Avoid modifiers which are implied by the context | 98 |
| Avoid modifiers which are implied by the context | 105 |
| Avoid modifiers which are implied by the context | 111 |
| Avoid modifiers which are implied by the context | 117 |
| Avoid modifiers which are implied by the context | 124 |
| Avoid modifiers which are implied by the context | 139 |
| Avoid modifiers which are implied by the context | 144 |
| Avoid modifiers which are implied by the context | 152 |
| Avoid modifiers which are implied by the context | 158 |
| Avoid modifiers which are implied by the context | 164 |
| Avoid modifiers which are implied by the context | 170 |
| Avoid modifiers which are implied by the context | 176 |
| Avoid modifiers which are implied by the context | 183 |
| Avoid modifiers which are implied by the context | 191 |
| Avoid modifiers which are implied by the context | 200 |
| Avoid modifiers which are implied by the context | 206 |
| Avoid modifiers which are implied by the context | 213 |
| Avoid modifiers which are implied by the context | 220 |
info/magnolia/cms/security/auth/Entity.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 60 |
| Avoid modifiers which are implied by the context | 66 |
| Avoid modifiers which are implied by the context | 72 |
| Avoid modifiers which are implied by the context | 74 |
| Avoid modifiers which are implied by the context | 79 |
info/magnolia/cms/security/auth/PrincipalCollection.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 61 |
| Avoid modifiers which are implied by the context | 63 |
| Avoid modifiers which are implied by the context | 66 |
| Avoid modifiers which are implied by the context | 71 |
| Avoid modifiers which are implied by the context | 76 |
| Avoid modifiers which are implied by the context | 78 |
info/magnolia/cms/security/auth/callback/Base64CallbackHandler.java
| Violation | Line |
|---|---|
| Useless parentheses. | 64 |
info/magnolia/cms/security/auth/callback/ClientCallback.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
info/magnolia/cms/security/auth/callback/FormClientCallback.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'hasQueryParameters'. | 80 |
info/magnolia/cms/security/auth/callback/RealmCallback.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 56 |
info/magnolia/cms/security/auth/callback/UserCallback.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 55 |
info/magnolia/cms/security/auth/login/BasicLogin.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 50 |
info/magnolia/cms/security/auth/login/LoginHandler.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 52 |
info/magnolia/cms/security/operations/AccessDefinition.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 47 |
info/magnolia/cms/security/operations/OperationPermissionDefinition.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 43 |
| Avoid modifiers which are implied by the context | 44 |
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 61 |
| Avoid modifiers which are implied by the context | 63 |
| Avoid modifiers which are implied by the context | 65 |
| Avoid modifiers which are implied by the context | 67 |
| Avoid modifiers which are implied by the context | 69 |
| Avoid modifiers which are implied by the context | 71 |
| Avoid modifiers which are implied by the context | 73 |
info/magnolia/cms/servlets/MgnlServletContextListener.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 51 |
info/magnolia/cms/util/ClasspathResourcesUtil.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 79–81 |
| Avoid modifiers which are implied by the context | 80 |
| Avoid empty catch blocks | 151–153 |
| These nested if statements could be combined | 274–276 |
info/magnolia/cms/util/ContentUtil.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 137–139 |
| Avoid modifiers which are implied by the context | 144–146 |
| Avoid empty catch blocks | 466–468 |
| Avoid empty catch blocks | 481–483 |
| These nested if statements could be combined | 527–530 |
| Useless parentheses. | 601 |
info/magnolia/cms/util/DateUtil.java
| Violation | Line |
|---|---|
| Useless parentheses. | 214 |
info/magnolia/cms/util/DelayedExecutor.java
| Violation | Line |
|---|---|
| Useless parentheses. | 84 |
info/magnolia/cms/util/DeprecationUtil.java
| Violation | Line |
|---|---|
| Unnecessary use of fully qualified name 'org.slf4j.LoggerFactory.getLogger' due to existing import 'org.slf4j.LoggerFactory' | 48 |
| Unnecessary use of fully qualified name 'org.slf4j.Logger' due to existing import 'org.slf4j.Logger' | 48 |
| Useless parentheses. | 67 |
info/magnolia/cms/util/InheritanceContentWrapper.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 75 |
info/magnolia/cms/util/LazyNodeDataWrapper.java
| Violation | Line |
|---|---|
| Useless parentheses. | 77 |
info/magnolia/cms/util/NodeDataUtil.java
| Violation | Line |
|---|---|
| Useless parentheses. | 112 |
| Useless parentheses. | 114 |
| Useless parentheses. | 116 |
| Useless parentheses. | 118 |
| Useless parentheses. | 120 |
| Useless parentheses. | 123 |
| Useless parentheses. | 198 |
| Useless parentheses. | 200 |
| Useless parentheses. | 202 |
| Useless parentheses. | 204 |
| Useless parentheses. | 206 |
| Useless parentheses. | 208 |
| Useless parentheses. | 240 |
| Useless parentheses. | 245 |
info/magnolia/cms/util/NodeMapWrapper.java
| Violation | Line |
|---|---|
| Useless parentheses. | 252 |
info/magnolia/cms/util/PathUtil.java
| Violation | Line |
|---|---|
| Useless parentheses. | 48 |
info/magnolia/cms/util/QueryUtil.java
| Violation | Line |
|---|---|
| Unnecessary use of fully qualified name 'javax.jcr.query.Query.JCR_SQL2' due to existing import 'javax.jcr.query.Query' | 243 |
info/magnolia/cms/util/RequestDispatchUtil.java
| Violation | Line |
|---|---|
| Useless parentheses. | 133 |
| Useless parentheses. | 133 |
info/magnolia/cms/util/SearchReplace.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'group'. | 90 |
info/magnolia/cms/util/ServletUtil.java
| Violation | Line |
|---|---|
| Useless parentheses. | 98 |
| Avoid empty if statements | 177–179 |
| Useless parentheses. | 177 |
| Useless parentheses. | 177 |
info/magnolia/cms/util/UnicodeNormalizer.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 56 |
info/magnolia/cms/util/UrlPattern.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 73–110 |
info/magnolia/content2bean/Bean2ContentProcessor.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 49 |
info/magnolia/content2bean/Bean2ContentTransformer.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 64 |
| Avoid modifiers which are implied by the context | 69 |
| Avoid modifiers which are implied by the context | 74 |
| Avoid modifiers which are implied by the context | 79 |
| Avoid modifiers which are implied by the context | 84 |
info/magnolia/content2bean/Content2BeanProcessor.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 54–55 |
| Avoid modifiers which are implied by the context | 60 |
info/magnolia/content2bean/Content2BeanTransformer.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 63 |
| Avoid modifiers which are implied by the context | 68 |
| Avoid modifiers which are implied by the context | 73 |
| Avoid modifiers which are implied by the context | 78 |
| Avoid modifiers which are implied by the context | 83 |
| Avoid modifiers which are implied by the context | 88 |
| Avoid modifiers which are implied by the context | 93 |
| Avoid modifiers which are implied by the context | 100 |
info/magnolia/content2bean/TransformationState.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 60 |
| Avoid modifiers which are implied by the context | 62 |
| Avoid modifiers which are implied by the context | 64 |
| Avoid modifiers which are implied by the context | 66 |
| Avoid modifiers which are implied by the context | 68 |
| Avoid modifiers which are implied by the context | 70 |
| Avoid modifiers which are implied by the context | 72 |
| Avoid modifiers which are implied by the context | 77 |
info/magnolia/content2bean/TypeMapping.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 61 |
info/magnolia/content2bean/impl/CollectionPropertyHidingTransformer.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 97–101 |
info/magnolia/content2bean/impl/Content2BeanTransformerImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 352–357 |
info/magnolia/content2bean/impl/TypeMappingImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 141–154 |
| These nested if statements could be combined | 254–256 |
info/magnolia/context/AbstractContext.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 70 |
info/magnolia/context/Context.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 63 |
| Avoid modifiers which are implied by the context | 68 |
| Avoid modifiers which are implied by the context | 73 |
| Avoid modifiers which are implied by the context | 75 |
| Avoid modifiers which are implied by the context | 77 |
| Avoid modifiers which are implied by the context | 79 |
| Avoid modifiers which are implied by the context | 81 |
| Avoid modifiers which are implied by the context | 83 |
| Avoid modifiers which are implied by the context | 85 |
| Avoid modifiers which are implied by the context | 87 |
| Avoid modifiers which are implied by the context | 89 |
| Avoid modifiers which are implied by the context | 91 |
| Avoid modifiers which are implied by the context | 93 |
| Avoid modifiers which are implied by the context | 98 |
| Avoid modifiers which are implied by the context | 100 |
| Avoid modifiers which are implied by the context | 105 |
| Avoid modifiers which are implied by the context | 110 |
| Avoid modifiers which are implied by the context | 112 |
| Avoid modifiers which are implied by the context | 122 |
| Avoid modifiers which are implied by the context | 127 |
| Avoid modifiers which are implied by the context | 134 |
| Avoid modifiers which are implied by the context | 141 |
| Avoid modifiers which are implied by the context | 149 |
| Avoid modifiers which are implied by the context | 157 |
| Avoid modifiers which are implied by the context | 164 |
| Avoid modifiers which are implied by the context | 171 |
| Avoid modifiers which are implied by the context | 177 |
| Avoid modifiers which are implied by the context | 183 |
| Avoid modifiers which are implied by the context | 190 |
| Avoid modifiers which are implied by the context | 195 |
info/magnolia/context/MgnlContext.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 420–422 |
| Avoid modifiers which are implied by the context | 433–435 |
info/magnolia/context/SingleJCRSessionSystemContext.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 49 |
info/magnolia/context/ThreadDependentSystemContext.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 48 |
info/magnolia/context/WebContext.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 62 |
| Avoid modifiers which are implied by the context | 68 |
| Avoid modifiers which are implied by the context | 73 |
| Avoid modifiers which are implied by the context | 78 |
| Avoid modifiers which are implied by the context | 89 |
| Avoid modifiers which are implied by the context | 95 |
| Avoid modifiers which are implied by the context | 101 |
| Avoid modifiers which are implied by the context | 106 |
| Avoid modifiers which are implied by the context | 112 |
| Avoid modifiers which are implied by the context | 117 |
| Avoid modifiers which are implied by the context | 150 |
| Avoid modifiers which are implied by the context | 155 |
| Avoid modifiers which are implied by the context | 161 |
info/magnolia/debug/TrackingStatus.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'trace'. | 50 |
info/magnolia/freemarker/FreemarkerServletContextWrapper.java
| Violation | Line |
|---|---|
| Useless parentheses. | 91 |
| Useless parentheses. | 91 |
| Useless parentheses. | 108 |
| Useless parentheses. | 108 |
| Avoid empty catch blocks | 112–114 |
| Avoid empty catch blocks | 180–182 |
info/magnolia/freemarker/models/BinaryNodeDataModel.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 76–78 |
| Avoid empty catch blocks | 88–90 |
| Avoid empty catch blocks | 102–104 |
| Useless parentheses. | 121 |
| Avoid empty catch blocks | 130–132 |
| Useless parentheses. | 141 |
| Useless parentheses. | 150 |
info/magnolia/freemarker/models/ContentMapModel.java
| Violation | Line |
|---|---|
| Useless parentheses. | 102 |
info/magnolia/freemarker/models/ContentModel.java
| Violation | Line |
|---|---|
| Useless parentheses. | 129 |
info/magnolia/freemarker/models/MagnoliaObjectWrapper.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 59 |
| Useless parentheses. | 96 |
| Useless parentheses. | 102 |
info/magnolia/importexport/BootstrapFilesComparator.java
| Violation | Line |
|---|---|
| Useless parentheses. | 75 |
| Useless parentheses. | 75 |
info/magnolia/importexport/DataTransporter.java
| Violation | Line |
|---|---|
| Useless parentheses. | 417 |
| Useless parentheses. | 419 |
info/magnolia/importexport/PropertiesImportExport.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 143–145 |
| Useless parentheses. | 258 |
| Useless parentheses. | 315 |
| Useless parentheses. | 318 |
| Useless parentheses. | 321 |
| Useless parentheses. | 324 |
| Useless parentheses. | 327 |
| Useless parentheses. | 330 |
| Useless parentheses. | 333 |
info/magnolia/importexport/filters/MetadataUuidFilter.java
| Violation | Line |
|---|---|
| Useless parentheses. | 145 |
info/magnolia/importexport/filters/SkipNodePropertyFilter.java
| Violation | Line |
|---|---|
| Useless parentheses. | 137 |
info/magnolia/jackrabbit/ProviderImpl.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 184–186 |
| Avoid empty catch blocks | 488–490 |
info/magnolia/jcr/decoration/ContentDecoratorNodeWrapper.java
| Violation | Line |
|---|---|
| Useless parentheses. | 306 |
| Useless parentheses. | 307 |
info/magnolia/jcr/node2bean/Node2BeanProcessor.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 69 |
| Avoid modifiers which are implied by the context | 75 |
info/magnolia/jcr/node2bean/Node2BeanTransformer.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 61 |
| Avoid modifiers which are implied by the context | 66 |
| Avoid modifiers which are implied by the context | 71 |
| Avoid modifiers which are implied by the context | 77 |
| Avoid modifiers which are implied by the context | 82 |
info/magnolia/jcr/node2bean/TransformationState.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 60 |
| Avoid modifiers which are implied by the context | 62 |
| Avoid modifiers which are implied by the context | 64 |
| Avoid modifiers which are implied by the context | 66 |
| Avoid modifiers which are implied by the context | 68 |
| Avoid modifiers which are implied by the context | 70 |
| Avoid modifiers which are implied by the context | 75 |
info/magnolia/jcr/node2bean/TypeMapping.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 49 |
info/magnolia/jcr/node2bean/impl/CollectionPropertyHidingTransformer.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 102–106 |
info/magnolia/jcr/node2bean/impl/Node2BeanTransformerImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 290–295 |
info/magnolia/jcr/node2bean/impl/TypeMappingImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 264–266 |
info/magnolia/jcr/util/ContentMap.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 118–120 |
| Avoid empty if statements | 202–205 |
| Avoid empty catch blocks | 242–244 |
| Avoid empty catch blocks | 255–257 |
| Avoid empty catch blocks | 269–271 |
| Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map' | 279 |
info/magnolia/jcr/util/MetaDataUtil.java
| Violation | Line |
|---|---|
| Useless parentheses. | 76 |
info/magnolia/jcr/util/PropertyUtil.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 164–166 |
| Useless parentheses. | 262 |
| Useless parentheses. | 264 |
| Useless parentheses. | 266 |
| Useless parentheses. | 268 |
| Useless parentheses. | 270 |
| Useless parentheses. | 273 |
| Useless parentheses. | 419 |
| Useless parentheses. | 421 |
| Useless parentheses. | 423 |
| Useless parentheses. | 425 |
| Useless parentheses. | 427 |
| Useless parentheses. | 429 |
| Useless parentheses. | 431 |
info/magnolia/jcr/wrapper/ChannelVisibilityContentDecorator.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 78–92 |
info/magnolia/jcr/wrapper/DelegateNodeWrapper.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 582–585 |
info/magnolia/jcr/wrapper/HTMLEscapingPropertyWrapper.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'transformLineBreaks'. | 50 |
info/magnolia/link/Link.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 59 |
| Avoid empty catch blocks | 122–123 |
info/magnolia/link/LinkTransformerManager.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 51 |
info/magnolia/module/InstallContext.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 104–140 |
info/magnolia/module/ModuleLifecycleContext.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 62 |
info/magnolia/module/ModuleManager.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 91–98 |
| Avoid modifiers which are implied by the context | 103–168 |
| These nested if statements could be combined | 149–151 |
| Avoid modifiers which are implied by the context | 173–213 |
info/magnolia/module/ModuleRegistry.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 98–105 |
info/magnolia/module/delta/FilterOrderingTask.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'getLastChild(Node,Collection)'. | 117 |
| Avoid unused private methods such as 'hasNodes(Node,Collection)'. | 129 |
info/magnolia/module/delta/MoveAndRenamePropertyTask.java
| Violation | Line |
|---|---|
| Useless parentheses. | 72 |
info/magnolia/module/delta/OrderFilterBeforeTask.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'getFirstChild(Node,Collection)'. | 111 |
| Avoid unused private methods such as 'hasNodes(Node,Collection)'. | 122 |
info/magnolia/module/delta/RemoveDuplicatePermissionTask.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 87–91 |
info/magnolia/module/files/MD5CheckingFileExtractorOperation.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 104–106 |
| Avoid empty while statements | 162–163 |
info/magnolia/module/model/VersionRange.java
| Violation | Line |
|---|---|
| Useless parentheses. | 90 |
info/magnolia/module/model/reader/DependencyLevelComparator.java
| Violation | Line |
|---|---|
| Useless parentheses. | 114 |
info/magnolia/objectfactory/CandidateParameterResolver.java
| Violation | Line |
|---|---|
| Unnecessary use of fully qualified name 'javax.inject.Provider' due to existing import 'javax.inject.Provider' | 63 |
info/magnolia/objectfactory/ParameterResolver.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 43 |
info/magnolia/objectfactory/guice/GuiceComponentConfigurationModule.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'bindProvider(ProviderConfiguration)'. | 121 |
| Avoid unused private methods such as 'bindInstance(InstanceConfiguration)'. | 136 |
| Avoid unused private methods such as 'bindImplementation(ImplementationConfiguration)'. | 149 |
| Avoid unused private methods such as 'bindInScope(ScopedBindingBuilder,ComponentConfiguration)'. | 170 |
info/magnolia/objectfactory/guice/GuiceComponentProvider.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'logger'. | 64 |
| Avoid unused private methods such as 'concat(ParameterResolver,ParameterResolver)'. | 123 |
info/magnolia/objectfactory/guice/GuicePropertyConfigurer.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 60–63 |
info/magnolia/repository/DefaultRepositoryManager.java
| Violation | Line |
|---|---|
| Useless parentheses. | 137 |
info/magnolia/repository/RepositoryConstants.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 57 |
info/magnolia/repository/RepositoryNotInitializedException.java
| Violation | Line |
|---|---|
| Useless parentheses. | 56 |
info/magnolia/setup/CoreModuleVersionHandler.java
| Violation | Line |
|---|---|
| Useless parentheses. | 184 |
| Useless parentheses. | 187 |
| Useless parentheses. | 189 |
| Useless parentheses. | 191 |
| Useless parentheses. | 193 |
| Useless parentheses. | 201 |
info/magnolia/setup/for4_5/IsNotAProblematicEnvironmentCondition.java
| Violation | Line |
|---|---|
| Useless parentheses. | 84 |
| Useless parentheses. | 84 |
info/magnolia/setup/for4_5/UpdateSecurityFilterClientCallbacksConfiguration.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'ctx'. | 191 |
| Avoid unused method parameters such as 'ctx'. | 207 |
| Unnecessary use of fully qualified name 'ArrayUtils.contains' due to existing import 'org.apache.commons.lang.ArrayUtils' | 210 |
info/magnolia/setup/initial/AddURIPermissionsToAllRoles.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'addPermission(Content,String,String,long)'. | 96 |
info/magnolia/setup/initial/LoginAuthTypePropertyMovedToFilter.java
| Violation | Line |
|---|---|
| Useless parentheses. | 50 |
info/magnolia/stats/JCRStats.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 53 |
info/magnolia/stats/JCRStatsMBean.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 44 |
info/magnolia/voting/Voting.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 59–63 |
info/magnolia/voting/voters/AbstractBoolVoter.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 53 |