PMD Results

The following document contains the results of PMD 5.1.2.

Files

info/magnolia/cms/gui/control/ContextMenu.java

Violation Line
Avoid unused local variables such as 'counter'. 110

info/magnolia/cms/gui/control/FreemarkerControl.java

Violation Line
Avoid unused private fields such as 'log'. 59

info/magnolia/cms/gui/control/Tree.java

Violation Line
Avoid unused constructor parameters such as 'request'. 178
These nested if statements could be combined 238–240
Useless parentheses. 255
These nested if statements could be combined 1123–1141

info/magnolia/cms/gui/control/TreeColumnHtmlRendererImpl.java

Violation Line
These nested if statements could be combined 114–125

info/magnolia/cms/gui/controlx/Control.java

Violation Line
Avoid modifiers which are implied by the context 47
Avoid modifiers which are implied by the context 52
Avoid modifiers which are implied by the context 54
Avoid modifiers which are implied by the context 56
Avoid modifiers which are implied by the context 61
Avoid modifiers which are implied by the context 66
Avoid modifiers which are implied by the context 71
Avoid modifiers which are implied by the context 76
Avoid modifiers which are implied by the context 78
Avoid modifiers which are implied by the context 83
Avoid modifiers which are implied by the context 88

info/magnolia/cms/gui/controlx/RenderKit.java

Violation Line
Avoid modifiers which are implied by the context 48
Avoid modifiers which are implied by the context 55

info/magnolia/cms/gui/controlx/Renderer.java

Violation Line
Avoid modifiers which are implied by the context 43

info/magnolia/cms/gui/controlx/impl/AbstractControl.java

Violation Line
These nested if statements could be combined 151–153

info/magnolia/cms/gui/controlx/list/ListControlRenderer.java

Violation Line
These nested if statements could be combined 69–71
These nested if statements could be combined 84–86

info/magnolia/cms/gui/controlx/list/ListModel.java

Violation Line
Avoid modifiers which are implied by the context 47
Avoid modifiers which are implied by the context 53
Avoid modifiers which are implied by the context 59
Avoid modifiers which are implied by the context 66
Avoid modifiers which are implied by the context 72
Avoid modifiers which are implied by the context 79
Avoid modifiers which are implied by the context 85
Avoid modifiers which are implied by the context 91
Avoid modifiers which are implied by the context 97
Avoid modifiers which are implied by the context 103

info/magnolia/cms/gui/controlx/list/ListModelIterator.java

Violation Line
Avoid modifiers which are implied by the context 48
Avoid modifiers which are implied by the context 54
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 65
Avoid modifiers which are implied by the context 71
Avoid modifiers which are implied by the context 76

info/magnolia/cms/gui/controlx/list/ValueProvider.java

Violation Line
Avoid modifiers which are implied by the context 50

info/magnolia/cms/gui/controlx/search/DialogBasedSearchConfig.java

Violation Line
Avoid empty catch blocks 150–152

info/magnolia/cms/gui/controlx/search/DialogBasedSearchControlDefinition.java

Violation Line
Avoid modifiers which are implied by the context 44

info/magnolia/cms/gui/controlx/search/SearchConfig.java

Violation Line
Avoid modifiers which are implied by the context 48
Avoid modifiers which are implied by the context 50
Avoid modifiers which are implied by the context 52

info/magnolia/cms/gui/controlx/search/SearchableListModel.java

Violation Line
Avoid modifiers which are implied by the context 47
Avoid modifiers which are implied by the context 49

info/magnolia/cms/gui/dialog/Dialog.java

Violation Line
Avoid empty catch blocks 139–141
Avoid unused local variables such as 'id'. 253

info/magnolia/cms/gui/dialog/DialogBox.java

Violation Line
No need to import a type that lives in the same package 36
No need to import a type that lives in the same package 37

info/magnolia/cms/gui/dialog/DialogControlImpl.java

Violation Line
Avoid empty catch blocks 464–466
These nested if statements could be combined 624–627

info/magnolia/cms/gui/dialog/DialogFile.java

Violation Line
Avoid empty catch blocks 170–172

info/magnolia/cms/gui/dialog/DialogFreemarker.java

Violation Line
Avoid empty catch blocks 184–186

info/magnolia/cms/gui/dialog/UUIDDialogControl.java

Violation Line
Avoid modifiers which are implied by the context 43

info/magnolia/cms/gui/fckeditor/FCKEditorTmpFiles.java

Violation Line
Avoid unused private methods such as 'getTmpFiles()'. 88

info/magnolia/cms/gui/i18n/I18nAuthoringSupport.java

Violation Line
Avoid modifiers which are implied by the context 60–64

info/magnolia/cms/gui/inline/BarEdit.java

Violation Line
Avoid unused constructor parameters such as 'request'. 74

info/magnolia/cms/gui/inline/BarMain.java

Violation Line
Avoid unused constructor parameters such as 'request'. 93
Avoid unused constructor parameters such as 'request'. 100

info/magnolia/cms/gui/inline/BarNew.java

Violation Line
Avoid unused constructor parameters such as 'request'. 73

info/magnolia/cms/gui/inline/ButtonEdit.java

Violation Line
Avoid unused constructor parameters such as 'request'. 74
Avoid unused constructor parameters such as 'request'. 81

info/magnolia/cms/gui/query/AbstractExpressionImpl.java

Violation Line
Useless parentheses. 75
Useless parentheses. 102

info/magnolia/cms/gui/query/DateSearchQueryParameter.java

Violation Line
Avoid unused private fields such as 'log'. 47

info/magnolia/cms/gui/query/SearchQueryExpression.java

Violation Line
Avoid modifiers which are implied by the context 45
Avoid modifiers which are implied by the context 51
Avoid modifiers which are implied by the context 57
Avoid modifiers which are implied by the context 63
Avoid modifiers which are implied by the context 69
Avoid modifiers which are implied by the context 75
Avoid modifiers which are implied by the context 82