PMD Results

The following document contains the results of PMD 5.1.2.

Files

info/magnolia/module/admininterface/AdminTreeConfiguration.java

Violation Line
Avoid modifiers which are implied by the context 52
Avoid modifiers which are implied by the context 59
Avoid modifiers which are implied by the context 66
Avoid modifiers which are implied by the context 73

info/magnolia/module/admininterface/DialogAwareSaveHandler.java

Violation Line
Avoid modifiers which are implied by the context 45
Avoid modifiers which are implied by the context 47

info/magnolia/module/admininterface/DialogMVCHandler.java

Violation Line
Useless parentheses. 256
Useless parentheses. 256

info/magnolia/module/admininterface/PageHandlerManager.java

Violation Line
Avoid modifiers which are implied by the context 131–136
Avoid modifiers which are implied by the context 133
Avoid modifiers which are implied by the context 135

info/magnolia/module/admininterface/PageMVCServlet.java

Violation Line
Avoid unused imports such as 'info.magnolia.cms.util.RequestFormUtil' 38

info/magnolia/module/admininterface/SaveHandler.java

Violation Line
Avoid modifiers which are implied by the context 50
Avoid modifiers which are implied by the context 55
Avoid modifiers which are implied by the context 61
Avoid modifiers which are implied by the context 67
Avoid modifiers which are implied by the context 73
Avoid modifiers which are implied by the context 79
Avoid modifiers which are implied by the context 81
Avoid modifiers which are implied by the context 83
Avoid modifiers which are implied by the context 88
Avoid modifiers which are implied by the context 93
Avoid modifiers which are implied by the context 98
Avoid modifiers which are implied by the context 103
Avoid modifiers which are implied by the context 108
Avoid modifiers which are implied by the context 113
Avoid modifiers which are implied by the context 118
Avoid modifiers which are implied by the context 123
Avoid modifiers which are implied by the context 129
Avoid modifiers which are implied by the context 135

info/magnolia/module/admininterface/SaveHandlerImpl.java

Violation Line
Avoid unused imports such as 'javax.jcr.version.Version' 88

info/magnolia/module/admininterface/UUIDSaveHandler.java

Violation Line
These nested if statements could be combined 81–83
These nested if statements could be combined 98–104

info/magnolia/module/admininterface/ValidatingSaveHandler.java

Violation Line
Avoid modifiers which are implied by the context 38

info/magnolia/module/admininterface/commands/ActivationCommand.java

Violation Line
Avoid unused method parameters such as 'ctx'. 106
These nested if statements could be combined 298–300

info/magnolia/module/admininterface/commands/DeleteCommand.java

Violation Line
Avoid unused private fields such as 'log'. 52

info/magnolia/module/admininterface/config/PermissionConfiguration.java

Violation Line
Avoid unused private fields such as 'PERMISSION_ALL'. 39
Avoid unused private fields such as 'PERMISSION_READ'. 41
Avoid unused private fields such as 'PERMISSION_NO'. 43

info/magnolia/module/admininterface/config/SecurityConfiguration.java

Violation Line
Avoid unused private fields such as 'log'. 58
These nested if statements could be combined 106–110

info/magnolia/module/admininterface/dialogs/ParagraphSelectDialog.java

Violation Line
Useless parentheses. 105

info/magnolia/module/admininterface/dialogs/RolesEditDialog.java

Violation Line
Avoid empty catch blocks 149–151

info/magnolia/module/admininterface/dialogs/UserEditDialog.java

Violation Line
Avoid empty catch blocks 157–159
Avoid empty catch blocks 243–245

info/magnolia/module/admininterface/lists/VersionsList.java

Violation Line
Avoid unused imports such as 'info.magnolia.context.SystemContext' 54
Avoid unused imports such as 'info.magnolia.objectfactory.Components' 57
Avoid unused imports such as 'javax.jcr.LoginException' 62

info/magnolia/module/admininterface/pages/DevelopmentUtilsPage.java

Violation Line
Avoid empty catch blocks 475–477
Useless parentheses. 540

info/magnolia/module/admininterface/pages/ExportPage.java

Violation Line
Avoid unused private fields such as 'log'. 94
These nested if statements could be combined 293–295

info/magnolia/module/admininterface/pages/JCRUtilsPage.java

Violation Line
Useless parentheses. 146

info/magnolia/module/admininterface/pages/LogViewerPage.java

Violation Line
Useless parentheses. 149
Avoid unused private methods such as 'sendUnCompressed(java.io.InputStream,HttpServletResponse)'. 178
Useless parentheses. 279
Useless parentheses. 280
Avoid empty catch blocks 320–322
Useless parentheses. 350

info/magnolia/module/admininterface/pages/PermissionPage.java

Violation Line
Useless parentheses. 293

info/magnolia/module/admininterface/setup/for4_4/RegisterMgnlDeletedType.java

Violation Line
Avoid empty catch blocks 68–71

info/magnolia/module/admininterface/templates/MgnlDeletedTemplateModel.java

Violation Line
Avoid unused local variables such as 'iterator'. 68