Magnolia Core - PMD Results

PMD Results

The following document contains the results of PMD 4.2.5.

Files

info/magnolia/cms/beans/config/ConfigLoader.java

Violation	Line
Avoid unused constructor parameters such as 'context'.	82 - 104

info/magnolia/cms/beans/config/ObservedManager.java

Violation	Line
Avoid unnecessary return statements	130

info/magnolia/cms/beans/runtime/File.java

Violation	Line
Avoid empty catch blocks	165 - 167

info/magnolia/cms/core/AbstractContent.java

Violation	Line
Avoid empty catch blocks	407 - 409

info/magnolia/cms/core/AbstractNodeData.java

Violation	Line
Avoid empty catch blocks	129 - 131
Avoid empty catch blocks	200 - 202

info/magnolia/cms/core/BinaryNodeData.java

Violation	Line
These nested if statements could be combined	75 - 82

info/magnolia/cms/core/DefaultACLBasedPermissions.java

Violation	Line
Avoid unused constructor parameters such as 'configuration'.	107 - 112

info/magnolia/cms/core/DefaultContent.java

Violation	Line
Avoid empty catch blocks	310 - 312
Avoid empty catch blocks	355 - 357
Avoid unused local variables such as 'nodeType'.	518
Avoid empty catch blocks	544 - 546
Avoid empty catch blocks	546 - 548
Ensure you override both equals() and hashCode()	674

info/magnolia/cms/core/DefaultHierarchyManager.java

Violation	Line
Avoid unused constructor parameters such as 'ignoredAccessManager'.	88 - 90
Avoid unused constructor parameters such as 'ignoredUserId'.	92 - 94
Avoid unused constructor parameters such as 'ignored'.	99 - 101
Avoid unused local variables such as 'type'.	316
Avoid empty catch blocks	392 - 394

info/magnolia/cms/core/MagnoliaAccessProvider.java

Violation	Line
Avoid unused private fields such as 'compiledPermissionsClass'.	79

info/magnolia/cms/core/MetaData.java

Violation	Line
Avoid unused constructor parameters such as 'ignoredAccessManager'.	153 - 155

info/magnolia/cms/core/Path.java

Violation	Line
These nested if statements could be combined	338 - 340

info/magnolia/cms/core/version/MgnlVersioningNodeWrapper.java

Violation	Line
Avoid empty catch blocks	139 - 141
Avoid empty catch blocks	141 - 143

info/magnolia/cms/filters/AbstractMgnlFilter.java

Violation	Line
Avoid unused private fields such as 'log'.	65

info/magnolia/cms/filters/RepositoryMappingFilter.java

Violation	Line
Avoid unused private fields such as 'log'.	61

info/magnolia/cms/i18n/AbstractMessagesImpl.java

Violation	Line
Ensure you override both equals() and hashCode()	136

info/magnolia/cms/security/DelegatingUserManager.java

Violation	Line
Avoid empty catch blocks	144 - 146
Avoid empty catch blocks	167 - 169
Avoid empty catch blocks	191 - 193

info/magnolia/cms/security/Digester.java

Violation	Line
Avoid unused private fields such as 'log'.	76

info/magnolia/cms/security/ExternalUser.java

Violation	Line
Avoid unused private fields such as 'userDetails'.	62

info/magnolia/cms/security/LogoutFilter.java

Violation	Line
Avoid unused private fields such as 'log'.	59
Avoid unused private fields such as 'servletContext'.	63

info/magnolia/cms/security/MgnlGroup.java

Violation	Line
Avoid unused private fields such as 'log'.	47

info/magnolia/cms/security/MgnlRole.java

Violation	Line
Avoid unused private fields such as 'log'.	48
Avoid unused private fields such as 'acls'.	56

info/magnolia/cms/security/MgnlRoleManager.java

Violation	Line
These nested if statements could be combined	154 - 156
These nested if statements could be combined	193 - 196

info/magnolia/cms/security/MgnlUserManager.java

Violation	Line
Avoid unnecessary return statements	579

info/magnolia/cms/security/SecurityCallbackFilter.java

Violation	Line
Avoid unused private fields such as 'log'.	68

info/magnolia/cms/security/SystemUserManager.java

Violation	Line
Avoid unused method parameters such as 'password'.	166 - 193

info/magnolia/cms/security/auth/login/BasicLogin.java

Violation	Line
Avoid unused private fields such as 'log'.	49

info/magnolia/cms/servlets/ClasspathSpool.java

Violation	Line
Avoid empty catch blocks	97 - 99

info/magnolia/cms/servlets/MgnlServletContextListener.java

Violation	Line
Avoid unused private fields such as 'log'.	49

info/magnolia/cms/util/ClasspathResourcesUtil.java

Violation	Line
Avoid empty catch blocks	145 - 147
These nested if statements could be combined	267 - 269

info/magnolia/cms/util/ContentUtil.java

Violation	Line
Avoid empty catch blocks	461 - 463
Avoid empty catch blocks	476 - 478
These nested if statements could be combined	524 - 527

info/magnolia/cms/util/InheritanceContentWrapper.java

Violation	Line
Avoid unused private fields such as 'log'.	73

info/magnolia/cms/util/LazyInitPrintWriter.java

Violation	Line
Error while parsing /Users/mika/Work/magnolia/checkout/magnolia_main/magnolia-core/src/main/java/info/magnolia/cms/util/LazyInitPrintWriter.java: Encountered " "(" "( "" at line 48, column 14. Was expecting one of: "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ...	0
Error while parsing /Users/mika/Work/magnolia/checkout/magnolia_main/magnolia-core/src/main/java/info/magnolia/cms/util/LazyInitPrintWriter.java: Encountered " "(" "( "" at line 48, column 14. Was expecting one of: "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ...	0
Error while parsing /Users/mika/Work/magnolia/checkout/magnolia_main/magnolia-core/src/main/java/info/magnolia/cms/util/LazyInitPrintWriter.java: Encountered " "(" "( "" at line 48, column 14. Was expecting one of: "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ... "." ...	0

info/magnolia/cms/util/RequestFormUtil.java

Violation	Line
Avoid empty catch blocks	153 - 155

info/magnolia/cms/util/SearchReplace.java

Violation	Line
Avoid unused local variables such as 'group'.	87

info/magnolia/cms/util/ServletUtil.java

Violation	Line
Avoid empty if statements	176 - 178

info/magnolia/cms/util/UnicodeNormalizer.java

Violation	Line
Avoid unused private fields such as 'log'.	53

info/magnolia/commands/chain/ChainBase.java

Violation	Line
Avoid unused private fields such as 'log'.	51
Avoid empty catch blocks	123 - 125

info/magnolia/commands/impl/ExportCommand.java

Violation	Line
These nested if statements could be combined	126 - 128

info/magnolia/content2bean/impl/CollectionPropertyHidingTransformer.java

Violation	Line
These nested if statements could be combined	97 - 101

info/magnolia/content2bean/impl/Content2BeanTransformerImpl.java

Violation	Line
These nested if statements could be combined	352 - 357

info/magnolia/content2bean/impl/TypeMappingImpl.java

Violation	Line
These nested if statements could be combined	141 - 154
These nested if statements could be combined	254 - 256

info/magnolia/context/AbstractContext.java

Violation	Line
Avoid unused private fields such as 'log'.	68

info/magnolia/context/SingleJCRSessionSystemContext.java

Violation	Line
Avoid unused private fields such as 'log'.	49

info/magnolia/freemarker/FreemarkerServletContextWrapper.java

Violation	Line
Avoid empty catch blocks	112 - 114
Avoid empty catch blocks	177 - 179

info/magnolia/freemarker/models/BinaryNodeDataModel.java

Violation	Line
Avoid empty catch blocks	73 - 75
Avoid empty catch blocks	85 - 87
Avoid empty catch blocks	99 - 101
Avoid empty catch blocks	127 - 129

info/magnolia/freemarker/models/MagnoliaObjectWrapper.java

Violation	Line
Avoid unused private fields such as 'log'.	50

info/magnolia/importexport/PropertiesImportExport.java

Violation	Line
Avoid empty if statements	141 - 143
Avoid unused method parameters such as 'dumpMetaData'.	249 - 264

info/magnolia/jackrabbit/ProviderImpl.java

Violation	Line
Avoid empty catch blocks	182 - 184
Avoid empty catch blocks	477 - 479

info/magnolia/jcr/node2bean/impl/CollectionPropertyHidingTransformer.java

Violation	Line
These nested if statements could be combined	102 - 106

info/magnolia/jcr/node2bean/impl/Node2BeanTransformerImpl.java

Violation	Line
These nested if statements could be combined	291 - 296

info/magnolia/jcr/node2bean/impl/TypeMappingImpl.java

Violation	Line
These nested if statements could be combined	264 - 266

info/magnolia/jcr/util/ContentMap.java

Violation	Line
Avoid empty catch blocks	116 - 118
Avoid empty if statements	200 - 203
Avoid empty catch blocks	240 - 242
Avoid empty catch blocks	253 - 255
Avoid empty catch blocks	267 - 269

info/magnolia/jcr/util/PropertiesImportExport.java

Violation	Line
Avoid empty if statements	153 - 155

info/magnolia/jcr/util/PropertyUtil.java

Violation	Line
Avoid empty catch blocks	184 - 186

info/magnolia/jcr/wrapper/ChannelVisibilityContentDecorator.java

Violation	Line
These nested if statements could be combined	76 - 90

info/magnolia/jcr/wrapper/DelegateNodeWrapper.java

Violation	Line
Overriding method merely calls super	582 - 585

info/magnolia/jcr/wrapper/DelegateSessionWrapper.java

Violation	Line
Overriding method merely calls super	354 - 357

info/magnolia/jcr/wrapper/HTMLEscapingPropertyWrapper.java

Violation	Line
Avoid unused private fields such as 'transformLineBreaks'.	49

info/magnolia/jcr/wrapper/MgnlPropertySettingContentDecorator.java

Violation	Line
These nested if statements could be combined	192 - 202
Avoid unnecessary return statements	220

info/magnolia/jcr/wrapper/MgnlPropertySettingNodeWrapper.java

Violation	Line
Avoid empty if statements	211 - 213

info/magnolia/link/Link.java

Violation	Line
Avoid empty catch blocks	140 - 142
Avoid empty catch blocks	156 - 158
Avoid empty catch blocks	158 - 159
Avoid empty catch blocks	194 - 196

info/magnolia/link/LinkFactory.java

Violation	Line
Avoid unused private fields such as 'log'.	48

info/magnolia/link/LinkTransformerManager.java

Violation	Line
Avoid unused private fields such as 'log'.	52

info/magnolia/link/LinkUtil.java

Violation	Line
Avoid empty catch blocks	543 - 545

info/magnolia/module/ModuleManager.java

Violation	Line
These nested if statements could be combined	144 - 146

info/magnolia/module/delta/ChangeAllPropertiesWithCertainValueTask.java

Violation	Line
These nested if statements could be combined	92 - 94

info/magnolia/module/delta/RemoveDuplicatePermissionTask.java

Violation	Line
These nested if statements could be combined	91 - 95

info/magnolia/module/delta/RenamePropertyTask.java

Violation	Line
Avoid unused constructor parameters such as 'name'.	43 - 46

info/magnolia/module/files/MD5CheckingFileExtractorOperation.java

Violation	Line
Avoid empty if statements	121 - 123
Avoid empty while statements	187 - 188

info/magnolia/objectfactory/guice/GuicePropertyConfigurer.java

Violation	Line
Avoid empty catch blocks	58 - 61

info/magnolia/setup/for4_5/UpdateSecurityFilterClientCallbacksConfiguration.java

Violation	Line
Avoid unused method parameters such as 'ctx'.	189 - 203
Avoid unused method parameters such as 'ctx'.	205 - 213