PMD Results
The following document contains the results of PMD 4.2.5.
Files
info/magnolia/cms/beans/config/ConfigLoader.java
Violation | Line |
---|
Avoid unused constructor parameters such as 'context'. | 84 - 106 |
info/magnolia/cms/beans/config/ObservedManager.java
Violation | Line |
---|
Avoid unnecessary return statements | 132 |
info/magnolia/cms/beans/runtime/File.java
Violation | Line |
---|
Avoid empty catch blocks | 168 - 170 |
info/magnolia/cms/core/AbstractContent.java
Violation | Line |
---|
Avoid empty catch blocks | 410 - 412 |
info/magnolia/cms/core/AbstractNodeData.java
Violation | Line |
---|
Avoid empty catch blocks | 132 - 134 |
Avoid empty catch blocks | 203 - 205 |
info/magnolia/cms/core/BinaryNodeData.java
Violation | Line |
---|
These nested if statements could be combined | 77 - 84 |
info/magnolia/cms/core/DefaultACLBasedPermissions.java
Violation | Line |
---|
Avoid unused constructor parameters such as 'configuration'. | 121 - 125 |
info/magnolia/cms/core/DefaultContent.java
Violation | Line |
---|
Avoid empty catch blocks | 315 - 317 |
Avoid empty catch blocks | 360 - 362 |
Avoid unused local variables such as 'nodeType'. | 526 |
Avoid empty catch blocks | 552 - 554 |
Avoid empty catch blocks | 554 - 556 |
Ensure you override both equals() and hashCode() | 682 |
info/magnolia/cms/core/DefaultHierarchyManager.java
Violation | Line |
---|
Avoid unused constructor parameters such as 'ignoredAccessManager'. | 93 - 95 |
Avoid unused constructor parameters such as 'ignoredUserId'. | 97 - 99 |
Avoid unused constructor parameters such as 'ignored'. | 104 - 106 |
Avoid unused local variables such as 'type'. | 329 |
Avoid empty catch blocks | 406 - 408 |
info/magnolia/cms/core/MagnoliaAccessProvider.java
Violation | Line |
---|
Avoid unused private fields such as 'compiledPermissionsClass'. | 81 |
info/magnolia/cms/core/MetaData.java
Violation | Line |
---|
Avoid unused constructor parameters such as 'ignoredAccessManager'. | 155 - 157 |
info/magnolia/cms/core/Path.java
Violation | Line |
---|
These nested if statements could be combined | 325 - 327 |
info/magnolia/cms/core/version/MgnlVersioningNodeWrapper.java
Violation | Line |
---|
Avoid unused local variables such as 'nodeType'. | 114 |
Avoid empty catch blocks | 141 - 143 |
Avoid empty catch blocks | 143 - 145 |
info/magnolia/cms/filters/AbstractMgnlFilter.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 67 |
info/magnolia/cms/filters/RepositoryMappingFilter.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 62 |
info/magnolia/cms/i18n/AbstractMessagesImpl.java
Violation | Line |
---|
Ensure you override both equals() and hashCode() | 140 |
info/magnolia/cms/security/DelegatingUserManager.java
Violation | Line |
---|
Avoid empty catch blocks | 146 - 148 |
Avoid empty catch blocks | 169 - 171 |
Avoid empty catch blocks | 193 - 195 |
info/magnolia/cms/security/Digester.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 78 |
info/magnolia/cms/security/ExternalUser.java
Violation | Line |
---|
Avoid unused private fields such as 'userDetails'. | 63 |
info/magnolia/cms/security/LogoutFilter.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 59 |
Avoid unused private fields such as 'servletContext'. | 63 |
info/magnolia/cms/security/MgnlGroup.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 48 |
info/magnolia/cms/security/MgnlRole.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 49 |
Avoid unused private fields such as 'acls'. | 57 |
info/magnolia/cms/security/MgnlRoleManager.java
Violation | Line |
---|
These nested if statements could be combined | 145 - 147 |
These nested if statements could be combined | 184 - 187 |
info/magnolia/cms/security/MgnlUserManager.java
Violation | Line |
---|
Avoid unnecessary return statements | 561 |
info/magnolia/cms/security/SecurityCallbackFilter.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 71 |
info/magnolia/cms/security/SystemUserManager.java
Violation | Line |
---|
Avoid unused method parameters such as 'password'. | 134 - 161 |
info/magnolia/cms/security/auth/callback/RealmCallback.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 56 |
info/magnolia/cms/security/auth/callback/UserCallback.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 55 |
info/magnolia/cms/security/auth/login/BasicLogin.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 50 |
info/magnolia/cms/servlets/ClasspathSpool.java
Violation | Line |
---|
Avoid empty catch blocks | 101 - 103 |
info/magnolia/cms/servlets/MgnlServletContextListener.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 51 |
info/magnolia/cms/util/ClasspathResourcesUtil.java
Violation | Line |
---|
Avoid empty catch blocks | 151 - 153 |
These nested if statements could be combined | 274 - 276 |
info/magnolia/cms/util/ContentUtil.java
Violation | Line |
---|
Avoid empty catch blocks | 466 - 468 |
Avoid empty catch blocks | 481 - 483 |
These nested if statements could be combined | 529 - 532 |
info/magnolia/cms/util/InheritanceContentWrapper.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 75 |
info/magnolia/cms/util/LazyInitPrintWriter.java
Violation | Line |
---|
Error while parsing /Users/mdivilek/dev/release/5.2/magnolia_main/target/checkout/magnolia-core/src/main/java/info/magnolia/cms/util/LazyInitPrintWriter.java: Encountered " "(" "( "" at line 48, column 14.
Was expecting one of:
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
| 0 |
Error while parsing /Users/mdivilek/dev/release/5.2/magnolia_main/target/checkout/magnolia-core/src/main/java/info/magnolia/cms/util/LazyInitPrintWriter.java: Encountered " "(" "( "" at line 48, column 14.
Was expecting one of:
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
| 0 |
Error while parsing /Users/mdivilek/dev/release/5.2/magnolia_main/target/checkout/magnolia-core/src/main/java/info/magnolia/cms/util/LazyInitPrintWriter.java: Encountered " "(" "( "" at line 48, column 14.
Was expecting one of:
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
"." ...
| 0 |
info/magnolia/cms/util/RequestFormUtil.java
Violation | Line |
---|
Avoid empty catch blocks | 161 - 163 |
info/magnolia/cms/util/SearchReplace.java
Violation | Line |
---|
Avoid unused local variables such as 'group'. | 90 |
info/magnolia/cms/util/ServletUtil.java
Violation | Line |
---|
Avoid empty if statements | 177 - 179 |
info/magnolia/cms/util/UnicodeNormalizer.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 56 |
info/magnolia/commands/chain/ChainBase.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 51 |
Avoid empty catch blocks | 123 - 125 |
info/magnolia/commands/impl/ExportCommand.java
Violation | Line |
---|
These nested if statements could be combined | 126 - 128 |
info/magnolia/content2bean/impl/CollectionPropertyHidingTransformer.java
Violation | Line |
---|
These nested if statements could be combined | 98 - 102 |
info/magnolia/content2bean/impl/Content2BeanTransformerImpl.java
Violation | Line |
---|
These nested if statements could be combined | 353 - 358 |
info/magnolia/content2bean/impl/TypeMappingImpl.java
Violation | Line |
---|
These nested if statements could be combined | 142 - 155 |
These nested if statements could be combined | 259 - 261 |
info/magnolia/context/AbstractContext.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 70 |
info/magnolia/context/SingleJCRSessionSystemContext.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 52 |
info/magnolia/freemarker/FreemarkerServletContextWrapper.java
Violation | Line |
---|
Avoid empty catch blocks | 105 - 107 |
Avoid empty catch blocks | 170 - 172 |
info/magnolia/freemarker/models/BinaryNodeDataModel.java
Violation | Line |
---|
Avoid empty catch blocks | 76 - 78 |
Avoid empty catch blocks | 88 - 90 |
Avoid empty catch blocks | 102 - 104 |
Avoid empty catch blocks | 130 - 132 |
info/magnolia/freemarker/models/MagnoliaObjectWrapper.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 54 |
info/magnolia/importexport/PropertiesImportExport.java
Violation | Line |
---|
Avoid empty if statements | 142 - 144 |
Avoid unused method parameters such as 'dumpMetaData'. | 250 - 265 |
info/magnolia/jackrabbit/ProviderImpl.java
Violation | Line |
---|
Avoid empty catch blocks | 184 - 186 |
Avoid empty catch blocks | 480 - 482 |
info/magnolia/jcr/node2bean/impl/CollectionPropertyHidingTransformer.java
Violation | Line |
---|
These nested if statements could be combined | 102 - 106 |
info/magnolia/jcr/node2bean/impl/Node2BeanTransformerImpl.java
Violation | Line |
---|
These nested if statements could be combined | 291 - 296 |
info/magnolia/jcr/node2bean/impl/TypeMappingImpl.java
Violation | Line |
---|
These nested if statements could be combined | 255 - 257 |
info/magnolia/jcr/util/ContentMap.java
Violation | Line |
---|
Avoid empty catch blocks | 118 - 120 |
Avoid empty if statements | 202 - 205 |
Avoid empty catch blocks | 242 - 244 |
Avoid empty catch blocks | 255 - 257 |
Avoid empty catch blocks | 269 - 271 |
info/magnolia/jcr/util/PropertiesImportExport.java
Violation | Line |
---|
Avoid empty if statements | 153 - 155 |
info/magnolia/jcr/util/PropertyUtil.java
Violation | Line |
---|
Avoid empty catch blocks | 184 - 186 |
info/magnolia/jcr/wrapper/ChannelVisibilityContentDecorator.java
Violation | Line |
---|
These nested if statements could be combined | 78 - 92 |
info/magnolia/jcr/wrapper/DelegateNodeWrapper.java
Violation | Line |
---|
Overriding method merely calls super | 582 - 585 |
info/magnolia/jcr/wrapper/DelegateSessionWrapper.java
Violation | Line |
---|
Overriding method merely calls super | 356 - 359 |
info/magnolia/jcr/wrapper/HTMLEscapingPropertyWrapper.java
Violation | Line |
---|
Avoid unused private fields such as 'transformLineBreaks'. | 50 |
info/magnolia/jcr/wrapper/LastUpdateContentDecorator.java
Violation | Line |
---|
Avoid unnecessary return statements | 167 |
info/magnolia/jcr/wrapper/LastUpdateNodeWrapper.java
Violation | Line |
---|
Avoid empty if statements | 210 - 212 |
info/magnolia/link/Link.java
Violation | Line |
---|
Avoid empty catch blocks | 148 - 150 |
Avoid empty catch blocks | 164 - 166 |
Avoid empty catch blocks | 166 - 167 |
Avoid empty catch blocks | 202 - 204 |
info/magnolia/link/LinkFactory.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 48 |
info/magnolia/link/LinkTransformerManager.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 54 |
info/magnolia/link/LinkUtil.java
Violation | Line |
---|
Avoid empty catch blocks | 553 - 555 |
info/magnolia/module/ModuleManager.java
Violation | Line |
---|
These nested if statements could be combined | 149 - 151 |
info/magnolia/module/delta/ChangeAllPropertiesWithCertainValueTask.java
Violation | Line |
---|
These nested if statements could be combined | 83 - 85 |
info/magnolia/module/delta/RemoveDuplicatePermissionTask.java
Violation | Line |
---|
These nested if statements could be combined | 87 - 91 |
info/magnolia/module/files/MD5CheckingFileExtractorOperation.java
Violation | Line |
---|
Avoid empty if statements | 104 - 106 |
Avoid empty while statements | 162 - 163 |
info/magnolia/objectfactory/guice/GuicePropertyConfigurer.java
Violation | Line |
---|
Avoid empty catch blocks | 60 - 63 |
info/magnolia/setup/CoreModuleVersionHandler.java
Violation | Line |
---|
Avoid unused private methods such as 'get45ConfigFileConditions()'. | 214 |
info/magnolia/setup/for4_5/UpdateSecurityFilterClientCallbacksConfiguration.java
Violation | Line |
---|
Avoid unused method parameters such as 'ctx'. | 189 - 203 |
Avoid unused method parameters such as 'ctx'. | 205 - 213 |
info/magnolia/stats/JCRStats.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 53 |
info/magnolia/voting/voters/AbstractBoolVoter.java
Violation | Line |
---|
Avoid unused private fields such as 'log'. | 53 |