Last Published: 2018-02-01
PMD Results
The following document contains the results of PMD 5.1.2.
Files
info/magnolia/channel/ChannelResolver.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 51 |
info/magnolia/cms/beans/config/ConfigLoader.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'context'. | 83 |
info/magnolia/cms/beans/config/ConfigurationException.java
| Violation | Line |
|---|---|
| Useless parentheses. | 46 |
info/magnolia/cms/beans/config/HostBasedVirtualURIMapping.java
| Violation | Line |
|---|---|
| Useless parentheses. | 171 |
info/magnolia/cms/beans/config/MIMEMapping.java
| Violation | Line |
|---|---|
| Useless parentheses. | 223 |
info/magnolia/cms/beans/config/ObservedManager.java
| Violation | Line |
|---|---|
| Avoid unnecessary return statements | 133 |
info/magnolia/cms/beans/config/RotatingVirtualURIMapping.java
| Violation | Line |
|---|---|
| Useless parentheses. | 119 |
info/magnolia/cms/beans/config/VirtualURIMapping.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 68–92 |
info/magnolia/cms/beans/runtime/Document.java
| Violation | Line |
|---|---|
| Useless parentheses. | 206 |
info/magnolia/cms/core/AbstractContent.java
| Violation | Line |
|---|---|
| Useless parentheses. | 340 |
| Useless parentheses. | 345 |
| Avoid empty catch blocks | 404–406 |
info/magnolia/cms/core/AbstractNodeData.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 132–134 |
| Avoid empty catch blocks | 203–205 |
info/magnolia/cms/core/BinaryNodeData.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 76–82 |
info/magnolia/cms/core/Content.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 762 |
| Avoid modifiers which are implied by the context | 770–779 |
| Avoid modifiers which are implied by the context | 777 |
info/magnolia/cms/core/DefaultACLBasedPermissions.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'configuration'. | 107 |
| Useless parentheses. | 117 |
| Useless parentheses. | 117 |
info/magnolia/cms/core/DefaultContent.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 341–343 |
| Avoid empty catch blocks | 384–386 |
| Avoid empty catch blocks | 554–556 |
| Ensure you override both equals() and hashCode() | 678 |
| Useless parentheses. | 696 |
info/magnolia/cms/core/DefaultHierarchyManager.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'repositoryManager'. | 84 |
| Avoid unused constructor parameters such as 'userId'. | 95 |
| Avoid unused constructor parameters such as 'ignoredAccessManager'. | 95 |
| Avoid unused constructor parameters such as 'ignoredUserId'. | 103 |
| Avoid unused constructor parameters such as 'ignored'. | 112 |
| Useless parentheses. | 193 |
| Avoid unused local variables such as 'type'. | 328 |
| Useless parentheses. | 351 |
| Avoid empty catch blocks | 403–405 |
info/magnolia/cms/core/MetaData.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'ignoredAccessManager'. | 152 |
| Avoid unused private methods such as 'setJCRProperty(String,Object)'. | 397 |
info/magnolia/cms/core/NodeTypeBasedPermissions.java
| Violation | Line |
|---|---|
| Useless parentheses. | 112 |
| Useless parentheses. | 112 |
info/magnolia/cms/core/Path.java
| Violation | Line |
|---|---|
| Useless parentheses. | 243 |
| Useless parentheses. | 243 |
| Useless parentheses. | 243 |
| Useless parentheses. | 244 |
| Useless parentheses. | 244 |
| Useless parentheses. | 244 |
| Useless parentheses. | 245 |
| Useless parentheses. | 245 |
| Useless parentheses. | 245 |
info/magnolia/cms/core/SystemProperty.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'getMagnoliaConfigurationProperties()'. | 162 |
info/magnolia/cms/core/search/QueryManagerImpl.java
| Violation | Line |
|---|---|
| Useless parentheses. | 94 |
| Useless parentheses. | 100 |
info/magnolia/cms/core/search/QueryResultImpl.java
| Violation | Line |
|---|---|
| Useless parentheses. | 131 |
info/magnolia/cms/core/version/ContentVersion.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'wrap(Collection)'. | 412 |
| Useless parentheses. | 425 |
| Useless parentheses. | 434 |
info/magnolia/cms/core/version/MgnlVersioningNodeWrapper.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'repositoryManager'. | 76 |
info/magnolia/cms/core/version/VersionManager.java
| Violation | Line |
|---|---|
| Useless parentheses. | 107 |
info/magnolia/cms/exchange/ActivationManager.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 44 |
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 64 |
| Avoid modifiers which are implied by the context | 66 |
| Avoid modifiers which are implied by the context | 71 |
info/magnolia/cms/exchange/ExchangeException.java
| Violation | Line |
|---|---|
| Useless parentheses. | 55 |
info/magnolia/cms/exchange/Subscriber.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 43 |
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 61 |
| Avoid modifiers which are implied by the context | 63 |
| Avoid modifiers which are implied by the context | 65 |
| Avoid modifiers which are implied by the context | 67 |
| Avoid modifiers which are implied by the context | 69 |
| Avoid modifiers which are implied by the context | 71 |
info/magnolia/cms/exchange/Subscription.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 43 |
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 57 |
info/magnolia/cms/exchange/Syndicator.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 60 |
| Avoid modifiers which are implied by the context | 68 |
| Avoid modifiers which are implied by the context | 77 |
| Avoid modifiers which are implied by the context | 85 |
| Avoid modifiers which are implied by the context | 94 |
| Avoid modifiers which are implied by the context | 99 |
| Avoid modifiers which are implied by the context | 104 |
info/magnolia/cms/filters/AggregatorFilter.java
| Violation | Line |
|---|---|
| Useless parentheses. | 223 |
info/magnolia/cms/filters/CosMultipartRequestFilter.java
| Violation | Line |
|---|---|
| Useless parentheses. | 100 |
info/magnolia/cms/filters/FilterManager.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 52 |
info/magnolia/cms/filters/RepositoryMappingFilter.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 62 |
info/magnolia/cms/filters/WebContainerResources.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 49 |
info/magnolia/cms/i18n/AbstractI18nContentSupport.java
| Violation | Line |
|---|---|
| Useless parentheses. | 391 |
info/magnolia/cms/i18n/AbstractMessagesImpl.java
| Violation | Line |
|---|---|
| Ensure you override both equals() and hashCode() | 140 |
info/magnolia/cms/i18n/I18nContentSupport.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 62 |
| Avoid modifiers which are implied by the context | 64 |
| Avoid modifiers which are implied by the context | 69 |
| Avoid modifiers which are implied by the context | 74 |
| Avoid modifiers which are implied by the context | 79 |
| Avoid modifiers which are implied by the context | 87 |
| Avoid modifiers which are implied by the context | 95 |
| Avoid modifiers which are implied by the context | 100 |
| Avoid modifiers which are implied by the context | 105 |
| Avoid modifiers which are implied by the context | 110 |
| Avoid modifiers which are implied by the context | 115 |
| Avoid modifiers which are implied by the context | 120 |
| Avoid modifiers which are implied by the context | 122 |
| Avoid modifiers which are implied by the context | 124 |
info/magnolia/cms/i18n/Messages.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 63 |
| Avoid modifiers which are implied by the context | 70 |
| Avoid modifiers which are implied by the context | 79 |
| Avoid modifiers which are implied by the context | 89 |
| Avoid modifiers which are implied by the context | 94 |
| Avoid modifiers which are implied by the context | 99 |
info/magnolia/cms/security/AccessDeniedException.java
| Violation | Line |
|---|---|
| Useless parentheses. | 53 |
info/magnolia/cms/security/AccessManagerImpl.java
| Violation | Line |
|---|---|
| Useless parentheses. | 83 |
info/magnolia/cms/security/DelegatingUserManager.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 163–165 |
| Avoid empty catch blocks | 187–189 |
| Avoid empty catch blocks | 206–208 |
info/magnolia/cms/security/Digester.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 76 |
info/magnolia/cms/security/ExternalUser.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'userDetails'. | 62 |
info/magnolia/cms/security/ExternalUserManager.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 58 |
info/magnolia/cms/security/Group.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 44 |
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 62 |
| Avoid modifiers which are implied by the context | 68 |
| Avoid modifiers which are implied by the context | 70 |
| Avoid modifiers which are implied by the context | 85 |
| Avoid modifiers which are implied by the context | 90 |
| Avoid modifiers which are implied by the context | 95 |
| Avoid modifiers which are implied by the context | 100 |
info/magnolia/cms/security/IPSecurityManager.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 51–55 |
info/magnolia/cms/security/IPSecurityManagerImpl.java
| Violation | Line |
|---|---|
| Useless parentheses. | 85 |
info/magnolia/cms/security/Lock.java
| Violation | Line |
|---|---|
| Useless parentheses. | 87 |
info/magnolia/cms/security/LogoutFilter.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 59 |
| Avoid unused private fields such as 'servletContext'. | 63 |
info/magnolia/cms/security/MgnlGroup.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 47 |
info/magnolia/cms/security/MgnlRole.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'acls'. | 56 |
info/magnolia/cms/security/MgnlRoleManager.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 167–169 |
| These nested if statements could be combined | 205–208 |
info/magnolia/cms/security/MgnlUserManager.java
| Violation | Line |
|---|---|
| Useless parentheses. | 322 |
| Avoid unnecessary return statements | 548 |
| Avoid unused private methods such as 'collectUniquePropertyNames(Node,String,String,Collection,boolean)'. | 633 |
info/magnolia/cms/security/Realm.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 62 |
| Avoid modifiers which are implied by the context | 99–106 |
info/magnolia/cms/security/RepositoryBackedSecurityManager.java
| Violation | Line |
|---|---|
| Useless parentheses. | 112 |
| Useless parentheses. | 167 |
info/magnolia/cms/security/Role.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 43 |
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 61 |
| Avoid modifiers which are implied by the context | 66 |
info/magnolia/cms/security/RoleManager.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 63 |
| Avoid modifiers which are implied by the context | 70 |
| Avoid modifiers which are implied by the context | 75 |
| Avoid modifiers which are implied by the context | 80 |
| Avoid modifiers which are implied by the context | 85 |
info/magnolia/cms/security/SecurityCallbackFilter.java
| Violation | Line |
|---|---|
| Unnecessary use of fully qualified name 'HttpServletResponse.SC_UNAUTHORIZED' due to existing import 'javax.servlet.http.HttpServletResponse' | 91 |
info/magnolia/cms/security/SecuritySupport.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 70–74 |
info/magnolia/cms/security/SystemUserManager.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'password'. | 166 |
info/magnolia/cms/security/UserManager.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 63 |
| Avoid modifiers which are implied by the context | 71 |
| Avoid modifiers which are implied by the context | 79 |
| Avoid modifiers which are implied by the context | 88 |
| Avoid modifiers which are implied by the context | 95 |
| Avoid modifiers which are implied by the context | 102 |
| Avoid modifiers which are implied by the context | 110 |
| Avoid modifiers which are implied by the context | 117 |
| Avoid modifiers which are implied by the context | 124 |
| Avoid modifiers which are implied by the context | 132 |
| Avoid modifiers which are implied by the context | 144 |
| Avoid modifiers which are implied by the context | 149 |
| Avoid modifiers which are implied by the context | 158 |
| Avoid modifiers which are implied by the context | 165 |
| Avoid modifiers which are implied by the context | 172 |
| Avoid modifiers which are implied by the context | 179 |
| Avoid modifiers which are implied by the context | 186 |
| Avoid modifiers which are implied by the context | 193 |
| Avoid modifiers which are implied by the context | 200 |
| Avoid modifiers which are implied by the context | 208 |
| Avoid modifiers which are implied by the context | 213 |
| Avoid modifiers which are implied by the context | 220 |
| Avoid modifiers which are implied by the context | 227 |
| Avoid modifiers which are implied by the context | 235 |
| Avoid modifiers which are implied by the context | 244 |
| Avoid modifiers which are implied by the context | 250 |
info/magnolia/cms/security/auth/Entity.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 64 |
| Avoid modifiers which are implied by the context | 70 |
| Avoid modifiers which are implied by the context | 72 |
| Avoid modifiers which are implied by the context | 77 |
info/magnolia/cms/security/auth/PrincipalCollection.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 60 |
| Avoid modifiers which are implied by the context | 62 |
| Avoid modifiers which are implied by the context | 65 |
| Avoid modifiers which are implied by the context | 70 |
| Avoid modifiers which are implied by the context | 75 |
| Avoid modifiers which are implied by the context | 77 |
info/magnolia/cms/security/auth/callback/Base64CallbackHandler.java
| Violation | Line |
|---|---|
| Useless parentheses. | 63 |
info/magnolia/cms/security/auth/login/BasicLogin.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 50 |
info/magnolia/cms/security/auth/login/LoginHandler.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 48 |
info/magnolia/cms/security/operations/OperationPermissionDefinition.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 43 |
| Avoid modifiers which are implied by the context | 44 |
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 61 |
| Avoid modifiers which are implied by the context | 63 |
| Avoid modifiers which are implied by the context | 65 |
| Avoid modifiers which are implied by the context | 67 |
| Avoid modifiers which are implied by the context | 69 |
| Avoid modifiers which are implied by the context | 71 |
| Avoid modifiers which are implied by the context | 73 |
info/magnolia/cms/servlets/MgnlServletContextListener.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 51 |
info/magnolia/cms/util/ClasspathResourcesUtil.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 72–74 |
| Avoid modifiers which are implied by the context | 73 |
| Avoid empty catch blocks | 155–157 |
| These nested if statements could be combined | 276–278 |
info/magnolia/cms/util/ContentUtil.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 134–136 |
| Avoid modifiers which are implied by the context | 141–143 |
| Avoid empty catch blocks | 457–459 |
| Avoid empty catch blocks | 471–473 |
| These nested if statements could be combined | 519–522 |
| Useless parentheses. | 593 |
info/magnolia/cms/util/DateUtil.java
| Violation | Line |
|---|---|
| Useless parentheses. | 204 |
info/magnolia/cms/util/DelayedExecutor.java
| Violation | Line |
|---|---|
| Useless parentheses. | 82 |
info/magnolia/cms/util/DeprecationUtil.java
| Violation | Line |
|---|---|
| Unnecessary use of fully qualified name 'org.slf4j.Logger' due to existing import 'org.slf4j.Logger' | 45 |
| Unnecessary use of fully qualified name 'org.slf4j.LoggerFactory.getLogger' due to existing import 'org.slf4j.LoggerFactory' | 45 |
| Useless parentheses. | 64 |
info/magnolia/cms/util/InheritanceContentWrapper.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 73 |
info/magnolia/cms/util/LazyNodeDataWrapper.java
| Violation | Line |
|---|---|
| Useless parentheses. | 74 |
info/magnolia/cms/util/NodeDataUtil.java
| Violation | Line |
|---|---|
| Useless parentheses. | 108 |
| Useless parentheses. | 110 |
| Useless parentheses. | 112 |
| Useless parentheses. | 114 |
| Useless parentheses. | 116 |
| Useless parentheses. | 119 |
| Useless parentheses. | 193 |
| Useless parentheses. | 195 |
| Useless parentheses. | 197 |
| Useless parentheses. | 199 |
| Useless parentheses. | 201 |
| Useless parentheses. | 203 |
| Useless parentheses. | 233 |
| Useless parentheses. | 238 |
info/magnolia/cms/util/NodeMapWrapper.java
| Violation | Line |
|---|---|
| Useless parentheses. | 244 |
info/magnolia/cms/util/PathUtil.java
| Violation | Line |
|---|---|
| Useless parentheses. | 46 |
info/magnolia/cms/util/QueryUtil.java
| Violation | Line |
|---|---|
| Unnecessary use of fully qualified name 'javax.jcr.query.Query.JCR_SQL2' due to existing import 'javax.jcr.query.Query' | 237 |
info/magnolia/cms/util/RequestDispatchUtil.java
| Violation | Line |
|---|---|
| Useless parentheses. | 129 |
| Useless parentheses. | 129 |
info/magnolia/cms/util/SearchReplace.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'group'. | 87 |
info/magnolia/cms/util/ServletUtil.java
| Violation | Line |
|---|---|
| Useless parentheses. | 99 |
| Useless parentheses. | 178 |
| Avoid empty if statements | 178–180 |
| Useless parentheses. | 178 |
info/magnolia/cms/util/UnicodeNormalizer.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 55 |
info/magnolia/cms/util/UrlPattern.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 74–97 |
info/magnolia/commands/MgnlCatalog.java
| Violation | Line |
|---|---|
| Useless parentheses. | 75 |
info/magnolia/commands/chain/ChainBase.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 51 |
| Avoid empty catch blocks | 123–125 |
| Useless parentheses. | 129 |
| Useless parentheses. | 132 |
info/magnolia/commands/chain/Command.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 58 |
info/magnolia/commands/impl/ExportCommand.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 131–133 |
info/magnolia/content2bean/Bean2ContentProcessor.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 48 |
info/magnolia/content2bean/Bean2ContentTransformer.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 64 |
| Avoid modifiers which are implied by the context | 69 |
| Avoid modifiers which are implied by the context | 74 |
| Avoid modifiers which are implied by the context | 79 |
| Avoid modifiers which are implied by the context | 84 |
info/magnolia/content2bean/Content2BeanProcessor.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 51–52 |
| Avoid modifiers which are implied by the context | 57 |
info/magnolia/content2bean/Content2BeanTransformer.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 63 |
| Avoid modifiers which are implied by the context | 68 |
| Avoid modifiers which are implied by the context | 73 |
| Avoid modifiers which are implied by the context | 78 |
| Avoid modifiers which are implied by the context | 83 |
| Avoid modifiers which are implied by the context | 88 |
| Avoid modifiers which are implied by the context | 93 |
| Avoid modifiers which are implied by the context | 100 |
info/magnolia/content2bean/TransformationState.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 60 |
| Avoid modifiers which are implied by the context | 62 |
| Avoid modifiers which are implied by the context | 64 |
| Avoid modifiers which are implied by the context | 66 |
| Avoid modifiers which are implied by the context | 68 |
| Avoid modifiers which are implied by the context | 70 |
| Avoid modifiers which are implied by the context | 72 |
| Avoid modifiers which are implied by the context | 77 |
info/magnolia/content2bean/impl/CollectionPropertyHidingTransformer.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 97–101 |
info/magnolia/content2bean/impl/Content2BeanTransformerImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 348–353 |
info/magnolia/content2bean/impl/TypeMappingImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 140–152 |
| These nested if statements could be combined | 253–255 |
info/magnolia/context/AbstractContext.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 68 |
info/magnolia/context/Context.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 61 |
| Avoid modifiers which are implied by the context | 66 |
| Avoid modifiers which are implied by the context | 71 |
| Avoid modifiers which are implied by the context | 73 |
| Avoid modifiers which are implied by the context | 75 |
| Avoid modifiers which are implied by the context | 77 |
| Avoid modifiers which are implied by the context | 79 |
| Avoid modifiers which are implied by the context | 81 |
| Avoid modifiers which are implied by the context | 83 |
| Avoid modifiers which are implied by the context | 85 |
| Avoid modifiers which are implied by the context | 87 |
| Avoid modifiers which are implied by the context | 89 |
| Avoid modifiers which are implied by the context | 96 |
| Avoid modifiers which are implied by the context | 101 |
| Avoid modifiers which are implied by the context | 106 |
| Avoid modifiers which are implied by the context | 108 |
| Avoid modifiers which are implied by the context | 110 |
| Avoid modifiers which are implied by the context | 115 |
| Avoid modifiers which are implied by the context | 117 |
| Avoid modifiers which are implied by the context | 126 |
| Avoid modifiers which are implied by the context | 131 |
| Avoid modifiers which are implied by the context | 139 |
| Avoid modifiers which are implied by the context | 147 |
| Avoid modifiers which are implied by the context | 156 |
| Avoid modifiers which are implied by the context | 165 |
| Avoid modifiers which are implied by the context | 172 |
| Avoid modifiers which are implied by the context | 177 |
| Avoid modifiers which are implied by the context | 184 |
| Avoid modifiers which are implied by the context | 190 |
| Avoid modifiers which are implied by the context | 198 |
| Avoid modifiers which are implied by the context | 203 |
info/magnolia/context/MgnlContext.java
| Violation | Line |
|---|---|
| Useless parentheses. | 398 |
| Avoid modifiers which are implied by the context | 419–421 |
info/magnolia/context/SingleJCRSessionSystemContext.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 49 |
info/magnolia/context/ThreadDependentSystemContext.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
info/magnolia/context/WebContext.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 60 |
| Avoid modifiers which are implied by the context | 67 |
| Avoid modifiers which are implied by the context | 72 |
| Avoid modifiers which are implied by the context | 77 |
| Avoid modifiers which are implied by the context | 89 |
| Avoid modifiers which are implied by the context | 96 |
| Avoid modifiers which are implied by the context | 103 |
| Avoid modifiers which are implied by the context | 108 |
| Avoid modifiers which are implied by the context | 115 |
| Avoid modifiers which are implied by the context | 120 |
| Avoid modifiers which are implied by the context | 153 |
| Avoid modifiers which are implied by the context | 158 |
| Avoid modifiers which are implied by the context | 165 |
info/magnolia/debug/TrackingStatus.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'trace'. | 50 |
info/magnolia/event/SystemEventBus.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 41 |
info/magnolia/importexport/BootstrapFilesComparator.java
| Violation | Line |
|---|---|
| Useless parentheses. | 73 |
| Useless parentheses. | 73 |
info/magnolia/importexport/DataTransporter.java
| Violation | Line |
|---|---|
| Useless parentheses. | 445 |
| Useless parentheses. | 447 |
info/magnolia/importexport/PropertiesImportExport.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 142–144 |
| Avoid unused method parameters such as 'dumpMetaData'. | 249 |
| Useless parentheses. | 287 |
| Useless parentheses. | 290 |
| Useless parentheses. | 293 |
| Useless parentheses. | 296 |
| Useless parentheses. | 299 |
| Useless parentheses. | 302 |
| Useless parentheses. | 305 |
info/magnolia/importexport/filters/MetadataUuidFilter.java
| Violation | Line |
|---|---|
| Useless parentheses. | 136 |
info/magnolia/importexport/filters/SkipNodePropertyFilter.java
| Violation | Line |
|---|---|
| Useless parentheses. | 134 |
info/magnolia/importexport/outputter/DocumentViewOutputter.java
| Violation | Line |
|---|---|
| Useless parentheses. | 113 |
| Useless parentheses. | 113 |
info/magnolia/importexport/postprocessors/MetaDataAsMixinConversionHelper.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'moveProperties(Node,Node,Map)'. | 212 |
info/magnolia/jackrabbit/ProviderImpl.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 197–199 |
| Avoid empty catch blocks | 460–462 |
info/magnolia/jcr/decoration/ContentDecoratorNodeWrapper.java
| Violation | Line |
|---|---|
| Useless parentheses. | 345 |
| Useless parentheses. | 346 |
info/magnolia/jcr/node2bean/impl/CollectionPropertyHidingTransformer.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 101–105 |
info/magnolia/jcr/node2bean/impl/Node2BeanTransformerImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 319–324 |
info/magnolia/jcr/node2bean/impl/TypeMappingImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 305–307 |
info/magnolia/jcr/nodebuilder/Ops.java
| Violation | Line |
|---|---|
| Useless parentheses. | 202 |
info/magnolia/jcr/util/ContentMap.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 112–114 |
| Avoid empty if statements | 196–199 |
| Unnecessary use of fully qualified name 'info.magnolia.link.LinkUtil.convertLinksFromUUIDPattern' due to existing import 'info.magnolia.link.LinkUtil' | 222 |
| Avoid empty catch blocks | 236–238 |
| Avoid empty catch blocks | 249–251 |
| Avoid empty catch blocks | 263–265 |
| Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map' | 273 |
info/magnolia/jcr/util/MetaDataUtil.java
| Violation | Line |
|---|---|
| Useless parentheses. | 79 |
info/magnolia/jcr/util/NodeNameHelper.java
| Violation | Line |
|---|---|
| Useless parentheses. | 225 |
| Useless parentheses. | 225 |
| Useless parentheses. | 225 |
| Useless parentheses. | 226 |
| Useless parentheses. | 226 |
| Useless parentheses. | 226 |
| Useless parentheses. | 227 |
| Useless parentheses. | 227 |
| Useless parentheses. | 227 |
| These nested if statements could be combined | 249–251 |
| Useless parentheses. | 265 |
info/magnolia/jcr/util/NodeUtil.java
| Violation | Line |
|---|---|
| Useless parentheses. | 936 |
info/magnolia/jcr/util/PropertiesImportExport.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 154–156 |
| Useless parentheses. | 261 |
| Useless parentheses. | 264 |
| Useless parentheses. | 267 |
| Useless parentheses. | 270 |
| Useless parentheses. | 273 |
| Useless parentheses. | 276 |
| Useless parentheses. | 279 |
info/magnolia/jcr/util/PropertyUtil.java
| Violation | Line |
|---|---|
| Useless parentheses. | 93 |
| Avoid empty catch blocks | 191–193 |
| Useless parentheses. | 295 |
| Useless parentheses. | 297 |
| Useless parentheses. | 299 |
| Useless parentheses. | 301 |
| Useless parentheses. | 303 |
| Useless parentheses. | 306 |
| Useless parentheses. | 490 |
| Useless parentheses. | 492 |
| Useless parentheses. | 494 |
| Useless parentheses. | 496 |
| Useless parentheses. | 498 |
| Useless parentheses. | 500 |
| Useless parentheses. | 502 |
| Useless parentheses. | 504 |
| Avoid unused private methods such as 'createBinaryFromInputStream(InputStream)'. | 520 |
info/magnolia/jcr/wrapper/ChannelVisibilityContentDecorator.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 76–90 |
info/magnolia/jcr/wrapper/DelegateNodeWrapper.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 589–592 |
info/magnolia/jcr/wrapper/DelegateSessionWrapper.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 354–357 |
info/magnolia/jcr/wrapper/HTMLEscapingPropertyWrapper.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'transformLineBreaks'. | 49 |
info/magnolia/jcr/wrapper/MgnlPropertySettingContentDecorator.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 209–219 |
| Useless parentheses. | 701 |
info/magnolia/jcr/wrapper/MgnlPropertySettingNodeWrapper.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 211–213 |
info/magnolia/link/Link.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 143–145 |
| Avoid empty catch blocks | 159–161 |
| Avoid empty catch blocks | 161–162 |
| Avoid empty catch blocks | 199–201 |
info/magnolia/link/LinkFactory.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 49 |
info/magnolia/link/LinkTransformerManager.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 52 |
info/magnolia/link/LinkUtil.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 600–602 |
| Avoid unused private methods such as 'getURI2RepositoryManager()'. | 732 |
info/magnolia/module/InstallContext.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 103–139 |
info/magnolia/module/ModuleLifecycleContext.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 59 |
info/magnolia/module/ModuleManager.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 90–97 |
| Avoid modifiers which are implied by the context | 102–165 |
| These nested if statements could be combined | 146–148 |
| Avoid modifiers which are implied by the context | 170–210 |
info/magnolia/module/ModuleRegistry.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 100–107 |
info/magnolia/module/delta/ChangeAllPropertiesWithCertainValueTask.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 106–108 |
| These nested if statements could be combined | 129–131 |
info/magnolia/module/delta/FilterOrderingTask.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'getLastChild(Node,Collection)'. | 116 |
| Avoid unused private methods such as 'hasNodes(Node,Collection)'. | 128 |
info/magnolia/module/delta/MoveAndRenamePropertyTask.java
| Violation | Line |
|---|---|
| Useless parentheses. | 70 |
info/magnolia/module/delta/OrderFilterBeforeTask.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'getFirstChild(Node,Collection)'. | 111 |
| Avoid unused private methods such as 'hasNodes(Node,Collection)'. | 122 |
info/magnolia/module/delta/RemoveDuplicatePermissionTask.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 91–95 |
info/magnolia/module/delta/RenamePropertyTask.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'name'. | 43 |
info/magnolia/module/files/MD5CheckingFileExtractorOperation.java
| Violation | Line |
|---|---|
| Avoid empty if statements | 120–122 |
| Avoid empty while statements | 186–187 |
info/magnolia/module/model/reader/DependencyLevelComparator.java
| Violation | Line |
|---|---|
| Useless parentheses. | 111 |
info/magnolia/monitoring/SystemMonitor.java
| Violation | Line |
|---|---|
| Useless parentheses. | 76 |
info/magnolia/objectfactory/CandidateParameterResolver.java
| Violation | Line |
|---|---|
| Unnecessary use of fully qualified name 'javax.inject.Provider' due to existing import 'javax.inject.Provider' | 62 |
info/magnolia/objectfactory/ObjectManufacturer.java
| Violation | Line |
|---|---|
| Useless parentheses. | 97 |
| Useless parentheses. | 171 |
info/magnolia/objectfactory/ParameterResolver.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 41 |
info/magnolia/objectfactory/guice/GuiceComponentConfigurationModule.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'bindProvider(ProviderConfiguration)'. | 121 |
| Avoid unused private methods such as 'bindInstance(InstanceConfiguration)'. | 136 |
| Avoid unused private methods such as 'bindImplementation(ImplementationConfiguration)'. | 149 |
| Avoid unused private methods such as 'bindProvider(ComponentConfiguration,Provider)'. | 181 |
| Avoid unused private methods such as 'bindInScope(ScopedBindingBuilder,ComponentConfiguration)'. | 189 |
info/magnolia/objectfactory/guice/GuiceComponentProvider.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'concat(ParameterResolver,ParameterResolver)'. | 137 |
info/magnolia/objectfactory/guice/GuicePropertyConfigurer.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 55–58 |
info/magnolia/repository/DefaultRepositoryManager.java
| Violation | Line |
|---|---|
| Useless parentheses. | 171 |
info/magnolia/repository/RepositoryConstants.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 57 |
info/magnolia/repository/RepositoryNotInitializedException.java
| Violation | Line |
|---|---|
| Useless parentheses. | 49 |
info/magnolia/setup/CoreModule.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'virtualURIManager'. | 55 |
| Avoid unused constructor parameters such as 'commandsManager'. | 55 |
info/magnolia/setup/CoreModuleVersionHandler.java
| Violation | Line |
|---|---|
| Useless parentheses. | 158 |
| Useless parentheses. | 169 |
| Useless parentheses. | 172 |
| Useless parentheses. | 174 |
| Useless parentheses. | 177 |
| Useless parentheses. | 190 |
| Useless parentheses. | 194 |
| Useless parentheses. | 197 |
| Useless parentheses. | 200 |
| Useless parentheses. | 203 |
| Useless parentheses. | 216 |
| Useless parentheses. | 220 |
| Useless parentheses. | 223 |
| Useless parentheses. | 227 |
| Useless parentheses. | 230 |
| Useless parentheses. | 238 |
info/magnolia/setup/MigrateVersionWorkspacesToNewStructureTask.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 138–140 |
info/magnolia/setup/for4_5/UpdateSecurityFilterClientCallbacksConfiguration.java
| Violation | Line |
|---|---|
| Avoid unused method parameters such as 'ctx'. | 190 |
| Avoid unused method parameters such as 'ctx'. | 206 |
| Unnecessary use of fully qualified name 'ArrayUtils.contains' due to existing import 'org.apache.commons.lang3.ArrayUtils' | 209 |
info/magnolia/setup/for5_2/IsNotAProblematicEnvironmentCondition.java
| Violation | Line |
|---|---|
| Useless parentheses. | 84 |
| Useless parentheses. | 84 |
info/magnolia/setup/initial/AddURIPermissionsToAllRoles.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'addPermission(Content,String,String,long)'. | 93 |
info/magnolia/setup/initial/LoginAuthTypePropertyMovedToFilter.java
| Violation | Line |
|---|---|
| Useless parentheses. | 48 |
info/magnolia/setup/nodetype/AbstractNodeTypeRegistrationTask.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'getNodeTypeNames(NamePathResolver,Collection)'. | 270 |
info/magnolia/stats/JCRStatsMBean.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 40 |
info/magnolia/voting/Voting.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 58–62 |
info/magnolia/voting/voters/RequestExtensionVoter.java
| Violation | Line |
|---|---|
| Useless parentheses. | 92 |
info/magnolia/voting/voters/RequestParametersVoter.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 61–67 |
info/magnolia/voting/voters/RoleBaseVoter.java
| Violation | Line |
|---|---|
| Useless parentheses. | 53 |