Last Published: 2019-10-25
PMD Results
The following document contains the results of PMD 6.13.0.
Violations By Priority
Priority 3
info/magnolia/channel/ChannelResolver.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ALL': the field is declared in an interface type | 46 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'UNRESOLVED': the field is declared in an interface type | 51 |
info/magnolia/cms/beans/config/ConfigLoader.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'context'. | 84 |
info/magnolia/cms/beans/config/ObservedManager.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryReturn | Avoid unnecessary return statements | 133 |
info/magnolia/cms/beans/config/VirtualURIMapping.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'static' on class 'MappingResult': types nested within an interface type are implicitly static | 68–92 |
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'MappingResult': members of interface types are implicitly public | 68–92 |
info/magnolia/cms/beans/runtime/File.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 172–174 |
info/magnolia/cms/core/AbstractContent.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 409–411 |
info/magnolia/cms/core/AbstractNodeData.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 136–138 |
| EmptyCatchBlock | Avoid empty catch blocks | 207–209 |
info/magnolia/cms/core/BinaryNodeData.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 76–82 |
info/magnolia/cms/core/Content.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'hasMixin': the method is declared in an interface type | 762 |
| UnnecessaryModifier | Unnecessary modifier 'public' on interface 'ContentFilter': members of interface types are implicitly public | 770–779 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'accept': the method is declared in an interface type | 777 |
info/magnolia/cms/core/DefaultACLBasedPermissions.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'configuration'. | 107 |
info/magnolia/cms/core/DefaultContent.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 341–343 |
| EmptyCatchBlock | Avoid empty catch blocks | 384–386 |
| EmptyCatchBlock | Avoid empty catch blocks | 554–556 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 678 |
info/magnolia/cms/core/DefaultHierarchyManager.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'repositoryManager'. | 84 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'ignoredAccessManager'. | 95 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'userId'. | 95 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'ignoredUserId'. | 103 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'ignored'. | 112 |
| UnusedLocalVariable | Avoid unused local variables such as 'type'. | 328 |
| EmptyCatchBlock | Avoid empty catch blocks | 403–405 |
info/magnolia/cms/core/MetaData.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'ignoredAccessManager'. | 153 |
info/magnolia/cms/core/version/CopyUtil.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 378–380 |
info/magnolia/cms/core/version/MgnlVersioningNodeWrapper.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'repositoryManager'. | 76 |
info/magnolia/cms/exchange/ActivationManager.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getSubscribers': the method is declared in an interface type | 46 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setSubscribers': the method is declared in an interface type | 52 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addSubscribers': the method is declared in an interface type | 58 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getConfigPath': the method is declared in an interface type | 66 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'hasAnyActiveSubscriber': the method is declared in an interface type | 68 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getPublicKey': the method is declared in an interface type | 73 |
info/magnolia/cms/exchange/Subscriber.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type | 45 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setName': the method is declared in an interface type | 47 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getURL': the method is declared in an interface type | 49 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setURL': the method is declared in an interface type | 51 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isActive': the method is declared in an interface type | 53 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setActive': the method is declared in an interface type | 55 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setSubscriptions': the method is declared in an interface type | 57 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getSubscriptions': the method is declared in an interface type | 59 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addSubscriptions': the method is declared in an interface type | 61 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getMatchedSubscription': the method is declared in an interface type | 63 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isSubscribed': the method is declared in an interface type | 65 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getConnectTimeout': the method is declared in an interface type | 67 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setConnectTimeout': the method is declared in an interface type | 69 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getReadTimeout': the method is declared in an interface type | 71 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setReadTimeout': the method is declared in an interface type | 73 |
info/magnolia/cms/exchange/Subscription.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type | 45 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setName': the method is declared in an interface type | 47 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getFromURI': the method is declared in an interface type | 49 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setFromURI': the method is declared in an interface type | 51 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getToURI': the method is declared in an interface type | 53 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setToURI': the method is declared in an interface type | 55 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getRepository': the method is declared in an interface type | 57 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setRepository': the method is declared in an interface type | 59 |
info/magnolia/cms/exchange/Syndicator.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'init': the method is declared in an interface type | 62 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'activate': the method is declared in an interface type | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'activate': the method is declared in an interface type | 79 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'activate': the method is declared in an interface type | 87 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'activate': the method is declared in an interface type | 96 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'deactivate': the method is declared in an interface type | 101 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'deactivate': the method is declared in an interface type | 106 |
info/magnolia/cms/filters/FilterManager.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'SERVER_FILTERS': the field is declared in an interface type | 52 |
info/magnolia/cms/filters/WebContainerResources.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isWebContainerResource': the method is declared in an interface type | 49 |
info/magnolia/cms/i18n/AbstractMessagesImpl.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 140 |
info/magnolia/cms/i18n/I18nContentSupport.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLocale': the method is declared in an interface type | 52 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setLocale': the method is declared in an interface type | 54 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getFallbackLocale': the method is declared in an interface type | 59 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setFallbackLocale': the method is declared in an interface type | 61 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'toI18NURI': the method is declared in an interface type | 66 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'toRawURI': the method is declared in an interface type | 71 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'determineLocale': the method is declared in an interface type | 76 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getNode': the method is declared in an interface type | 81 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getProperty': the method is declared in an interface type | 86 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'hasProperty': the method is declared in an interface type | 91 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getProperty': the method is declared in an interface type | 96 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLocales': the method is declared in an interface type | 101 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isEnabled': the method is declared in an interface type | 103 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getDefaultLocale': the method is declared in an interface type | 105 |
info/magnolia/cms/i18n/Messages.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLocale': the method is declared in an interface type | 48 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getBasename': the method is declared in an interface type | 55 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'get': the method is declared in an interface type | 63 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'get': the method is declared in an interface type | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getWithDefault': the method is declared in an interface type | 79 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getWithDefault': the method is declared in an interface type | 89 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'keys': the method is declared in an interface type | 94 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'reload': the method is declared in an interface type | 99 |
info/magnolia/cms/security/CsrfTokenSecurityFilter.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'response'. | 138 |
info/magnolia/cms/security/DelegatingUserManager.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 163–165 |
| EmptyCatchBlock | Avoid empty catch blocks | 187–189 |
| EmptyCatchBlock | Avoid empty catch blocks | 206–208 |
info/magnolia/cms/security/Digester.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 76 |
info/magnolia/cms/security/ExternalUser.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'userDetails'. | 62 |
info/magnolia/cms/security/ExternalUserManager.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 58 |
info/magnolia/cms/security/Group.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type | 44 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addRole': the method is declared in an interface type | 50 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addGroup': the method is declared in an interface type | 56 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'removeRole': the method is declared in an interface type | 62 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'removeGroup': the method is declared in an interface type | 68 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'hasRole': the method is declared in an interface type | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getGroups': the method is declared in an interface type | 85 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAllGroups': the method is declared in an interface type | 90 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getRoles': the method is declared in an interface type | 95 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getId': the method is declared in an interface type | 100 |
info/magnolia/cms/security/IPSecurityManager.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'Factory': members of interface types are implicitly public | 51–55 |
| UnnecessaryModifier | Unnecessary modifier 'static' on class 'Factory': types nested within an interface type are implicitly static | 51–55 |
info/magnolia/cms/security/LogoutFilter.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 59 |
| UnusedPrivateField | Avoid unused private fields such as 'servletContext'. | 63 |
info/magnolia/cms/security/MgnlGroup.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 47 |
info/magnolia/cms/security/MgnlRole.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 48 |
| UnusedPrivateField | Avoid unused private fields such as 'acls'. | 56 |
info/magnolia/cms/security/MgnlRoleManager.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 149–151 |
| CollapsibleIfStatements | These nested if statements could be combined | 187–190 |
info/magnolia/cms/security/MgnlUser.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 89 |
info/magnolia/cms/security/MgnlUserManager.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryReturn | Avoid unnecessary return statements | 513 |
info/magnolia/cms/security/Realm.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'REALM_ADMIN': the field is declared in an interface type | 47 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'REALM_ALL': the field is declared in an interface type | 52 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'REALM_SYSTEM': the field is declared in an interface type | 57 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'DEFAULT_REALM': the field is declared in an interface type | 62 |
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'Factory': members of interface types are implicitly public | 99–106 |
info/magnolia/cms/security/Role.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'getName': the method is declared in an interface type | 43 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'addPermission': the method is declared in an interface type | 49 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'removePermission': the method is declared in an interface type | 55 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'removePermission': the method is declared in an interface type | 61 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'getId': the method is declared in an interface type | 66 |
info/magnolia/cms/security/RoleManager.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'createRole': the method is declared in an interface type | 54 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'createRole': the method is declared in an interface type | 56 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getRole': the method is declared in an interface type | 63 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getACLs': the method is declared in an interface type | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addPermission': the method is declared in an interface type | 75 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'removePermission': the method is declared in an interface type | 80 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getRoleNameById': the method is declared in an interface type | 85 |
info/magnolia/cms/security/SecuritySupport.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'Factory': members of interface types are implicitly public | 70–74 |
| UnnecessaryModifier | Unnecessary modifier 'static' on class 'Factory': types nested within an interface type are implicitly static | 70–74 |
info/magnolia/cms/security/SystemUserManager.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'password'. | 166 |
info/magnolia/cms/security/UserManager.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'SYSTEM_USER': the field is declared in an interface type | 53 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'SYSTEM_PSWD': the field is declared in an interface type | 58 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ANONYMOUS_USER': the field is declared in an interface type | 63 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUser': the method is declared in an interface type | 71 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUserById': the method is declared in an interface type | 79 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUser': the method is declared in an interface type | 88 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getSystemUser': the method is declared in an interface type | 95 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAnonymousUser': the method is declared in an interface type | 102 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAllUsers': the method is declared in an interface type | 110 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'createUser': the method is declared in an interface type | 117 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'createUser': the method is declared in an interface type | 124 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'changePassword': the method is declared in an interface type | 132 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setProperty': the method is declared in an interface type | 144 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setProperty': the method is declared in an interface type | 149 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setLockTimePeriod': the method is declared in an interface type | 158 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLockTimePeriod': the method is declared in an interface type | 165 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setMaxFailedLoginAttempts': the method is declared in an interface type | 172 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getMaxFailedLoginAttempts': the method is declared in an interface type | 179 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addRole': the method is declared in an interface type | 186 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addGroup': the method is declared in an interface type | 193 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'updateLastAccessTimestamp': the method is declared in an interface type | 200 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'hasAny': the method is declared in an interface type | 208 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getACLs': the method is declared in an interface type | 213 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'removeGroup': the method is declared in an interface type | 220 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'removeRole': the method is declared in an interface type | 227 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUsersWithGroup': the method is declared in an interface type | 235 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUsersWithGroup': the method is declared in an interface type | 244 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUsersWithRole': the method is declared in an interface type | 250 |
info/magnolia/cms/security/auth/Entity.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'FULL_NAME': the field is declared in an interface type | 46 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'NAME': the field is declared in an interface type | 48 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'EMAIL': the field is declared in an interface type | 50 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'LANGUAGE': the field is declared in an interface type | 52 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'LOCALE': the field is declared in an interface type | 54 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ADDRESS_LINE': the field is declared in an interface type | 56 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'PASSWORD': the field is declared in an interface type | 58 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type | 64 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setName': the method is declared in an interface type | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addProperty': the method is declared in an interface type | 72 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getProperty': the method is declared in an interface type | 77 |
info/magnolia/cms/security/auth/PrincipalCollection.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type | 48 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setName': the method is declared in an interface type | 50 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'set': the method is declared in an interface type | 52 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'add': the method is declared in an interface type | 54 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addAll': the method is declared in an interface type | 56 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'remove': the method is declared in an interface type | 58 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'clearAll': the method is declared in an interface type | 60 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'contains': the method is declared in an interface type | 62 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'iterator': the method is declared in an interface type | 65 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'contains': the method is declared in an interface type | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'get': the method is declared in an interface type | 75 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCollection': the method is declared in an interface type | 77 |
info/magnolia/cms/security/auth/login/BasicLogin.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 50 |
info/magnolia/cms/security/auth/login/LoginHandler.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'handle': the method is declared in an interface type | 48 |
info/magnolia/cms/security/operations/ConfiguredOperationPermissionDefinition.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 131 |
info/magnolia/cms/security/operations/OperationPermissionDefinition.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'DELETABLE': the field is declared in an interface type | 43 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'WRITABLE': the field is declared in an interface type | 44 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'READABLE': the field is declared in an interface type | 45 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'EXECUTABLE': the field is declared in an interface type | 47 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'MOVEABLE': the field is declared in an interface type | 48 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ADDIBLE': the field is declared in an interface type | 49 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getRead': the method is declared in an interface type | 51 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getWrite': the method is declared in an interface type | 53 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getDelete': the method is declared in an interface type | 55 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getExecute': the method is declared in an interface type | 57 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getMove': the method is declared in an interface type | 59 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAdd': the method is declared in an interface type | 61 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'canRead': the method is declared in an interface type | 63 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'canWrite': the method is declared in an interface type | 65 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'canDelete': the method is declared in an interface type | 67 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'canExecute': the method is declared in an interface type | 69 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'canMove': the method is declared in an interface type | 71 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'canAdd': the method is declared in an interface type | 73 |
info/magnolia/cms/servlets/ClasspathSpool.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 98–100 |
info/magnolia/cms/util/ClasspathResourcesUtil.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'static' on interface 'Filter': member interfaces are implicitly static | 72–74 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'accept': the method is declared in an interface type | 73 |
| EmptyCatchBlock | Avoid empty catch blocks | 155–157 |
| CollapsibleIfStatements | These nested if statements could be combined | 276–278 |
info/magnolia/cms/util/ContentUtil.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'static' on interface 'Visitor': member interfaces are implicitly static | 134–136 |
| UnnecessaryModifier | Unnecessary modifier 'static' on interface 'PostVisitor': member interfaces are implicitly static | 141–143 |
| EmptyCatchBlock | Avoid empty catch blocks | 457–459 |
| EmptyCatchBlock | Avoid empty catch blocks | 471–473 |
| CollapsibleIfStatements | These nested if statements could be combined | 519–522 |
info/magnolia/cms/util/InheritanceContentWrapper.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 76 |
info/magnolia/cms/util/SearchReplace.java
| Rule | Violation | Line |
|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'group'. | 90 |
info/magnolia/cms/util/ServletUtil.java
| Rule | Violation | Line |
|---|---|---|
| EmptyIfStmt | Avoid empty if statements | 178–180 |
info/magnolia/cms/util/UnicodeNormalizer.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 55 |
info/magnolia/cms/util/UrlPattern.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'MatchAllPattern': members of interface types are implicitly public | 74–97 |
| UnnecessaryModifier | Unnecessary modifier 'static' on class 'MatchAllPattern': types nested within an interface type are implicitly static | 74–97 |
info/magnolia/commands/chain/ChainBase.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 51 |
| EmptyCatchBlock | Avoid empty catch blocks | 123–125 |
info/magnolia/commands/chain/Command.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'CONTINUE_PROCESSING': the field is declared in an interface type | 45 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'PROCESSING_COMPLETE': the field is declared in an interface type | 46 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'clone': the method is declared in an interface type | 58 |
info/magnolia/commands/impl/ExportCommand.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 131–133 |
info/magnolia/content2bean/Bean2ContentProcessor.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'toContent': the method is declared in an interface type | 47 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setNodeDatas': the method is declared in an interface type | 49 |
info/magnolia/content2bean/Bean2ContentTransformer.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'resolveItemType': the method is declared in an interface type | 50 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'resolveName': the method is declared in an interface type | 55 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'prepareContent': the method is declared in an interface type | 60 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'finishContent': the method is declared in an interface type | 65 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isNode': the method is declared in an interface type | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isProperty': the method is declared in an interface type | 75 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setNodeData': the method is declared in an interface type | 80 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'convertNodeDataValue': the method is declared in an interface type | 85 |
info/magnolia/content2bean/Content2BeanProcessor.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'toBean': the method is declared in an interface type | 52–53 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setProperties': the method is declared in an interface type | 58 |
info/magnolia/content2bean/Content2BeanTransformer.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'newState': the method is declared in an interface type | 54 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'resolveType': the method is declared in an interface type | 59 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'resolveType': the method is declared in an interface type | 64 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getChildren': the method is declared in an interface type | 69 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'newBeanInstance': the method is declared in an interface type | 74 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'initBean': the method is declared in an interface type | 79 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setProperty': the method is declared in an interface type | 84 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setProperty': the method is declared in an interface type | 89 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'convertPropertyValue': the method is declared in an interface type | 94 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getTypeMapping': the method is declared in an interface type | 101 |
info/magnolia/content2bean/TransformationState.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'pushType': the method is declared in an interface type | 49 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'popType': the method is declared in an interface type | 51 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCurrentType': the method is declared in an interface type | 53 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'peekType': the method is declared in an interface type | 55 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'pushBean': the method is declared in an interface type | 57 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'popBean': the method is declared in an interface type | 59 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCurrentBean': the method is declared in an interface type | 61 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setCurrentBean': the method is declared in an interface type | 63 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'peekBean': the method is declared in an interface type | 65 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'pushContent': the method is declared in an interface type | 67 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'popContent': the method is declared in an interface type | 69 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCurrentContent': the method is declared in an interface type | 71 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'peekContent': the method is declared in an interface type | 73 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLevel': the method is declared in an interface type | 78 |
info/magnolia/content2bean/impl/CollectionPropertyHidingTransformer.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 98–102 |
info/magnolia/content2bean/impl/Content2BeanTransformerImpl.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 349–354 |
info/magnolia/content2bean/impl/TypeMappingImpl.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 141–153 |
| CollapsibleIfStatements | These nested if statements could be combined | 254–256 |
info/magnolia/context/Context.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'LOCAL_SCOPE': the field is declared in an interface type | 59 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'SESSION_SCOPE': the field is declared in an interface type | 64 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'APPLICATION_SCOPE': the field is declared in an interface type | 69 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_REPOSITORY': the field is declared in an interface type | 71 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_PATH': the field is declared in an interface type | 73 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_VERSION': the field is declared in an interface type | 75 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_VERSION_MAP': the field is declared in an interface type | 77 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_UUID': the field is declared in an interface type | 79 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_RECURSIVE': the field is declared in an interface type | 81 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_COMMENT': the field is declared in an interface type | 83 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_MESSAGE': the field is declared in an interface type | 85 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_EXCEPTION': the field is declared in an interface type | 87 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_REQUESTOR': the field is declared in an interface type | 94 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_USERNAME': the field is declared in an interface type | 99 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUser': the method is declared in an interface type | 104 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getSubject': the method is declared in an interface type | 106 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setLocale': the method is declared in an interface type | 108 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLocale': the method is declared in an interface type | 113 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getJCRSession': the method is declared in an interface type | 115 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAccessManager': the method is declared in an interface type | 120 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setAttribute': the method is declared in an interface type | 128 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAttribute': the method is declared in an interface type | 137 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAttribute': the method is declared in an interface type | 146 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAttributes': the method is declared in an interface type | 153 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'removeAttribute': the method is declared in an interface type | 158 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAttributes': the method is declared in an interface type | 165 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getMessages': the method is declared in an interface type | 171 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getMessages': the method is declared in an interface type | 179 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'release': the method is declared in an interface type | 184 |
info/magnolia/context/MgnlContext.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'static' on interface 'Op': member interfaces are implicitly static | 397–399 |
info/magnolia/context/SingleJCRSessionSystemContext.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 49 |
info/magnolia/context/ThreadDependentSystemContext.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'releaseThread': the method is declared in an interface type | 45 |
info/magnolia/context/WebContext.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_REQUEST_CHARACTER_ENCODING': the field is declared in an interface type | 60 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_REQUEST_URI': the field is declared in an interface type | 68 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'init': the method is declared in an interface type | 73 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAggregationState': the method is declared in an interface type | 78 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getPostedForm': the method is declared in an interface type | 90 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getParameter': the method is declared in an interface type | 97 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getParameters': the method is declared in an interface type | 104 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getContextPath': the method is declared in an interface type | 109 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getRequest': the method is declared in an interface type | 116 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getResponse': the method is declared in an interface type | 121 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'push': the method is declared in an interface type | 138 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'pop': the method is declared in an interface type | 143 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getParameterValues': the method is declared in an interface type | 150 |
info/magnolia/event/SystemEventBus.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'NAME': the field is declared in an interface type | 41 |
info/magnolia/importexport/PropertiesImportExport.java
| Rule | Violation | Line |
|---|---|---|
| EmptyIfStmt | Avoid empty if statements | 143–145 |
| UnusedFormalParameter | Avoid unused method parameters such as 'dumpMetaData'. | 250 |
info/magnolia/importexport/contenthandler/YamlContentHandler.java
| Rule | Violation | Line |
|---|---|---|
| TooManyStaticImports | Too many static imports may lead to messy code | 34–301 |
info/magnolia/importexport/exporter/YamlExporter.java
| Rule | Violation | Line |
|---|---|---|
| EmptyStatementNotInLoop | An empty statement (semicolon) not part of a loop | 113 |
info/magnolia/init/DefaultMagnoliaInitPaths.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'magnoliaServletContextListener'. | 79 |
info/magnolia/jackrabbit/ProviderImpl.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 214–216 |
| EmptyCatchBlock | Avoid empty catch blocks | 491–493 |
info/magnolia/jcr/node2bean/impl/CollectionPropertyHidingTransformer.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 101–105 |
info/magnolia/jcr/node2bean/impl/Node2BeanTransformerImpl.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 319–324 |
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 495 |
info/magnolia/jcr/node2bean/impl/TypeMappingImpl.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 309–311 |
info/magnolia/jcr/util/ContentMap.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 112–114 |
| EmptyIfStmt | Avoid empty if statements | 196–199 |
| EmptyCatchBlock | Avoid empty catch blocks | 236–238 |
| EmptyCatchBlock | Avoid empty catch blocks | 249–251 |
| EmptyCatchBlock | Avoid empty catch blocks | 263–265 |
info/magnolia/jcr/util/NodeNameHelper.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 261–263 |
info/magnolia/jcr/util/PropertiesImportExport.java
| Rule | Violation | Line |
|---|---|---|
| EmptyIfStmt | Avoid empty if statements | 154–156 |
info/magnolia/jcr/util/PropertyUtil.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 191–193 |
info/magnolia/jcr/wrapper/ChannelVisibilityContentDecorator.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 76–90 |
info/magnolia/jcr/wrapper/DelegateNodeWrapper.java
| Rule | Violation | Line |
|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 589–592 |
info/magnolia/jcr/wrapper/DelegateSessionWrapper.java
| Rule | Violation | Line |
|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 354–357 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 360 |
info/magnolia/jcr/wrapper/HTMLEscapingPropertyWrapper.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'transformLineBreaks'. | 49 |
info/magnolia/jcr/wrapper/MgnlPropertySettingContentDecorator.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 209–219 |
info/magnolia/jcr/wrapper/MgnlPropertySettingNodeWrapper.java
| Rule | Violation | Line |
|---|---|---|
| EmptyIfStmt | Avoid empty if statements | 211–213 |
info/magnolia/link/Link.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 105–107 |
| EmptyCatchBlock | Avoid empty catch blocks | 121–123 |
| EmptyCatchBlock | Avoid empty catch blocks | 123–124 |
| EmptyCatchBlock | Avoid empty catch blocks | 145–147 |
info/magnolia/link/LinkTransformerManager.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 53 |
info/magnolia/link/LinkUtil.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 481–483 |
info/magnolia/module/ModuleLifecycleContext.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on field 'PHASE_SYSTEM_STARTUP': the field is declared in an interface type | 49 |
| UnnecessaryModifier | Unnecessary modifier 'public' on field 'PHASE_MODULE_RESTART': the field is declared in an interface type | 54 |
| UnnecessaryModifier | Unnecessary modifier 'public' on field 'PHASE_SYSTEM_SHUTDOWN': the field is declared in an interface type | 59 |
info/magnolia/module/ModuleManager.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'Factory': members of interface types are implicitly public | 91–99 |
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'ModuleManagementState': members of interface types are implicitly public | 104–167 |
| UnnecessaryModifier | Unnecessary modifier 'static' on class 'ModuleManagementState': types nested within an interface type are implicitly static | 104–167 |
| CollapsibleIfStatements | These nested if statements could be combined | 148–150 |
| UnnecessaryModifier | Unnecessary modifier 'static' on class 'ModuleAndDeltas': types nested within an interface type are implicitly static | 172–212 |
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'ModuleAndDeltas': members of interface types are implicitly public | 172–212 |
info/magnolia/module/ModuleRegistry.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'Factory': members of interface types are implicitly public | 101–109 |
info/magnolia/module/delta/ChangeAllPropertiesWithCertainValueTask.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 106–108 |
| CollapsibleIfStatements | These nested if statements could be combined | 129–131 |
info/magnolia/module/delta/RemoveDuplicatePermissionTask.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 91–95 |
info/magnolia/module/delta/RenamePropertyTask.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'name'. | 43 |
info/magnolia/module/files/MD5CheckingFileExtractorOperation.java
| Rule | Violation | Line |
|---|---|---|
| EmptyIfStmt | Avoid empty if statements | 107–109 |
| EmptyWhileStmt | Avoid empty while statements | 165–166 |
info/magnolia/module/model/VersionRange.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'static' on enum 'Hand': nested enums are implicitly static | 183 |
| UnnecessaryModifier | Unnecessary modifier 'static' on enum 'Boundary': nested enums are implicitly static | 185–207 |
| UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'Boundary(Hand, char, boolean)': enum constructors are implicitly private | 193–197 |
info/magnolia/module/model/reader/LightModuleDefinitionReader.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final | 123 |
info/magnolia/module/ui/InstallationResourcesServlet.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'in': resource specifications are implicitly final | 74 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'out': resource specifications are implicitly final | 75 |
info/magnolia/objectfactory/DefaultClassFactory.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'static' on interface 'Invoker': member interfaces are implicitly static | 102–104 |
info/magnolia/objectfactory/ParameterResolver.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'UNRESOLVED': the field is declared in an interface type | 41 |
info/magnolia/objectfactory/guice/GuicePropertyConfigurer.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 55–58 |
info/magnolia/repository/RepositoryConstants.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'WEBSITE': the field is declared in an interface type | 45 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'USERS': the field is declared in an interface type | 46 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'USER_ROLES': the field is declared in an interface type | 47 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'USER_GROUPS': the field is declared in an interface type | 48 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'CONFIG': the field is declared in an interface type | 49 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'VERSION_STORE': the field is declared in an interface type | 50 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'SYSTEM': the field is declared in an interface type | 51 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'NAMESPACE_PREFIX': the field is declared in an interface type | 56 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'NAMESPACE_URI': the field is declared in an interface type | 57 |
info/magnolia/setup/CoreModule.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'commandsManager'. | 56 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'virtualURIManager'. | 56 |
info/magnolia/setup/MigrateVersionWorkspacesToNewStructureTask.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 138–140 |
info/magnolia/setup/for4_5/UpdateSecurityFilterClientCallbacksConfiguration.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'ctx'. | 194 |
| UnusedFormalParameter | Avoid unused method parameters such as 'ctx'. | 208 |
info/magnolia/stats/JCRStatsMBean.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getSessionCount': the method is declared in an interface type | 40 |
info/magnolia/voting/Voting.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'AND': the field is declared in an interface type | 47 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'OR': the field is declared in an interface type | 48 |
| UnnecessaryModifier | Unnecessary modifiers 'public static' on field 'HIGHEST_LEVEL': the field is declared in an interface type | 49 |
| UnnecessaryModifier | Unnecessary modifier 'static' on class 'Factory': types nested within an interface type are implicitly static | 59–63 |
info/magnolia/voting/voters/RequestParametersVoter.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 61–67 |
Priority 4
info/magnolia/cms/beans/config/ConfigurationException.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 46 |
info/magnolia/cms/beans/config/HostBasedVirtualURIMapping.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 171 |
info/magnolia/cms/beans/config/MIMEMapping.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 222 |
info/magnolia/cms/beans/runtime/Document.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 206 |
| UselessParentheses | Useless parentheses. | 206 |
info/magnolia/cms/beans/runtime/MultipartForm.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 116 |
info/magnolia/cms/core/AbstractContent.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 340 |
| UselessParentheses | Useless parentheses. | 345 |
info/magnolia/cms/core/DefaultACLBasedPermissions.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 117 |
| UselessParentheses | Useless parentheses. | 117 |
info/magnolia/cms/core/DefaultContent.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 696 |
info/magnolia/cms/core/DefaultHierarchyManager.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 193 |
| UselessParentheses | Useless parentheses. | 351 |
info/magnolia/cms/core/NodeTypeBasedPermissions.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 112 |
| UselessParentheses | Useless parentheses. | 112 |
info/magnolia/cms/core/Path.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 243 |
| UselessParentheses | Useless parentheses. | 243 |
| UselessParentheses | Useless parentheses. | 243 |
| UselessParentheses | Useless parentheses. | 244 |
| UselessParentheses | Useless parentheses. | 244 |
| UselessParentheses | Useless parentheses. | 244 |
| UselessParentheses | Useless parentheses. | 245 |
| UselessParentheses | Useless parentheses. | 245 |
| UselessParentheses | Useless parentheses. | 245 |
info/magnolia/cms/core/search/QueryManagerImpl.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 94 |
| UselessParentheses | Useless parentheses. | 100 |
info/magnolia/cms/core/search/QueryResultImpl.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 132 |
info/magnolia/cms/core/version/ContentVersion.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 405 |
| UselessParentheses | Useless parentheses. | 414 |
info/magnolia/cms/exchange/ExchangeException.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 57 |
info/magnolia/cms/filters/AggregatorFilter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 228 |
info/magnolia/cms/filters/CosMultipartRequestFilter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 98 |
| UselessParentheses | Useless parentheses. | 100 |
info/magnolia/cms/filters/ServletDispatchingFilter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 220 |
info/magnolia/cms/i18n/AbstractI18nContentSupport.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 341 |
info/magnolia/cms/security/AccessDeniedException.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 53 |
info/magnolia/cms/security/AccessManagerImpl.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 83 |
info/magnolia/cms/security/IPSecurityManagerImpl.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 85 |
info/magnolia/cms/security/Lock.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 87 |
info/magnolia/cms/security/MgnlUserManager.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 319 |
info/magnolia/cms/security/RepositoryBackedSecurityManager.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 112 |
| UselessParentheses | Useless parentheses. | 167 |
info/magnolia/cms/security/SecurityCallbackFilter.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'HttpServletResponse.SC_UNAUTHORIZED' due to existing static import 'javax.servlet.http.HttpServletResponse.*' | 91 |
info/magnolia/cms/security/URISecurityFilter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 108 |
info/magnolia/cms/security/auth/callback/Base64CallbackHandler.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 63 |
info/magnolia/cms/util/ContentUtil.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 593 |
info/magnolia/cms/util/DateUtil.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 204 |
info/magnolia/cms/util/DelayedExecutor.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 82 |
info/magnolia/cms/util/DeprecationUtil.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 64 |
info/magnolia/cms/util/LazyNodeDataWrapper.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 77 |
info/magnolia/cms/util/NodeDataUtil.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 111 |
| UselessParentheses | Useless parentheses. | 113 |
| UselessParentheses | Useless parentheses. | 115 |
| UselessParentheses | Useless parentheses. | 117 |
| UselessParentheses | Useless parentheses. | 119 |
| UselessParentheses | Useless parentheses. | 122 |
| UselessParentheses | Useless parentheses. | 196 |
| UselessParentheses | Useless parentheses. | 198 |
| UselessParentheses | Useless parentheses. | 200 |
| UselessParentheses | Useless parentheses. | 202 |
| UselessParentheses | Useless parentheses. | 204 |
| UselessParentheses | Useless parentheses. | 206 |
| UselessParentheses | Useless parentheses. | 236 |
| UselessParentheses | Useless parentheses. | 241 |
info/magnolia/cms/util/NodeMapWrapper.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 247 |
info/magnolia/cms/util/PathUtil.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 46 |
info/magnolia/cms/util/QueryUtil.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'javax.jcr.query.Query.JCR_SQL2' due to existing import 'javax.jcr.query.Query' | 168 |
info/magnolia/cms/util/RequestDispatchUtil.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 129 |
| UselessParentheses | Useless parentheses. | 129 |
info/magnolia/cms/util/ServletUtil.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 99 |
| UselessParentheses | Useless parentheses. | 178 |
| UselessParentheses | Useless parentheses. | 178 |
info/magnolia/commands/MgnlCatalog.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 75 |
info/magnolia/commands/chain/ChainBase.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 129 |
| UselessParentheses | Useless parentheses. | 132 |
info/magnolia/commands/impl/VersionCommand.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 95 |
| UselessParentheses | Useless parentheses. | 136 |
info/magnolia/context/MgnlContext.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 376 |
info/magnolia/debug/PerformanceTestStatus.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 72 |
info/magnolia/importexport/BootstrapFilesComparator.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 73 |
| UselessParentheses | Useless parentheses. | 73 |
info/magnolia/importexport/DataTransporter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 509 |
| UselessParentheses | Useless parentheses. | 511 |
info/magnolia/importexport/PropertiesImportExport.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 288 |
| UselessParentheses | Useless parentheses. | 291 |
| UselessParentheses | Useless parentheses. | 294 |
| UselessParentheses | Useless parentheses. | 297 |
| UselessParentheses | Useless parentheses. | 300 |
| UselessParentheses | Useless parentheses. | 303 |
| UselessParentheses | Useless parentheses. | 306 |
info/magnolia/importexport/filters/MetadataUuidFilter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 136 |
info/magnolia/importexport/filters/SkipNodePropertyFilter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 134 |
info/magnolia/jcr/node2bean/impl/Node2BeanTransformerImpl.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 518 |
info/magnolia/jcr/nodebuilder/Ops.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 202 |
info/magnolia/jcr/util/ContentMap.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'info.magnolia.link.LinkUtil.convertLinksFromUUIDPattern' due to existing import 'info.magnolia.link.LinkUtil' | 222 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map' | 273 |
info/magnolia/jcr/util/MetaDataUtil.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 80 |
info/magnolia/jcr/util/NodeNameHelper.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 237 |
| UselessParentheses | Useless parentheses. | 237 |
| UselessParentheses | Useless parentheses. | 237 |
| UselessParentheses | Useless parentheses. | 238 |
| UselessParentheses | Useless parentheses. | 238 |
| UselessParentheses | Useless parentheses. | 238 |
| UselessParentheses | Useless parentheses. | 239 |
| UselessParentheses | Useless parentheses. | 239 |
| UselessParentheses | Useless parentheses. | 239 |
| UselessParentheses | Useless parentheses. | 277 |
info/magnolia/jcr/util/NodeUtil.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 936 |
info/magnolia/jcr/util/PropertiesImportExport.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 261 |
| UselessParentheses | Useless parentheses. | 264 |
| UselessParentheses | Useless parentheses. | 267 |
| UselessParentheses | Useless parentheses. | 270 |
| UselessParentheses | Useless parentheses. | 273 |
| UselessParentheses | Useless parentheses. | 276 |
| UselessParentheses | Useless parentheses. | 279 |
info/magnolia/jcr/util/PropertyUtil.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 93 |
| UselessParentheses | Useless parentheses. | 118 |
| UselessParentheses | Useless parentheses. | 120 |
| UselessParentheses | Useless parentheses. | 295 |
| UselessParentheses | Useless parentheses. | 297 |
| UselessParentheses | Useless parentheses. | 299 |
| UselessParentheses | Useless parentheses. | 301 |
| UselessParentheses | Useless parentheses. | 303 |
| UselessParentheses | Useless parentheses. | 306 |
| UselessParentheses | Useless parentheses. | 341 |
| UselessParentheses | Useless parentheses. | 491 |
| UselessParentheses | Useless parentheses. | 493 |
| UselessParentheses | Useless parentheses. | 495 |
| UselessParentheses | Useless parentheses. | 497 |
| UselessParentheses | Useless parentheses. | 499 |
| UselessParentheses | Useless parentheses. | 501 |
| UselessParentheses | Useless parentheses. | 503 |
| UselessParentheses | Useless parentheses. | 505 |
info/magnolia/jcr/wrapper/DelegateNodeWrapper.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 576 |
info/magnolia/jcr/wrapper/DelegateSessionWrapper.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 341 |
info/magnolia/jcr/wrapper/MgnlPropertySettingContentDecorator.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 703 |
info/magnolia/module/ModuleManagerImpl.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 523 |
info/magnolia/module/delta/BootstrapConditionally.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 88 |
info/magnolia/module/delta/MoveAndRenamePropertyTask.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 70 |
info/magnolia/module/model/reader/DependencyLevelComparator.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 111 |
info/magnolia/module/webapp/WebappVersionHandler.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 81 |
| UselessParentheses | Useless parentheses. | 81 |
info/magnolia/objectfactory/CandidateParameterResolver.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'javax.inject.Provider' due to existing import 'javax.inject.Provider' | 62 |
info/magnolia/objectfactory/ObjectManufacturer.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 165 |
info/magnolia/repository/DefaultRepositoryManager.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 171 |
info/magnolia/repository/RepositoryNotInitializedException.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 49 |
info/magnolia/setup/CoreModuleVersionHandler.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 163 |
| UselessParentheses | Useless parentheses. | 174 |
| UselessParentheses | Useless parentheses. | 177 |
| UselessParentheses | Useless parentheses. | 179 |
| UselessParentheses | Useless parentheses. | 182 |
| UselessParentheses | Useless parentheses. | 195 |
| UselessParentheses | Useless parentheses. | 199 |
| UselessParentheses | Useless parentheses. | 202 |
| UselessParentheses | Useless parentheses. | 205 |
| UselessParentheses | Useless parentheses. | 208 |
| UselessParentheses | Useless parentheses. | 221 |
| UselessParentheses | Useless parentheses. | 225 |
| UselessParentheses | Useless parentheses. | 228 |
| UselessParentheses | Useless parentheses. | 232 |
| UselessParentheses | Useless parentheses. | 235 |
| UselessParentheses | Useless parentheses. | 243 |
info/magnolia/setup/for4_5/UpdateSecurityFilterClientCallbacksConfiguration.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'ArrayUtils.contains' due to existing static import 'org.apache.commons.lang3.ArrayUtils.contains' | 211 |
info/magnolia/setup/for5_2/IsNotAProblematicEnvironmentCondition.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 84 |
| UselessParentheses | Useless parentheses. | 84 |
info/magnolia/setup/initial/LoginAuthTypePropertyMovedToFilter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 48 |
info/magnolia/voting/voters/RequestExtensionVoter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 92 |
info/magnolia/voting/voters/RoleBaseVoter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 53 |
Files
info/magnolia/channel/ChannelResolver.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ALL': the field is declared in an interface type | 3 | 46 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'UNRESOLVED': the field is declared in an interface type | 3 | 51 |
info/magnolia/cms/beans/config/ConfigLoader.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'context'. | 3 | 84 |
info/magnolia/cms/beans/config/ConfigurationException.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 46 |
info/magnolia/cms/beans/config/HostBasedVirtualURIMapping.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 171 |
info/magnolia/cms/beans/config/MIMEMapping.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 222 |
info/magnolia/cms/beans/config/ObservedManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryReturn | Avoid unnecessary return statements | 3 | 133 |
info/magnolia/cms/beans/config/VirtualURIMapping.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'static' on class 'MappingResult': types nested within an interface type are implicitly static | 3 | 68–92 |
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'MappingResult': members of interface types are implicitly public | 3 | 68–92 |
info/magnolia/cms/beans/runtime/Document.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 206 |
| UselessParentheses | Useless parentheses. | 4 | 206 |
info/magnolia/cms/beans/runtime/File.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 172–174 |
info/magnolia/cms/beans/runtime/MultipartForm.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 116 |
info/magnolia/cms/core/AbstractContent.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 340 |
| UselessParentheses | Useless parentheses. | 4 | 345 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 409–411 |
info/magnolia/cms/core/AbstractNodeData.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 136–138 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 207–209 |
info/magnolia/cms/core/BinaryNodeData.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 76–82 |
info/magnolia/cms/core/Content.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'hasMixin': the method is declared in an interface type | 3 | 762 |
| UnnecessaryModifier | Unnecessary modifier 'public' on interface 'ContentFilter': members of interface types are implicitly public | 3 | 770–779 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'accept': the method is declared in an interface type | 3 | 777 |
info/magnolia/cms/core/DefaultACLBasedPermissions.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'configuration'. | 3 | 107 |
| UselessParentheses | Useless parentheses. | 4 | 117 |
| UselessParentheses | Useless parentheses. | 4 | 117 |
info/magnolia/cms/core/DefaultContent.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 341–343 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 384–386 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 554–556 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 678 |
| UselessParentheses | Useless parentheses. | 4 | 696 |
info/magnolia/cms/core/DefaultHierarchyManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'repositoryManager'. | 3 | 84 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'ignoredAccessManager'. | 3 | 95 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'userId'. | 3 | 95 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'ignoredUserId'. | 3 | 103 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'ignored'. | 3 | 112 |
| UselessParentheses | Useless parentheses. | 4 | 193 |
| UnusedLocalVariable | Avoid unused local variables such as 'type'. | 3 | 328 |
| UselessParentheses | Useless parentheses. | 4 | 351 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 403–405 |
info/magnolia/cms/core/MetaData.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'ignoredAccessManager'. | 3 | 153 |
info/magnolia/cms/core/NodeTypeBasedPermissions.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 112 |
| UselessParentheses | Useless parentheses. | 4 | 112 |
info/magnolia/cms/core/Path.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 243 |
| UselessParentheses | Useless parentheses. | 4 | 243 |
| UselessParentheses | Useless parentheses. | 4 | 243 |
| UselessParentheses | Useless parentheses. | 4 | 244 |
| UselessParentheses | Useless parentheses. | 4 | 244 |
| UselessParentheses | Useless parentheses. | 4 | 244 |
| UselessParentheses | Useless parentheses. | 4 | 245 |
| UselessParentheses | Useless parentheses. | 4 | 245 |
| UselessParentheses | Useless parentheses. | 4 | 245 |
info/magnolia/cms/core/search/QueryManagerImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 94 |
| UselessParentheses | Useless parentheses. | 4 | 100 |
info/magnolia/cms/core/search/QueryResultImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 132 |
info/magnolia/cms/core/version/ContentVersion.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 405 |
| UselessParentheses | Useless parentheses. | 4 | 414 |
info/magnolia/cms/core/version/CopyUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 378–380 |
info/magnolia/cms/core/version/MgnlVersioningNodeWrapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'repositoryManager'. | 3 | 76 |
info/magnolia/cms/exchange/ActivationManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getSubscribers': the method is declared in an interface type | 3 | 46 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setSubscribers': the method is declared in an interface type | 3 | 52 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addSubscribers': the method is declared in an interface type | 3 | 58 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getConfigPath': the method is declared in an interface type | 3 | 66 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'hasAnyActiveSubscriber': the method is declared in an interface type | 3 | 68 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getPublicKey': the method is declared in an interface type | 3 | 73 |
info/magnolia/cms/exchange/ExchangeException.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 57 |
info/magnolia/cms/exchange/Subscriber.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type | 3 | 45 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setName': the method is declared in an interface type | 3 | 47 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getURL': the method is declared in an interface type | 3 | 49 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setURL': the method is declared in an interface type | 3 | 51 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isActive': the method is declared in an interface type | 3 | 53 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setActive': the method is declared in an interface type | 3 | 55 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setSubscriptions': the method is declared in an interface type | 3 | 57 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getSubscriptions': the method is declared in an interface type | 3 | 59 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addSubscriptions': the method is declared in an interface type | 3 | 61 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getMatchedSubscription': the method is declared in an interface type | 3 | 63 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isSubscribed': the method is declared in an interface type | 3 | 65 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getConnectTimeout': the method is declared in an interface type | 3 | 67 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setConnectTimeout': the method is declared in an interface type | 3 | 69 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getReadTimeout': the method is declared in an interface type | 3 | 71 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setReadTimeout': the method is declared in an interface type | 3 | 73 |
info/magnolia/cms/exchange/Subscription.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type | 3 | 45 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setName': the method is declared in an interface type | 3 | 47 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getFromURI': the method is declared in an interface type | 3 | 49 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setFromURI': the method is declared in an interface type | 3 | 51 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getToURI': the method is declared in an interface type | 3 | 53 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setToURI': the method is declared in an interface type | 3 | 55 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getRepository': the method is declared in an interface type | 3 | 57 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setRepository': the method is declared in an interface type | 3 | 59 |
info/magnolia/cms/exchange/Syndicator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'init': the method is declared in an interface type | 3 | 62 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'activate': the method is declared in an interface type | 3 | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'activate': the method is declared in an interface type | 3 | 79 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'activate': the method is declared in an interface type | 3 | 87 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'activate': the method is declared in an interface type | 3 | 96 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'deactivate': the method is declared in an interface type | 3 | 101 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'deactivate': the method is declared in an interface type | 3 | 106 |
info/magnolia/cms/filters/AggregatorFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 228 |
info/magnolia/cms/filters/CosMultipartRequestFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 98 |
| UselessParentheses | Useless parentheses. | 4 | 100 |
info/magnolia/cms/filters/FilterManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'SERVER_FILTERS': the field is declared in an interface type | 3 | 52 |
info/magnolia/cms/filters/ServletDispatchingFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 220 |
info/magnolia/cms/filters/WebContainerResources.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isWebContainerResource': the method is declared in an interface type | 3 | 49 |
info/magnolia/cms/i18n/AbstractI18nContentSupport.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 341 |
info/magnolia/cms/i18n/AbstractMessagesImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 140 |
info/magnolia/cms/i18n/I18nContentSupport.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLocale': the method is declared in an interface type | 3 | 52 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setLocale': the method is declared in an interface type | 3 | 54 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getFallbackLocale': the method is declared in an interface type | 3 | 59 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setFallbackLocale': the method is declared in an interface type | 3 | 61 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'toI18NURI': the method is declared in an interface type | 3 | 66 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'toRawURI': the method is declared in an interface type | 3 | 71 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'determineLocale': the method is declared in an interface type | 3 | 76 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getNode': the method is declared in an interface type | 3 | 81 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getProperty': the method is declared in an interface type | 3 | 86 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'hasProperty': the method is declared in an interface type | 3 | 91 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getProperty': the method is declared in an interface type | 3 | 96 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLocales': the method is declared in an interface type | 3 | 101 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isEnabled': the method is declared in an interface type | 3 | 103 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getDefaultLocale': the method is declared in an interface type | 3 | 105 |
info/magnolia/cms/i18n/Messages.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLocale': the method is declared in an interface type | 3 | 48 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getBasename': the method is declared in an interface type | 3 | 55 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'get': the method is declared in an interface type | 3 | 63 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'get': the method is declared in an interface type | 3 | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getWithDefault': the method is declared in an interface type | 3 | 79 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getWithDefault': the method is declared in an interface type | 3 | 89 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'keys': the method is declared in an interface type | 3 | 94 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'reload': the method is declared in an interface type | 3 | 99 |
info/magnolia/cms/security/AccessDeniedException.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 53 |
info/magnolia/cms/security/AccessManagerImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 83 |
info/magnolia/cms/security/CsrfTokenSecurityFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'response'. | 3 | 138 |
info/magnolia/cms/security/DelegatingUserManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 163–165 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 187–189 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 206–208 |
info/magnolia/cms/security/Digester.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 3 | 76 |
info/magnolia/cms/security/ExternalUser.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'userDetails'. | 3 | 62 |
info/magnolia/cms/security/ExternalUserManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 3 | 58 |
info/magnolia/cms/security/Group.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type | 3 | 44 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addRole': the method is declared in an interface type | 3 | 50 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addGroup': the method is declared in an interface type | 3 | 56 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'removeRole': the method is declared in an interface type | 3 | 62 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'removeGroup': the method is declared in an interface type | 3 | 68 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'hasRole': the method is declared in an interface type | 3 | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getGroups': the method is declared in an interface type | 3 | 85 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAllGroups': the method is declared in an interface type | 3 | 90 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getRoles': the method is declared in an interface type | 3 | 95 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getId': the method is declared in an interface type | 3 | 100 |
info/magnolia/cms/security/IPSecurityManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'Factory': members of interface types are implicitly public | 3 | 51–55 |
| UnnecessaryModifier | Unnecessary modifier 'static' on class 'Factory': types nested within an interface type are implicitly static | 3 | 51–55 |
info/magnolia/cms/security/IPSecurityManagerImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 85 |
info/magnolia/cms/security/Lock.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 87 |
info/magnolia/cms/security/LogoutFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 3 | 59 |
| UnusedPrivateField | Avoid unused private fields such as 'servletContext'. | 3 | 63 |
info/magnolia/cms/security/MgnlGroup.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 3 | 47 |
info/magnolia/cms/security/MgnlRole.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 3 | 48 |
| UnusedPrivateField | Avoid unused private fields such as 'acls'. | 3 | 56 |
info/magnolia/cms/security/MgnlRoleManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 149–151 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 187–190 |
info/magnolia/cms/security/MgnlUser.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 3 | 89 |
info/magnolia/cms/security/MgnlUserManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 319 |
| UnnecessaryReturn | Avoid unnecessary return statements | 3 | 513 |
info/magnolia/cms/security/Realm.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'REALM_ADMIN': the field is declared in an interface type | 3 | 47 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'REALM_ALL': the field is declared in an interface type | 3 | 52 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'REALM_SYSTEM': the field is declared in an interface type | 3 | 57 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'DEFAULT_REALM': the field is declared in an interface type | 3 | 62 |
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'Factory': members of interface types are implicitly public | 3 | 99–106 |
info/magnolia/cms/security/RepositoryBackedSecurityManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 112 |
| UselessParentheses | Useless parentheses. | 4 | 167 |
info/magnolia/cms/security/Role.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'getName': the method is declared in an interface type | 3 | 43 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'addPermission': the method is declared in an interface type | 3 | 49 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'removePermission': the method is declared in an interface type | 3 | 55 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'removePermission': the method is declared in an interface type | 3 | 61 |
| UnnecessaryModifier | Unnecessary modifiers 'public abstract' on method 'getId': the method is declared in an interface type | 3 | 66 |
info/magnolia/cms/security/RoleManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'createRole': the method is declared in an interface type | 3 | 54 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'createRole': the method is declared in an interface type | 3 | 56 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getRole': the method is declared in an interface type | 3 | 63 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getACLs': the method is declared in an interface type | 3 | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addPermission': the method is declared in an interface type | 3 | 75 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'removePermission': the method is declared in an interface type | 3 | 80 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getRoleNameById': the method is declared in an interface type | 3 | 85 |
info/magnolia/cms/security/SecurityCallbackFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'HttpServletResponse.SC_UNAUTHORIZED' due to existing static import 'javax.servlet.http.HttpServletResponse.*' | 4 | 91 |
info/magnolia/cms/security/SecuritySupport.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'Factory': members of interface types are implicitly public | 3 | 70–74 |
| UnnecessaryModifier | Unnecessary modifier 'static' on class 'Factory': types nested within an interface type are implicitly static | 3 | 70–74 |
info/magnolia/cms/security/SystemUserManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'password'. | 3 | 166 |
info/magnolia/cms/security/URISecurityFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 108 |
info/magnolia/cms/security/UserManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'SYSTEM_USER': the field is declared in an interface type | 3 | 53 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'SYSTEM_PSWD': the field is declared in an interface type | 3 | 58 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ANONYMOUS_USER': the field is declared in an interface type | 3 | 63 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUser': the method is declared in an interface type | 3 | 71 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUserById': the method is declared in an interface type | 3 | 79 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUser': the method is declared in an interface type | 3 | 88 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getSystemUser': the method is declared in an interface type | 3 | 95 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAnonymousUser': the method is declared in an interface type | 3 | 102 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAllUsers': the method is declared in an interface type | 3 | 110 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'createUser': the method is declared in an interface type | 3 | 117 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'createUser': the method is declared in an interface type | 3 | 124 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'changePassword': the method is declared in an interface type | 3 | 132 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setProperty': the method is declared in an interface type | 3 | 144 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setProperty': the method is declared in an interface type | 3 | 149 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setLockTimePeriod': the method is declared in an interface type | 3 | 158 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLockTimePeriod': the method is declared in an interface type | 3 | 165 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setMaxFailedLoginAttempts': the method is declared in an interface type | 3 | 172 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getMaxFailedLoginAttempts': the method is declared in an interface type | 3 | 179 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addRole': the method is declared in an interface type | 3 | 186 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addGroup': the method is declared in an interface type | 3 | 193 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'updateLastAccessTimestamp': the method is declared in an interface type | 3 | 200 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'hasAny': the method is declared in an interface type | 3 | 208 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getACLs': the method is declared in an interface type | 3 | 213 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'removeGroup': the method is declared in an interface type | 3 | 220 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'removeRole': the method is declared in an interface type | 3 | 227 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUsersWithGroup': the method is declared in an interface type | 3 | 235 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUsersWithGroup': the method is declared in an interface type | 3 | 244 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUsersWithRole': the method is declared in an interface type | 3 | 250 |
info/magnolia/cms/security/auth/Entity.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'FULL_NAME': the field is declared in an interface type | 3 | 46 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'NAME': the field is declared in an interface type | 3 | 48 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'EMAIL': the field is declared in an interface type | 3 | 50 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'LANGUAGE': the field is declared in an interface type | 3 | 52 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'LOCALE': the field is declared in an interface type | 3 | 54 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ADDRESS_LINE': the field is declared in an interface type | 3 | 56 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'PASSWORD': the field is declared in an interface type | 3 | 58 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type | 3 | 64 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setName': the method is declared in an interface type | 3 | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addProperty': the method is declared in an interface type | 3 | 72 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getProperty': the method is declared in an interface type | 3 | 77 |
info/magnolia/cms/security/auth/PrincipalCollection.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type | 3 | 48 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setName': the method is declared in an interface type | 3 | 50 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'set': the method is declared in an interface type | 3 | 52 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'add': the method is declared in an interface type | 3 | 54 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'addAll': the method is declared in an interface type | 3 | 56 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'remove': the method is declared in an interface type | 3 | 58 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'clearAll': the method is declared in an interface type | 3 | 60 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'contains': the method is declared in an interface type | 3 | 62 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'iterator': the method is declared in an interface type | 3 | 65 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'contains': the method is declared in an interface type | 3 | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'get': the method is declared in an interface type | 3 | 75 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCollection': the method is declared in an interface type | 3 | 77 |
info/magnolia/cms/security/auth/callback/Base64CallbackHandler.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 63 |
info/magnolia/cms/security/auth/login/BasicLogin.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 3 | 50 |
info/magnolia/cms/security/auth/login/LoginHandler.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'handle': the method is declared in an interface type | 3 | 48 |
info/magnolia/cms/security/operations/ConfiguredOperationPermissionDefinition.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 3 | 131 |
info/magnolia/cms/security/operations/OperationPermissionDefinition.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'DELETABLE': the field is declared in an interface type | 3 | 43 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'WRITABLE': the field is declared in an interface type | 3 | 44 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'READABLE': the field is declared in an interface type | 3 | 45 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'EXECUTABLE': the field is declared in an interface type | 3 | 47 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'MOVEABLE': the field is declared in an interface type | 3 | 48 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ADDIBLE': the field is declared in an interface type | 3 | 49 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getRead': the method is declared in an interface type | 3 | 51 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getWrite': the method is declared in an interface type | 3 | 53 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getDelete': the method is declared in an interface type | 3 | 55 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getExecute': the method is declared in an interface type | 3 | 57 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getMove': the method is declared in an interface type | 3 | 59 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAdd': the method is declared in an interface type | 3 | 61 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'canRead': the method is declared in an interface type | 3 | 63 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'canWrite': the method is declared in an interface type | 3 | 65 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'canDelete': the method is declared in an interface type | 3 | 67 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'canExecute': the method is declared in an interface type | 3 | 69 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'canMove': the method is declared in an interface type | 3 | 71 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'canAdd': the method is declared in an interface type | 3 | 73 |
info/magnolia/cms/servlets/ClasspathSpool.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 98–100 |
info/magnolia/cms/util/ClasspathResourcesUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'static' on interface 'Filter': member interfaces are implicitly static | 3 | 72–74 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'accept': the method is declared in an interface type | 3 | 73 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 155–157 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 276–278 |
info/magnolia/cms/util/ContentUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'static' on interface 'Visitor': member interfaces are implicitly static | 3 | 134–136 |
| UnnecessaryModifier | Unnecessary modifier 'static' on interface 'PostVisitor': member interfaces are implicitly static | 3 | 141–143 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 457–459 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 471–473 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 519–522 |
| UselessParentheses | Useless parentheses. | 4 | 593 |
info/magnolia/cms/util/DateUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 204 |
info/magnolia/cms/util/DelayedExecutor.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 82 |
info/magnolia/cms/util/DeprecationUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 64 |
info/magnolia/cms/util/InheritanceContentWrapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 3 | 76 |
info/magnolia/cms/util/LazyNodeDataWrapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 77 |
info/magnolia/cms/util/NodeDataUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 111 |
| UselessParentheses | Useless parentheses. | 4 | 113 |
| UselessParentheses | Useless parentheses. | 4 | 115 |
| UselessParentheses | Useless parentheses. | 4 | 117 |
| UselessParentheses | Useless parentheses. | 4 | 119 |
| UselessParentheses | Useless parentheses. | 4 | 122 |
| UselessParentheses | Useless parentheses. | 4 | 196 |
| UselessParentheses | Useless parentheses. | 4 | 198 |
| UselessParentheses | Useless parentheses. | 4 | 200 |
| UselessParentheses | Useless parentheses. | 4 | 202 |
| UselessParentheses | Useless parentheses. | 4 | 204 |
| UselessParentheses | Useless parentheses. | 4 | 206 |
| UselessParentheses | Useless parentheses. | 4 | 236 |
| UselessParentheses | Useless parentheses. | 4 | 241 |
info/magnolia/cms/util/NodeMapWrapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 247 |
info/magnolia/cms/util/PathUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 46 |
info/magnolia/cms/util/QueryUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'javax.jcr.query.Query.JCR_SQL2' due to existing import 'javax.jcr.query.Query' | 4 | 168 |
info/magnolia/cms/util/RequestDispatchUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 129 |
| UselessParentheses | Useless parentheses. | 4 | 129 |
info/magnolia/cms/util/SearchReplace.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'group'. | 3 | 90 |
info/magnolia/cms/util/ServletUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 99 |
| EmptyIfStmt | Avoid empty if statements | 3 | 178–180 |
| UselessParentheses | Useless parentheses. | 4 | 178 |
| UselessParentheses | Useless parentheses. | 4 | 178 |
info/magnolia/cms/util/UnicodeNormalizer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 3 | 55 |
info/magnolia/cms/util/UrlPattern.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'MatchAllPattern': members of interface types are implicitly public | 3 | 74–97 |
| UnnecessaryModifier | Unnecessary modifier 'static' on class 'MatchAllPattern': types nested within an interface type are implicitly static | 3 | 74–97 |
info/magnolia/commands/MgnlCatalog.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 75 |
info/magnolia/commands/chain/ChainBase.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 3 | 51 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 123–125 |
| UselessParentheses | Useless parentheses. | 4 | 129 |
| UselessParentheses | Useless parentheses. | 4 | 132 |
info/magnolia/commands/chain/Command.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'CONTINUE_PROCESSING': the field is declared in an interface type | 3 | 45 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'PROCESSING_COMPLETE': the field is declared in an interface type | 3 | 46 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'clone': the method is declared in an interface type | 3 | 58 |
info/magnolia/commands/impl/ExportCommand.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 131–133 |
info/magnolia/commands/impl/VersionCommand.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 95 |
| UselessParentheses | Useless parentheses. | 4 | 136 |
info/magnolia/content2bean/Bean2ContentProcessor.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'toContent': the method is declared in an interface type | 3 | 47 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setNodeDatas': the method is declared in an interface type | 3 | 49 |
info/magnolia/content2bean/Bean2ContentTransformer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'resolveItemType': the method is declared in an interface type | 3 | 50 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'resolveName': the method is declared in an interface type | 3 | 55 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'prepareContent': the method is declared in an interface type | 3 | 60 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'finishContent': the method is declared in an interface type | 3 | 65 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isNode': the method is declared in an interface type | 3 | 70 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isProperty': the method is declared in an interface type | 3 | 75 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setNodeData': the method is declared in an interface type | 3 | 80 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'convertNodeDataValue': the method is declared in an interface type | 3 | 85 |
info/magnolia/content2bean/Content2BeanProcessor.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'toBean': the method is declared in an interface type | 3 | 52–53 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setProperties': the method is declared in an interface type | 3 | 58 |
info/magnolia/content2bean/Content2BeanTransformer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'newState': the method is declared in an interface type | 3 | 54 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'resolveType': the method is declared in an interface type | 3 | 59 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'resolveType': the method is declared in an interface type | 3 | 64 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getChildren': the method is declared in an interface type | 3 | 69 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'newBeanInstance': the method is declared in an interface type | 3 | 74 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'initBean': the method is declared in an interface type | 3 | 79 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setProperty': the method is declared in an interface type | 3 | 84 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setProperty': the method is declared in an interface type | 3 | 89 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'convertPropertyValue': the method is declared in an interface type | 3 | 94 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getTypeMapping': the method is declared in an interface type | 3 | 101 |
info/magnolia/content2bean/TransformationState.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'pushType': the method is declared in an interface type | 3 | 49 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'popType': the method is declared in an interface type | 3 | 51 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCurrentType': the method is declared in an interface type | 3 | 53 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'peekType': the method is declared in an interface type | 3 | 55 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'pushBean': the method is declared in an interface type | 3 | 57 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'popBean': the method is declared in an interface type | 3 | 59 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCurrentBean': the method is declared in an interface type | 3 | 61 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setCurrentBean': the method is declared in an interface type | 3 | 63 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'peekBean': the method is declared in an interface type | 3 | 65 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'pushContent': the method is declared in an interface type | 3 | 67 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'popContent': the method is declared in an interface type | 3 | 69 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getCurrentContent': the method is declared in an interface type | 3 | 71 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'peekContent': the method is declared in an interface type | 3 | 73 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLevel': the method is declared in an interface type | 3 | 78 |
info/magnolia/content2bean/impl/CollectionPropertyHidingTransformer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 98–102 |
info/magnolia/content2bean/impl/Content2BeanTransformerImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 349–354 |
info/magnolia/content2bean/impl/TypeMappingImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 141–153 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 254–256 |
info/magnolia/context/Context.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'LOCAL_SCOPE': the field is declared in an interface type | 3 | 59 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'SESSION_SCOPE': the field is declared in an interface type | 3 | 64 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'APPLICATION_SCOPE': the field is declared in an interface type | 3 | 69 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_REPOSITORY': the field is declared in an interface type | 3 | 71 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_PATH': the field is declared in an interface type | 3 | 73 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_VERSION': the field is declared in an interface type | 3 | 75 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_VERSION_MAP': the field is declared in an interface type | 3 | 77 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_UUID': the field is declared in an interface type | 3 | 79 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_RECURSIVE': the field is declared in an interface type | 3 | 81 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_COMMENT': the field is declared in an interface type | 3 | 83 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_MESSAGE': the field is declared in an interface type | 3 | 85 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_EXCEPTION': the field is declared in an interface type | 3 | 87 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_REQUESTOR': the field is declared in an interface type | 3 | 94 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_USERNAME': the field is declared in an interface type | 3 | 99 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getUser': the method is declared in an interface type | 3 | 104 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getSubject': the method is declared in an interface type | 3 | 106 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setLocale': the method is declared in an interface type | 3 | 108 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getLocale': the method is declared in an interface type | 3 | 113 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getJCRSession': the method is declared in an interface type | 3 | 115 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAccessManager': the method is declared in an interface type | 3 | 120 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setAttribute': the method is declared in an interface type | 3 | 128 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAttribute': the method is declared in an interface type | 3 | 137 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAttribute': the method is declared in an interface type | 3 | 146 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAttributes': the method is declared in an interface type | 3 | 153 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'removeAttribute': the method is declared in an interface type | 3 | 158 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAttributes': the method is declared in an interface type | 3 | 165 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getMessages': the method is declared in an interface type | 3 | 171 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getMessages': the method is declared in an interface type | 3 | 179 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'release': the method is declared in an interface type | 3 | 184 |
info/magnolia/context/MgnlContext.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 376 |
| UnnecessaryModifier | Unnecessary modifier 'static' on interface 'Op': member interfaces are implicitly static | 3 | 397–399 |
info/magnolia/context/SingleJCRSessionSystemContext.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 3 | 49 |
info/magnolia/context/ThreadDependentSystemContext.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'releaseThread': the method is declared in an interface type | 3 | 45 |
info/magnolia/context/WebContext.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_REQUEST_CHARACTER_ENCODING': the field is declared in an interface type | 3 | 60 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ATTRIBUTE_REQUEST_URI': the field is declared in an interface type | 3 | 68 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'init': the method is declared in an interface type | 3 | 73 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getAggregationState': the method is declared in an interface type | 3 | 78 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getPostedForm': the method is declared in an interface type | 3 | 90 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getParameter': the method is declared in an interface type | 3 | 97 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getParameters': the method is declared in an interface type | 3 | 104 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getContextPath': the method is declared in an interface type | 3 | 109 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getRequest': the method is declared in an interface type | 3 | 116 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getResponse': the method is declared in an interface type | 3 | 121 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'push': the method is declared in an interface type | 3 | 138 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'pop': the method is declared in an interface type | 3 | 143 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getParameterValues': the method is declared in an interface type | 3 | 150 |
info/magnolia/debug/PerformanceTestStatus.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 72 |
info/magnolia/event/SystemEventBus.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'NAME': the field is declared in an interface type | 3 | 41 |
info/magnolia/importexport/BootstrapFilesComparator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 73 |
| UselessParentheses | Useless parentheses. | 4 | 73 |
info/magnolia/importexport/DataTransporter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 509 |
| UselessParentheses | Useless parentheses. | 4 | 511 |
info/magnolia/importexport/PropertiesImportExport.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyIfStmt | Avoid empty if statements | 3 | 143–145 |
| UnusedFormalParameter | Avoid unused method parameters such as 'dumpMetaData'. | 3 | 250 |
| UselessParentheses | Useless parentheses. | 4 | 288 |
| UselessParentheses | Useless parentheses. | 4 | 291 |
| UselessParentheses | Useless parentheses. | 4 | 294 |
| UselessParentheses | Useless parentheses. | 4 | 297 |
| UselessParentheses | Useless parentheses. | 4 | 300 |
| UselessParentheses | Useless parentheses. | 4 | 303 |
| UselessParentheses | Useless parentheses. | 4 | 306 |
info/magnolia/importexport/contenthandler/YamlContentHandler.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyStaticImports | Too many static imports may lead to messy code | 3 | 34–301 |
info/magnolia/importexport/exporter/YamlExporter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyStatementNotInLoop | An empty statement (semicolon) not part of a loop | 3 | 113 |
info/magnolia/importexport/filters/MetadataUuidFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 136 |
info/magnolia/importexport/filters/SkipNodePropertyFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 134 |
info/magnolia/init/DefaultMagnoliaInitPaths.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'magnoliaServletContextListener'. | 3 | 79 |
info/magnolia/jackrabbit/ProviderImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 214–216 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 491–493 |
info/magnolia/jcr/node2bean/impl/CollectionPropertyHidingTransformer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 101–105 |
info/magnolia/jcr/node2bean/impl/Node2BeanTransformerImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 319–324 |
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 3 | 495 |
| UselessParentheses | Useless parentheses. | 4 | 518 |
info/magnolia/jcr/node2bean/impl/TypeMappingImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 309–311 |
info/magnolia/jcr/nodebuilder/Ops.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 202 |
info/magnolia/jcr/util/ContentMap.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 112–114 |
| EmptyIfStmt | Avoid empty if statements | 3 | 196–199 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'info.magnolia.link.LinkUtil.convertLinksFromUUIDPattern' due to existing import 'info.magnolia.link.LinkUtil' | 4 | 222 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 236–238 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 249–251 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 263–265 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map' | 4 | 273 |
info/magnolia/jcr/util/MetaDataUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 80 |
info/magnolia/jcr/util/NodeNameHelper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 237 |
| UselessParentheses | Useless parentheses. | 4 | 237 |
| UselessParentheses | Useless parentheses. | 4 | 237 |
| UselessParentheses | Useless parentheses. | 4 | 238 |
| UselessParentheses | Useless parentheses. | 4 | 238 |
| UselessParentheses | Useless parentheses. | 4 | 238 |
| UselessParentheses | Useless parentheses. | 4 | 239 |
| UselessParentheses | Useless parentheses. | 4 | 239 |
| UselessParentheses | Useless parentheses. | 4 | 239 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 261–263 |
| UselessParentheses | Useless parentheses. | 4 | 277 |
info/magnolia/jcr/util/NodeUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 936 |
info/magnolia/jcr/util/PropertiesImportExport.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyIfStmt | Avoid empty if statements | 3 | 154–156 |
| UselessParentheses | Useless parentheses. | 4 | 261 |
| UselessParentheses | Useless parentheses. | 4 | 264 |
| UselessParentheses | Useless parentheses. | 4 | 267 |
| UselessParentheses | Useless parentheses. | 4 | 270 |
| UselessParentheses | Useless parentheses. | 4 | 273 |
| UselessParentheses | Useless parentheses. | 4 | 276 |
| UselessParentheses | Useless parentheses. | 4 | 279 |
info/magnolia/jcr/util/PropertyUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 93 |
| UselessParentheses | Useless parentheses. | 4 | 118 |
| UselessParentheses | Useless parentheses. | 4 | 120 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 191–193 |
| UselessParentheses | Useless parentheses. | 4 | 295 |
| UselessParentheses | Useless parentheses. | 4 | 297 |
| UselessParentheses | Useless parentheses. | 4 | 299 |
| UselessParentheses | Useless parentheses. | 4 | 301 |
| UselessParentheses | Useless parentheses. | 4 | 303 |
| UselessParentheses | Useless parentheses. | 4 | 306 |
| UselessParentheses | Useless parentheses. | 4 | 341 |
| UselessParentheses | Useless parentheses. | 4 | 491 |
| UselessParentheses | Useless parentheses. | 4 | 493 |
| UselessParentheses | Useless parentheses. | 4 | 495 |
| UselessParentheses | Useless parentheses. | 4 | 497 |
| UselessParentheses | Useless parentheses. | 4 | 499 |
| UselessParentheses | Useless parentheses. | 4 | 501 |
| UselessParentheses | Useless parentheses. | 4 | 503 |
| UselessParentheses | Useless parentheses. | 4 | 505 |
info/magnolia/jcr/wrapper/ChannelVisibilityContentDecorator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 76–90 |
info/magnolia/jcr/wrapper/DelegateNodeWrapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 576 |
| UselessOverridingMethod | Overriding method merely calls super | 3 | 589–592 |
info/magnolia/jcr/wrapper/DelegateSessionWrapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 341 |
| UselessOverridingMethod | Overriding method merely calls super | 3 | 354–357 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 360 |
info/magnolia/jcr/wrapper/HTMLEscapingPropertyWrapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'transformLineBreaks'. | 3 | 49 |
info/magnolia/jcr/wrapper/MgnlPropertySettingContentDecorator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 209–219 |
| UselessParentheses | Useless parentheses. | 4 | 703 |
info/magnolia/jcr/wrapper/MgnlPropertySettingNodeWrapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyIfStmt | Avoid empty if statements | 3 | 211–213 |
info/magnolia/link/Link.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 105–107 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 121–123 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 123–124 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 145–147 |
info/magnolia/link/LinkTransformerManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 3 | 53 |
info/magnolia/link/LinkUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 481–483 |
info/magnolia/module/ModuleLifecycleContext.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on field 'PHASE_SYSTEM_STARTUP': the field is declared in an interface type | 3 | 49 |
| UnnecessaryModifier | Unnecessary modifier 'public' on field 'PHASE_MODULE_RESTART': the field is declared in an interface type | 3 | 54 |
| UnnecessaryModifier | Unnecessary modifier 'public' on field 'PHASE_SYSTEM_SHUTDOWN': the field is declared in an interface type | 3 | 59 |
info/magnolia/module/ModuleManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'Factory': members of interface types are implicitly public | 3 | 91–99 |
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'ModuleManagementState': members of interface types are implicitly public | 3 | 104–167 |
| UnnecessaryModifier | Unnecessary modifier 'static' on class 'ModuleManagementState': types nested within an interface type are implicitly static | 3 | 104–167 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 148–150 |
| UnnecessaryModifier | Unnecessary modifier 'static' on class 'ModuleAndDeltas': types nested within an interface type are implicitly static | 3 | 172–212 |
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'ModuleAndDeltas': members of interface types are implicitly public | 3 | 172–212 |
info/magnolia/module/ModuleManagerImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 523 |
info/magnolia/module/ModuleRegistry.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'Factory': members of interface types are implicitly public | 3 | 101–109 |
info/magnolia/module/delta/BootstrapConditionally.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 88 |
info/magnolia/module/delta/ChangeAllPropertiesWithCertainValueTask.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 106–108 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 129–131 |
info/magnolia/module/delta/MoveAndRenamePropertyTask.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 70 |
info/magnolia/module/delta/RemoveDuplicatePermissionTask.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 91–95 |
info/magnolia/module/delta/RenamePropertyTask.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'name'. | 3 | 43 |
info/magnolia/module/files/MD5CheckingFileExtractorOperation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyIfStmt | Avoid empty if statements | 3 | 107–109 |
| EmptyWhileStmt | Avoid empty while statements | 3 | 165–166 |
info/magnolia/module/model/VersionRange.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'static' on enum 'Hand': nested enums are implicitly static | 3 | 183 |
| UnnecessaryModifier | Unnecessary modifier 'static' on enum 'Boundary': nested enums are implicitly static | 3 | 185–207 |
| UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'Boundary(Hand, char, boolean)': enum constructors are implicitly private | 3 | 193–197 |
info/magnolia/module/model/reader/DependencyLevelComparator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 111 |
info/magnolia/module/model/reader/LightModuleDefinitionReader.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final | 3 | 123 |
info/magnolia/module/ui/InstallationResourcesServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'in': resource specifications are implicitly final | 3 | 74 |
| UnnecessaryModifier | Unnecessary modifier 'final' on resource specification 'out': resource specifications are implicitly final | 3 | 75 |
info/magnolia/module/webapp/WebappVersionHandler.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 81 |
| UselessParentheses | Useless parentheses. | 4 | 81 |
info/magnolia/objectfactory/CandidateParameterResolver.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'javax.inject.Provider' due to existing import 'javax.inject.Provider' | 4 | 62 |
info/magnolia/objectfactory/DefaultClassFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'static' on interface 'Invoker': member interfaces are implicitly static | 3 | 102–104 |
info/magnolia/objectfactory/ObjectManufacturer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 165 |
info/magnolia/objectfactory/ParameterResolver.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'UNRESOLVED': the field is declared in an interface type | 3 | 41 |
info/magnolia/objectfactory/guice/GuicePropertyConfigurer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 55–58 |
info/magnolia/repository/DefaultRepositoryManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 171 |
info/magnolia/repository/RepositoryConstants.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'WEBSITE': the field is declared in an interface type | 3 | 45 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'USERS': the field is declared in an interface type | 3 | 46 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'USER_ROLES': the field is declared in an interface type | 3 | 47 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'USER_GROUPS': the field is declared in an interface type | 3 | 48 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'CONFIG': the field is declared in an interface type | 3 | 49 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'VERSION_STORE': the field is declared in an interface type | 3 | 50 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'SYSTEM': the field is declared in an interface type | 3 | 51 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'NAMESPACE_PREFIX': the field is declared in an interface type | 3 | 56 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'NAMESPACE_URI': the field is declared in an interface type | 3 | 57 |
info/magnolia/repository/RepositoryNotInitializedException.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 49 |
info/magnolia/setup/CoreModule.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'commandsManager'. | 3 | 56 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'virtualURIManager'. | 3 | 56 |
info/magnolia/setup/CoreModuleVersionHandler.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 163 |
| UselessParentheses | Useless parentheses. | 4 | 174 |
| UselessParentheses | Useless parentheses. | 4 | 177 |
| UselessParentheses | Useless parentheses. | 4 | 179 |
| UselessParentheses | Useless parentheses. | 4 | 182 |
| UselessParentheses | Useless parentheses. | 4 | 195 |
| UselessParentheses | Useless parentheses. | 4 | 199 |
| UselessParentheses | Useless parentheses. | 4 | 202 |
| UselessParentheses | Useless parentheses. | 4 | 205 |
| UselessParentheses | Useless parentheses. | 4 | 208 |
| UselessParentheses | Useless parentheses. | 4 | 221 |
| UselessParentheses | Useless parentheses. | 4 | 225 |
| UselessParentheses | Useless parentheses. | 4 | 228 |
| UselessParentheses | Useless parentheses. | 4 | 232 |
| UselessParentheses | Useless parentheses. | 4 | 235 |
| UselessParentheses | Useless parentheses. | 4 | 243 |
info/magnolia/setup/MigrateVersionWorkspacesToNewStructureTask.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 138–140 |
info/magnolia/setup/for4_5/UpdateSecurityFilterClientCallbacksConfiguration.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'ctx'. | 3 | 194 |
| UnusedFormalParameter | Avoid unused method parameters such as 'ctx'. | 3 | 208 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'ArrayUtils.contains' due to existing static import 'org.apache.commons.lang3.ArrayUtils.contains' | 4 | 211 |
info/magnolia/setup/for5_2/IsNotAProblematicEnvironmentCondition.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 84 |
| UselessParentheses | Useless parentheses. | 4 | 84 |
info/magnolia/setup/initial/LoginAuthTypePropertyMovedToFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 48 |
info/magnolia/stats/JCRStatsMBean.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getSessionCount': the method is declared in an interface type | 3 | 40 |
info/magnolia/voting/Voting.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'AND': the field is declared in an interface type | 3 | 47 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'OR': the field is declared in an interface type | 3 | 48 |
| UnnecessaryModifier | Unnecessary modifiers 'public static' on field 'HIGHEST_LEVEL': the field is declared in an interface type | 3 | 49 |
| UnnecessaryModifier | Unnecessary modifier 'static' on class 'Factory': types nested within an interface type are implicitly static | 3 | 59–63 |
info/magnolia/voting/voters/RequestExtensionVoter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 92 |
info/magnolia/voting/voters/RequestParametersVoter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 61–67 |
info/magnolia/voting/voters/RoleBaseVoter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 53 |