PMD Results

The following document contains the results of PMD 6.21.0.

Violations By Priority

Priority 3

info/magnolia/rendering/context/AggregationStateBasedRenderingContext.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'legacyContent'. 170

info/magnolia/rendering/context/RenderingListener.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'before': the method is declared in an interface type 52
UnnecessaryModifier Unnecessary modifier 'public' on method 'after': the method is declared in an interface type 54

info/magnolia/rendering/engine/FilteringResponseOutputProvider.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'log'. 52
UselessOverridingMethod Overriding method merely calls super 72–74

info/magnolia/rendering/engine/RenderExceptionHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'handleException': the method is declared in an interface type 46
UnnecessaryModifier Unnecessary modifier 'public' on method 'handleException': the method is declared in an interface type 51

info/magnolia/rendering/engine/RenderingEngine.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRenderingContext': the method is declared in an interface type 85
UnnecessaryModifier Unnecessary modifier 'public' on method 'initListeners': the method is declared in an interface type 91
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRenderEmptyAreas': the method is declared in an interface type 93
UnnecessaryModifier Unnecessary modifier 'public' on method 'getAutoPopulateFromRequest': the method is declared in an interface type 95

info/magnolia/rendering/engine/RenderingFilter.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 264–271

info/magnolia/rendering/listeners/AbstractRenderingListener.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'RenderingListenerReturnCode': nested enums are implicitly static 59–63

info/magnolia/rendering/model/RenderingModel.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'SKIP_RENDERING': the field is declared in an interface type 73

info/magnolia/rendering/renderer/FreemarkerRenderer.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'log'. 63

info/magnolia/rendering/template/AreaDefinition.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'TYPE_NO_COMPONENT': the field is declared in an interface type 45
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'TYPE_LIST': the field is declared in an interface type 46
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'TYPE_SINGLE': the field is declared in an interface type 47
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'CONTENT_STRUCTURE_FLAT': the field is declared in an interface type 48
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'CONTENT_STRUCTURE_NODE': the field is declared in an interface type 49
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'DEFAULT_TYPE': the field is declared in an interface type 50
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'CMS_ADD': the field is declared in an interface type 52
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'CMS_PLACEHOLDER': the field is declared in an interface type 53
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'CMS_EDIT': the field is declared in an interface type 54

info/magnolia/rendering/template/AutoGenerationConfiguration.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'TEMPLATE_ID': the field is declared in an interface type 47
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'NODE_TYPE': the field is declared in an interface type 49

info/magnolia/rendering/template/assignment/MetaDataBasedTemplateDefinitionAssignment.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simpleTranslator'. 80
EmptyCatchBlock Avoid empty catch blocks 115–117

Priority 4

info/magnolia/rendering/engine/ModeDependentRenderExceptionHandler.java

Rule Violation Line
UselessParentheses Useless parentheses. 116

info/magnolia/rendering/template/configured/ConfiguredInheritance.java

Rule Violation Line
UselessParentheses Useless parentheses. 166

info/magnolia/rendering/template/configured/FilteredInheritancePredicate.java

Rule Violation Line
UselessParentheses Useless parentheses. 51

info/magnolia/rendering/template/registry/validator/TemplateDefinitionValidator.java

Rule Violation Line
UselessParentheses Useless parentheses. 137

Files

info/magnolia/rendering/context/AggregationStateBasedRenderingContext.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'legacyContent'. 3 170

info/magnolia/rendering/context/RenderingListener.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'before': the method is declared in an interface type 3 52
UnnecessaryModifier Unnecessary modifier 'public' on method 'after': the method is declared in an interface type 3 54

info/magnolia/rendering/engine/FilteringResponseOutputProvider.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'log'. 3 52
UselessOverridingMethod Overriding method merely calls super 3 72–74

info/magnolia/rendering/engine/ModeDependentRenderExceptionHandler.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 116

info/magnolia/rendering/engine/RenderExceptionHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'handleException': the method is declared in an interface type 3 46
UnnecessaryModifier Unnecessary modifier 'public' on method 'handleException': the method is declared in an interface type 3 51

info/magnolia/rendering/engine/RenderingEngine.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRenderingContext': the method is declared in an interface type 3 85
UnnecessaryModifier Unnecessary modifier 'public' on method 'initListeners': the method is declared in an interface type 3 91
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRenderEmptyAreas': the method is declared in an interface type 3 93
UnnecessaryModifier Unnecessary modifier 'public' on method 'getAutoPopulateFromRequest': the method is declared in an interface type 3 95

info/magnolia/rendering/engine/RenderingFilter.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 264–271

info/magnolia/rendering/listeners/AbstractRenderingListener.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'RenderingListenerReturnCode': nested enums are implicitly static 3 59–63

info/magnolia/rendering/model/RenderingModel.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'SKIP_RENDERING': the field is declared in an interface type 3 73

info/magnolia/rendering/renderer/FreemarkerRenderer.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'log'. 3 63

info/magnolia/rendering/template/AreaDefinition.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'TYPE_NO_COMPONENT': the field is declared in an interface type 3 45
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'TYPE_LIST': the field is declared in an interface type 3 46
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'TYPE_SINGLE': the field is declared in an interface type 3 47
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'CONTENT_STRUCTURE_FLAT': the field is declared in an interface type 3 48
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'CONTENT_STRUCTURE_NODE': the field is declared in an interface type 3 49
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'DEFAULT_TYPE': the field is declared in an interface type 3 50
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'CMS_ADD': the field is declared in an interface type 3 52
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'CMS_PLACEHOLDER': the field is declared in an interface type 3 53
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'CMS_EDIT': the field is declared in an interface type 3 54

info/magnolia/rendering/template/AutoGenerationConfiguration.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'TEMPLATE_ID': the field is declared in an interface type 3 47
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'NODE_TYPE': the field is declared in an interface type 3 49

info/magnolia/rendering/template/assignment/MetaDataBasedTemplateDefinitionAssignment.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'simpleTranslator'. 3 80
EmptyCatchBlock Avoid empty catch blocks 3 115–117

info/magnolia/rendering/template/configured/ConfiguredInheritance.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 166

info/magnolia/rendering/template/configured/FilteredInheritancePredicate.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 51

info/magnolia/rendering/template/registry/validator/TemplateDefinitionValidator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 137