PMD Results

The following document contains the results of PMD 6.21.0.

Violations By Priority

Priority 3

name/fraser/neil/plaintext/diff_match_patch.java

Rule Violation Line
EmptyWhileStmt Avoid empty while statements 816–818
EmptyWhileStmt Avoid empty while statements 1129–1131
CollapsibleIfStatements These nested if statements could be combined 1866–1876

org/vaadin/aceeditor/AceEditor.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'diffMethod': the field is declared in an interface type 69–70
UnnecessaryModifier Unnecessary modifier 'public' on method 'diff': the method is declared in an interface type 72
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'selectionChangedMethod': the field is declared in an interface type 90–92
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectionChanged': the method is declared in an interface type 94
UnusedFormalParameter Avoid unused constructor parameters such as 'selection'. 102
UnconditionalIfStatement Do not use if statements that are always true or always false 276

org/vaadin/aceeditor/Suggester.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSuggestions': the method is declared in an interface type 15
UnnecessaryModifier Unnecessary modifier 'public' on method 'applySuggestion': the method is declared in an interface type 32

org/vaadin/aceeditor/client/AceDoc.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'text'. 169

org/vaadin/aceeditor/client/AceEditorClientRpc.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'diff': the method is declared in an interface type 6
UnnecessaryModifier Unnecessary modifier 'public' on method 'changedOnServer': the method is declared in an interface type 15

org/vaadin/aceeditor/client/AceEditorConnector.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 310–312
EmptyIfStmt Avoid empty if statements 313–315

org/vaadin/aceeditor/client/AceEditorServerRpc.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'changed': the method is declared in an interface type 11
UnnecessaryModifier Unnecessary modifier 'public' on method 'changedDelayed': the method is declared in an interface type 14

org/vaadin/aceeditor/client/AceEditorWidget.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'changed': the method is declared in an interface type 28
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectionChanged': the method is declared in an interface type 31
UnnecessaryModifier Unnecessary modifier 'public' on method 'focusChanged': the method is declared in an interface type 35

org/vaadin/aceeditor/client/MarkerAddition.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'text2'. 9

org/vaadin/aceeditor/client/SuggestPopup.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 125–126

org/vaadin/aceeditor/client/SuggesterClientRpc.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'showSuggestions': the method is declared in an interface type 9
UnnecessaryModifier Unnecessary modifier 'public' on method 'applySuggestionDiff': the method is declared in an interface type 11

org/vaadin/aceeditor/client/SuggesterServerRpc.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'suggest': the method is declared in an interface type 13
UnnecessaryModifier Unnecessary modifier 'public' on method 'suggestionSelected': the method is declared in an interface type 15

org/vaadin/aceeditor/client/TransportDoc.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'asTransport': the method is declared in an interface type 22
UnnecessaryModifier Unnecessary modifier 'public' on method 'fromTransport': the method is declared in an interface type 26

org/vaadin/aceeditor/client/gwt/GwtAceChangeCursorHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onChangeCursor': the method is declared in an interface type 12

org/vaadin/aceeditor/client/gwt/GwtAceChangeEvent.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getActionString': private methods cannot be overridden 29–31

org/vaadin/aceeditor/client/gwt/GwtAceChangeHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onChange': the method is declared in an interface type 12

org/vaadin/aceeditor/client/gwt/GwtAceChangeSelectionHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onChangeSelection': the method is declared in an interface type 8

org/vaadin/aceeditor/client/gwt/GwtAceEditor.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'setModeFullPath': private methods cannot be overridden 43–45
UnnecessaryModifier Unnecessary modifier 'final' on method 'setThemeFullPath': private methods cannot be overridden 51–53
UnnecessaryModifier Unnecessary modifier 'final' on method 'getModeString': private methods cannot be overridden 55–57
UnnecessaryModifier Unnecessary modifier 'final' on method 'getThemeString': private methods cannot be overridden 59–61

org/vaadin/aceeditor/client/gwt/GwtAceEvent.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getTypeString': private methods cannot be overridden 24–26

org/vaadin/aceeditor/client/gwt/GwtAceFocusBlurHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onFocus': the method is declared in an interface type 7
UnnecessaryModifier Unnecessary modifier 'public' on method 'onBlur': the method is declared in an interface type 9

org/vaadin/aceeditor/client/gwt/GwtAceKeyboardHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on enum 'Command': the enum is declared in an interface type 16–25
UnnecessaryModifier Unnecessary modifier 'public' on method 'handleKeyboard': the method is declared in an interface type 37–38

Priority 4

name/fraser/neil/plaintext/diff_match_patch.java

Rule Violation Line
UselessParentheses Useless parentheses. 241
UselessParentheses Useless parentheses. 383
UselessParentheses Useless parentheses. 400
UselessParentheses Useless parentheses. 435
UselessParentheses Useless parentheses. 787–788
UselessParentheses Useless parentheses. 789–790
UselessParentheses Useless parentheses. 1093
UselessParentheses Useless parentheses. 1094
UselessParentheses Useless parentheses. 1094–1096
UselessParentheses Useless parentheses. 1582

org/vaadin/aceeditor/client/AceEditorWidget.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'com.vaadin.client.VConsole' 7
UselessParentheses Useless parentheses. 226
UselessParentheses Useless parentheses. 522
UselessParentheses Useless parentheses. 666

org/vaadin/aceeditor/client/AceRange.java

Rule Violation Line
UselessParentheses Useless parentheses. 87

org/vaadin/aceeditor/client/SuggestPopup.java

Rule Violation Line
UselessParentheses Useless parentheses. 169
UselessParentheses Useless parentheses. 182

org/vaadin/aceeditor/client/SuggesterConnector.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.util.logging.Logger' 17

org/vaadin/aceeditor/client/Util.java

Rule Violation Line
UselessParentheses Useless parentheses. 61
UselessParentheses Useless parentheses. 77

Files

name/fraser/neil/plaintext/diff_match_patch.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 241
UselessParentheses Useless parentheses. 4 383
UselessParentheses Useless parentheses. 4 400
UselessParentheses Useless parentheses. 4 435
UselessParentheses Useless parentheses. 4 787–788
UselessParentheses Useless parentheses. 4 789–790
EmptyWhileStmt Avoid empty while statements 3 816–818
UselessParentheses Useless parentheses. 4 1093
UselessParentheses Useless parentheses. 4 1094
UselessParentheses Useless parentheses. 4 1094–1096
EmptyWhileStmt Avoid empty while statements 3 1129–1131
UselessParentheses Useless parentheses. 4 1582
CollapsibleIfStatements These nested if statements could be combined 3 1866–1876

org/vaadin/aceeditor/AceEditor.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'diffMethod': the field is declared in an interface type 3 69–70
UnnecessaryModifier Unnecessary modifier 'public' on method 'diff': the method is declared in an interface type 3 72
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'selectionChangedMethod': the field is declared in an interface type 3 90–92
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectionChanged': the method is declared in an interface type 3 94
UnusedFormalParameter Avoid unused constructor parameters such as 'selection'. 3 102
UnconditionalIfStatement Do not use if statements that are always true or always false 3 276

org/vaadin/aceeditor/Suggester.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSuggestions': the method is declared in an interface type 3 15
UnnecessaryModifier Unnecessary modifier 'public' on method 'applySuggestion': the method is declared in an interface type 3 32

org/vaadin/aceeditor/client/AceDoc.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'text'. 3 169

org/vaadin/aceeditor/client/AceEditorClientRpc.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'diff': the method is declared in an interface type 3 6
UnnecessaryModifier Unnecessary modifier 'public' on method 'changedOnServer': the method is declared in an interface type 3 15

org/vaadin/aceeditor/client/AceEditorConnector.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 310–312
EmptyIfStmt Avoid empty if statements 3 313–315

org/vaadin/aceeditor/client/AceEditorServerRpc.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'changed': the method is declared in an interface type 3 11
UnnecessaryModifier Unnecessary modifier 'public' on method 'changedDelayed': the method is declared in an interface type 3 14

org/vaadin/aceeditor/client/AceEditorWidget.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'com.vaadin.client.VConsole' 4 7
UnnecessaryModifier Unnecessary modifier 'public' on method 'changed': the method is declared in an interface type 3 28
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectionChanged': the method is declared in an interface type 3 31
UnnecessaryModifier Unnecessary modifier 'public' on method 'focusChanged': the method is declared in an interface type 3 35
UselessParentheses Useless parentheses. 4 226
UselessParentheses Useless parentheses. 4 522
UselessParentheses Useless parentheses. 4 666

org/vaadin/aceeditor/client/AceRange.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 87

org/vaadin/aceeditor/client/MarkerAddition.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'text2'. 3 9

org/vaadin/aceeditor/client/SuggestPopup.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 125–126
UselessParentheses Useless parentheses. 4 169
UselessParentheses Useless parentheses. 4 182

org/vaadin/aceeditor/client/SuggesterClientRpc.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'showSuggestions': the method is declared in an interface type 3 9
UnnecessaryModifier Unnecessary modifier 'public' on method 'applySuggestionDiff': the method is declared in an interface type 3 11

org/vaadin/aceeditor/client/SuggesterConnector.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.util.logging.Logger' 4 17

org/vaadin/aceeditor/client/SuggesterServerRpc.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'suggest': the method is declared in an interface type 3 13
UnnecessaryModifier Unnecessary modifier 'public' on method 'suggestionSelected': the method is declared in an interface type 3 15

org/vaadin/aceeditor/client/TransportDoc.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'asTransport': the method is declared in an interface type 3 22
UnnecessaryModifier Unnecessary modifier 'public' on method 'fromTransport': the method is declared in an interface type 3 26

org/vaadin/aceeditor/client/Util.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 61
UselessParentheses Useless parentheses. 4 77

org/vaadin/aceeditor/client/gwt/GwtAceChangeCursorHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onChangeCursor': the method is declared in an interface type 3 12

org/vaadin/aceeditor/client/gwt/GwtAceChangeEvent.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getActionString': private methods cannot be overridden 3 29–31

org/vaadin/aceeditor/client/gwt/GwtAceChangeHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onChange': the method is declared in an interface type 3 12

org/vaadin/aceeditor/client/gwt/GwtAceChangeSelectionHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onChangeSelection': the method is declared in an interface type 3 8

org/vaadin/aceeditor/client/gwt/GwtAceEditor.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'setModeFullPath': private methods cannot be overridden 3 43–45
UnnecessaryModifier Unnecessary modifier 'final' on method 'setThemeFullPath': private methods cannot be overridden 3 51–53
UnnecessaryModifier Unnecessary modifier 'final' on method 'getModeString': private methods cannot be overridden 3 55–57
UnnecessaryModifier Unnecessary modifier 'final' on method 'getThemeString': private methods cannot be overridden 3 59–61

org/vaadin/aceeditor/client/gwt/GwtAceEvent.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getTypeString': private methods cannot be overridden 3 24–26

org/vaadin/aceeditor/client/gwt/GwtAceFocusBlurHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onFocus': the method is declared in an interface type 3 7
UnnecessaryModifier Unnecessary modifier 'public' on method 'onBlur': the method is declared in an interface type 3 9

org/vaadin/aceeditor/client/gwt/GwtAceKeyboardHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on enum 'Command': the enum is declared in an interface type 3 16–25
UnnecessaryModifier Unnecessary modifier 'public' on method 'handleKeyboard': the method is declared in an interface type 3 37–38