PMD Results
The following document contains the results of PMD 5.1.2.
Files
com/vaadin/client/ui/VScrollTablePatched.java
| Violation |
Line |
| Avoid unused private fields such as 'detachedScrollPosition'. |
296 |
| Avoid unused private fields such as 'initialContentReceived'. |
507 |
| Avoid unused private fields such as 'isNewBody'. |
520 |
| Avoid unused private fields such as 'touchScrollDelegate'. |
543 |
| Avoid unused private methods such as 'sendColumnWidthUpdates(Collection)'. |
741 |
| Overriding method merely calls super |
1913–1916 |
| Useless parentheses. |
2071–2072 |
| Useless parentheses. |
2097–2098 |
| Avoid empty if statements |
2145–2147 |
| Avoid unused local variables such as 'hCell'. |
2153 |
| Useless parentheses. |
2198 |
| These nested if statements could be combined |
2214–2227 |
| These nested if statements could be combined |
2216–2226 |
| Useless parentheses. |
2283 |
| Useless parentheses. |
2341–2342 |
| Useless parentheses. |
2342–2343 |
| Useless parentheses. |
2420 |
| Useless parentheses. |
2440 |
| These nested if statements could be combined |
3397–3400 |
| These nested if statements could be combined |
3579–3585 |
| These nested if statements could be combined |
4268–4271 |
| Useless parentheses. |
4805 |
| Useless parentheses. |
5756 |
| Useless parentheses. |
5850–5851 |
| Useless parentheses. |
5939 |
| Avoid unused local variables such as 'thisTrElement'. |
6071 |
| Avoid unused method parameters such as 'rowUidl'. |
6335 |
| Avoid unused method parameters such as 'rowUidl'. |
6342 |
| Useless parentheses. |
6446 |
| Useless parentheses. |
6446 |
| Useless parentheses. |
6652–6653 |
| Useless parentheses. |
6710 |
| These nested if statements could be combined |
6894–6903 |
| Useless parentheses. |
6981 |
| Useless parentheses. |
7008 |
| Useless parentheses. |
7032–7033 |
| Ensure you override both equals() and hashCode() |
7053 |
| Useless parentheses. |
7058 |
| Useless parentheses. |
7058 |
com/vaadin/client/ui/VTreeTablePatched.java
| Violation |
Line |
| Useless parentheses. |
812 |
| Useless parentheses. |
812 |
com/vaadin/client/ui/panel/EnterFriendlyPanelConnector.java
| Violation |
Line |
| Avoid unused imports such as 'com.google.gwt.dom.client.Style' |
20 |
| Avoid unused imports such as 'com.google.gwt.dom.client.Style.Unit' |
22 |
| Avoid unused imports such as 'com.vaadin.client.ComponentConnector' |
27 |
| Avoid unused imports such as 'com.vaadin.client.ConnectorHierarchyChangeEvent' |
28 |
| Avoid unused imports such as 'com.vaadin.client.LayoutManager' |
29 |
| Avoid unused imports such as 'com.vaadin.client.Profiler' |
31 |
| Avoid unused imports such as 'com.vaadin.client.ui.AbstractSingleComponentContainerConnector' |
33 |
| No need to import a type that lives in the same package |
40 |
| Avoid unused imports such as 'com.vaadin.shared.ui.panel.PanelState' |
45 |
com/vaadin/client/ui/table/TableConnectorPatched.java
| Violation |
Line |
| Avoid unused imports such as 'com.vaadin.shared.ui.Connect' |
41 |
| Useless parentheses. |
114 |
| These nested if statements could be combined |
267–287 |
com/vaadin/client/ui/treetable/TreeTableConnectorPatched.java
| Violation |
Line |
| These nested if statements could be combined |
53–61 |
| Useless parentheses. |
77–78 |
info/magnolia/ui/vaadin/actionbar/Actionbar.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
217 |
| Avoid modifiers which are implied by the context |
218 |
| Avoid modifiers which are implied by the context |
220 |
info/magnolia/ui/vaadin/dialog/BaseDialog.java
| Violation |
Line |
| Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' |
240 |
| Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' |
274 |
| Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' |
307 |
info/magnolia/ui/vaadin/dialog/ConfirmationDialog.java
| Violation |
Line |
| Overriding method merely calls super |
128–130 |
info/magnolia/ui/vaadin/editor/CroppableImage.java
| Violation |
Line |
| Overriding method merely calls super |
62–64 |
| Avoid modifiers which are implied by the context |
151 |
| Avoid modifiers which are implied by the context |
152–153 |
| Avoid modifiers which are implied by the context |
161 |
| Avoid modifiers which are implied by the context |
162–163 |
info/magnolia/ui/vaadin/editor/JCrop.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'handler'. |
62 |
info/magnolia/ui/vaadin/editor/JCropField.java
| Violation |
Line |
| Useless parentheses. |
158 |
| Useless parentheses. |
158 |
info/magnolia/ui/vaadin/form/Form.java
| Violation |
Line |
| Avoid unused private fields such as 'isValidationVisible'. |
63 |
info/magnolia/ui/vaadin/grid/MagnoliaTreeTable.java
| Violation |
Line |
| Overriding method merely calls super |
75–77 |
| Overriding method merely calls super |
116–118 |
info/magnolia/ui/vaadin/gwt/client/actionbar/widget/ActionbarWidgetViewImpl.java
| Violation |
Line |
| Useless parentheses. |
332 |
| Useless parentheses. |
335 |
info/magnolia/ui/vaadin/gwt/client/applauncher/connector/AppLauncherConnector.java
| Violation |
Line |
| Useless parentheses. |
123 |
| Overriding method merely calls super |
143–145 |
info/magnolia/ui/vaadin/gwt/client/applauncher/widget/AppLauncherView.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
52–57 |
info/magnolia/ui/vaadin/gwt/client/dialog/connector/DialogContainingFormConnector.java
| Violation |
Line |
| Useless parentheses. |
101 |
info/magnolia/ui/vaadin/gwt/client/dialog/widget/BaseDialogView.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
66–73 |
info/magnolia/ui/vaadin/gwt/client/dialog/widget/DialogHeaderWidget.java
| Violation |
Line |
| These nested if statements could be combined |
124–126 |
info/magnolia/ui/vaadin/gwt/client/form/formsection/widget/FormSectionWidget.java
| Violation |
Line |
| Useless parentheses. |
81 |
info/magnolia/ui/vaadin/gwt/client/form/tab/connector/FormTabConnector.java
| Violation |
Line |
| Overriding method merely calls super |
48–50 |
info/magnolia/ui/vaadin/gwt/client/form/widget/FormView.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
61–65 |
info/magnolia/ui/vaadin/gwt/client/form/widget/FormViewImpl.java
| Violation |
Line |
| Useless parentheses. |
177 |
info/magnolia/ui/vaadin/gwt/client/grid/VMagnoliaTable.java
| Violation |
Line |
| Overriding method merely calls super |
174–176 |
| Unnecessary use of fully qualified name 'com.google.gwt.user.client.Element' due to existing import 'com.google.gwt.user.client.Element' |
220 |
info/magnolia/ui/vaadin/gwt/client/grid/VMagnoliaTreeTable.java
| Violation |
Line |
| Useless parentheses. |
60 |
info/magnolia/ui/vaadin/gwt/client/jquerywrapper/JQueryCallback.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
40 |
info/magnolia/ui/vaadin/gwt/client/jquerywrapper/JQueryFunction.java
| Violation |
Line |
| Unnecessary final modifier in final class |
46–50 |
info/magnolia/ui/vaadin/gwt/client/layout/CssRule.java
| Violation |
Line |
| Avoid unused private fields such as 'rules'. |
45 |
| Avoid unused private methods such as 'searchForRule(JavaScriptObject,String,boolean)'. |
77–79 |
info/magnolia/ui/vaadin/gwt/client/layout/thumbnaillayout/widget/LazyThumbnailLayoutImageBundle.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
45 |
| Avoid modifiers which are implied by the context |
47 |
info/magnolia/ui/vaadin/gwt/client/layout/thumbnaillayout/widget/LazyThumbnailLayoutWidget.java
| Violation |
Line |
| Useless parentheses. |
217 |
info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/MagnoliaShellConnector.java
| Violation |
Line |
| Avoid empty if statements |
260–262 |
info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/MagnoliaShellViewImpl.java
| Violation |
Line |
| These nested if statements could be combined |
218–220 |
info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/ShellAppLauncher.java
| Violation |
Line |
| Useless parentheses. |
235 |
info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/VShellImageBundle.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
45 |
| Avoid modifiers which are implied by the context |
47 |
| Avoid modifiers which are implied by the context |
50 |
info/magnolia/ui/vaadin/gwt/client/magnoliashell/viewport/TransitionDelegate.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
55–71 |
info/magnolia/ui/vaadin/gwt/client/magnoliashell/viewport/widget/AppsViewportWidget.java
| Violation |
Line |
| Avoid unused local variables such as 'style'. |
195 |
| Useless parentheses. |
402 |
info/magnolia/ui/vaadin/gwt/client/mgwt/SliderClientBundle.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
44 |
info/magnolia/ui/vaadin/gwt/client/richtext/TextAreaStretcherConnector.java
| Violation |
Line |
| Useless parentheses. |
275 |
info/magnolia/ui/vaadin/gwt/client/richtext/VMagnoliaRichTextField.java
| Violation |
Line |
| Overriding method merely calls super |
160–162 |
info/magnolia/ui/vaadin/gwt/client/shared/icon/IconParameters.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
41 |
info/magnolia/ui/vaadin/gwt/client/tabsheet/tab/widget/MagnoliaTabWidget.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'connector'. |
48 |
info/magnolia/ui/vaadin/gwt/client/tabsheet/widget/MagnoliaTabSheetViewImpl.java
| Violation |
Line |
| Avoid unused private fields such as 'eventBus'. |
96 |
| An empty statement (semicolon) not part of a loop |
252 |
info/magnolia/ui/vaadin/gwt/client/usermenu/UserMenuClientRpc.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
44 |
info/magnolia/ui/vaadin/layout/SmallAppLayout.java
| Violation |
Line |
| Unnecessary use of fully qualified name 'com.vaadin.data.util.converter.Converter.ConversionException' due to existing import 'com.vaadin.data.util.converter.Converter' |
130 |
| Unnecessary use of fully qualified name 'com.vaadin.data.util.converter.Converter.ConversionException' due to existing import 'com.vaadin.data.util.converter.Converter' |
135 |
org/vaadin/openesignforms/ckeditor/widgetset/client/ui/VCKEditorTextField.java
| Violation |
Line |
| Avoid unused imports such as 'com.vaadin.client.VConsole' |
26 |
| These nested if statements could be combined |
314–316 |
| Avoid unnecessary return statements |
457 |
org/vaadin/peter/contextmenu/ContextMenu.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
526–528 |
| Avoid modifiers which are implied by the context |
536 |
| Avoid modifiers which are implied by the context |
557–560 |
| Avoid modifiers which are implied by the context |
566 |
| Avoid modifiers which are implied by the context |
599–615 |
| Avoid modifiers which are implied by the context |
601–605 |
| Avoid modifiers which are implied by the context |
613–614 |
| Avoid modifiers which are implied by the context |
623–666 |
| Avoid modifiers which are implied by the context |
625–628 |
| Avoid modifiers which are implied by the context |
630–633 |
| Avoid modifiers which are implied by the context |
635–638 |
| Avoid modifiers which are implied by the context |
646–647 |
| Avoid modifiers which are implied by the context |
655–656 |
| Avoid modifiers which are implied by the context |
664–665 |
| Avoid modifiers which are implied by the context |
668–682 |
| Avoid modifiers which are implied by the context |
669–672 |
| Avoid modifiers which are implied by the context |
680–681 |
org/vaadin/peter/contextmenu/client/ContextMenuClientRpc.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
19 |
org/vaadin/peter/contextmenu/client/ContextMenuItemWidgetHandler.java
| Violation |
Line |
| These nested if statements could be combined |
112–114 |
org/vaadin/peter/contextmenu/client/ContextMenuOverlay.java
| Violation |
Line |
| Useless parentheses. |
188 |
| Useless parentheses. |
188 |
| Useless parentheses. |
196 |
| Useless parentheses. |
196 |
org/vaadin/peter/contextmenu/client/ContextMenuServerRpc.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
16 |
| Avoid modifiers which are implied by the context |
28–29 |
| Avoid modifiers which are implied by the context |
34 |
