PMD Results

The following document contains the results of PMD 5.1.2.

Files

info/magnolia/ui/workbench/AbstractContentPresenterBase.java

Violation Line
Avoid unused local variables such as 'item'. 188

info/magnolia/ui/workbench/ContentView.java

Violation Line
Avoid modifiers which are implied by the context 7485

info/magnolia/ui/workbench/WorkbenchViewImpl.java

Violation Line
Avoid unused private fields such as 'previousViewType'. 102
Avoid unused local variables such as 'deleteShortcut'. 187

info/magnolia/ui/workbench/column/definition/ColumnAvailabilityRule.java

Violation Line
Avoid modifiers which are implied by the context 44

info/magnolia/ui/workbench/list/ListViewImpl.java

Violation Line
Avoid unused private fields such as 'log'. 67

info/magnolia/ui/workbench/search/SearchJcrContainer.java

Violation Line
Useless parentheses. 226
Useless parentheses. 227
Useless parentheses. 228
Useless parentheses. 228

info/magnolia/ui/workbench/thumbnail/ThumbnailContainer.java

Violation Line
Avoid modifiers which are implied by the context 241243

info/magnolia/ui/workbench/thumbnail/ThumbnailPresenter.java

Violation Line
Avoid unused private fields such as 'log'. 61

info/magnolia/ui/workbench/tree/HierarchicalJcrContainer.java

Violation Line
Avoid unused private methods such as 'getSession()'. 269

info/magnolia/ui/workbench/tree/InplaceEditingFieldFactory.java

Violation Line
Unnecessary use of fully qualified name 'com.vaadin.data.Property.ValueChangeEvent' due to existing import 'com.vaadin.data.Property' 142

info/magnolia/ui/workbench/tree/TreeView.java

Violation Line
Avoid modifiers which are implied by the context 5861

info/magnolia/ui/workbench/tree/TreeViewImpl.java

Violation Line
Avoid unused local variables such as 'field'. 313

info/magnolia/ui/workbench/tree/drop/DropConstraint.java

Violation Line
Avoid modifiers which are implied by the context 55
Avoid modifiers which are implied by the context 66
Avoid modifiers which are implied by the context 77
Avoid modifiers which are implied by the context 87
Avoid modifiers which are implied by the context 93

info/magnolia/ui/workbench/tree/drop/TreeViewDropHandler.java

Violation Line
These nested if statements could be combined 191194
Unnecessary use of fully qualified name 'NodeUtil.isSame' due to existing import 'info.magnolia.jcr.util.NodeUtil' 235
Unnecessary use of fully qualified name 'NodeUtil.moveProperty' due to existing import 'info.magnolia.jcr.util.NodeUtil' 280