Last Published: 2016-12-02
PMD Results
The following document contains the results of PMD 5.1.2.
Files
com/vaadin/client/ui/VScrollTablePatched.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.google.gwt.event.dom.client.ContextMenuEvent' | 52 |
| Avoid unused imports such as 'com.google.gwt.event.dom.client.ContextMenuHandler' | 53 |
| Avoid unused imports such as 'com.google.gwt.user.client.ui.RootPanel' | 81 |
| Avoid modifiers which are implied by the context | 163 |
| Avoid unused private fields such as 'detachedScrollPosition'. | 438 |
| Avoid unused private fields such as 'initialContentReceived'. | 690 |
| Avoid unused private fields such as 'touchScrollDelegate'. | 726 |
| Avoid unused private methods such as 'sendColumnWidthUpdates(Collection)'. | 967 |
| Overriding method merely calls super | 2203–2206 |
| Useless parentheses. | 2365–2366 |
| Useless parentheses. | 2391–2392 |
| Avoid empty if statements | 2439–2441 |
| Avoid unused local variables such as 'hCell'. | 2447 |
| Useless parentheses. | 2492 |
| These nested if statements could be combined | 2508–2521 |
| These nested if statements could be combined | 2510–2520 |
| Useless parentheses. | 2572 |
| Useless parentheses. | 2630–2631 |
| Useless parentheses. | 2631–2632 |
| Useless parentheses. | 2683 |
| Useless parentheses. | 2732 |
| Useless parentheses. | 2752 |
| These nested if statements could be combined | 3287–3331 |
| These nested if statements could be combined | 3750–3753 |
| These nested if statements could be combined | 3932–3938 |
| These nested if statements could be combined | 4627–4630 |
| Useless parentheses. | 5177 |
| Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' | 5425 |
| Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' | 5911 |
| These nested if statements could be combined | 6112–6223 |
| Useless parentheses. | 6153 |
| Useless parentheses. | 6250–6251 |
| Useless parentheses. | 6348 |
| Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' | 6659 |
| Avoid unused method parameters such as 'rowUidl'. | 6748 |
| Avoid unused method parameters such as 'rowUidl'. | 6755 |
| Useless parentheses. | 6860 |
| Useless parentheses. | 6860 |
| Useless parentheses. | 7096–7097 |
| Useless parentheses. | 7154 |
| These nested if statements could be combined | 7315–7324 |
| Useless parentheses. | 7427 |
| Useless parentheses. | 7453 |
| Useless parentheses. | 7479–7480 |
| Useless parentheses. | 7489–7490 |
| Ensure you override both equals() and hashCode() | 7508 |
| Useless parentheses. | 7513 |
| Useless parentheses. | 7513 |
| Avoid unused private methods such as 'getLogger()'. | 8392 |
com/vaadin/client/ui/VTreeTablePatched.java
| Violation | Line |
|---|---|
| Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' | 151 |
| Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' | 277 |
| Useless parentheses. | 810 |
| Useless parentheses. | 810 |
com/vaadin/client/ui/panel/EnterFriendlyPanelConnector.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.google.gwt.dom.client.Style' | 20 |
| Avoid unused imports such as 'com.google.gwt.dom.client.Style.Unit' | 22 |
| Avoid unused imports such as 'com.vaadin.client.ComponentConnector' | 27 |
| Avoid unused imports such as 'com.vaadin.client.ConnectorHierarchyChangeEvent' | 28 |
| Avoid unused imports such as 'com.vaadin.client.LayoutManager' | 29 |
| Avoid unused imports such as 'com.vaadin.client.Profiler' | 31 |
| Avoid unused imports such as 'com.vaadin.client.ui.AbstractSingleComponentContainerConnector' | 33 |
| No need to import a type that lives in the same package | 40 |
| Avoid unused imports such as 'com.vaadin.shared.ui.panel.PanelState' | 45 |
com/vaadin/client/ui/table/TableConnectorPatched.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.vaadin.shared.ui.Connect' | 40 |
| Useless parentheses. | 124 |
| Avoid unused local variables such as 'totalRowsHaveChanged'. | 124 |
| These nested if statements could be combined | 259–279 |
com/vaadin/client/ui/treetable/TreeTableConnectorPatched.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 58–66 |
| Useless parentheses. | 82–83 |
info/magnolia/ui/vaadin/actionbar/Actionbar.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 217 |
| Avoid modifiers which are implied by the context | 218 |
| Avoid modifiers which are implied by the context | 220 |
info/magnolia/ui/vaadin/dialog/BaseDialog.java
| Violation | Line |
|---|---|
| Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' | 240 |
| Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' | 274 |
| Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' | 307 |
info/magnolia/ui/vaadin/dialog/ConfirmationDialog.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 128–130 |
info/magnolia/ui/vaadin/editor/CroppableImage.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 62–64 |
| Avoid modifiers which are implied by the context | 151 |
| Avoid modifiers which are implied by the context | 152–153 |
| Avoid modifiers which are implied by the context | 161 |
| Avoid modifiers which are implied by the context | 162–163 |
info/magnolia/ui/vaadin/editor/JCrop.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'handler'. | 65 |
info/magnolia/ui/vaadin/editor/JCropField.java
| Violation | Line |
|---|---|
| Useless parentheses. | 158 |
| Useless parentheses. | 158 |
info/magnolia/ui/vaadin/grid/MagnoliaTreeTable.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'log'. | 56 |
| Overriding method merely calls super | 74–76 |
| Overriding method merely calls super | 115–117 |
info/magnolia/ui/vaadin/gwt/client/actionbar/widget/ActionbarWidgetViewImpl.java
| Violation | Line |
|---|---|
| Useless parentheses. | 332 |
| Useless parentheses. | 335 |
info/magnolia/ui/vaadin/gwt/client/applauncher/connector/AppLauncherConnector.java
| Violation | Line |
|---|---|
| Useless parentheses. | 123 |
| Overriding method merely calls super | 143–145 |
info/magnolia/ui/vaadin/gwt/client/applauncher/widget/AppLauncherView.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 52–57 |
info/magnolia/ui/vaadin/gwt/client/dialog/connector/DialogContainingFormConnector.java
| Violation | Line |
|---|---|
| Useless parentheses. | 117 |
info/magnolia/ui/vaadin/gwt/client/dialog/widget/BaseDialogView.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 66–73 |
info/magnolia/ui/vaadin/gwt/client/dialog/widget/DialogHeaderWidget.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 124–126 |
info/magnolia/ui/vaadin/gwt/client/extension/MaxLengthIndicatorConnector.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'setIndicatorVisible(boolean)'. | 140 |
info/magnolia/ui/vaadin/gwt/client/form/formsection/widget/FormSectionWidget.java
| Violation | Line |
|---|---|
| Useless parentheses. | 79 |
info/magnolia/ui/vaadin/gwt/client/form/tab/connector/FormTabConnector.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 48–50 |
info/magnolia/ui/vaadin/gwt/client/form/widget/FormViewImpl.java
| Violation | Line |
|---|---|
| Useless parentheses. | 178 |
info/magnolia/ui/vaadin/gwt/client/grid/VMagnoliaTable.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 174–176 |
| Unnecessary use of fully qualified name 'com.google.gwt.user.client.Element' due to existing import 'com.google.gwt.user.client.Element' | 220 |
info/magnolia/ui/vaadin/gwt/client/grid/VMagnoliaTreeTable.java
| Violation | Line |
|---|---|
| Useless parentheses. | 60 |
info/magnolia/ui/vaadin/gwt/client/jquerywrapper/JQueryCallback.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 40 |
info/magnolia/ui/vaadin/gwt/client/jquerywrapper/JQueryFunction.java
| Violation | Line |
|---|---|
| Unnecessary final modifier in final class | 46–50 |
info/magnolia/ui/vaadin/gwt/client/layout/CssRule.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'rules'. | 48 |
| Avoid unused private methods such as 'searchForRule(JavaScriptObject,String,boolean)'. | 80–82 |
info/magnolia/ui/vaadin/gwt/client/layout/thumbnaillayout/widget/LazyThumbnailLayoutImageBundle.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 47 |
info/magnolia/ui/vaadin/gwt/client/layout/thumbnaillayout/widget/ThumbnailsSizeKeeper.java
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'scaleDimension(int,double)'. | 111 |
info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/MagnoliaShellViewImpl.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 224–226 |
info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/ShellAppLauncher.java
| Violation | Line |
|---|---|
| Useless parentheses. | 235 |
info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/VShellImageBundle.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 50 |
info/magnolia/ui/vaadin/gwt/client/magnoliashell/viewport/widget/AppsViewportWidget.java
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'style'. | 195 |
| Useless parentheses. | 402 |
info/magnolia/ui/vaadin/gwt/client/mgwt/SliderClientBundle.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 44 |
info/magnolia/ui/vaadin/gwt/client/richtext/TextAreaStretcherConnector.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 124–127 |
| Useless parentheses. | 333 |
info/magnolia/ui/vaadin/gwt/client/richtext/VMagnoliaRichTextField.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 160–162 |
info/magnolia/ui/vaadin/gwt/client/shared/icon/IconParameters.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 41 |
info/magnolia/ui/vaadin/gwt/client/tabsheet/tab/widget/MagnoliaTabWidget.java
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'connector'. | 48 |
info/magnolia/ui/vaadin/gwt/client/tabsheet/widget/TabBarWidget.java
| Violation | Line |
|---|---|
| Useless parentheses. | 143 |
| Useless parentheses. | 146 |
info/magnolia/ui/vaadin/gwt/client/usermenu/UserMenuClientRpc.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 44 |
info/magnolia/ui/vaadin/layout/SmallAppLayout.java
| Violation | Line |
|---|---|
| Unnecessary use of fully qualified name 'com.vaadin.data.util.converter.Converter.ConversionException' due to existing import 'com.vaadin.data.util.converter.Converter' | 130 |
| Unnecessary use of fully qualified name 'com.vaadin.data.util.converter.Converter.ConversionException' due to existing import 'com.vaadin.data.util.converter.Converter' | 135 |
org/vaadin/openesignforms/ckeditor/widgetset/client/ui/VCKEditorTextField.java
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.vaadin.client.VConsole' | 26 |
| These nested if statements could be combined | 314–316 |
| Avoid unnecessary return statements | 457 |
org/vaadin/peter/contextmenu/ContextMenu.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 526–528 |
| Avoid modifiers which are implied by the context | 536 |
| Avoid modifiers which are implied by the context | 557–560 |
| Avoid modifiers which are implied by the context | 566 |
| Avoid modifiers which are implied by the context | 599–615 |
| Avoid modifiers which are implied by the context | 601–605 |
| Avoid modifiers which are implied by the context | 613–614 |
| Avoid modifiers which are implied by the context | 623–666 |
| Avoid modifiers which are implied by the context | 625–628 |
| Avoid modifiers which are implied by the context | 630–633 |
| Avoid modifiers which are implied by the context | 635–638 |
| Avoid modifiers which are implied by the context | 646–647 |
| Avoid modifiers which are implied by the context | 655–656 |
| Avoid modifiers which are implied by the context | 664–665 |
| Avoid modifiers which are implied by the context | 668–682 |
| Avoid modifiers which are implied by the context | 669–672 |
| Avoid modifiers which are implied by the context | 680–681 |
org/vaadin/peter/contextmenu/client/ContextMenuClientRpc.java
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 19 |
org/vaadin/peter/contextmenu/client/ContextMenuItemWidgetHandler.java
| Violation | Line |
|---|---|
| These nested if statements could be combined | 112–114 |