PMD Results

The following document contains the results of PMD 5.1.2.

Files

info/magnolia/ui/admincentral/AdmincentralVaadinServlet.java

Violation Line
Avoid unused method parameters such as 'e'. 166
Avoid unused method parameters such as 'request'. 210

info/magnolia/ui/admincentral/setup/ConvertAclToAppPermissionTask.java

Violation Line
Useless parentheses. 176

info/magnolia/ui/admincentral/shellapp/applauncher/AppLauncherView.java

Violation Line
Avoid modifiers which are implied by the context 4749

info/magnolia/ui/admincentral/shellapp/favorites/FavoritesEntry.java

Violation Line
Avoid empty if statements 236239
Useless parentheses. 340

info/magnolia/ui/admincentral/shellapp/favorites/FavoritesForm.java

Violation Line
Avoid unused constructor parameters such as 'newGroup'. 102
Avoid unused constructor parameters such as 'newFavorite'. 102
Avoid unused constructor parameters such as 'availableGroups'. 102

info/magnolia/ui/admincentral/shellapp/favorites/FavoritesGroup.java

Violation Line
Avoid unused private fields such as 'editableFavoriteItems'. 76
Avoid unused constructor parameters such as 'view'. 89

info/magnolia/ui/admincentral/shellapp/favorites/FavoritesManagerImpl.java

Violation Line
Unnecessary use of fully qualified name 'Favorite.NAME' due to existing import 'info.magnolia.ui.framework.AdmincentralNodeTypes.Favorite' 94
Unnecessary use of fully qualified name 'Favorite.NAME' due to existing import 'info.magnolia.ui.framework.AdmincentralNodeTypes.Favorite' 162
Unnecessary use of fully qualified name 'Favorite.NAME' due to existing import 'info.magnolia.ui.framework.AdmincentralNodeTypes.Favorite' 197

info/magnolia/ui/admincentral/shellapp/pulse/PulsePresenter.java

Violation Line
Avoid unused constructor parameters such as 'admincentralEventBus'. 83

info/magnolia/ui/admincentral/shellapp/pulse/PulseView.java

Violation Line
Avoid modifiers which are implied by the context 5760

info/magnolia/ui/admincentral/shellapp/pulse/item/detail/PulseDetailPresenter.java

Violation Line
Avoid modifiers which are implied by the context 4650

info/magnolia/ui/admincentral/shellapp/pulse/item/detail/PulseDetailView.java

Violation Line
Avoid modifiers which are implied by the context 5458

info/magnolia/ui/admincentral/shellapp/pulse/item/detail/PulseItemCategoryNavigator.java

Violation Line
Avoid modifiers which are implied by the context 170

info/magnolia/ui/admincentral/shellapp/pulse/item/list/AbstractPulseListView.java

Violation Line
Avoid unused private methods such as 'setComponentVisibility(boolean)'. 241

info/magnolia/ui/admincentral/shellapp/pulse/item/list/PulseListFooter.java

Violation Line
Avoid unused private methods such as 'enableActions(boolean)'. 207

info/magnolia/ui/admincentral/shellapp/pulse/task/TaskTypeHelper.java

Violation Line
Useless parentheses. 91

info/magnolia/ui/admincentral/shellapp/pulse/task/TasksListPresenter.java

Violation Line
Avoid unused private methods such as 'doTasksStatusUpdate(Task.Status)'. 266

info/magnolia/ui/admincentral/shellapp/pulse/task/action/availability/TaskAvailabilityRule.java

Violation Line
Useless parentheses. 91

info/magnolia/ui/admincentral/shellapp/pulse/task/data/TaskQuery.java

Violation Line
Avoid unused constructor parameters such as 'taskDefinitionRegistry'. 78

info/magnolia/ui/admincentral/usermenu/action/EditUserProfileDialogAction.java

Violation Line
Avoid unused private fields such as 'eventBus'. 65

info/magnolia/ui/admincentral/usermenu/field/factory/TimeZoneFieldFactory.java

Violation Line
These nested if statements could be combined 102104