PMD Results

The following document contains the results of PMD 5.1.2.

Files

com/googlecode/mgwt/collection/shared/LightArray.java

Violation Line
Avoid modifiers which are implied by the context 33
Avoid modifiers which are implied by the context 41
Avoid modifiers which are implied by the context 48
Avoid modifiers which are implied by the context 62
Avoid modifiers which are implied by the context 69

com/googlecode/mgwt/collection/shared/LightArrayBoolean.java

Violation Line
Avoid modifiers which are implied by the context 30
Avoid modifiers which are implied by the context 38
Avoid modifiers which are implied by the context 46
Avoid modifiers which are implied by the context 53
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 67

com/googlecode/mgwt/collection/shared/LightArrayInt.java

Violation Line
Avoid modifiers which are implied by the context 30
Avoid modifiers which are implied by the context 38
Avoid modifiers which are implied by the context 46
Avoid modifiers which are implied by the context 53
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 67

com/googlecode/mgwt/collection/shared/LightMap.java

Violation Line
Avoid modifiers which are implied by the context 31
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 46
Avoid modifiers which are implied by the context 53
Avoid modifiers which are implied by the context 61
Avoid modifiers which are implied by the context 69

com/googlecode/mgwt/dom/client/event/EventTypes.java

Violation Line
Avoid modifiers which are implied by the context 4
Avoid modifiers which are implied by the context 6

com/googlecode/mgwt/dom/client/event/mouse/SimulatedTouchEndEvent.java

Violation Line
Avoid unused private fields such as 'x'. 34
Avoid unused private fields such as 'y'. 35
Avoid unused private fields such as 'x_start'. 36
Avoid unused private fields such as 'y_start'. 37
Avoid unused private fields such as 'multiTouch'. 38

com/googlecode/mgwt/dom/client/event/mouse/SimulatedTouchMoveEvent.java

Violation Line
Avoid unused private fields such as 'x'. 34
Avoid unused private fields such as 'y'. 35
Avoid unused private fields such as 'x_start'. 37
Avoid unused private fields such as 'y_start'. 38
Avoid unused private fields such as 'multiTouch'. 39

com/googlecode/mgwt/dom/client/event/tap/HasTapHandlers.java

Violation Line
Avoid modifiers which are implied by the context 34

com/googlecode/mgwt/dom/client/event/tap/TapEvent.java

Violation Line
Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 56

com/googlecode/mgwt/dom/client/event/tap/TapHandler.java

Violation Line
Avoid modifiers which are implied by the context 27

com/googlecode/mgwt/dom/client/event/touch/HasTouchHandlers.java

Violation Line
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 51
Avoid modifiers which are implied by the context 63
Avoid modifiers which are implied by the context 75
Avoid modifiers which are implied by the context 87

com/googlecode/mgwt/dom/client/event/touch/JsTouch.java

Violation Line
Unnecessary final modifier in final class 3436
Unnecessary final modifier in final class 4345

com/googlecode/mgwt/dom/client/event/touch/Touch.java

Violation Line
Avoid modifiers which are implied by the context 31
Avoid modifiers which are implied by the context 38
Avoid modifiers which are implied by the context 40

com/googlecode/mgwt/dom/client/event/touch/TouchCancelHandler.java

Violation Line
Avoid modifiers which are implied by the context 32

com/googlecode/mgwt/dom/client/event/touch/TouchEndHandler.java

Violation Line
Avoid modifiers which are implied by the context 32

com/googlecode/mgwt/dom/client/event/touch/TouchMoveHandler.java

Violation Line
Avoid modifiers which are implied by the context 32

com/googlecode/mgwt/dom/client/event/touch/TouchStartHandler.java

Violation Line
Avoid modifiers which are implied by the context 32

com/googlecode/mgwt/dom/client/recognizer/EventPropagator.java

Violation Line
Avoid modifiers which are implied by the context 34

com/googlecode/mgwt/dom/client/recognizer/TimeProvider.java

Violation Line
Avoid modifiers which are implied by the context 26

com/googlecode/mgwt/dom/client/recognizer/TimerExecutor.java

Violation Line
Avoid modifiers which are implied by the context 26
Avoid modifiers which are implied by the context 2830
Avoid modifiers which are implied by the context 29

com/googlecode/mgwt/dom/client/recognizer/longtap/HasLongTapHandlers.java

Violation Line
Avoid modifiers which are implied by the context 34

com/googlecode/mgwt/dom/client/recognizer/longtap/LongTapEvent.java

Violation Line
Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 67

com/googlecode/mgwt/dom/client/recognizer/longtap/LongTapHandler.java

Violation Line
Avoid modifiers which are implied by the context 32

com/googlecode/mgwt/dom/client/recognizer/longtap/LongTapRecognizer.java

Violation Line
These nested if statements could be combined 202205

com/googlecode/mgwt/dom/client/recognizer/pinch/HasPinchHandlers.java

Violation Line
Avoid modifiers which are implied by the context 33

com/googlecode/mgwt/dom/client/recognizer/pinch/OffsetProvider.java

Violation Line
Avoid modifiers which are implied by the context 32
Avoid modifiers which are implied by the context 39

com/googlecode/mgwt/dom/client/recognizer/pinch/PinchEvent.java

Violation Line
Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 64

com/googlecode/mgwt/dom/client/recognizer/pinch/PinchHandler.java

Violation Line
Avoid modifiers which are implied by the context 33

com/googlecode/mgwt/dom/client/recognizer/swipe/HasSwipeHandlers.java

Violation Line
Avoid modifiers which are implied by the context 34
Avoid modifiers which are implied by the context 42
Avoid modifiers which are implied by the context 50

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeEndEvent.java

Violation Line
Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 54

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeEndHandler.java

Violation Line
Avoid modifiers which are implied by the context 32

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeMoveEvent.java

Violation Line
Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 60

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeMoveHandler.java

Violation Line
Avoid modifiers which are implied by the context 32

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeStartEvent.java

Violation Line
Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 58

com/googlecode/mgwt/dom/client/recognizer/tap/MultiTapEvent.java

Violation Line
Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 85

com/googlecode/mgwt/dom/client/recognizer/tap/MultiTapHandler.java

Violation Line
Avoid modifiers which are implied by the context 32

com/googlecode/mgwt/dom/client/recognizer/tap/MultiTapRecognizer.java

Violation Line
These nested if statements could be combined 191194
These nested if statements could be combined 265269

com/googlecode/mgwt/ui/client/widget/touch/TouchWidgetImpl.java

Violation Line
Avoid modifiers which are implied by the context 40
Avoid modifiers which are implied by the context 49
Avoid modifiers which are implied by the context 58
Avoid modifiers which are implied by the context 67

com/vaadin/client/ui/VScrollTablePatched.java

Violation Line
Avoid unused imports such as 'com.google.gwt.event.dom.client.ContextMenuEvent' 52
Avoid unused imports such as 'com.google.gwt.event.dom.client.ContextMenuHandler' 53
Avoid unused imports such as 'com.google.gwt.user.client.ui.RootPanel' 81
Avoid modifiers which are implied by the context 165
Avoid unused private fields such as 'detachedScrollPosition'. 440
Avoid unused private fields such as 'initialContentReceived'. 692
Avoid unused private fields such as 'touchScrollDelegate'. 733
Avoid unused private methods such as 'sendColumnWidthUpdates(Collection)'. 974
Overriding method merely calls super 22082211
Useless parentheses. 23702371
Useless parentheses. 23962397
Avoid empty if statements 24442446
Avoid unused local variables such as 'hCell'. 2452
Useless parentheses. 2497
These nested if statements could be combined 25132526
These nested if statements could be combined 25152525
Useless parentheses. 2577
Useless parentheses. 26352636
Useless parentheses. 26362637
Useless parentheses. 2688
Useless parentheses. 2737
Useless parentheses. 2757
These nested if statements could be combined 33023346
These nested if statements could be combined 37733776
These nested if statements could be combined 39553961
These nested if statements could be combined 46574660
Useless parentheses. 5207
Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' 5459
Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' 5945
These nested if statements could be combined 61466257
Useless parentheses. 6187
Useless parentheses. 62846285
Useless parentheses. 6382
Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' 6693
Avoid unused method parameters such as 'rowUidl'. 6782
Avoid unused method parameters such as 'rowUidl'. 6789
Useless parentheses. 6894
Useless parentheses. 6894
Useless parentheses. 71307131
Useless parentheses. 7188
These nested if statements could be combined 73527361
Useless parentheses. 7464
Useless parentheses. 7490
Useless parentheses. 75167517
Useless parentheses. 75267527
Ensure you override both equals() and hashCode() 7545
Useless parentheses. 7550
Useless parentheses. 7550
Avoid unused private methods such as 'getLogger()'. 8435

com/vaadin/client/ui/VSliderPatched.java

Violation Line
Useless parentheses. 251
Useless parentheses. 252
Avoid empty if statements 263264
Avoid empty if statements 265266
Avoid empty if statements 266267
These nested if statements could be combined 328331
Useless parentheses. 364
Useless parentheses. 433
Useless parentheses. 434
Useless parentheses. 445
Useless parentheses. 572

com/vaadin/client/ui/VTreeTablePatched.java

Violation Line
Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' 151
Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' 277
Useless parentheses. 810
Useless parentheses. 810

com/vaadin/client/ui/panel/EnterFriendlyPanelConnector.java

Violation Line
Avoid unused imports such as 'com.google.gwt.dom.client.Style' 20
Avoid unused imports such as 'com.google.gwt.dom.client.Style.Unit' 22
Avoid unused imports such as 'com.vaadin.client.ComponentConnector' 27
Avoid unused imports such as 'com.vaadin.client.ConnectorHierarchyChangeEvent' 28
Avoid unused imports such as 'com.vaadin.client.LayoutManager' 29
Avoid unused imports such as 'com.vaadin.client.Profiler' 31
Avoid unused imports such as 'com.vaadin.client.ui.AbstractSingleComponentContainerConnector' 33
No need to import a type that lives in the same package 40
Avoid unused imports such as 'com.vaadin.shared.ui.panel.PanelState' 45

com/vaadin/client/ui/table/TableConnectorPatched.java

Violation Line
Avoid unused imports such as 'com.vaadin.shared.ui.Connect' 50
Avoid unused local variables such as 'totalRowsHaveChanged'. 188
Useless parentheses. 188
These nested if statements could be combined 328348

com/vaadin/client/ui/treetable/TreeTableConnectorPatched.java

Violation Line
These nested if statements could be combined 5866
Useless parentheses. 8283

info/magnolia/ui/vaadin/actionbar/Actionbar.java

Violation Line
Avoid modifiers which are implied by the context 217
Avoid modifiers which are implied by the context 218
Avoid modifiers which are implied by the context 220

info/magnolia/ui/vaadin/dialog/BaseDialog.java

Violation Line
Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' 240
Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' 274
Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' 307

info/magnolia/ui/vaadin/dialog/ConfirmationDialog.java

Violation Line
Overriding method merely calls super 128130

info/magnolia/ui/vaadin/editor/CroppableImage.java

Violation Line
Overriding method merely calls super 6264
Avoid modifiers which are implied by the context 151
Avoid modifiers which are implied by the context 152153
Avoid modifiers which are implied by the context 161
Avoid modifiers which are implied by the context 162163

info/magnolia/ui/vaadin/editor/JCrop.java

Violation Line
Avoid unused constructor parameters such as 'handler'. 65

info/magnolia/ui/vaadin/editor/JCropField.java

Violation Line
Useless parentheses. 158
Useless parentheses. 158

info/magnolia/ui/vaadin/grid/MagnoliaTreeTable.java

Violation Line
Avoid unused private fields such as 'log'. 56
Overriding method merely calls super 7476
Overriding method merely calls super 115117

info/magnolia/ui/vaadin/gwt/client/actionbar/connector/ActionbarConnector.java

Violation Line
Useless parentheses. 74

info/magnolia/ui/vaadin/gwt/client/actionbar/widget/ActionbarWidgetViewImpl.java

Violation Line
Useless parentheses. 332
Useless parentheses. 335

info/magnolia/ui/vaadin/gwt/client/applauncher/connector/AppLauncherConnector.java

Violation Line
Useless parentheses. 123
Overriding method merely calls super 143145

info/magnolia/ui/vaadin/gwt/client/applauncher/widget/AppLauncherView.java

Violation Line
Avoid modifiers which are implied by the context 5257

info/magnolia/ui/vaadin/gwt/client/dialog/connector/DialogContainingFormConnector.java

Violation Line
Useless parentheses. 117

info/magnolia/ui/vaadin/gwt/client/dialog/widget/DialogHeaderWidget.java

Violation Line
These nested if statements could be combined 124126

info/magnolia/ui/vaadin/gwt/client/extension/MaxLengthIndicatorConnector.java

Violation Line
Avoid unused private methods such as 'setIndicatorVisible(boolean)'. 140

info/magnolia/ui/vaadin/gwt/client/form/formsection/widget/FormSectionWidget.java

Violation Line
Useless parentheses. 78

info/magnolia/ui/vaadin/gwt/client/form/tab/connector/FormTabConnector.java

Violation Line
Overriding method merely calls super 4850

info/magnolia/ui/vaadin/gwt/client/form/widget/FormViewImpl.java

Violation Line
Useless parentheses. 181

info/magnolia/ui/vaadin/gwt/client/grid/VMagnoliaTable.java

Violation Line
Overriding method merely calls super 176178
Unnecessary use of fully qualified name 'com.google.gwt.user.client.Element' due to existing import 'com.google.gwt.user.client.Element' 222

info/magnolia/ui/vaadin/gwt/client/grid/VMagnoliaTreeTable.java

Violation Line
Useless parentheses. 60

info/magnolia/ui/vaadin/gwt/client/jquerywrapper/JQueryCallback.java

Violation Line
Avoid modifiers which are implied by the context 40

info/magnolia/ui/vaadin/gwt/client/jquerywrapper/JQueryFunction.java

Violation Line
Unnecessary final modifier in final class 4650

info/magnolia/ui/vaadin/gwt/client/layout/CssRule.java

Violation Line
Avoid unused private fields such as 'rules'. 48
Avoid unused private methods such as 'searchForRule(JavaScriptObject,String,boolean)'. 8082

info/magnolia/ui/vaadin/gwt/client/layout/thumbnaillayout/widget/LazyThumbnailLayoutImageBundle.java

Violation Line
Avoid modifiers which are implied by the context 45
Avoid modifiers which are implied by the context 47

info/magnolia/ui/vaadin/gwt/client/layout/thumbnaillayout/widget/ThumbnailsSizeKeeper.java

Violation Line
Avoid unused private methods such as 'scaleDimension(int,double)'. 111

info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/MagnoliaShellViewImpl.java

Violation Line
These nested if statements could be combined 231233

info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/ShellAppLauncher.java

Violation Line
Useless parentheses. 235

info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/VShellImageBundle.java

Violation Line
Avoid modifiers which are implied by the context 45
Avoid modifiers which are implied by the context 47
Avoid modifiers which are implied by the context 50

info/magnolia/ui/vaadin/gwt/client/magnoliashell/viewport/widget/AppsViewportWidget.java

Violation Line
Avoid unused local variables such as 'style'. 195
Useless parentheses. 402

info/magnolia/ui/vaadin/gwt/client/richtext/TextAreaStretcherConnector.java

Violation Line
These nested if statements could be combined 115118

info/magnolia/ui/vaadin/gwt/client/richtext/VMagnoliaRichTextField.java

Violation Line
Overriding method merely calls super 160162

info/magnolia/ui/vaadin/gwt/client/shared/icon/IconParameters.java

Violation Line
Avoid modifiers which are implied by the context 41

info/magnolia/ui/vaadin/gwt/client/tabsheet/tab/widget/MagnoliaTabWidget.java

Violation Line
Avoid unused constructor parameters such as 'connector'. 48

info/magnolia/ui/vaadin/gwt/client/tabsheet/widget/TabBarWidget.java

Violation Line
Useless parentheses. 143
Useless parentheses. 146

info/magnolia/ui/vaadin/gwt/client/usermenu/UserMenuClientRpc.java

Violation Line
Avoid modifiers which are implied by the context 44

info/magnolia/ui/vaadin/layout/SmallAppLayout.java

Violation Line
Unnecessary use of fully qualified name 'com.vaadin.data.util.converter.Converter.ConversionException' due to existing import 'com.vaadin.data.util.converter.Converter' 130
Unnecessary use of fully qualified name 'com.vaadin.data.util.converter.Converter.ConversionException' due to existing import 'com.vaadin.data.util.converter.Converter' 135

org/vaadin/openesignforms/ckeditor/widgetset/client/ui/VCKEditorTextField.java

Violation Line
Avoid empty if statements 299301
Avoid empty if statements 322324
Avoid empty if statements 351353
Avoid empty if statements 371373
Avoid empty if statements 385387
Avoid empty if statements 388390
These nested if statements could be combined 402404
Avoid empty if statements 486488
Avoid empty if statements 489491
Avoid empty if statements 506508
Avoid empty if statements 509511
These nested if statements could be combined 523534
Avoid empty if statements 550552
Avoid empty if statements 578580
Avoid unused private methods such as 'logState(String)'. 583
Avoid unnecessary return statements 623

org/vaadin/peter/contextmenu/ContextMenu.java

Violation Line
Avoid modifiers which are implied by the context 526528
Avoid modifiers which are implied by the context 536
Avoid modifiers which are implied by the context 557560
Avoid modifiers which are implied by the context 566
Avoid modifiers which are implied by the context 599615
Avoid modifiers which are implied by the context 601605
Avoid modifiers which are implied by the context 613614
Avoid modifiers which are implied by the context 623666
Avoid modifiers which are implied by the context 625628
Avoid modifiers which are implied by the context 630633
Avoid modifiers which are implied by the context 635638
Avoid modifiers which are implied by the context 646647
Avoid modifiers which are implied by the context 655656
Avoid modifiers which are implied by the context 664665
Avoid modifiers which are implied by the context 668682
Avoid modifiers which are implied by the context 669672
Avoid modifiers which are implied by the context 680681

org/vaadin/peter/contextmenu/client/ContextMenuClientRpc.java

Violation Line
Avoid modifiers which are implied by the context 19

org/vaadin/peter/contextmenu/client/ContextMenuItemWidgetHandler.java

Violation Line
These nested if statements could be combined 112114

org/vaadin/peter/contextmenu/client/ContextMenuOverlay.java

Violation Line
Useless parentheses. 188
Useless parentheses. 188
Useless parentheses. 196
Useless parentheses. 196

org/vaadin/peter/contextmenu/client/ContextMenuServerRpc.java

Violation Line
Avoid modifiers which are implied by the context 16
Avoid modifiers which are implied by the context 2829
Avoid modifiers which are implied by the context 34