PMD Results

The following document contains the results of PMD 5.1.2.

Files

info/magnolia/security/app/action/AbstractDeleteGroupOrRoleAction.java

Violation Line
Avoid unused private methods such as 'formatUserAndGroupList(Collection)'. 255

info/magnolia/security/app/action/DeleteFolderAction.java

Violation Line
These nested if statements could be combined 152167

info/magnolia/security/app/dialog/action/SaveRoleDialogAction.java

Violation Line
Avoid unused private methods such as 'convertNewNodeAdapterForUpdating(JcrNewNodeAdapter,Node,String)'. 230

info/magnolia/security/app/dialog/field/AbstractAccessFieldFactory.java

Violation Line
Avoid using a branching statement as the last in a loop. 126

info/magnolia/security/app/dialog/field/AccessControlList.java

Violation Line
Avoid unused constructor parameters such as 'accessType'. 174

info/magnolia/security/app/dialog/field/AccessControlListField.java

Violation Line
Overriding method merely calls super 209211

info/magnolia/security/app/dialog/field/GroupManagementFieldFactory.java

Violation Line
Overriding method merely calls super 117119
Overriding method merely calls super 125127
Avoid empty catch blocks 143145

info/magnolia/security/app/dialog/field/WorkspaceAccessControlList.java

Violation Line
Useless parentheses. 248

info/magnolia/security/app/dialog/field/WorkspaceAccessFieldFactory.java

Violation Line
Avoid unused constructor parameters such as 'workbenchChooseDialogPresenter'. 125

info/magnolia/security/app/tools/permission/PermissionToolPresenter.java

Violation Line
Useless parentheses. 203

info/magnolia/security/app/util/AccessControlPropertyUtil.java

Violation Line
Useless parentheses. 69