PMD Results

The following document contains the results of PMD 5.1.2.

Files

com/googlecode/mgwt/collection/shared/LightArray.java

Violation Line
Avoid modifiers which are implied by the context 33
Avoid modifiers which are implied by the context 41
Avoid modifiers which are implied by the context 48
Avoid modifiers which are implied by the context 62
Avoid modifiers which are implied by the context 69

com/googlecode/mgwt/collection/shared/LightArrayBoolean.java

Violation Line
Avoid modifiers which are implied by the context 30
Avoid modifiers which are implied by the context 38
Avoid modifiers which are implied by the context 46
Avoid modifiers which are implied by the context 53
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 67

com/googlecode/mgwt/collection/shared/LightArrayInt.java

Violation Line
Avoid modifiers which are implied by the context 30
Avoid modifiers which are implied by the context 38
Avoid modifiers which are implied by the context 46
Avoid modifiers which are implied by the context 53
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 67

com/googlecode/mgwt/collection/shared/LightMap.java

Violation Line
Avoid modifiers which are implied by the context 31
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 46
Avoid modifiers which are implied by the context 53
Avoid modifiers which are implied by the context 61
Avoid modifiers which are implied by the context 69

com/googlecode/mgwt/dom/client/event/EventTypes.java

Violation Line
Avoid modifiers which are implied by the context 4
Avoid modifiers which are implied by the context 6

com/googlecode/mgwt/dom/client/event/mouse/SimulatedTouchEndEvent.java

Violation Line
Avoid unused private fields such as 'x'. 34
Avoid unused private fields such as 'y'. 35
Avoid unused private fields such as 'x_start'. 36
Avoid unused private fields such as 'y_start'. 37
Avoid unused private fields such as 'multiTouch'. 38

com/googlecode/mgwt/dom/client/event/mouse/SimulatedTouchMoveEvent.java

Violation Line
Avoid unused private fields such as 'x'. 34
Avoid unused private fields such as 'y'. 35
Avoid unused private fields such as 'x_start'. 37
Avoid unused private fields such as 'y_start'. 38
Avoid unused private fields such as 'multiTouch'. 39

com/googlecode/mgwt/dom/client/event/tap/HasTapHandlers.java

Violation Line
Avoid modifiers which are implied by the context 34

com/googlecode/mgwt/dom/client/event/tap/TapEvent.java

Violation Line
Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 56

com/googlecode/mgwt/dom/client/event/tap/TapHandler.java

Violation Line
Avoid modifiers which are implied by the context 27

com/googlecode/mgwt/dom/client/event/touch/HasTouchHandlers.java

Violation Line
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 51
Avoid modifiers which are implied by the context 63
Avoid modifiers which are implied by the context 75
Avoid modifiers which are implied by the context 87

com/googlecode/mgwt/dom/client/event/touch/JsTouch.java

Violation Line
Unnecessary final modifier in final class 34–36
Unnecessary final modifier in final class 43–45

com/googlecode/mgwt/dom/client/event/touch/Touch.java

Violation Line
Avoid modifiers which are implied by the context 31
Avoid modifiers which are implied by the context 38
Avoid modifiers which are implied by the context 40

com/googlecode/mgwt/dom/client/event/touch/TouchCancelHandler.java

Violation Line
Avoid modifiers which are implied by the context 32

com/googlecode/mgwt/dom/client/event/touch/TouchEndHandler.java

Violation Line
Avoid modifiers which are implied by the context 32

com/googlecode/mgwt/dom/client/event/touch/TouchMoveHandler.java

Violation Line
Avoid modifiers which are implied by the context 32

com/googlecode/mgwt/dom/client/event/touch/TouchStartHandler.java

Violation Line
Avoid modifiers which are implied by the context 32

com/googlecode/mgwt/dom/client/recognizer/EventPropagator.java

Violation Line
Avoid modifiers which are implied by the context 34

com/googlecode/mgwt/dom/client/recognizer/TimeProvider.java

Violation Line
Avoid modifiers which are implied by the context 26

com/googlecode/mgwt/dom/client/recognizer/TimerExecutor.java

Violation Line
Avoid modifiers which are implied by the context 26
Avoid modifiers which are implied by the context 28–30
Avoid modifiers which are implied by the context 29

com/googlecode/mgwt/dom/client/recognizer/longtap/HasLongTapHandlers.java

Violation Line
Avoid modifiers which are implied by the context 34

com/googlecode/mgwt/dom/client/recognizer/longtap/LongTapEvent.java

Violation Line
Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 67

com/googlecode/mgwt/dom/client/recognizer/longtap/LongTapHandler.java

Violation Line
Avoid modifiers which are implied by the context 32

com/googlecode/mgwt/dom/client/recognizer/longtap/LongTapRecognizer.java

Violation Line
These nested if statements could be combined 202–205

com/googlecode/mgwt/dom/client/recognizer/pinch/HasPinchHandlers.java

Violation Line
Avoid modifiers which are implied by the context 33

com/googlecode/mgwt/dom/client/recognizer/pinch/OffsetProvider.java

Violation Line
Avoid modifiers which are implied by the context 32
Avoid modifiers which are implied by the context 39

com/googlecode/mgwt/dom/client/recognizer/pinch/PinchEvent.java

Violation Line
Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 64

com/googlecode/mgwt/dom/client/recognizer/pinch/PinchHandler.java

Violation Line
Avoid modifiers which are implied by the context 33

com/googlecode/mgwt/dom/client/recognizer/swipe/HasSwipeHandlers.java

Violation Line
Avoid modifiers which are implied by the context 34
Avoid modifiers which are implied by the context 42
Avoid modifiers which are implied by the context 50

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeEndEvent.java

Violation Line
Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 54

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeEndHandler.java

Violation Line
Avoid modifiers which are implied by the context 32

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeMoveEvent.java

Violation Line
Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 60

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeMoveHandler.java

Violation Line
Avoid modifiers which are implied by the context 32

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeStartEvent.java

Violation Line
Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 58

com/googlecode/mgwt/dom/client/recognizer/tap/MultiTapEvent.java

Violation Line
Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 85

com/googlecode/mgwt/dom/client/recognizer/tap/MultiTapHandler.java

Violation Line
Avoid modifiers which are implied by the context 32

com/googlecode/mgwt/dom/client/recognizer/tap/MultiTapRecognizer.java

Violation Line
These nested if statements could be combined 191–194
These nested if statements could be combined 265–269

com/googlecode/mgwt/ui/client/widget/touch/TouchWidgetImpl.java

Violation Line
Avoid modifiers which are implied by the context 40
Avoid modifiers which are implied by the context 49
Avoid modifiers which are implied by the context 58
Avoid modifiers which are implied by the context 67

com/vaadin/client/ui/VSliderPatched.java

Violation Line
Avoid empty if statements 263–264
Avoid empty if statements 265–266
Avoid empty if statements 266–267
These nested if statements could be combined 328–331
Useless parentheses. 364

com/vaadin/client/ui/panel/EnterFriendlyPanelConnector.java

Violation Line
Avoid unused imports such as 'com.google.gwt.dom.client.Style' 20
Avoid unused imports such as 'com.google.gwt.dom.client.Style.Unit' 22
Avoid unused imports such as 'com.vaadin.client.ComponentConnector' 27
Avoid unused imports such as 'com.vaadin.client.ConnectorHierarchyChangeEvent' 28
Avoid unused imports such as 'com.vaadin.client.LayoutManager' 29
Avoid unused imports such as 'com.vaadin.client.Profiler' 31
Avoid unused imports such as 'com.vaadin.client.ui.AbstractSingleComponentContainerConnector' 33
No need to import a type that lives in the same package 40
Avoid unused imports such as 'com.vaadin.shared.ui.panel.PanelState' 45

com/vaadin/v7/client/ui/VScrollTablePatched.java

Violation Line
Avoid unused imports such as 'com.google.gwt.event.dom.client.ContextMenuEvent' 50
Avoid unused imports such as 'com.google.gwt.event.dom.client.ContextMenuHandler' 51
Avoid unused imports such as 'com.google.gwt.user.client.ui.RootPanel' 80
Avoid modifiers which are implied by the context 175
Avoid unused private fields such as 'detachedScrollPosition'. 450
Avoid unused private fields such as 'initialContentReceived'. 703
Avoid unused private fields such as 'touchScrollDelegate'. 744
Avoid unused private methods such as 'sendColumnWidthUpdates(Collection)'. 984
Overriding method merely calls super 2221–2224
Useless parentheses. 2382–2384
Useless parentheses. 2410–2411
Avoid empty if statements 2458–2460
Avoid unused local variables such as 'hCell'. 2466
Useless parentheses. 2511
These nested if statements could be combined 2527–2540
These nested if statements could be combined 2529–2539
Useless parentheses. 2591
Useless parentheses. 2647–2648
Useless parentheses. 2649–2650
Useless parentheses. 2702
Useless parentheses. 2752–2753
Useless parentheses. 2773–2775
These nested if statements could be combined 3320–3365
These nested if statements could be combined 3789–3792
These nested if statements could be combined 3971–3977
These nested if statements could be combined 4676–4679
Useless parentheses. 5226
Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' 5480
Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' 5967
These nested if statements could be combined 6166–6279
Useless parentheses. 6207–6208
Useless parentheses. 6305–6306
Useless parentheses. 6402–6403
Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' 6714
Avoid unused method parameters such as 'rowUidl'. 6802
Avoid unused method parameters such as 'rowUidl'. 6809
Useless parentheses. 6914
Useless parentheses. 6914
Useless parentheses. 7151–7152
Useless parentheses. 7210
These nested if statements could be combined 7375–7384
Useless parentheses. 7486
Useless parentheses. 7512
Useless parentheses. 7537–7538
Useless parentheses. 7547–7549
Ensure you override both equals() and hashCode() 7567
Useless parentheses. 7572
Useless parentheses. 7573
Avoid unused private methods such as 'getLogger()'. 8465

com/vaadin/v7/client/ui/VTreeTablePatched.java

Violation Line
Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' 153
Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' 279
Useless parentheses. 812–813
Useless parentheses. 814

com/vaadin/v7/client/ui/table/TableConnectorPatched.java

Violation Line
Avoid unused imports such as 'com.vaadin.shared.ui.Connect' 42
Useless parentheses. 187
Avoid unused local variables such as 'totalRowsHaveChanged'. 187
These nested if statements could be combined 327–345

com/vaadin/v7/client/ui/treetable/TreeTableConnectorPatched.java

Violation Line
Avoid unused imports such as 'com.vaadin.shared.ui.Connect' 24
Avoid unused imports such as 'com.vaadin.v7.ui.TreeTable' 32
These nested if statements could be combined 61–69
Useless parentheses. 84–85

info/magnolia/ui/vaadin/actionbar/Actionbar.java

Violation Line
Avoid modifiers which are implied by the context 216
Avoid modifiers which are implied by the context 217
Avoid modifiers which are implied by the context 219

info/magnolia/ui/vaadin/dialog/BaseDialog.java

Violation Line
Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' 239
Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' 273
Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' 306

info/magnolia/ui/vaadin/dialog/ConfirmationDialog.java

Violation Line
Overriding method merely calls super 128–130

info/magnolia/ui/vaadin/editor/CroppableImage.java

Violation Line
Overriding method merely calls super 62–64
Avoid modifiers which are implied by the context 151
Avoid modifiers which are implied by the context 152–153
Avoid modifiers which are implied by the context 161
Avoid modifiers which are implied by the context 162–163

info/magnolia/ui/vaadin/editor/JCrop.java

Violation Line
Avoid unused constructor parameters such as 'handler'. 65

info/magnolia/ui/vaadin/editor/JCropField.java

Violation Line
Useless parentheses. 158
Useless parentheses. 158

info/magnolia/ui/vaadin/grid/MagnoliaTreeTable.java

Violation Line
Avoid unused private fields such as 'log'. 56
Overriding method merely calls super 74–76
Overriding method merely calls super 115–117

info/magnolia/ui/vaadin/gwt/client/actionbar/connector/ActionbarConnector.java

Violation Line
Useless parentheses. 74

info/magnolia/ui/vaadin/gwt/client/actionbar/widget/ActionbarWidgetViewImpl.java

Violation Line
Useless parentheses. 332
Useless parentheses. 335

info/magnolia/ui/vaadin/gwt/client/applauncher/connector/AppLauncherConnector.java

Violation Line
Useless parentheses. 123
Overriding method merely calls super 143–145

info/magnolia/ui/vaadin/gwt/client/applauncher/widget/AppLauncherView.java

Violation Line
Avoid modifiers which are implied by the context 52–57

info/magnolia/ui/vaadin/gwt/client/dialog/connector/DialogContainingFormConnector.java

Violation Line
Useless parentheses. 117

info/magnolia/ui/vaadin/gwt/client/dialog/widget/DialogHeaderWidget.java

Violation Line
These nested if statements could be combined 124–126

info/magnolia/ui/vaadin/gwt/client/extension/MaxLengthIndicatorConnector.java

Violation Line
Avoid unused private methods such as 'setIndicatorVisible(boolean)'. 140

info/magnolia/ui/vaadin/gwt/client/form/formsection/widget/FormSectionWidget.java

Violation Line
Useless parentheses. 78

info/magnolia/ui/vaadin/gwt/client/form/tab/connector/FormTabConnector.java

Violation Line
Overriding method merely calls super 48–50

info/magnolia/ui/vaadin/gwt/client/form/widget/FormViewImpl.java

Violation Line
Useless parentheses. 181

info/magnolia/ui/vaadin/gwt/client/grid/VMagnoliaTable.java

Violation Line
Overriding method merely calls super 176–178
Unnecessary use of fully qualified name 'com.google.gwt.user.client.Element' due to existing import 'com.google.gwt.user.client.Element' 222

info/magnolia/ui/vaadin/gwt/client/grid/VMagnoliaTreeTable.java

Violation Line
Useless parentheses. 60

info/magnolia/ui/vaadin/gwt/client/jquerywrapper/JQueryCallback.java

Violation Line
Avoid modifiers which are implied by the context 40

info/magnolia/ui/vaadin/gwt/client/jquerywrapper/JQueryFunction.java

Violation Line
Unnecessary final modifier in final class 46–50

info/magnolia/ui/vaadin/gwt/client/layout/CssRule.java

Violation Line
Avoid unused private fields such as 'rules'. 48
Avoid unused private methods such as 'searchForRule(JavaScriptObject,String,boolean)'. 80–82

info/magnolia/ui/vaadin/gwt/client/layout/thumbnaillayout/widget/LazyThumbnailLayoutImageBundle.java

Violation Line
Avoid modifiers which are implied by the context 45
Avoid modifiers which are implied by the context 47

info/magnolia/ui/vaadin/gwt/client/layout/thumbnaillayout/widget/ThumbnailsSizeKeeper.java

Violation Line
Avoid unused private methods such as 'scaleDimension(int,double)'. 111

info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/MagnoliaShellViewImpl.java

Violation Line
These nested if statements could be combined 231–233

info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/ShellAppLauncher.java

Violation Line
Useless parentheses. 241

info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/VShellImageBundle.java

Violation Line
Avoid modifiers which are implied by the context 45
Avoid modifiers which are implied by the context 47
Avoid modifiers which are implied by the context 50

info/magnolia/ui/vaadin/gwt/client/magnoliashell/viewport/widget/AppsViewportWidget.java

Violation Line
Avoid unused local variables such as 'style'. 195
Useless parentheses. 402

info/magnolia/ui/vaadin/gwt/client/richtext/TextAreaStretcherConnector.java

Violation Line
These nested if statements could be combined 115–118

info/magnolia/ui/vaadin/gwt/client/richtext/VMagnoliaRichTextField.java

Violation Line
Overriding method merely calls super 161–163

info/magnolia/ui/vaadin/gwt/client/shared/icon/IconParameters.java

Violation Line
Avoid modifiers which are implied by the context 41

info/magnolia/ui/vaadin/gwt/client/tabsheet/tab/widget/MagnoliaTabWidget.java

Violation Line
Avoid unused constructor parameters such as 'connector'. 48

info/magnolia/ui/vaadin/gwt/client/tabsheet/widget/TabBarWidget.java

Violation Line
Useless parentheses. 143
Useless parentheses. 146

info/magnolia/ui/vaadin/layout/SmallAppLayout.java

Violation Line
Unnecessary use of fully qualified name 'com.vaadin.v7.data.util.converter.Converter.ConversionException' due to existing import 'com.vaadin.v7.data.util.converter.Converter' 130
Unnecessary use of fully qualified name 'com.vaadin.v7.data.util.converter.Converter.ConversionException' due to existing import 'com.vaadin.v7.data.util.converter.Converter' 135