PMD Results

The following document contains the results of PMD 5.1.2.

Files

info/magnolia/ui/workbench/ContentView.java

Violation Line
Avoid modifiers which are implied by the context 7485

info/magnolia/ui/workbench/WorkbenchPresenter.java

Violation Line
Useless parentheses. 144
Useless parentheses. 144

info/magnolia/ui/workbench/WorkbenchViewImpl.java

Violation Line
Avoid unused constructor parameters such as 'i18n'. 115
Avoid unused local variables such as 'deleteShortcut'. 129

info/magnolia/ui/workbench/column/definition/BooleanPropertyColumnDefinition.java

Violation Line
Avoid empty if statements 102104

info/magnolia/ui/workbench/column/definition/ColumnAvailabilityRule.java

Violation Line
Avoid modifiers which are implied by the context 44

info/magnolia/ui/workbench/search/SearchJcrContainer.java

Violation Line
Useless parentheses. 243
Useless parentheses. 244
Useless parentheses. 245
Useless parentheses. 245

info/magnolia/ui/workbench/thumbnail/ThumbnailContainer.java

Violation Line
Avoid modifiers which are implied by the context 244246

info/magnolia/ui/workbench/tree/HierarchicalJcrContainer.java

Violation Line
Useless parentheses. 179
Useless parentheses. 192
Avoid unused private methods such as 'getSession()'. 386

info/magnolia/ui/workbench/tree/TreeView.java

Violation Line
Avoid modifiers which are implied by the context 5861

info/magnolia/ui/workbench/tree/drop/DropConstraint.java

Violation Line
Avoid modifiers which are implied by the context 53
Avoid modifiers which are implied by the context 64
Avoid modifiers which are implied by the context 75
Avoid modifiers which are implied by the context 85
Avoid modifiers which are implied by the context 91

info/magnolia/ui/workbench/tree/drop/JcrDropConstraint.java

Violation Line
Useless parentheses. 80
Useless parentheses. 80
Useless parentheses. 163
Useless parentheses. 163
Useless parentheses. 198
Useless parentheses. 198

info/magnolia/ui/workbench/tree/drop/TreeViewDropHandler.java

Violation Line
These nested if statements could be combined 200203
Unnecessary use of fully qualified name 'NodeUtil.isSame' due to existing import 'info.magnolia.jcr.util.NodeUtil' 246
Unnecessary use of fully qualified name 'NodeUtil.moveProperty' due to existing import 'info.magnolia.jcr.util.NodeUtil' 295