PMD Results

The following document contains the results of PMD 5.1.2.

Files

info/magnolia/ui/form/field/AbstractCustomMultiField.java

Violation Line
Avoid unused constructor parameters such as 'i18nAuthoringSupport'. 95
Avoid unused constructor parameters such as 'i18nContentSupport'. 106
Unnecessary use of fully qualified name 'com.vaadin.v7.data.Property.ValueChangeEvent' due to existing import 'com.vaadin.v7.data.Property' 210
Useless parentheses. 231

info/magnolia/ui/form/field/CompositeField.java

Violation Line
Avoid unused constructor parameters such as 'i18nContentSupport'. 67

info/magnolia/ui/form/field/LinkField.java

Violation Line
Avoid unused constructor parameters such as 'linkFieldDefinition'. 78
Avoid unused constructor parameters such as 'componentProvider'. 78
Avoid unused constructor parameters such as 'linkFieldDefinition'. 83
Avoid unused constructor parameters such as 'uiContext'. 83
Avoid unused constructor parameters such as 'componentProvider'. 83
Avoid unused constructor parameters such as 'appController'. 83
Overriding method merely calls super 130132
Overriding method merely calls super 135137

info/magnolia/ui/form/field/MultiField.java

Violation Line
Avoid unused constructor parameters such as 'i18nContentSupport'. 101
Avoid unused private methods such as 'removeValueProperty(int)'. 272
Avoid unused private methods such as 'onDelete(Component,Property)'. 314
Avoid unused private methods such as 'onMove(Component,Property,boolean)'. 337
Useless parentheses. 354

info/magnolia/ui/form/field/PasswordFields.java

Violation Line
Avoid unused constructor parameters such as 'verificationMessage'. 102
Avoid unused constructor parameters such as 'verificationErrorMessage'. 102
Avoid unused constructor parameters such as 'verification'. 102
These nested if statements could be combined 138140
Overriding method merely calls super 173175
Overriding method merely calls super 187189
Overriding method merely calls super 192194

info/magnolia/ui/form/field/SwitchableField.java

Violation Line
Avoid unused constructor parameters such as 'i18nContentSupport'. 81

info/magnolia/ui/form/field/component/ContentPreviewComponent.java

Violation Line
Avoid modifiers which are implied by the context 53

info/magnolia/ui/form/field/converter/NonRoundingConverterFactory.java

Violation Line
Avoid unused private methods such as 'amendMaximumFractionDigits(NumberFormat)'. 81

info/magnolia/ui/form/field/factory/AbstractFieldFactory.java

Violation Line
These nested if statements could be combined 137140
Useless parentheses. 201
Useless parentheses. 201

info/magnolia/ui/form/field/factory/BasicUploadFieldFactory.java

Violation Line
Avoid unused constructor parameters such as 'admincentralEventBus'. 76

info/magnolia/ui/form/field/factory/CompositeFieldFactory.java

Violation Line
Avoid unused constructor parameters such as 'i18nContentSupport'. 87

info/magnolia/ui/form/field/factory/DateFieldFactory.java

Violation Line
Avoid empty catch blocks 154155

info/magnolia/ui/form/field/factory/LinkFieldFactory.java

Violation Line
Avoid unused private methods such as 'resolveCurrentAppName()'. 177

info/magnolia/ui/form/field/factory/MultiValueFieldFactory.java

Violation Line
Avoid unused constructor parameters such as 'i18nContentSupport'. 84

info/magnolia/ui/form/field/factory/SelectFieldFactory.java

Violation Line
These nested if statements could be combined 261263

info/magnolia/ui/form/field/factory/SwitchableFieldFactory.java

Violation Line
Avoid unused constructor parameters such as 'i18nContentSupport'. 106

info/magnolia/ui/form/field/transformer/TransformedProperty.java

Violation Line
Useless parentheses. 78

info/magnolia/ui/form/field/transformer/basic/BasicTransformer.java

Violation Line
Useless parentheses. 166
Avoid empty catch blocks 173175

info/magnolia/ui/form/field/transformer/basic/NotNullInitialStringValueTransformer.java

Violation Line
Useless parentheses. 61

info/magnolia/ui/form/field/transformer/composite/SwitchableTransformer.java

Violation Line
Overriding method merely calls super 9092

info/magnolia/ui/form/field/transformer/item/FileTransformer.java

Violation Line
These nested if statements could be combined 175177

info/magnolia/ui/form/field/transformer/multi/DelegatingMultiValueFieldTransformer.java

Violation Line
Avoid unused constructor parameters such as 'i18nContentSupport'. 94
Avoid unused private methods such as 'reorganizeIndex(int)'. 193

info/magnolia/ui/form/field/transformer/multi/DelegatingMultiValueSubnodeTransformer.java

Violation Line
Avoid unused private methods such as 'detectsChildNodeType(MultiValueFieldDefinition)'. 148

info/magnolia/ui/form/field/transformer/multi/MultiTransformer.java

Violation Line
Avoid modifiers which are implied by the context 52
Avoid modifiers which are implied by the context 59

info/magnolia/ui/form/field/upload/UploadField.java

Violation Line
Avoid modifiers which are implied by the context 45
Avoid modifiers which are implied by the context 51

info/magnolia/ui/form/field/upload/UploadProgressIndicator.java

Violation Line
Avoid modifiers which are implied by the context 46
Avoid modifiers which are implied by the context 51
Avoid modifiers which are implied by the context 56
Avoid modifiers which are implied by the context 61

info/magnolia/ui/form/field/upload/basic/BasicUploadField.java

Violation Line
Useless parentheses. 325

info/magnolia/ui/form/field/upload/basic/BasicUploadProgressIndicator.java

Violation Line
Useless parentheses. 153

info/magnolia/ui/form/validator/registry/FieldValidatorFactoryFactory.java

Violation Line
Unnecessary use of fully qualified name 'info.magnolia.ui.form.validator.factory.FieldValidatorFactory' due to existing import 'info.magnolia.ui.form.validator.factory.FieldValidatorFactory' 66