PMD Results
The following document contains the results of PMD 5.1.2.
Files
com/googlecode/mgwt/collection/shared/LightArray.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
33 |
| Avoid modifiers which are implied by the context |
41 |
| Avoid modifiers which are implied by the context |
48 |
| Avoid modifiers which are implied by the context |
62 |
| Avoid modifiers which are implied by the context |
69 |
com/googlecode/mgwt/collection/shared/LightArrayBoolean.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
30 |
| Avoid modifiers which are implied by the context |
38 |
| Avoid modifiers which are implied by the context |
46 |
| Avoid modifiers which are implied by the context |
53 |
| Avoid modifiers which are implied by the context |
60 |
| Avoid modifiers which are implied by the context |
67 |
com/googlecode/mgwt/collection/shared/LightArrayInt.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
30 |
| Avoid modifiers which are implied by the context |
38 |
| Avoid modifiers which are implied by the context |
46 |
| Avoid modifiers which are implied by the context |
53 |
| Avoid modifiers which are implied by the context |
60 |
| Avoid modifiers which are implied by the context |
67 |
com/googlecode/mgwt/collection/shared/LightMap.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
31 |
| Avoid modifiers which are implied by the context |
39 |
| Avoid modifiers which are implied by the context |
46 |
| Avoid modifiers which are implied by the context |
53 |
| Avoid modifiers which are implied by the context |
61 |
| Avoid modifiers which are implied by the context |
69 |
com/googlecode/mgwt/dom/client/event/EventTypes.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
4 |
| Avoid modifiers which are implied by the context |
6 |
com/googlecode/mgwt/dom/client/event/mouse/SimulatedTouchEndEvent.java
| Violation |
Line |
| Avoid unused private fields such as 'x'. |
34 |
| Avoid unused private fields such as 'y'. |
35 |
| Avoid unused private fields such as 'x_start'. |
36 |
| Avoid unused private fields such as 'y_start'. |
37 |
| Avoid unused private fields such as 'multiTouch'. |
38 |
com/googlecode/mgwt/dom/client/event/mouse/SimulatedTouchMoveEvent.java
| Violation |
Line |
| Avoid unused private fields such as 'x'. |
34 |
| Avoid unused private fields such as 'y'. |
35 |
| Avoid unused private fields such as 'x_start'. |
37 |
| Avoid unused private fields such as 'y_start'. |
38 |
| Avoid unused private fields such as 'multiTouch'. |
39 |
com/googlecode/mgwt/dom/client/event/tap/HasTapHandlers.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
34 |
com/googlecode/mgwt/dom/client/event/tap/TapEvent.java
| Violation |
Line |
| Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' |
56 |
com/googlecode/mgwt/dom/client/event/tap/TapHandler.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
27 |
com/googlecode/mgwt/dom/client/event/touch/HasTouchHandlers.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
39 |
| Avoid modifiers which are implied by the context |
51 |
| Avoid modifiers which are implied by the context |
63 |
| Avoid modifiers which are implied by the context |
75 |
| Avoid modifiers which are implied by the context |
87 |
com/googlecode/mgwt/dom/client/event/touch/JsTouch.java
| Violation |
Line |
| Unnecessary final modifier in final class |
34–36 |
| Unnecessary final modifier in final class |
43–45 |
com/googlecode/mgwt/dom/client/event/touch/Touch.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
31 |
| Avoid modifiers which are implied by the context |
38 |
| Avoid modifiers which are implied by the context |
40 |
com/googlecode/mgwt/dom/client/event/touch/TouchCancelHandler.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
32 |
com/googlecode/mgwt/dom/client/event/touch/TouchEndHandler.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
32 |
com/googlecode/mgwt/dom/client/event/touch/TouchMoveHandler.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
32 |
com/googlecode/mgwt/dom/client/event/touch/TouchStartHandler.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
32 |
com/googlecode/mgwt/dom/client/recognizer/EventPropagator.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
34 |
com/googlecode/mgwt/dom/client/recognizer/TimeProvider.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
26 |
com/googlecode/mgwt/dom/client/recognizer/TimerExecutor.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
26 |
| Avoid modifiers which are implied by the context |
28–30 |
| Avoid modifiers which are implied by the context |
29 |
com/googlecode/mgwt/dom/client/recognizer/longtap/HasLongTapHandlers.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
34 |
com/googlecode/mgwt/dom/client/recognizer/longtap/LongTapEvent.java
| Violation |
Line |
| Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' |
67 |
com/googlecode/mgwt/dom/client/recognizer/longtap/LongTapHandler.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
32 |
com/googlecode/mgwt/dom/client/recognizer/longtap/LongTapRecognizer.java
| Violation |
Line |
| These nested if statements could be combined |
202–205 |
com/googlecode/mgwt/dom/client/recognizer/pinch/HasPinchHandlers.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
33 |
com/googlecode/mgwt/dom/client/recognizer/pinch/OffsetProvider.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
32 |
| Avoid modifiers which are implied by the context |
39 |
com/googlecode/mgwt/dom/client/recognizer/pinch/PinchEvent.java
| Violation |
Line |
| Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' |
64 |
com/googlecode/mgwt/dom/client/recognizer/pinch/PinchHandler.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
33 |
com/googlecode/mgwt/dom/client/recognizer/swipe/HasSwipeHandlers.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
34 |
| Avoid modifiers which are implied by the context |
42 |
| Avoid modifiers which are implied by the context |
50 |
com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeEndEvent.java
| Violation |
Line |
| Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' |
54 |
com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeEndHandler.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
32 |
com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeMoveEvent.java
| Violation |
Line |
| Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' |
60 |
com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeMoveHandler.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
32 |
com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeStartEvent.java
| Violation |
Line |
| Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' |
58 |
com/googlecode/mgwt/dom/client/recognizer/tap/MultiTapEvent.java
| Violation |
Line |
| Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' |
85 |
com/googlecode/mgwt/dom/client/recognizer/tap/MultiTapHandler.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
32 |
com/googlecode/mgwt/dom/client/recognizer/tap/MultiTapRecognizer.java
| Violation |
Line |
| These nested if statements could be combined |
191–194 |
| These nested if statements could be combined |
265–269 |
com/googlecode/mgwt/ui/client/widget/touch/TouchWidgetImpl.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
40 |
| Avoid modifiers which are implied by the context |
49 |
| Avoid modifiers which are implied by the context |
58 |
| Avoid modifiers which are implied by the context |
67 |
com/vaadin/v7/client/ui/VScrollTablePatched.java
| Violation |
Line |
| Avoid unused imports such as 'com.google.gwt.event.dom.client.ContextMenuEvent' |
51 |
| Avoid unused imports such as 'com.google.gwt.event.dom.client.ContextMenuHandler' |
52 |
| Avoid unused imports such as 'com.google.gwt.user.client.ui.RootPanel' |
80 |
| Avoid modifiers which are implied by the context |
174 |
| Avoid unused private fields such as 'detachedScrollPosition'. |
451 |
| Avoid unused private fields such as 'initialContentReceived'. |
704 |
| Avoid unused private fields such as 'touchScrollDelegate'. |
745 |
| Avoid unused private methods such as 'sendColumnWidthUpdates(Collection)'. |
985 |
| Overriding method merely calls super |
2216–2219 |
| Useless parentheses. |
2378–2380 |
| Useless parentheses. |
2406–2407 |
| Avoid empty if statements |
2454–2456 |
| Avoid unused local variables such as 'hCell'. |
2462 |
| Useless parentheses. |
2507 |
| These nested if statements could be combined |
2523–2536 |
| These nested if statements could be combined |
2525–2535 |
| Useless parentheses. |
2587 |
| Useless parentheses. |
2643–2644 |
| Useless parentheses. |
2645–2646 |
| Useless parentheses. |
2698 |
| Useless parentheses. |
2748–2749 |
| Useless parentheses. |
2769–2771 |
| These nested if statements could be combined |
3319–3364 |
| These nested if statements could be combined |
3788–3791 |
| These nested if statements could be combined |
3970–3976 |
| These nested if statements could be combined |
4674–4677 |
| Useless parentheses. |
5223 |
| Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' |
5480 |
| Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' |
5964 |
| These nested if statements could be combined |
6163–6276 |
| Useless parentheses. |
6204–6205 |
| Useless parentheses. |
6302–6303 |
| Useless parentheses. |
6399–6400 |
| Avoid using a branching statement as the last in a loop. |
6776 |
| Avoid unused method parameters such as 'rowUidl'. |
6784 |
| Avoid unused method parameters such as 'rowUidl'. |
6791 |
| Useless parentheses. |
6896 |
| Useless parentheses. |
6896 |
| Useless parentheses. |
7130–7131 |
| Useless parentheses. |
7188 |
| These nested if statements could be combined |
7353–7362 |
| Useless parentheses. |
7466 |
| Useless parentheses. |
7492 |
| Useless parentheses. |
7517–7518 |
| Useless parentheses. |
7527–7529 |
| Useless parentheses. |
7552 |
| Useless parentheses. |
7553 |
| Avoid unused private methods such as 'getLogger()'. |
8458 |
com/vaadin/v7/client/ui/VTreeTablePatched.java
| Violation |
Line |
| Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' |
153 |
| Avoid using a branching statement as the last in a loop. |
357 |
| Useless parentheses. |
800–801 |
| Useless parentheses. |
802 |
com/vaadin/v7/client/ui/table/TableConnectorPatched.java
| Violation |
Line |
| Avoid unused local variables such as 'totalRowsHaveChanged'. |
184 |
| Useless parentheses. |
184 |
| These nested if statements could be combined |
325–343 |
com/vaadin/v7/client/ui/treetable/TreeTableConnectorPatched.java
| Violation |
Line |
| Avoid unused imports such as 'com.vaadin.shared.ui.Connect' |
24 |
| Avoid unused imports such as 'com.vaadin.v7.ui.TreeTable' |
32 |
| These nested if statements could be combined |
61–69 |
| Useless parentheses. |
84–85 |
info/magnolia/ui/vaadin/actionbar/Actionbar.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
216 |
| Avoid modifiers which are implied by the context |
217 |
| Avoid modifiers which are implied by the context |
219 |
info/magnolia/ui/vaadin/dialog/BaseDialog.java
| Violation |
Line |
| Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' |
239 |
| Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' |
273 |
| Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' |
306 |
info/magnolia/ui/vaadin/dialog/ConfirmationDialog.java
| Violation |
Line |
| Overriding method merely calls super |
128–130 |
info/magnolia/ui/vaadin/editor/CroppableImage.java
| Violation |
Line |
| Overriding method merely calls super |
62–64 |
| Avoid modifiers which are implied by the context |
151 |
| Avoid modifiers which are implied by the context |
152–153 |
| Avoid modifiers which are implied by the context |
161 |
| Avoid modifiers which are implied by the context |
162–163 |
info/magnolia/ui/vaadin/editor/JCrop.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'handler'. |
65 |
info/magnolia/ui/vaadin/editor/JCropField.java
| Violation |
Line |
| Useless parentheses. |
158 |
| Useless parentheses. |
158 |
info/magnolia/ui/vaadin/grid/MagnoliaTreeTable.java
| Violation |
Line |
| Avoid unused private fields such as 'log'. |
56 |
| Overriding method merely calls super |
74–76 |
| Overriding method merely calls super |
115–117 |
info/magnolia/ui/vaadin/gwt/client/actionbar/connector/ActionbarConnector.java
| Violation |
Line |
| Useless parentheses. |
74 |
info/magnolia/ui/vaadin/gwt/client/actionbar/widget/ActionbarWidgetViewImpl.java
| Violation |
Line |
| Useless parentheses. |
332 |
| Useless parentheses. |
335 |
info/magnolia/ui/vaadin/gwt/client/applauncher/connector/AppLauncherConnector.java
| Violation |
Line |
| Useless parentheses. |
123 |
| Overriding method merely calls super |
143–145 |
info/magnolia/ui/vaadin/gwt/client/applauncher/widget/AppLauncherView.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
52–57 |
info/magnolia/ui/vaadin/gwt/client/dialog/connector/DialogContainingFormConnector.java
| Violation |
Line |
| Useless parentheses. |
117 |
info/magnolia/ui/vaadin/gwt/client/dialog/widget/DialogHeaderWidget.java
| Violation |
Line |
| These nested if statements could be combined |
124–126 |
info/magnolia/ui/vaadin/gwt/client/extension/MaxLengthIndicatorConnector.java
| Violation |
Line |
| Avoid unused private methods such as 'setIndicatorVisible(boolean)'. |
140 |
info/magnolia/ui/vaadin/gwt/client/form/formsection/widget/FormSectionWidget.java
| Violation |
Line |
| Useless parentheses. |
78 |
info/magnolia/ui/vaadin/gwt/client/form/tab/connector/FormTabConnector.java
| Violation |
Line |
| Overriding method merely calls super |
48–50 |
info/magnolia/ui/vaadin/gwt/client/form/widget/FormViewImpl.java
| Violation |
Line |
| Useless parentheses. |
181 |
info/magnolia/ui/vaadin/gwt/client/grid/VMagnoliaTable.java
| Violation |
Line |
| Overriding method merely calls super |
176–178 |
| Unnecessary use of fully qualified name 'com.google.gwt.user.client.Element' due to existing import 'com.google.gwt.user.client.Element' |
222 |
info/magnolia/ui/vaadin/gwt/client/grid/VMagnoliaTreeTable.java
| Violation |
Line |
| Useless parentheses. |
60 |
info/magnolia/ui/vaadin/gwt/client/jquerywrapper/JQueryCallback.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
40 |
info/magnolia/ui/vaadin/gwt/client/jquerywrapper/JQueryFunction.java
| Violation |
Line |
| Unnecessary final modifier in final class |
46–50 |
info/magnolia/ui/vaadin/gwt/client/layout/CssRule.java
| Violation |
Line |
| Avoid unused private fields such as 'rules'. |
48 |
| Avoid unused private methods such as 'searchForRule(JavaScriptObject,String,boolean)'. |
80–82 |
info/magnolia/ui/vaadin/gwt/client/layout/thumbnaillayout/widget/LazyThumbnailLayoutImageBundle.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
45 |
| Avoid modifiers which are implied by the context |
47 |
info/magnolia/ui/vaadin/gwt/client/layout/thumbnaillayout/widget/ThumbnailsSizeKeeper.java
| Violation |
Line |
| Avoid unused private methods such as 'scaleDimension(int,double)'. |
111 |
info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/MagnoliaShellViewImpl.java
| Violation |
Line |
| These nested if statements could be combined |
231–233 |
info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/ShellAppLauncher.java
| Violation |
Line |
| Useless parentheses. |
241 |
info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/VShellImageBundle.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
45 |
| Avoid modifiers which are implied by the context |
47 |
| Avoid modifiers which are implied by the context |
50 |
info/magnolia/ui/vaadin/gwt/client/magnoliashell/viewport/widget/AppsViewportWidget.java
| Violation |
Line |
| Avoid unused local variables such as 'style'. |
195 |
| Useless parentheses. |
402 |
info/magnolia/ui/vaadin/gwt/client/richtext/TextAreaStretcherConnector.java
| Violation |
Line |
| These nested if statements could be combined |
115–118 |
info/magnolia/ui/vaadin/gwt/client/richtext/VMagnoliaRichTextField.java
| Violation |
Line |
| Overriding method merely calls super |
161–163 |
info/magnolia/ui/vaadin/gwt/client/shared/icon/IconParameters.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
41 |
info/magnolia/ui/vaadin/gwt/client/tabsheet/tab/widget/MagnoliaTabWidget.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'connector'. |
48 |
info/magnolia/ui/vaadin/gwt/client/tabsheet/widget/TabBarWidget.java
| Violation |
Line |
| Useless parentheses. |
143 |
| Useless parentheses. |
146 |
info/magnolia/ui/vaadin/layout/SmallAppLayout.java
| Violation |
Line |
| Unnecessary use of fully qualified name 'com.vaadin.v7.data.util.converter.Converter.ConversionException' due to existing import 'com.vaadin.v7.data.util.converter.Converter' |
130 |
| Unnecessary use of fully qualified name 'com.vaadin.v7.data.util.converter.Converter.ConversionException' due to existing import 'com.vaadin.v7.data.util.converter.Converter' |
135 |
