PMD Results
The following document contains the results of PMD 6.4.0.
Files
info/magnolia/ui/actionbar/ActionbarPresenter.java
| Violation |
Priority |
Line |
| Avoid unused private fields such as 'definition'. |
3 |
73 |
| Avoid unused local variables such as 'sectionName'. |
3 |
217 |
info/magnolia/ui/contentapp/ContentApp.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'componentProvider'. |
3 |
93 |
info/magnolia/ui/contentapp/browser/BrowserLocation.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
67 |
info/magnolia/ui/contentapp/browser/BrowserSubApp.java
| Violation |
Priority |
Line |
| Avoid empty if statements |
3 |
446–448 |
info/magnolia/ui/contentapp/browser/BrowserViewImpl.java
| Violation |
Priority |
Line |
| Avoid unused private fields such as 'actionBar'. |
3 |
53 |
| Avoid unused private fields such as 'listener'. |
3 |
63 |
info/magnolia/ui/contentapp/browser/JcrContentClipboard.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
132 |
info/magnolia/ui/contentapp/detail/DetailEditorViewImpl.java
| Violation |
Priority |
Line |
| Avoid unused private fields such as 'actionBar'. |
3 |
55 |
info/magnolia/ui/contentapp/detail/DetailLocation.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
87 |
info/magnolia/ui/contentapp/detail/DetailPresenter.java
| Violation |
Priority |
Line |
| Avoid unused private fields such as 'i18nizer'. |
3 |
102 |
| Avoid unused constructor parameters such as 'formBuilder'. |
3 |
127 |
| Avoid unused private methods such as 'getEditorDefinition()'. |
3 |
266 |
info/magnolia/ui/contentapp/detail/DetailSubApp.java
| Violation |
Priority |
Line |
| Avoid unused private fields such as 'log'. |
3 |
74 |
info/magnolia/ui/contentapp/detail/action/RestorePreviousVersionAction.java
| Violation |
Priority |
Line |
| Avoid unused private fields such as 'log'. |
3 |
63 |
info/magnolia/ui/contentapp/movedialog/action/OpenMoveDialogAction.java
| Violation |
Priority |
Line |
| Avoid unused private fields such as 'componentProvider'. |
3 |
61 |
| Avoid unused private fields such as 'sourceNodeAdapter'. |
3 |
63 |
info/magnolia/ui/contentapp/movedialog/predicate/MovePossibilityPredicate.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
81 |
| Useless parentheses. |
4 |
81 |
info/magnolia/ui/contentapp/setup/AbstractDataTypeMigrationTask.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
90 |
| Useless parentheses. |
4 |
91 |
| Useless parentheses. |
4 |
115 |
info/magnolia/ui/contentapp/setup/AppNodeVisitor.java
| Violation |
Priority |
Line |
| Avoid unused private fields such as 'OBSOLETE_APP_PROPERTY_NAME'. |
3 |
54 |
info/magnolia/ui/contentapp/setup/for5_3/MoveActionNodeTypeRestrictionToAvailabilityTask.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
101 |
info/magnolia/ui/dialog/BaseDialogViewImpl.java
| Violation |
Priority |
Line |
| Useless qualified this usage in the same class. |
3 |
143 |
| Overriding method merely calls super |
3 |
185–187 |
info/magnolia/ui/dialog/choosedialog/ChooseDialogPresenterImpl.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
3 |
100 |
| Useless qualified this usage in the same class. |
3 |
161 |
info/magnolia/ui/dialog/formdialog/FormBuilder.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
3 |
103 |
info/magnolia/ui/dialog/formdialog/FormDialogPresenterImpl.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'formBuilder'. |
3 |
107 |
| Avoid unused constructor parameters such as 'formBuilder'. |
3 |
115 |
info/magnolia/ui/dialog/registry/DialogDefinitionRegistry.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'fieldTypeDefinitionRegistry'. |
3 |
77 |
info/magnolia/ui/dialog/setup/migration/ActionCreator.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
49 |
info/magnolia/ui/dialog/setup/migration/ControlMigrator.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
53 |
info/magnolia/ui/form/definition/DefinitionConverter.java
| Violation |
Priority |
Line |
| Unnecessary use of fully qualified name 'info.magnolia.ui.framework.databinding.layout.ConfiguredTabDefinition' due to existing import 'info.magnolia.ui.framework.databinding.layout.ConfiguredTabDefinition' |
4 |
73 |
info/magnolia/ui/form/field/AbstractCustomMultiField.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'i18nAuthoringSupport'. |
3 |
95 |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
3 |
106 |
| Unnecessary use of fully qualified name 'com.vaadin.v7.data.Property.ValueChangeEvent' due to existing import 'com.vaadin.v7.data.Property' |
4 |
210 |
| Useless parentheses. |
4 |
231 |
info/magnolia/ui/form/field/CompositeField.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
3 |
67 |
info/magnolia/ui/form/field/LinkField.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'linkFieldDefinition'. |
3 |
81 |
| Avoid unused constructor parameters such as 'componentProvider'. |
3 |
81 |
| Avoid unused constructor parameters such as 'uiContext'. |
3 |
86 |
| Avoid unused constructor parameters such as 'appController'. |
3 |
86 |
| Avoid unused constructor parameters such as 'linkFieldDefinition'. |
3 |
86 |
| Avoid unused constructor parameters such as 'componentProvider'. |
3 |
86 |
| Overriding method merely calls super |
3 |
133–135 |
| Overriding method merely calls super |
3 |
138–140 |
info/magnolia/ui/form/field/MultiField.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
3 |
104 |
| Useless parentheses. |
4 |
342 |
| Useless qualified this usage in the same class. |
3 |
344 |
| Useless qualified this usage in the same class. |
3 |
345 |
info/magnolia/ui/form/field/PasswordFields.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'verificationErrorMessage'. |
3 |
102 |
| Avoid unused constructor parameters such as 'verification'. |
3 |
102 |
| Avoid unused constructor parameters such as 'verificationMessage'. |
3 |
102 |
| These nested if statements could be combined |
3 |
138–140 |
| Overriding method merely calls super |
3 |
173–175 |
| Overriding method merely calls super |
3 |
187–189 |
| Overriding method merely calls super |
3 |
192–194 |
info/magnolia/ui/form/field/SwitchableField.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
3 |
81 |
info/magnolia/ui/form/field/component/ContentPreviewComponent.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
53 |
info/magnolia/ui/form/field/factory/AbstractFieldFactory.java
| Violation |
Priority |
Line |
| These nested if statements could be combined |
3 |
137–140 |
| Useless parentheses. |
4 |
201 |
| Useless parentheses. |
4 |
201 |
info/magnolia/ui/form/field/factory/BasicUploadFieldFactory.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'admincentralEventBus'. |
3 |
78 |
info/magnolia/ui/form/field/factory/CompositeFieldFactory.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
3 |
87 |
info/magnolia/ui/form/field/factory/DateFieldFactory.java
| Violation |
Priority |
Line |
| Avoid empty catch blocks |
3 |
154–155 |
info/magnolia/ui/form/field/factory/MultiValueFieldFactory.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
3 |
84 |
info/magnolia/ui/form/field/factory/SelectFieldFactory.java
| Violation |
Priority |
Line |
| These nested if statements could be combined |
3 |
261–263 |
info/magnolia/ui/form/field/factory/SwitchableFieldFactory.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
3 |
106 |
info/magnolia/ui/form/field/transformer/TransformedProperty.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
78 |
info/magnolia/ui/form/field/transformer/basic/BasicTransformer.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
166 |
| Useless parentheses. |
4 |
166–168 |
| Avoid empty catch blocks |
3 |
173–175 |
info/magnolia/ui/form/field/transformer/basic/NotNullInitialStringValueTransformer.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
61 |
info/magnolia/ui/form/field/transformer/composite/SwitchableTransformer.java
| Violation |
Priority |
Line |
| Overriding method merely calls super |
3 |
90–92 |
info/magnolia/ui/form/field/transformer/item/FileTransformer.java
| Violation |
Priority |
Line |
| These nested if statements could be combined |
3 |
175–177 |
info/magnolia/ui/form/field/transformer/multi/DelegatingMultiValueFieldTransformer.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
3 |
94 |
info/magnolia/ui/form/field/transformer/multi/MultiTransformer.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
52 |
| Avoid modifiers which are implied by the context |
3 |
59 |
info/magnolia/ui/form/field/transformer/multi/MultiValueChildNodeTransformer.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
108 |
| Useless parentheses. |
4 |
109 |
info/magnolia/ui/form/field/upload/UploadField.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
45 |
| Avoid modifiers which are implied by the context |
3 |
51 |
info/magnolia/ui/form/field/upload/UploadProgressIndicator.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
46 |
| Avoid modifiers which are implied by the context |
3 |
51 |
| Avoid modifiers which are implied by the context |
3 |
56 |
| Avoid modifiers which are implied by the context |
3 |
61 |
info/magnolia/ui/form/field/upload/basic/BasicUploadField.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
325 |
info/magnolia/ui/form/field/upload/basic/BasicUploadProgressIndicator.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
153 |
info/magnolia/ui/form/field/upload/basic/ResurfaceBasicUploadField.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
282 |
info/magnolia/ui/form/field/upload/basic/ResurfaceBasicUploadProgressIndicator.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
167 |
info/magnolia/ui/form/fieldtype/registry/AbstractFieldTypeDefinitionValidator.java
| Violation |
Priority |
Line |
| Avoid unused imports such as 'info.magnolia.config.registry.DefinitionProvider.Problem.DefaultTypes' |
4 |
36 |
info/magnolia/ui/form/fieldtype/registry/FieldTypeDefinitionRegistry.java
| Violation |
Priority |
Line |
| Avoid unused private fields such as 'NULL_DEFINITION_PROVIDER'. |
3 |
67 |
info/magnolia/ui/form/validator/registry/FieldValidatorFactoryFactory.java
| Violation |
Priority |
Line |
| Unnecessary use of fully qualified name 'info.magnolia.ui.form.validator.factory.FieldValidatorFactory' due to existing import 'info.magnolia.ui.form.validator.factory.FieldValidatorFactory' |
4 |
66 |
info/magnolia/ui/framework/action/AbstractMultiItemAction.java
| Violation |
Priority |
Line |
| Avoid unused private fields such as 'log'. |
3 |
65 |
info/magnolia/ui/framework/action/DeleteItemAction.java
| Violation |
Priority |
Line |
| Avoid empty catch blocks |
3 |
137–139 |
info/magnolia/ui/framework/action/async/DefaultAsyncActionExecutor.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
114 |
| Unnecessary use of fully qualified name 'info.magnolia.module.scheduler.CommandJob' due to existing import 'info.magnolia.module.scheduler.CommandJob' |
4 |
128 |
| Useless parentheses. |
4 |
157 |
info/magnolia/ui/framework/action/service/CompatibilityActionExecutionService.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
125 |
| Unnecessary use of fully qualified name 'Collectors.toList' due to existing static import 'java.util.stream.Collectors.toList' |
4 |
150 |
| Unnecessary use of fully qualified name 'Collectors.toList' due to existing static import 'java.util.stream.Collectors.toList' |
4 |
216 |
| Unnecessary use of fully qualified name 'Collectors.toList' due to existing static import 'java.util.stream.Collectors.toList' |
4 |
225 |
info/magnolia/ui/framework/availability/AcceptsClipboardContent.java
| Violation |
Priority |
Line |
| Avoid unused private fields such as 'contentConnector'. |
3 |
47 |
info/magnolia/ui/framework/command/CleanTempFilesCommand.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'configurationProperties'. |
3 |
62 |
info/magnolia/ui/framework/command/ImportZipCommand.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
135 |
| Useless parentheses. |
4 |
136 |
| Useless parentheses. |
4 |
229 |
info/magnolia/ui/framework/setup/AddIsPublishedRuleToAllDeactivateActionsTask.java
| Violation |
Priority |
Line |
| These nested if statements could be combined |
3 |
67–84 |
info/magnolia/ui/framework/setup/UiFrameworkCompatibilityModuleVersionHandler.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
163 |
| Useless parentheses. |
4 |
164 |
| Useless parentheses. |
4 |
166 |
info/magnolia/ui/framework/tools/jcr/JcrNodeFormToolPresenter.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
69 |
info/magnolia/ui/imageprovider/definition/ImageProviderDefinition.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
47 |
| Avoid modifiers which are implied by the context |
3 |
48 |
| Avoid modifiers which are implied by the context |
3 |
49 |
info/magnolia/ui/mediaeditor/MediaEditorEventBus.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
41 |
info/magnolia/ui/mediaeditor/MediaEditorPresenterFactoryImpl.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'moduleRegistry'. |
3 |
91 |
info/magnolia/ui/mediaeditor/data/EditHistoryTrackingProperty.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
56 |
info/magnolia/ui/mediaeditor/event/MediaEditorInternalEvent.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
49–54 |
info/magnolia/ui/mediaeditor/field/image/ViewImageField.java
| Violation |
Priority |
Line |
| Overriding method merely calls super |
3 |
86–88 |
| Avoid modifiers which are implied by the context |
3 |
119 |
| Avoid modifiers which are implied by the context |
3 |
120–121 |
info/magnolia/ui/mediaeditor/setup/MediaEditorModuleVersionHandler.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
49 |
info/magnolia/ui/vaadin/integration/ItemAdapter.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
47 |
info/magnolia/ui/vaadin/integration/contentconnector/AbstractContentConnector.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'componentProvider'. |
3 |
53 |
info/magnolia/ui/vaadin/integration/contentconnector/JcrContentConnector.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'componentProvider'. |
3 |
80 |
info/magnolia/ui/vaadin/integration/jcr/JcrItemUtil.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
165 |
info/magnolia/ui/vaadin/integration/jcr/JcrPropertyAdapter.java
| Violation |
Priority |
Line |
| These nested if statements could be combined |
3 |
188–209 |
info/magnolia/ui/vaadin/integration/jcr/ModelConstants.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
45 |
info/magnolia/ui/workbench/ContentView.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
74–85 |
info/magnolia/ui/workbench/WorkbenchPresenter.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
144 |
| Useless parentheses. |
4 |
144 |
info/magnolia/ui/workbench/WorkbenchViewImpl.java
| Violation |
Priority |
Line |
| Avoid unused constructor parameters such as 'i18n'. |
3 |
127 |
| Avoid unused local variables such as 'deleteShortcut'. |
3 |
141 |
info/magnolia/ui/workbench/column/definition/BooleanPropertyColumnDefinition.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
73–83 |
| Avoid empty if statements |
3 |
102–104 |
info/magnolia/ui/workbench/column/definition/ColumnAvailabilityRule.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
44 |
info/magnolia/ui/workbench/search/SearchJcrContainer.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
243 |
| Useless parentheses. |
4 |
244 |
| Useless parentheses. |
4 |
245 |
| Useless parentheses. |
4 |
245 |
info/magnolia/ui/workbench/thumbnail/ThumbnailContainer.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
244–246 |
info/magnolia/ui/workbench/tree/HierarchicalJcrContainer.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
144 |
| Useless parentheses. |
4 |
179 |
| Useless parentheses. |
4 |
192 |
info/magnolia/ui/workbench/tree/TreeView.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
58–61 |
info/magnolia/ui/workbench/tree/drop/DropConstraint.java
| Violation |
Priority |
Line |
| Avoid modifiers which are implied by the context |
3 |
58 |
| Avoid modifiers which are implied by the context |
3 |
69 |
| Avoid modifiers which are implied by the context |
3 |
80 |
| Avoid modifiers which are implied by the context |
3 |
90 |
| Avoid modifiers which are implied by the context |
3 |
96 |
info/magnolia/ui/workbench/tree/drop/JcrDropConstraint.java
| Violation |
Priority |
Line |
| Useless parentheses. |
4 |
83 |
| Useless parentheses. |
4 |
83 |
| Useless parentheses. |
4 |
166 |
| Useless parentheses. |
4 |
166 |
| Useless parentheses. |
4 |
201 |
| Useless parentheses. |
4 |
201 |
info/magnolia/ui/workbench/tree/drop/TreeViewDropHandler.java
| Violation |
Priority |
Line |
| These nested if statements could be combined |
3 |
201–204 |
| Unnecessary use of fully qualified name 'NodeUtil.isSame' due to existing static import 'info.magnolia.jcr.util.NodeUtil.*' |
4 |
247 |
| Unnecessary use of fully qualified name 'NodeUtil.moveProperty' due to existing static import 'info.magnolia.jcr.util.NodeUtil.*' |
4 |
296 |
