PMD Results
The following document contains the results of PMD 5.1.2.
Files
info/magnolia/ui/actionbar/ActionbarPresenter.java
| Violation |
Line |
| Avoid unused private fields such as 'definition'. |
73 |
| Avoid unused local variables such as 'sectionName'. |
217 |
info/magnolia/ui/contentapp/ContentApp.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'componentProvider'. |
93 |
info/magnolia/ui/contentapp/browser/BrowserLocation.java
| Violation |
Line |
| Useless parentheses. |
67 |
info/magnolia/ui/contentapp/browser/BrowserSubApp.java
| Violation |
Line |
| Avoid empty if statements |
446–448 |
info/magnolia/ui/contentapp/browser/BrowserViewImpl.java
| Violation |
Line |
| Avoid unused private fields such as 'actionBar'. |
53 |
| Avoid unused private fields such as 'listener'. |
63 |
info/magnolia/ui/contentapp/browser/JcrContentClipboard.java
| Violation |
Line |
| Useless parentheses. |
132 |
info/magnolia/ui/contentapp/detail/DetailEditorViewImpl.java
| Violation |
Line |
| Avoid unused private fields such as 'actionBar'. |
55 |
info/magnolia/ui/contentapp/detail/DetailLocation.java
| Violation |
Line |
| Useless parentheses. |
87 |
info/magnolia/ui/contentapp/detail/DetailSubApp.java
| Violation |
Line |
| Avoid unused private fields such as 'log'. |
74 |
info/magnolia/ui/contentapp/detail/action/RestorePreviousVersionAction.java
| Violation |
Line |
| Avoid unused private fields such as 'log'. |
63 |
info/magnolia/ui/contentapp/movedialog/action/OpenMoveDialogAction.java
| Violation |
Line |
| Avoid unused private fields such as 'componentProvider'. |
61 |
| Avoid unused private fields such as 'sourceNodeAdapter'. |
63 |
info/magnolia/ui/contentapp/movedialog/predicate/MovePossibilityPredicate.java
| Violation |
Line |
| Useless parentheses. |
81 |
| Useless parentheses. |
81 |
info/magnolia/ui/contentapp/setup/AbstractDataTypeMigrationTask.java
| Violation |
Line |
| Useless parentheses. |
90 |
| Useless parentheses. |
91 |
| Useless parentheses. |
115 |
info/magnolia/ui/contentapp/setup/AppNodeVisitor.java
| Violation |
Line |
| Avoid unused private fields such as 'OBSOLETE_APP_PROPERTY_NAME'. |
54 |
info/magnolia/ui/contentapp/setup/for5_3/ChangeAvailabilityRuleClassesTask.java
| Violation |
Line |
| Avoid unused private methods such as 'getClassMapping()'. |
99 |
info/magnolia/ui/contentapp/setup/for5_3/MoveActionNodeTypeRestrictionToAvailabilityTask.java
| Violation |
Line |
| Useless parentheses. |
101 |
info/magnolia/ui/dialog/BaseDialogViewImpl.java
| Violation |
Line |
| Overriding method merely calls super |
185–187 |
info/magnolia/ui/dialog/choosedialog/ChooseDialogPresenterImpl.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
100 |
info/magnolia/ui/dialog/formdialog/FormBuilder.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
103 |
info/magnolia/ui/dialog/formdialog/FormDialogPresenterImpl.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'formBuilder'. |
107 |
info/magnolia/ui/dialog/formdialog/FormPresenterImpl.java
| Violation |
Line |
| Avoid unused private methods such as 'buildReducedForm(FormDefinition,FormViewReduced,Item,FormItem,Locale)'. |
200 |
| Avoid unused method parameters such as 'locale'. |
228 |
info/magnolia/ui/dialog/formdialog/ResurfaceFormViewImpl.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'context'. |
90 |
info/magnolia/ui/dialog/registry/DialogDefinitionRegistry.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'fieldTypeDefinitionRegistry'. |
79 |
info/magnolia/ui/dialog/setup/migration/ActionCreator.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
49 |
info/magnolia/ui/dialog/setup/migration/ControlMigrator.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
53 |
info/magnolia/ui/form/field/AbstractCustomMultiField.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'i18nAuthoringSupport'. |
95 |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
106 |
| Unnecessary use of fully qualified name 'com.vaadin.v7.data.Property.ValueChangeEvent' due to existing import 'com.vaadin.v7.data.Property' |
210 |
| Useless parentheses. |
231 |
info/magnolia/ui/form/field/CompositeField.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
67 |
info/magnolia/ui/form/field/LinkField.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'componentProvider'. |
81 |
| Avoid unused constructor parameters such as 'linkFieldDefinition'. |
81 |
| Avoid unused constructor parameters such as 'componentProvider'. |
86 |
| Avoid unused constructor parameters such as 'uiContext'. |
86 |
| Avoid unused constructor parameters such as 'appController'. |
86 |
| Avoid unused constructor parameters such as 'linkFieldDefinition'. |
86 |
| Overriding method merely calls super |
133–135 |
| Overriding method merely calls super |
138–140 |
info/magnolia/ui/form/field/MultiField.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
104 |
| Avoid unused private methods such as 'removeValueProperty(int)'. |
261 |
| Avoid unused private methods such as 'onDelete(Component,Property)'. |
303 |
| Avoid unused private methods such as 'onMove(Component,Property,boolean)'. |
326 |
| Useless parentheses. |
343 |
info/magnolia/ui/form/field/PasswordFields.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'verificationErrorMessage'. |
102 |
| Avoid unused constructor parameters such as 'verification'. |
102 |
| Avoid unused constructor parameters such as 'verificationMessage'. |
102 |
| These nested if statements could be combined |
138–140 |
| Overriding method merely calls super |
173–175 |
| Overriding method merely calls super |
187–189 |
| Overriding method merely calls super |
192–194 |
info/magnolia/ui/form/field/SwitchableField.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
81 |
info/magnolia/ui/form/field/component/ContentPreviewComponent.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
53 |
info/magnolia/ui/form/field/factory/AbstractFieldFactory.java
| Violation |
Line |
| These nested if statements could be combined |
137–140 |
| Useless parentheses. |
201 |
| Useless parentheses. |
201 |
info/magnolia/ui/form/field/factory/BasicUploadFieldFactory.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'admincentralEventBus'. |
78 |
info/magnolia/ui/form/field/factory/CompositeFieldFactory.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
87 |
info/magnolia/ui/form/field/factory/DateFieldFactory.java
| Violation |
Line |
| Avoid empty catch blocks |
154–155 |
info/magnolia/ui/form/field/factory/LinkFieldFactory.java
| Violation |
Line |
| Avoid unused private methods such as 'resolveCurrentAppName()'. |
181 |
info/magnolia/ui/form/field/factory/MultiValueFieldFactory.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
84 |
info/magnolia/ui/form/field/factory/SelectFieldFactory.java
| Violation |
Line |
| These nested if statements could be combined |
261–263 |
info/magnolia/ui/form/field/factory/SwitchableFieldFactory.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
106 |
info/magnolia/ui/form/field/transformer/TransformedProperty.java
| Violation |
Line |
| Useless parentheses. |
78 |
info/magnolia/ui/form/field/transformer/basic/BasicTransformer.java
| Violation |
Line |
| Useless parentheses. |
166 |
| Avoid empty catch blocks |
173–175 |
info/magnolia/ui/form/field/transformer/basic/NotNullInitialStringValueTransformer.java
| Violation |
Line |
| Useless parentheses. |
61 |
info/magnolia/ui/form/field/transformer/composite/SwitchableTransformer.java
| Violation |
Line |
| Overriding method merely calls super |
90–92 |
info/magnolia/ui/form/field/transformer/item/FileTransformer.java
| Violation |
Line |
| These nested if statements could be combined |
175–177 |
info/magnolia/ui/form/field/transformer/multi/DelegatingMultiValueFieldTransformer.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'i18nContentSupport'. |
94 |
| Avoid unused private methods such as 'reorganizeIndex(int)'. |
193 |
info/magnolia/ui/form/field/transformer/multi/DelegatingMultiValueSubnodeTransformer.java
| Violation |
Line |
| Avoid unused private methods such as 'detectsChildNodeType(MultiValueFieldDefinition)'. |
148 |
info/magnolia/ui/form/field/transformer/multi/MultiTransformer.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
52 |
| Avoid modifiers which are implied by the context |
59 |
info/magnolia/ui/form/field/upload/UploadField.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
45 |
| Avoid modifiers which are implied by the context |
51 |
info/magnolia/ui/form/field/upload/UploadProgressIndicator.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
46 |
| Avoid modifiers which are implied by the context |
51 |
| Avoid modifiers which are implied by the context |
56 |
| Avoid modifiers which are implied by the context |
61 |
info/magnolia/ui/form/field/upload/basic/BasicUploadField.java
| Violation |
Line |
| Useless parentheses. |
325 |
info/magnolia/ui/form/field/upload/basic/BasicUploadProgressIndicator.java
| Violation |
Line |
| Useless parentheses. |
153 |
info/magnolia/ui/form/field/upload/basic/ResurfaceBasicUploadField.java
| Violation |
Line |
| Useless parentheses. |
282 |
info/magnolia/ui/form/field/upload/basic/ResurfaceBasicUploadProgressIndicator.java
| Violation |
Line |
| Useless parentheses. |
167 |
info/magnolia/ui/form/fieldtype/registry/FieldTypeDefinitionRegistry.java
| Violation |
Line |
| Avoid unused private fields such as 'NULL_DEFINITION_PROVIDER'. |
68 |
info/magnolia/ui/form/validator/registry/FieldValidatorFactoryFactory.java
| Violation |
Line |
| Unnecessary use of fully qualified name 'info.magnolia.ui.form.validator.factory.FieldValidatorFactory' due to existing import 'info.magnolia.ui.form.validator.factory.FieldValidatorFactory' |
66 |
info/magnolia/ui/framework/action/AbstractMultiItemAction.java
| Violation |
Line |
| Avoid unused private fields such as 'log'. |
65 |
info/magnolia/ui/framework/action/DeleteItemAction.java
| Violation |
Line |
| Avoid empty catch blocks |
137–139 |
info/magnolia/ui/framework/action/async/DefaultAsyncActionExecutor.java
| Violation |
Line |
| Useless parentheses. |
114 |
| Unnecessary use of fully qualified name 'info.magnolia.module.scheduler.CommandJob' due to existing import 'info.magnolia.module.scheduler.CommandJob' |
128 |
| Useless parentheses. |
157 |
info/magnolia/ui/framework/action/service/CompatibilityActionExecutionService.java
| Violation |
Line |
| Useless parentheses. |
125 |
info/magnolia/ui/framework/app/contenttypes/AppWithContentType.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'resourceOrigin'. |
133 |
| Avoid unused constructor parameters such as 'problem'. |
134 |
info/magnolia/ui/framework/availability/AcceptsClipboardContent.java
| Violation |
Line |
| Avoid unused private fields such as 'contentConnector'. |
47 |
info/magnolia/ui/framework/availability/IsNotVersionedRule.java
| Violation |
Line |
| Useless parentheses. |
76 |
info/magnolia/ui/framework/availability/IsVersionRule.java
| Violation |
Line |
| Useless parentheses. |
61 |
info/magnolia/ui/framework/command/CleanTempFilesCommand.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'configurationProperties'. |
62 |
info/magnolia/ui/framework/command/ImportZipCommand.java
| Violation |
Line |
| Useless parentheses. |
229 |
info/magnolia/ui/framework/setup/AddIsPublishedRuleToAllDeactivateActionsTask.java
| Violation |
Line |
| These nested if statements could be combined |
67–84 |
info/magnolia/ui/framework/setup/UiFrameworkCompatibilityModuleVersionHandler.java
| Violation |
Line |
| Useless parentheses. |
163 |
| Useless parentheses. |
164 |
| Useless parentheses. |
166 |
info/magnolia/ui/imageprovider/definition/ImageProviderDefinition.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
47 |
| Avoid modifiers which are implied by the context |
48 |
| Avoid modifiers which are implied by the context |
49 |
info/magnolia/ui/mediaeditor/MediaEditorEventBus.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
41 |
info/magnolia/ui/mediaeditor/MediaEditorPresenterFactoryImpl.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'moduleRegistry'. |
88 |
info/magnolia/ui/mediaeditor/data/EditHistoryTrackingProperty.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
56 |
info/magnolia/ui/mediaeditor/data/EditHistoryTrackingPropertyImpl.java
| Violation |
Line |
| Avoid unused private methods such as 'logErrorAndNotify(String,Exception)'. |
178 |
info/magnolia/ui/mediaeditor/field/image/ViewImageField.java
| Violation |
Line |
| Overriding method merely calls super |
86–88 |
| Avoid modifiers which are implied by the context |
119 |
| Avoid modifiers which are implied by the context |
120–121 |
info/magnolia/ui/mediaeditor/setup/MediaEditorModuleVersionHandler.java
| Violation |
Line |
| Useless parentheses. |
49 |
info/magnolia/ui/vaadin/integration/ItemAdapter.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
47 |
info/magnolia/ui/vaadin/integration/contentconnector/AbstractContentConnector.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'componentProvider'. |
53 |
info/magnolia/ui/vaadin/integration/contentconnector/JcrContentConnector.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'componentProvider'. |
80 |
info/magnolia/ui/vaadin/integration/jcr/JcrItemUtil.java
| Violation |
Line |
| Useless parentheses. |
165 |
info/magnolia/ui/vaadin/integration/jcr/JcrNewNodeAdapter.java
| Violation |
Line |
| Avoid unused private methods such as 'getUniqueNewItemName(Item)'. |
179 |
info/magnolia/ui/vaadin/integration/jcr/JcrNodeAdapter.java
| Violation |
Line |
| Avoid unused private methods such as 'jcrItemHasProperty(String)'. |
156 |
info/magnolia/ui/vaadin/integration/jcr/JcrPropertyAdapter.java
| Violation |
Line |
| These nested if statements could be combined |
188–209 |
info/magnolia/ui/vaadin/integration/jcr/ModelConstants.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
45 |
info/magnolia/ui/workbench/ContentView.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
74–85 |
info/magnolia/ui/workbench/WorkbenchViewImpl.java
| Violation |
Line |
| Avoid unused constructor parameters such as 'i18n'. |
169 |
| Avoid unused local variables such as 'deleteShortcut'. |
183 |
info/magnolia/ui/workbench/column/definition/BooleanPropertyColumnDefinition.java
| Violation |
Line |
| Avoid empty if statements |
102–104 |
info/magnolia/ui/workbench/column/definition/ColumnAvailabilityRule.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
44 |
info/magnolia/ui/workbench/search/SearchJcrContainer.java
| Violation |
Line |
| Useless parentheses. |
243 |
| Useless parentheses. |
244 |
| Useless parentheses. |
245 |
| Useless parentheses. |
245 |
info/magnolia/ui/workbench/thumbnail/ThumbnailContainer.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
244–246 |
info/magnolia/ui/workbench/tree/HierarchicalJcrContainer.java
| Violation |
Line |
| Useless parentheses. |
179 |
| Useless parentheses. |
192 |
| Avoid unused private methods such as 'getSession()'. |
386 |
info/magnolia/ui/workbench/tree/TreeView.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
58–61 |
info/magnolia/ui/workbench/tree/drop/DropConstraint.java
| Violation |
Line |
| Avoid modifiers which are implied by the context |
58 |
| Avoid modifiers which are implied by the context |
69 |
| Avoid modifiers which are implied by the context |
80 |
| Avoid modifiers which are implied by the context |
90 |
| Avoid modifiers which are implied by the context |
96 |
info/magnolia/ui/workbench/tree/drop/JcrDropConstraint.java
| Violation |
Line |
| Useless parentheses. |
83 |
| Useless parentheses. |
83 |
| Useless parentheses. |
166 |
| Useless parentheses. |
166 |
| Useless parentheses. |
201 |
| Useless parentheses. |
201 |
info/magnolia/ui/workbench/tree/drop/TreeViewDropHandler.java
| Violation |
Line |
| These nested if statements could be combined |
201–204 |
| Unnecessary use of fully qualified name 'NodeUtil.isSame' due to existing import 'info.magnolia.jcr.util.NodeUtil' |
247 |
| Unnecessary use of fully qualified name 'NodeUtil.moveProperty' due to existing import 'info.magnolia.jcr.util.NodeUtil' |
296 |
