Magnolia UI Framework – PMD Results

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 3

info/magnolia/ui/dev/NoScssCacheVaadinServlet.java

Rule	Violation	Line
UnusedPrivateField	Avoid unused private fields such as 'log'.	58

info/magnolia/ui/field/SelectFieldBinder.java

Rule	Violation	Line
UnusedLocalVariable	Avoid unused local variables such as 'type'.	69

info/magnolia/ui/field/factory/TokenFieldWrapper.java

Rule	Violation	Line
UselessOverridingMethod	Overriding method merely calls super	129–131

info/magnolia/ui/framework/ViewContextProxy.java

Rule	Violation	Line
TooManyStaticImports	Too many static imports may lead to messy code	34–124

info/magnolia/ui/framework/app/DefaultLocationHistoryMapper.java

Rule	Violation	Line
UnusedFormalParameter	Avoid unused method parameters such as 'parameter'.	82
UnusedFormalParameter	Avoid unused method parameters such as 'subAppId'.	82

info/magnolia/ui/framework/app/embedded/EmbeddedPageSubApp.java

Rule	Violation	Line
UnusedPrivateField	Avoid unused private fields such as 'log'.	53

info/magnolia/ui/framework/app/embedded/EmbeddedPageViewImpl.java

Rule	Violation	Line
UnusedPrivateField	Avoid unused private fields such as 'log'.	53
UnusedFormalParameter	Avoid unused constructor parameters such as 'appContext'.	64

info/magnolia/ui/framework/databinding/SwitchableFormView.java

Rule	Violation	Line
UnusedPrivateField	Avoid unused private fields such as 'formFieldFactory'.	80

info/magnolia/ui/framework/ioc/DeflateUiContextDependentBindings.java

Rule	Violation	Line
UnusedPrivateField	Avoid unused private fields such as 'log'.	111

info/magnolia/ui/framework/layout/DeclarativeLayoutProducer.java

Rule	Violation	Line
UnnecessaryModifier	Unnecessary modifier 'final' on resource specification 'templateReader': resource specifications are implicitly final	88

info/magnolia/ui/framework/message/LocalMessageDispatcher.java

Rule	Violation	Line
UnusedFormalParameter	Avoid unused constructor parameters such as 'vaadinSession'.	65

info/magnolia/ui/framework/message/MessagesManager.java

Rule	Violation	Line
UnnecessaryModifier	Unnecessary modifier 'public' on interface 'MessageListener': members of interface types are implicitly public	50–57

info/magnolia/ui/framework/task/LocalTaskDispatcher.java

Rule	Violation	Line
UnusedFormalParameter	Avoid unused constructor parameters such as 'vaadinSession'.	78
EmptyCatchBlock	Avoid empty catch blocks	105–106

info/magnolia/util/Util.java

Rule	Violation	Line
CollapsibleIfStatements	These nested if statements could be combined	54–56

Priority 4

info/magnolia/ui/LightBoxBuilder.java

Rule	Violation	Line
UnusedImports	Avoid unused imports such as 'com.vaadin.server.Sizeable'	36

info/magnolia/ui/contentapp/action/CommitActionDefinition.java

Rule	Violation	Line
UnusedImports	Avoid unused imports such as 'info.magnolia.ui.api.action.ConfiguredActionDefinition'	36

info/magnolia/ui/contentapp/browser/Workbench.java

Rule	Violation	Line
UnusedImports	Avoid unused imports such as 'com.vaadin.ui.Label'	48

info/magnolia/ui/contentapp/detail/ContentDetailSubApp.java

Rule	Violation	Line
UnusedImports	Avoid unused imports such as 'com.vaadin.ui.CssLayout'	64
UselessParentheses	Useless parentheses.	218

info/magnolia/ui/datasource/WithDatasource.java

Rule	Violation	Line
UselessParentheses	Useless parentheses.	55

info/magnolia/ui/dialog/EditorActionLayout.java

Rule	Violation	Line
UnusedImports	Avoid unused imports such as 'com.vaadin.ui.Label'	42

info/magnolia/ui/framework/app/AppControllerImpl.java

Rule	Violation	Line
UselessParentheses	Useless parentheses.	487–490

info/magnolia/ui/framework/app/AppInstanceControllerImpl.java

Rule	Violation	Line
UselessParentheses	Useless parentheses.	197
UselessParentheses	Useless parentheses.	197
UselessParentheses	Useless parentheses.	493

info/magnolia/ui/framework/app/embedded/EmbeddedPageSubApp.java

Rule	Violation	Line
UselessParentheses	Useless parentheses.	66

info/magnolia/ui/framework/chooser/SingleItemWorkbenchChooser.java

Rule	Violation	Line
UnusedImports	Avoid unused imports such as 'info.magnolia.ui.framework.datasource.definition.DatasourceDefinition'	37

info/magnolia/ui/framework/ioc/ViewContextParameterResolver.java

Rule	Violation	Line
UselessParentheses	Useless parentheses.	119

info/magnolia/ui/framework/layout/DeclarativeLayoutProducer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'Design.ComponentMapper' due to existing static import 'com.vaadin.ui.declarative.Design.*'	87
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'Design.read' due to existing static import 'com.vaadin.ui.declarative.Design.*'	93
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'Design.ComponentMapper' due to existing static import 'com.vaadin.ui.declarative.Design.*'	108
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'Design.ComponentMapper' due to existing static import 'com.vaadin.ui.declarative.Design.*'	110
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'Design.ComponentMapper' due to existing static import 'com.vaadin.ui.declarative.Design.*'	113
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'Design.ComponentFactory' due to existing static import 'com.vaadin.ui.declarative.Design.*'	128

info/magnolia/util/Util.java

Rule	Violation	Line
UselessParentheses	Useless parentheses.	70

Files

info/magnolia/ui/LightBoxBuilder.java

Rule	Violation	Priority	Line
UnusedImports	Avoid unused imports such as 'com.vaadin.server.Sizeable'	4	36

info/magnolia/ui/contentapp/action/CommitActionDefinition.java

Rule	Violation	Priority	Line
UnusedImports	Avoid unused imports such as 'info.magnolia.ui.api.action.ConfiguredActionDefinition'	4	36

info/magnolia/ui/contentapp/browser/Workbench.java

Rule	Violation	Priority	Line
UnusedImports	Avoid unused imports such as 'com.vaadin.ui.Label'	4	48

info/magnolia/ui/contentapp/detail/ContentDetailSubApp.java

Rule	Violation	Priority	Line
UnusedImports	Avoid unused imports such as 'com.vaadin.ui.CssLayout'	4	64
UselessParentheses	Useless parentheses.	4	218

info/magnolia/ui/datasource/WithDatasource.java

Rule	Violation	Priority	Line
UselessParentheses	Useless parentheses.	4	55

info/magnolia/ui/dev/NoScssCacheVaadinServlet.java

Rule	Violation	Priority	Line
UnusedPrivateField	Avoid unused private fields such as 'log'.	3	58

info/magnolia/ui/dialog/EditorActionLayout.java

Rule	Violation	Priority	Line
UnusedImports	Avoid unused imports such as 'com.vaadin.ui.Label'	4	42

info/magnolia/ui/field/SelectFieldBinder.java

Rule	Violation	Priority	Line
UnusedLocalVariable	Avoid unused local variables such as 'type'.	3	69

info/magnolia/ui/field/factory/TokenFieldWrapper.java

Rule	Violation	Priority	Line
UselessOverridingMethod	Overriding method merely calls super	3	129–131

info/magnolia/ui/framework/ViewContextProxy.java

Rule	Violation	Priority	Line
TooManyStaticImports	Too many static imports may lead to messy code	3	34–124

info/magnolia/ui/framework/app/AppControllerImpl.java

Rule	Violation	Priority	Line
UselessParentheses	Useless parentheses.	4	487–490

info/magnolia/ui/framework/app/AppInstanceControllerImpl.java

Rule	Violation	Priority	Line
UselessParentheses	Useless parentheses.	4	197
UselessParentheses	Useless parentheses.	4	197
UselessParentheses	Useless parentheses.	4	493

info/magnolia/ui/framework/app/DefaultLocationHistoryMapper.java

Rule	Violation	Priority	Line
UnusedFormalParameter	Avoid unused method parameters such as 'parameter'.	3	82
UnusedFormalParameter	Avoid unused method parameters such as 'subAppId'.	3	82

info/magnolia/ui/framework/app/embedded/EmbeddedPageSubApp.java

Rule	Violation	Priority	Line
UnusedPrivateField	Avoid unused private fields such as 'log'.	3	53
UselessParentheses	Useless parentheses.	4	66

info/magnolia/ui/framework/app/embedded/EmbeddedPageViewImpl.java

Rule	Violation	Priority	Line
UnusedPrivateField	Avoid unused private fields such as 'log'.	3	53
UnusedFormalParameter	Avoid unused constructor parameters such as 'appContext'.	3	64

info/magnolia/ui/framework/chooser/SingleItemWorkbenchChooser.java

Rule	Violation	Priority	Line
UnusedImports	Avoid unused imports such as 'info.magnolia.ui.framework.datasource.definition.DatasourceDefinition'	4	37

info/magnolia/ui/framework/databinding/SwitchableFormView.java

Rule	Violation	Priority	Line
UnusedPrivateField	Avoid unused private fields such as 'formFieldFactory'.	3	80

info/magnolia/ui/framework/ioc/DeflateUiContextDependentBindings.java

Rule	Violation	Priority	Line
UnusedPrivateField	Avoid unused private fields such as 'log'.	3	111

info/magnolia/ui/framework/ioc/ViewContextParameterResolver.java

Rule	Violation	Priority	Line
UselessParentheses	Useless parentheses.	4	119

info/magnolia/ui/framework/layout/DeclarativeLayoutProducer.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'Design.ComponentMapper' due to existing static import 'com.vaadin.ui.declarative.Design.*'	4	87
UnnecessaryModifier	Unnecessary modifier 'final' on resource specification 'templateReader': resource specifications are implicitly final	3	88
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'Design.read' due to existing static import 'com.vaadin.ui.declarative.Design.*'	4	93
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'Design.ComponentMapper' due to existing static import 'com.vaadin.ui.declarative.Design.*'	4	108
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'Design.ComponentMapper' due to existing static import 'com.vaadin.ui.declarative.Design.*'	4	110
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'Design.ComponentMapper' due to existing static import 'com.vaadin.ui.declarative.Design.*'	4	113
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'Design.ComponentFactory' due to existing static import 'com.vaadin.ui.declarative.Design.*'	4	128

info/magnolia/ui/framework/message/LocalMessageDispatcher.java

Rule	Violation	Priority	Line
UnusedFormalParameter	Avoid unused constructor parameters such as 'vaadinSession'.	3	65

info/magnolia/ui/framework/message/MessagesManager.java

Rule	Violation	Priority	Line
UnnecessaryModifier	Unnecessary modifier 'public' on interface 'MessageListener': members of interface types are implicitly public	3	50–57

info/magnolia/ui/framework/task/LocalTaskDispatcher.java

Rule	Violation	Priority	Line
UnusedFormalParameter	Avoid unused constructor parameters such as 'vaadinSession'.	3	78
EmptyCatchBlock	Avoid empty catch blocks	3	105–106

info/magnolia/util/Util.java

Rule	Violation	Priority	Line
CollapsibleIfStatements	These nested if statements could be combined	3	54–56
UselessParentheses	Useless parentheses.	4	70