PMD Results

The following document contains the results of PMD 6.21.0.

Violations By Priority

Priority 3

info/magnolia/ui/actionbar/ActionbarPresenter.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'definition'. 73
UnusedLocalVariable Avoid unused local variables such as 'sectionName'. 217

info/magnolia/ui/contentapp/ContentApp.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'componentProvider'. 93

info/magnolia/ui/contentapp/browser/BrowserSubApp.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 452–454

info/magnolia/ui/contentapp/browser/BrowserViewImpl.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'actionBar'. 58
UnusedPrivateField Avoid unused private fields such as 'listener'. 68

info/magnolia/ui/contentapp/detail/DetailEditorViewImpl.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'actionBar'. 55

info/magnolia/ui/contentapp/detail/DetailPresenter.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'i18nizer'. 102
UnusedFormalParameter Avoid unused constructor parameters such as 'formBuilder'. 127
UnusedPrivateMethod Avoid unused private methods such as 'getEditorDefinition()'. 266

info/magnolia/ui/contentapp/detail/DetailSubApp.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'log'. 79

info/magnolia/ui/contentapp/detail/action/RestorePreviousVersionAction.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'log'. 63

info/magnolia/ui/contentapp/movedialog/action/OpenMoveDialogAction.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'componentProvider'. 66
UnusedPrivateField Avoid unused private fields such as 'sourceNodeAdapter'. 68

info/magnolia/ui/contentapp/setup/AppNodeVisitor.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'OBSOLETE_APP_PROPERTY_NAME'. 54

info/magnolia/ui/dialog/BaseDialogViewImpl.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 143
UselessOverridingMethod Overriding method merely calls super 185–187

info/magnolia/ui/dialog/choosedialog/ChooseDialogPresenterImpl.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 100
UselessQualifiedThis Useless qualified this usage in the same class. 161

info/magnolia/ui/dialog/formdialog/FormBuilder.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 103

info/magnolia/ui/dialog/formdialog/FormDialogPresenterImpl.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'formBuilder'. 107

info/magnolia/ui/dialog/formdialog/FormPresenterImpl.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 228

info/magnolia/ui/dialog/registry/DialogDefinitionRegistry.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fieldTypeDefinitionRegistry'. 77

info/magnolia/ui/dialog/setup/migration/ActionCreator.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'create': the method is declared in an interface type 49

info/magnolia/ui/dialog/setup/migration/ControlMigrator.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'migrate': the method is declared in an interface type 53

info/magnolia/ui/form/field/AbstractCustomMultiField.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nAuthoringSupport'. 95
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 106

info/magnolia/ui/form/field/CompositeField.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 72

info/magnolia/ui/form/field/LinkField.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'componentProvider'. 81
UnusedFormalParameter Avoid unused constructor parameters such as 'linkFieldDefinition'. 81
UnusedFormalParameter Avoid unused constructor parameters such as 'appController'. 86
UnusedFormalParameter Avoid unused constructor parameters such as 'componentProvider'. 86
UnusedFormalParameter Avoid unused constructor parameters such as 'uiContext'. 86
UnusedFormalParameter Avoid unused constructor parameters such as 'linkFieldDefinition'. 86
UselessOverridingMethod Overriding method merely calls super 133–135
UselessOverridingMethod Overriding method merely calls super 138–140

info/magnolia/ui/form/field/MultiField.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 109
UselessQualifiedThis Useless qualified this usage in the same class. 350
UselessQualifiedThis Useless qualified this usage in the same class. 351

info/magnolia/ui/form/field/PasswordFields.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'verificationMessage'. 99
UnusedFormalParameter Avoid unused constructor parameters such as 'verification'. 99
UnusedFormalParameter Avoid unused constructor parameters such as 'verificationErrorMessage'. 99
CollapsibleIfStatements These nested if statements could be combined 137–139

info/magnolia/ui/form/field/SwitchableField.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 86

info/magnolia/ui/form/field/component/ContentPreviewComponent.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onValueChange': the method is declared in an interface type 53

info/magnolia/ui/form/field/definition/migration/AbstractConfiguredFieldDefinitionConverter.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 128–130

info/magnolia/ui/form/field/definition/migration/HiddenFieldDefinitionConverter.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 46–48

info/magnolia/ui/form/field/factory/AbstractFieldFactory.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 142–145

info/magnolia/ui/form/field/factory/BasicUploadFieldFactory.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'admincentralEventBus'. 83

info/magnolia/ui/form/field/factory/CompositeFieldFactory.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 92

info/magnolia/ui/form/field/factory/DateFieldFactory.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 159–160

info/magnolia/ui/form/field/factory/MultiValueFieldFactory.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 89

info/magnolia/ui/form/field/factory/SelectFieldFactory.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 266–268

info/magnolia/ui/form/field/factory/SwitchableFieldFactory.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 110

info/magnolia/ui/form/field/transformer/basic/BasicTransformer.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 173–175

info/magnolia/ui/form/field/transformer/composite/SwitchableTransformer.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 90–92

info/magnolia/ui/form/field/transformer/item/FileTransformer.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 175–177

info/magnolia/ui/form/field/transformer/multi/DelegatingMultiValueFieldTransformer.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 94

info/magnolia/ui/form/field/transformer/multi/MultiTransformer.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'createProperty': the method is declared in an interface type 52
UnnecessaryModifier Unnecessary modifier 'public' on method 'removeProperty': the method is declared in an interface type 59

info/magnolia/ui/form/field/upload/UploadField.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setAllowedMimeTypePattern': the method is declared in an interface type 45
UnnecessaryModifier Unnecessary modifier 'public' on method 'setMaxUploadSize': the method is declared in an interface type 51

info/magnolia/ui/form/field/upload/UploadProgressIndicator.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'refreshLayout': the method is declared in an interface type 46
UnnecessaryModifier Unnecessary modifier 'public' on method 'setProgress': the method is declared in an interface type 51
UnnecessaryModifier Unnecessary modifier 'public' on method 'setVisible': the method is declared in an interface type 56
UnnecessaryModifier Unnecessary modifier 'public' on method 'asVaadinComponent': the method is declared in an interface type 61

info/magnolia/ui/form/fieldtype/registry/FieldTypeDefinitionRegistry.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'NULL_DEFINITION_PROVIDER'. 68

info/magnolia/ui/framework/action/AbstractMultiItemAction.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'log'. 71

info/magnolia/ui/framework/action/DeleteConfirmationAction.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'log'. 69

info/magnolia/ui/framework/action/DeleteItemAction.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 140–142

info/magnolia/ui/framework/app/contenttypes/AppWithContentType.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'resourceOrigin'. 138

info/magnolia/ui/framework/availability/AcceptsClipboardContent.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'contentConnector'. 52

info/magnolia/ui/framework/command/CleanTempFilesCommand.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'configurationProperties'. 67

info/magnolia/ui/framework/setup/AddIsPublishedRuleToAllDeactivateActionsTask.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 67–84

info/magnolia/ui/imageprovider/definition/ImageProviderDefinition.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'ORIGINAL_IMAGE_NODE_NAME': the field is declared in an interface type 47
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'IMAGING_SERVLET_PATH': the field is declared in an interface type 48
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'IMAGE_EXTENSION': the field is declared in an interface type 49

info/magnolia/ui/vaadin/integration/ItemAdapter.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'isNew': the method is declared in an interface type 47

info/magnolia/ui/vaadin/integration/contentconnector/AbstractContentConnector.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'componentProvider'. 53

info/magnolia/ui/vaadin/integration/contentconnector/JcrContentConnector.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'componentProvider'. 80

info/magnolia/ui/vaadin/integration/jcr/JcrPropertyAdapter.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 188–209

info/magnolia/ui/vaadin/integration/jcr/ModelConstants.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'JCR_NAME': the field is declared in an interface type 45

info/magnolia/ui/workbench/ContentView.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Listener': members of interface types are implicitly public 74–85

info/magnolia/ui/workbench/WorkbenchViewImpl.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18n'. 169
UnusedLocalVariable Avoid unused local variables such as 'deleteShortcut'. 183

info/magnolia/ui/workbench/column/definition/BooleanPropertyColumnDefinition.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'DisplayMode': nested enums are implicitly static 73–83
EmptyIfStmt Avoid empty if statements 102–104

info/magnolia/ui/workbench/column/definition/ColumnAvailabilityRule.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'isAvailable': the method is declared in an interface type 44

info/magnolia/ui/workbench/thumbnail/ThumbnailContainer.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'IdProvider': member interfaces are implicitly static 245–247

info/magnolia/ui/workbench/tree/TreeView.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Listener': members of interface types are implicitly public 58–61

info/magnolia/ui/workbench/tree/drop/DropConstraint.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'isAllowedAt': the method is declared in an interface type 58
UnnecessaryModifier Unnecessary modifier 'public' on method 'allowedAsChild': the method is declared in an interface type 69
UnnecessaryModifier Unnecessary modifier 'public' on method 'allowedBefore': the method is declared in an interface type 80
UnnecessaryModifier Unnecessary modifier 'public' on method 'allowedAfter': the method is declared in an interface type 90
UnnecessaryModifier Unnecessary modifier 'public' on method 'allowedToMove': the method is declared in an interface type 96

info/magnolia/ui/workbench/tree/drop/TreeViewDropHandler.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 201–204

Priority 4

info/magnolia/ui/contentapp/browser/BrowserLocation.java

Rule Violation Line
UselessParentheses Useless parentheses. 72

info/magnolia/ui/contentapp/browser/JcrContentClipboard.java

Rule Violation Line
UselessParentheses Useless parentheses. 137

info/magnolia/ui/contentapp/detail/DetailLocation.java

Rule Violation Line
UselessParentheses Useless parentheses. 92

info/magnolia/ui/contentapp/movedialog/predicate/MovePossibilityPredicate.java

Rule Violation Line
UselessParentheses Useless parentheses. 81
UselessParentheses Useless parentheses. 81

info/magnolia/ui/contentapp/setup/AbstractDataTypeMigrationTask.java

Rule Violation Line
UselessParentheses Useless parentheses. 90
UselessParentheses Useless parentheses. 91
UselessParentheses Useless parentheses. 115

info/magnolia/ui/contentapp/setup/for5_3/MoveActionNodeTypeRestrictionToAvailabilityTask.java

Rule Violation Line
UselessParentheses Useless parentheses. 101

info/magnolia/ui/form/field/AbstractCustomMultiField.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.vaadin.v7.data.Property.ValueChangeEvent' due to existing import 'com.vaadin.v7.data.Property' 210
UselessParentheses Useless parentheses. 231

info/magnolia/ui/form/field/MultiField.java

Rule Violation Line
UselessParentheses Useless parentheses. 348

info/magnolia/ui/form/field/definition/migration/AbstractSelectFieldDefinitionConverter.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.ui.form.field.definition.SelectFieldDefinition' due to existing import 'info.magnolia.ui.form.field.definition.SelectFieldDefinition' 71

info/magnolia/ui/form/field/definition/migration/MultiValueFieldDefinitionConverter.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.ui.form.field.definition.MultiValueFieldDefinition' due to existing import 'info.magnolia.ui.form.field.definition.MultiValueFieldDefinition' 107

info/magnolia/ui/form/field/definition/migration/OptionGroupFieldDefinitionConverter.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.ui.form.field.definition.OptionGroupFieldDefinition' due to existing import 'info.magnolia.ui.form.field.definition.OptionGroupFieldDefinition' 49

info/magnolia/ui/form/field/definition/migration/SwitchableFieldDefinitionConverter.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.ui.form.field.definition.SwitchableFieldDefinition' due to existing import 'info.magnolia.ui.form.field.definition.SwitchableFieldDefinition' 87

info/magnolia/ui/form/field/factory/AbstractFieldFactory.java

Rule Violation Line
UselessParentheses Useless parentheses. 206
UselessParentheses Useless parentheses. 206

info/magnolia/ui/form/field/transformer/TransformedProperty.java

Rule Violation Line
UselessParentheses Useless parentheses. 78

info/magnolia/ui/form/field/transformer/basic/BasicTransformer.java

Rule Violation Line
UselessParentheses Useless parentheses. 166
UselessParentheses Useless parentheses. 166–168

info/magnolia/ui/form/field/transformer/basic/NotNullInitialStringValueTransformer.java

Rule Violation Line
UselessParentheses Useless parentheses. 61

info/magnolia/ui/form/field/transformer/multi/MultiValueChildNodeTransformer.java

Rule Violation Line
UselessParentheses Useless parentheses. 108
UselessParentheses Useless parentheses. 109

info/magnolia/ui/form/field/upload/basic/BasicUploadField.java

Rule Violation Line
UselessParentheses Useless parentheses. 329

info/magnolia/ui/form/field/upload/basic/BasicUploadProgressIndicator.java

Rule Violation Line
UselessParentheses Useless parentheses. 153

info/magnolia/ui/form/field/upload/basic/ResurfaceBasicUploadField.java

Rule Violation Line
UselessParentheses Useless parentheses. 282

info/magnolia/ui/form/field/upload/basic/ResurfaceBasicUploadProgressIndicator.java

Rule Violation Line
UselessParentheses Useless parentheses. 167

info/magnolia/ui/form/fieldtype/registry/AbstractFieldTypeDefinitionValidator.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'info.magnolia.config.registry.DefinitionProvider.Problem.DefaultTypes' 36

info/magnolia/ui/form/validator/registry/FieldValidatorFactoryFactory.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.ui.form.validator.factory.FieldValidatorFactory' due to existing import 'info.magnolia.ui.form.validator.factory.FieldValidatorFactory' 66

info/magnolia/ui/framework/CompatibilityJcrSearchSuppliersGenerator.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.ui.contentapp.definition.ContentSubAppDescriptor' due to existing import 'info.magnolia.ui.contentapp.definition.ContentSubAppDescriptor' 73

info/magnolia/ui/framework/action/async/DefaultAsyncActionExecutor.java

Rule Violation Line
UselessParentheses Useless parentheses. 114
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.module.scheduler.CommandJob' due to existing import 'info.magnolia.module.scheduler.CommandJob' 128
UselessParentheses Useless parentheses. 157

info/magnolia/ui/framework/action/service/CompatibilityActionExecutionService.java

Rule Violation Line
UselessParentheses Useless parentheses. 123

info/magnolia/ui/framework/command/ImportZipCommand.java

Rule Violation Line
UselessParentheses Useless parentheses. 140
UselessParentheses Useless parentheses. 141
UselessParentheses Useless parentheses. 234

info/magnolia/ui/framework/setup/UiFrameworkCompatibilityModuleVersionHandler.java

Rule Violation Line
UselessParentheses Useless parentheses. 163
UselessParentheses Useless parentheses. 164
UselessParentheses Useless parentheses. 166

info/magnolia/ui/framework/tools/jcr/JcrNodeFormToolPresenter.java

Rule Violation Line
UselessParentheses Useless parentheses. 74

info/magnolia/ui/vaadin/integration/jcr/JcrItemUtil.java

Rule Violation Line
UselessParentheses Useless parentheses. 165

info/magnolia/ui/workbench/search/SearchJcrContainer.java

Rule Violation Line
UselessParentheses Useless parentheses. 243
UselessParentheses Useless parentheses. 244
UselessParentheses Useless parentheses. 245
UselessParentheses Useless parentheses. 245

info/magnolia/ui/workbench/tree/HierarchicalJcrContainer.java

Rule Violation Line
UselessParentheses Useless parentheses. 144
UselessParentheses Useless parentheses. 179
UselessParentheses Useless parentheses. 192

info/magnolia/ui/workbench/tree/drop/JcrDropConstraint.java

Rule Violation Line
UselessParentheses Useless parentheses. 83
UselessParentheses Useless parentheses. 83
UselessParentheses Useless parentheses. 166
UselessParentheses Useless parentheses. 166
UselessParentheses Useless parentheses. 201
UselessParentheses Useless parentheses. 201

info/magnolia/ui/workbench/tree/drop/TreeViewDropHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'NodeUtil.isSame' due to existing static import 'info.magnolia.jcr.util.NodeUtil.*' 247
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'NodeUtil.moveProperty' due to existing static import 'info.magnolia.jcr.util.NodeUtil.*' 296

Files

info/magnolia/ui/actionbar/ActionbarPresenter.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'definition'. 3 73
UnusedLocalVariable Avoid unused local variables such as 'sectionName'. 3 217

info/magnolia/ui/contentapp/ContentApp.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'componentProvider'. 3 93

info/magnolia/ui/contentapp/browser/BrowserLocation.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 72

info/magnolia/ui/contentapp/browser/BrowserSubApp.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 452–454

info/magnolia/ui/contentapp/browser/BrowserViewImpl.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'actionBar'. 3 58
UnusedPrivateField Avoid unused private fields such as 'listener'. 3 68

info/magnolia/ui/contentapp/browser/JcrContentClipboard.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 137

info/magnolia/ui/contentapp/detail/DetailEditorViewImpl.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'actionBar'. 3 55

info/magnolia/ui/contentapp/detail/DetailLocation.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 92

info/magnolia/ui/contentapp/detail/DetailPresenter.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'i18nizer'. 3 102
UnusedFormalParameter Avoid unused constructor parameters such as 'formBuilder'. 3 127
UnusedPrivateMethod Avoid unused private methods such as 'getEditorDefinition()'. 3 266

info/magnolia/ui/contentapp/detail/DetailSubApp.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'log'. 3 79

info/magnolia/ui/contentapp/detail/action/RestorePreviousVersionAction.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'log'. 3 63

info/magnolia/ui/contentapp/movedialog/action/OpenMoveDialogAction.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'componentProvider'. 3 66
UnusedPrivateField Avoid unused private fields such as 'sourceNodeAdapter'. 3 68

info/magnolia/ui/contentapp/movedialog/predicate/MovePossibilityPredicate.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 81
UselessParentheses Useless parentheses. 4 81

info/magnolia/ui/contentapp/setup/AbstractDataTypeMigrationTask.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 90
UselessParentheses Useless parentheses. 4 91
UselessParentheses Useless parentheses. 4 115

info/magnolia/ui/contentapp/setup/AppNodeVisitor.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'OBSOLETE_APP_PROPERTY_NAME'. 3 54

info/magnolia/ui/contentapp/setup/for5_3/MoveActionNodeTypeRestrictionToAvailabilityTask.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 101

info/magnolia/ui/dialog/BaseDialogViewImpl.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 143
UselessOverridingMethod Overriding method merely calls super 3 185–187

info/magnolia/ui/dialog/choosedialog/ChooseDialogPresenterImpl.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 3 100
UselessQualifiedThis Useless qualified this usage in the same class. 3 161

info/magnolia/ui/dialog/formdialog/FormBuilder.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 3 103

info/magnolia/ui/dialog/formdialog/FormDialogPresenterImpl.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'formBuilder'. 3 107

info/magnolia/ui/dialog/formdialog/FormPresenterImpl.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'locale'. 3 228

info/magnolia/ui/dialog/registry/DialogDefinitionRegistry.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'fieldTypeDefinitionRegistry'. 3 77

info/magnolia/ui/dialog/setup/migration/ActionCreator.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'create': the method is declared in an interface type 3 49

info/magnolia/ui/dialog/setup/migration/ControlMigrator.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'migrate': the method is declared in an interface type 3 53

info/magnolia/ui/form/field/AbstractCustomMultiField.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nAuthoringSupport'. 3 95
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 3 106
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.vaadin.v7.data.Property.ValueChangeEvent' due to existing import 'com.vaadin.v7.data.Property' 4 210
UselessParentheses Useless parentheses. 4 231

info/magnolia/ui/form/field/CompositeField.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 3 72

info/magnolia/ui/form/field/LinkField.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'componentProvider'. 3 81
UnusedFormalParameter Avoid unused constructor parameters such as 'linkFieldDefinition'. 3 81
UnusedFormalParameter Avoid unused constructor parameters such as 'appController'. 3 86
UnusedFormalParameter Avoid unused constructor parameters such as 'componentProvider'. 3 86
UnusedFormalParameter Avoid unused constructor parameters such as 'uiContext'. 3 86
UnusedFormalParameter Avoid unused constructor parameters such as 'linkFieldDefinition'. 3 86
UselessOverridingMethod Overriding method merely calls super 3 133–135
UselessOverridingMethod Overriding method merely calls super 3 138–140

info/magnolia/ui/form/field/MultiField.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 3 109
UselessParentheses Useless parentheses. 4 348
UselessQualifiedThis Useless qualified this usage in the same class. 3 350
UselessQualifiedThis Useless qualified this usage in the same class. 3 351

info/magnolia/ui/form/field/PasswordFields.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'verificationMessage'. 3 99
UnusedFormalParameter Avoid unused constructor parameters such as 'verification'. 3 99
UnusedFormalParameter Avoid unused constructor parameters such as 'verificationErrorMessage'. 3 99
CollapsibleIfStatements These nested if statements could be combined 3 137–139

info/magnolia/ui/form/field/SwitchableField.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 3 86

info/magnolia/ui/form/field/component/ContentPreviewComponent.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onValueChange': the method is declared in an interface type 3 53

info/magnolia/ui/form/field/definition/migration/AbstractConfiguredFieldDefinitionConverter.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 128–130

info/magnolia/ui/form/field/definition/migration/AbstractSelectFieldDefinitionConverter.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.ui.form.field.definition.SelectFieldDefinition' due to existing import 'info.magnolia.ui.form.field.definition.SelectFieldDefinition' 4 71

info/magnolia/ui/form/field/definition/migration/HiddenFieldDefinitionConverter.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 46–48

info/magnolia/ui/form/field/definition/migration/MultiValueFieldDefinitionConverter.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.ui.form.field.definition.MultiValueFieldDefinition' due to existing import 'info.magnolia.ui.form.field.definition.MultiValueFieldDefinition' 4 107

info/magnolia/ui/form/field/definition/migration/OptionGroupFieldDefinitionConverter.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.ui.form.field.definition.OptionGroupFieldDefinition' due to existing import 'info.magnolia.ui.form.field.definition.OptionGroupFieldDefinition' 4 49

info/magnolia/ui/form/field/definition/migration/SwitchableFieldDefinitionConverter.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.ui.form.field.definition.SwitchableFieldDefinition' due to existing import 'info.magnolia.ui.form.field.definition.SwitchableFieldDefinition' 4 87

info/magnolia/ui/form/field/factory/AbstractFieldFactory.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 142–145
UselessParentheses Useless parentheses. 4 206
UselessParentheses Useless parentheses. 4 206

info/magnolia/ui/form/field/factory/BasicUploadFieldFactory.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'admincentralEventBus'. 3 83

info/magnolia/ui/form/field/factory/CompositeFieldFactory.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 3 92

info/magnolia/ui/form/field/factory/DateFieldFactory.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 159–160

info/magnolia/ui/form/field/factory/MultiValueFieldFactory.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 3 89

info/magnolia/ui/form/field/factory/SelectFieldFactory.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 266–268

info/magnolia/ui/form/field/factory/SwitchableFieldFactory.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 3 110

info/magnolia/ui/form/field/transformer/TransformedProperty.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 78

info/magnolia/ui/form/field/transformer/basic/BasicTransformer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 166
UselessParentheses Useless parentheses. 4 166–168
EmptyCatchBlock Avoid empty catch blocks 3 173–175

info/magnolia/ui/form/field/transformer/basic/NotNullInitialStringValueTransformer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 61

info/magnolia/ui/form/field/transformer/composite/SwitchableTransformer.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 90–92

info/magnolia/ui/form/field/transformer/item/FileTransformer.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 175–177

info/magnolia/ui/form/field/transformer/multi/DelegatingMultiValueFieldTransformer.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18nContentSupport'. 3 94

info/magnolia/ui/form/field/transformer/multi/MultiTransformer.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'createProperty': the method is declared in an interface type 3 52
UnnecessaryModifier Unnecessary modifier 'public' on method 'removeProperty': the method is declared in an interface type 3 59

info/magnolia/ui/form/field/transformer/multi/MultiValueChildNodeTransformer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 108
UselessParentheses Useless parentheses. 4 109

info/magnolia/ui/form/field/upload/UploadField.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setAllowedMimeTypePattern': the method is declared in an interface type 3 45
UnnecessaryModifier Unnecessary modifier 'public' on method 'setMaxUploadSize': the method is declared in an interface type 3 51

info/magnolia/ui/form/field/upload/UploadProgressIndicator.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'refreshLayout': the method is declared in an interface type 3 46
UnnecessaryModifier Unnecessary modifier 'public' on method 'setProgress': the method is declared in an interface type 3 51
UnnecessaryModifier Unnecessary modifier 'public' on method 'setVisible': the method is declared in an interface type 3 56
UnnecessaryModifier Unnecessary modifier 'public' on method 'asVaadinComponent': the method is declared in an interface type 3 61

info/magnolia/ui/form/field/upload/basic/BasicUploadField.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 329

info/magnolia/ui/form/field/upload/basic/BasicUploadProgressIndicator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 153

info/magnolia/ui/form/field/upload/basic/ResurfaceBasicUploadField.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 282

info/magnolia/ui/form/field/upload/basic/ResurfaceBasicUploadProgressIndicator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 167

info/magnolia/ui/form/fieldtype/registry/AbstractFieldTypeDefinitionValidator.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'info.magnolia.config.registry.DefinitionProvider.Problem.DefaultTypes' 4 36

info/magnolia/ui/form/fieldtype/registry/FieldTypeDefinitionRegistry.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'NULL_DEFINITION_PROVIDER'. 3 68

info/magnolia/ui/form/validator/registry/FieldValidatorFactoryFactory.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.ui.form.validator.factory.FieldValidatorFactory' due to existing import 'info.magnolia.ui.form.validator.factory.FieldValidatorFactory' 4 66

info/magnolia/ui/framework/CompatibilityJcrSearchSuppliersGenerator.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.ui.contentapp.definition.ContentSubAppDescriptor' due to existing import 'info.magnolia.ui.contentapp.definition.ContentSubAppDescriptor' 4 73

info/magnolia/ui/framework/action/AbstractMultiItemAction.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'log'. 3 71

info/magnolia/ui/framework/action/DeleteConfirmationAction.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'log'. 3 69

info/magnolia/ui/framework/action/DeleteItemAction.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 140–142

info/magnolia/ui/framework/action/async/DefaultAsyncActionExecutor.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 114
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.module.scheduler.CommandJob' due to existing import 'info.magnolia.module.scheduler.CommandJob' 4 128
UselessParentheses Useless parentheses. 4 157

info/magnolia/ui/framework/action/service/CompatibilityActionExecutionService.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 123

info/magnolia/ui/framework/app/contenttypes/AppWithContentType.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'resourceOrigin'. 3 138

info/magnolia/ui/framework/availability/AcceptsClipboardContent.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'contentConnector'. 3 52

info/magnolia/ui/framework/command/CleanTempFilesCommand.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'configurationProperties'. 3 67

info/magnolia/ui/framework/command/ImportZipCommand.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 140
UselessParentheses Useless parentheses. 4 141
UselessParentheses Useless parentheses. 4 234

info/magnolia/ui/framework/setup/AddIsPublishedRuleToAllDeactivateActionsTask.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 67–84

info/magnolia/ui/framework/setup/UiFrameworkCompatibilityModuleVersionHandler.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 163
UselessParentheses Useless parentheses. 4 164
UselessParentheses Useless parentheses. 4 166

info/magnolia/ui/framework/tools/jcr/JcrNodeFormToolPresenter.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 74

info/magnolia/ui/imageprovider/definition/ImageProviderDefinition.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'ORIGINAL_IMAGE_NODE_NAME': the field is declared in an interface type 3 47
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'IMAGING_SERVLET_PATH': the field is declared in an interface type 3 48
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'IMAGE_EXTENSION': the field is declared in an interface type 3 49

info/magnolia/ui/vaadin/integration/ItemAdapter.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'isNew': the method is declared in an interface type 3 47

info/magnolia/ui/vaadin/integration/contentconnector/AbstractContentConnector.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'componentProvider'. 3 53

info/magnolia/ui/vaadin/integration/contentconnector/JcrContentConnector.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'componentProvider'. 3 80

info/magnolia/ui/vaadin/integration/jcr/JcrItemUtil.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 165

info/magnolia/ui/vaadin/integration/jcr/JcrPropertyAdapter.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 188–209

info/magnolia/ui/vaadin/integration/jcr/ModelConstants.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'JCR_NAME': the field is declared in an interface type 3 45

info/magnolia/ui/workbench/ContentView.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Listener': members of interface types are implicitly public 3 74–85

info/magnolia/ui/workbench/WorkbenchViewImpl.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'i18n'. 3 169
UnusedLocalVariable Avoid unused local variables such as 'deleteShortcut'. 3 183

info/magnolia/ui/workbench/column/definition/BooleanPropertyColumnDefinition.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'DisplayMode': nested enums are implicitly static 3 73–83
EmptyIfStmt Avoid empty if statements 3 102–104

info/magnolia/ui/workbench/column/definition/ColumnAvailabilityRule.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public abstract' on method 'isAvailable': the method is declared in an interface type 3 44

info/magnolia/ui/workbench/search/SearchJcrContainer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 243
UselessParentheses Useless parentheses. 4 244
UselessParentheses Useless parentheses. 4 245
UselessParentheses Useless parentheses. 4 245

info/magnolia/ui/workbench/thumbnail/ThumbnailContainer.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on interface 'IdProvider': member interfaces are implicitly static 3 245–247

info/magnolia/ui/workbench/tree/HierarchicalJcrContainer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 144
UselessParentheses Useless parentheses. 4 179
UselessParentheses Useless parentheses. 4 192

info/magnolia/ui/workbench/tree/TreeView.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Listener': members of interface types are implicitly public 3 58–61

info/magnolia/ui/workbench/tree/drop/DropConstraint.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'isAllowedAt': the method is declared in an interface type 3 58
UnnecessaryModifier Unnecessary modifier 'public' on method 'allowedAsChild': the method is declared in an interface type 3 69
UnnecessaryModifier Unnecessary modifier 'public' on method 'allowedBefore': the method is declared in an interface type 3 80
UnnecessaryModifier Unnecessary modifier 'public' on method 'allowedAfter': the method is declared in an interface type 3 90
UnnecessaryModifier Unnecessary modifier 'public' on method 'allowedToMove': the method is declared in an interface type 3 96

info/magnolia/ui/workbench/tree/drop/JcrDropConstraint.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 83
UselessParentheses Useless parentheses. 4 83
UselessParentheses Useless parentheses. 4 166
UselessParentheses Useless parentheses. 4 166
UselessParentheses Useless parentheses. 4 201
UselessParentheses Useless parentheses. 4 201

info/magnolia/ui/workbench/tree/drop/TreeViewDropHandler.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 201–204
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'NodeUtil.isSame' due to existing static import 'info.magnolia.jcr.util.NodeUtil.*' 4 247
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'NodeUtil.moveProperty' due to existing static import 'info.magnolia.jcr.util.NodeUtil.*' 4 296