PMD Results

The following document contains the results of PMD 6.21.0.

Violations By Priority

Priority 3

info/magnolia/ui/contentapp/browser/MagnoliaGridDecoration.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'grid'. 15
UnusedPrivateField Avoid unused private fields such as 'itemInteractionAvailability'. 16
UnusedPrivateField Avoid unused private fields such as 'datasource'. 17

info/magnolia/ui/contenttype/AppWithContentType.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'resourceOrigin'. 135

info/magnolia/ui/dev/NoScssCacheVaadinServlet.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'log'. 58

info/magnolia/ui/field/factory/LinkFieldFactory.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'itemResolver'. 78

info/magnolia/ui/field/factory/RichTextFieldFactory.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'appDescriptorRegistry'. 85

info/magnolia/ui/field/factory/TokenFieldWrapper.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 147–149

info/magnolia/ui/framework/UiComponentContextProxy.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 34–142

info/magnolia/ui/framework/app/DefaultLocationHistoryMapper.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'parameter'. 82
UnusedFormalParameter Avoid unused method parameters such as 'subAppId'. 82

info/magnolia/ui/framework/app/embedded/EmbeddedPageSubApp.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'log'. 53

info/magnolia/ui/framework/app/embedded/EmbeddedPageViewImpl.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'log'. 53
UnusedFormalParameter Avoid unused constructor parameters such as 'appContext'. 64

info/magnolia/ui/framework/ioc/DeflateUiContextDependentBindings.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'log'. 111

info/magnolia/ui/framework/ioc/UiContextBoundComponentProvider.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'currentUiContextReference'. 67

info/magnolia/ui/framework/layout/DeclarativeLayoutProducer.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'templateReader': resource specifications are implicitly final 90

info/magnolia/ui/framework/message/LocalMessageDispatcher.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'vaadinSession'. 65

info/magnolia/ui/framework/message/MessagesManager.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'MessageListener': members of interface types are implicitly public 50–57

info/magnolia/ui/framework/task/LocalTaskDispatcher.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'context'. 65
UnusedFormalParameter Avoid unused constructor parameters such as 'componentProvider'. 65
EmptyCatchBlock Avoid empty catch blocks 79–80

info/magnolia/util/Util.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 54–56

Priority 4

info/magnolia/ui/contentapp/action/CommitAction.java

Rule Violation Line
UselessParentheses Useless parentheses. 93

info/magnolia/ui/contentapp/browser/GridWithShortcuts.java

Rule Violation Line
UselessParentheses Useless parentheses. 369
UselessParentheses Useless parentheses. 370

info/magnolia/ui/contentapp/detail/ContentDetailSubApp.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Collectors.toList' due to existing static import 'java.util.stream.Collectors.*' 158
UselessParentheses Useless parentheses. 220

info/magnolia/ui/datasource/WithDatasource.java

Rule Violation Line
UselessParentheses Useless parentheses. 54

info/magnolia/ui/editor/FormPresenter.java

Rule Violation Line
UselessParentheses Useless parentheses. 279

info/magnolia/ui/editor/SwitchableFormView.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'com.vaadin.ui.Layout' 60

info/magnolia/ui/field/ConfiguredComplexPropertyDefinition.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'java.util.Optional' 44

info/magnolia/ui/field/MultiFieldDefinition.java

Rule Violation Line
UselessParentheses Useless parentheses. 71

info/magnolia/ui/framework/app/AppControllerImpl.java

Rule Violation Line
UselessParentheses Useless parentheses. 492–495

info/magnolia/ui/framework/app/AppInstanceControllerImpl.java

Rule Violation Line
UselessParentheses Useless parentheses. 214
UselessParentheses Useless parentheses. 214
UselessParentheses Useless parentheses. 511

info/magnolia/ui/framework/app/embedded/EmbeddedPageSubApp.java

Rule Violation Line
UselessParentheses Useless parentheses. 66

info/magnolia/ui/framework/ioc/UiComponentContextParameterResolver.java

Rule Violation Line
UselessParentheses Useless parentheses. 119

info/magnolia/ui/framework/layout/DeclarativeLayoutProducer.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Design.ComponentMapper' due to existing static import 'com.vaadin.ui.declarative.Design.*' 89
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Design.read' due to existing static import 'com.vaadin.ui.declarative.Design.*' 95
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Design.ComponentMapper' due to existing static import 'com.vaadin.ui.declarative.Design.*' 110
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Design.ComponentMapper' due to existing static import 'com.vaadin.ui.declarative.Design.*' 112
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Design.ComponentMapper' due to existing static import 'com.vaadin.ui.declarative.Design.*' 115
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Design.ComponentFactory' due to existing static import 'com.vaadin.ui.declarative.Design.*' 130

info/magnolia/ui/framework/layout/SingleFieldLayoutProducer.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.ui.framework.layout.SingleFieldLayoutProducer' due to existing same package import 'info.magnolia.ui.framework.layout.*' 58
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.ui.framework.layout.SingleFieldLayoutProducer' due to existing same package import 'info.magnolia.ui.framework.layout.*' 61

info/magnolia/util/Util.java

Rule Violation Line
UselessParentheses Useless parentheses. 70

Files

info/magnolia/ui/contentapp/action/CommitAction.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 93

info/magnolia/ui/contentapp/browser/GridWithShortcuts.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 369
UselessParentheses Useless parentheses. 4 370

info/magnolia/ui/contentapp/browser/MagnoliaGridDecoration.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'grid'. 3 15
UnusedPrivateField Avoid unused private fields such as 'itemInteractionAvailability'. 3 16
UnusedPrivateField Avoid unused private fields such as 'datasource'. 3 17

info/magnolia/ui/contentapp/detail/ContentDetailSubApp.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Collectors.toList' due to existing static import 'java.util.stream.Collectors.*' 4 158
UselessParentheses Useless parentheses. 4 220

info/magnolia/ui/contenttype/AppWithContentType.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'resourceOrigin'. 3 135

info/magnolia/ui/datasource/WithDatasource.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 54

info/magnolia/ui/dev/NoScssCacheVaadinServlet.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'log'. 3 58

info/magnolia/ui/editor/FormPresenter.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 279

info/magnolia/ui/editor/SwitchableFormView.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'com.vaadin.ui.Layout' 4 60

info/magnolia/ui/field/ConfiguredComplexPropertyDefinition.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'java.util.Optional' 4 44

info/magnolia/ui/field/MultiFieldDefinition.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 71

info/magnolia/ui/field/factory/LinkFieldFactory.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'itemResolver'. 3 78

info/magnolia/ui/field/factory/RichTextFieldFactory.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'appDescriptorRegistry'. 3 85

info/magnolia/ui/field/factory/TokenFieldWrapper.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 147–149

info/magnolia/ui/framework/UiComponentContextProxy.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 34–142

info/magnolia/ui/framework/app/AppControllerImpl.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 492–495

info/magnolia/ui/framework/app/AppInstanceControllerImpl.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 214
UselessParentheses Useless parentheses. 4 214
UselessParentheses Useless parentheses. 4 511

info/magnolia/ui/framework/app/DefaultLocationHistoryMapper.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'parameter'. 3 82
UnusedFormalParameter Avoid unused method parameters such as 'subAppId'. 3 82

info/magnolia/ui/framework/app/embedded/EmbeddedPageSubApp.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'log'. 3 53
UselessParentheses Useless parentheses. 4 66

info/magnolia/ui/framework/app/embedded/EmbeddedPageViewImpl.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'log'. 3 53
UnusedFormalParameter Avoid unused constructor parameters such as 'appContext'. 3 64

info/magnolia/ui/framework/ioc/DeflateUiContextDependentBindings.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'log'. 3 111

info/magnolia/ui/framework/ioc/UiComponentContextParameterResolver.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 119

info/magnolia/ui/framework/ioc/UiContextBoundComponentProvider.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'currentUiContextReference'. 3 67

info/magnolia/ui/framework/layout/DeclarativeLayoutProducer.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Design.ComponentMapper' due to existing static import 'com.vaadin.ui.declarative.Design.*' 4 89
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'templateReader': resource specifications are implicitly final 3 90
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Design.read' due to existing static import 'com.vaadin.ui.declarative.Design.*' 4 95
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Design.ComponentMapper' due to existing static import 'com.vaadin.ui.declarative.Design.*' 4 110
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Design.ComponentMapper' due to existing static import 'com.vaadin.ui.declarative.Design.*' 4 112
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Design.ComponentMapper' due to existing static import 'com.vaadin.ui.declarative.Design.*' 4 115
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Design.ComponentFactory' due to existing static import 'com.vaadin.ui.declarative.Design.*' 4 130

info/magnolia/ui/framework/layout/SingleFieldLayoutProducer.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.ui.framework.layout.SingleFieldLayoutProducer' due to existing same package import 'info.magnolia.ui.framework.layout.*' 4 58
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'info.magnolia.ui.framework.layout.SingleFieldLayoutProducer' due to existing same package import 'info.magnolia.ui.framework.layout.*' 4 61

info/magnolia/ui/framework/message/LocalMessageDispatcher.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'vaadinSession'. 3 65

info/magnolia/ui/framework/message/MessagesManager.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'MessageListener': members of interface types are implicitly public 3 50–57

info/magnolia/ui/framework/task/LocalTaskDispatcher.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'context'. 3 65
UnusedFormalParameter Avoid unused constructor parameters such as 'componentProvider'. 3 65
EmptyCatchBlock Avoid empty catch blocks 3 79–80

info/magnolia/util/Util.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 54–56
UselessParentheses Useless parentheses. 4 70