PMD Results

The following document contains the results of PMD 6.21.0.

Violations By Priority

Priority 3

info/magnolia/ui/admincentral/AdmincentralUI.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 111
UselessQualifiedThis Useless qualified this usage in the same class. 116

info/magnolia/ui/admincentral/AdmincentralVaadinServlet.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'e'. 161

info/magnolia/ui/admincentral/setup/AppLauncherReorderingTask.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Order': nested enums are implicitly static 113–115

info/magnolia/ui/admincentral/shellapp/applauncher/AppLauncherView.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Presenter': members of interface types are implicitly public 47–49

info/magnolia/ui/admincentral/shellapp/favorites/FavoritesEntry.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 236–239

info/magnolia/ui/admincentral/shellapp/favorites/FavoritesForm.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'newFavorite'. 102
UnusedFormalParameter Avoid unused constructor parameters such as 'availableGroups'. 102
UnusedFormalParameter Avoid unused constructor parameters such as 'newGroup'. 102

info/magnolia/ui/admincentral/shellapp/favorites/FavoritesGroup.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'editableFavoriteItems'. 76
UnusedFormalParameter Avoid unused constructor parameters such as 'view'. 89

info/magnolia/ui/admincentral/shellapp/favorites/FavoritesPresenter.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'adminCentralEventBus'. 80

info/magnolia/ui/admincentral/shellapp/pulse/PulsePresenter.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'admincentralEventBus'. 83

info/magnolia/ui/admincentral/shellapp/pulse/item/detail/PulseItemCategoryNavigator.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'itemCategoryChanged': the method is declared in an interface type 153

info/magnolia/ui/admincentral/usermenu/action/EditUserProfileDialogAction.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'eventBus'. 65

info/magnolia/ui/admincentral/usermenu/field/factory/TimeZoneFieldFactory.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 102–104

Priority 4

info/magnolia/ui/admincentral/setup/ConvertAclToAppPermissionTask.java

Rule Violation Line
UselessParentheses Useless parentheses. 176

info/magnolia/ui/admincentral/shellapp/favorites/EditingEvent.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.NoSuchMethodException' due to existing implicit import 'java.lang.*' 65
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.RuntimeException' due to existing implicit import 'java.lang.*' 67

info/magnolia/ui/admincentral/shellapp/favorites/FavoritesEntry.java

Rule Violation Line
UselessParentheses Useless parentheses. 340

info/magnolia/ui/admincentral/shellapp/favorites/FavoritesManagerImpl.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Favorite.NAME' due to existing static import 'info.magnolia.ui.framework.AdmincentralNodeTypes.Favorite.*' 94
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Favorite.NAME' due to existing static import 'info.magnolia.ui.framework.AdmincentralNodeTypes.Favorite.*' 162
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Favorite.NAME' due to existing static import 'info.magnolia.ui.framework.AdmincentralNodeTypes.Favorite.*' 197

info/magnolia/ui/admincentral/shellapp/pulse/item/NestedMapProperty.java

Rule Violation Line
UselessParentheses Useless parentheses. 119
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.NoSuchMethodException' due to existing implicit import 'java.lang.*' 167
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.NoSuchMethodException' due to existing implicit import 'java.lang.*' 171

info/magnolia/ui/admincentral/shellapp/pulse/item/detail/PulseItemCategoryNavigator.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.NoSuchMethodException' due to existing implicit import 'java.lang.*' 131
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.RuntimeException' due to existing implicit import 'java.lang.*' 132

info/magnolia/ui/admincentral/shellapp/pulse/task/TaskTypeHelper.java

Rule Violation Line
UselessParentheses Useless parentheses. 91

info/magnolia/ui/admincentral/shellapp/pulse/task/action/availability/TaskAvailabilityRule.java

Rule Violation Line
UselessParentheses Useless parentheses. 81

Files

info/magnolia/ui/admincentral/AdmincentralUI.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 111
UselessQualifiedThis Useless qualified this usage in the same class. 3 116

info/magnolia/ui/admincentral/AdmincentralVaadinServlet.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'e'. 3 161

info/magnolia/ui/admincentral/setup/AppLauncherReorderingTask.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Order': nested enums are implicitly static 3 113–115

info/magnolia/ui/admincentral/setup/ConvertAclToAppPermissionTask.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 176

info/magnolia/ui/admincentral/shellapp/applauncher/AppLauncherView.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Presenter': members of interface types are implicitly public 3 47–49

info/magnolia/ui/admincentral/shellapp/favorites/EditingEvent.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.NoSuchMethodException' due to existing implicit import 'java.lang.*' 4 65
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.RuntimeException' due to existing implicit import 'java.lang.*' 4 67

info/magnolia/ui/admincentral/shellapp/favorites/FavoritesEntry.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 236–239
UselessParentheses Useless parentheses. 4 340

info/magnolia/ui/admincentral/shellapp/favorites/FavoritesForm.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'newFavorite'. 3 102
UnusedFormalParameter Avoid unused constructor parameters such as 'availableGroups'. 3 102
UnusedFormalParameter Avoid unused constructor parameters such as 'newGroup'. 3 102

info/magnolia/ui/admincentral/shellapp/favorites/FavoritesGroup.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'editableFavoriteItems'. 3 76
UnusedFormalParameter Avoid unused constructor parameters such as 'view'. 3 89

info/magnolia/ui/admincentral/shellapp/favorites/FavoritesManagerImpl.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Favorite.NAME' due to existing static import 'info.magnolia.ui.framework.AdmincentralNodeTypes.Favorite.*' 4 94
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Favorite.NAME' due to existing static import 'info.magnolia.ui.framework.AdmincentralNodeTypes.Favorite.*' 4 162
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'Favorite.NAME' due to existing static import 'info.magnolia.ui.framework.AdmincentralNodeTypes.Favorite.*' 4 197

info/magnolia/ui/admincentral/shellapp/favorites/FavoritesPresenter.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'adminCentralEventBus'. 3 80

info/magnolia/ui/admincentral/shellapp/pulse/PulsePresenter.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'admincentralEventBus'. 3 83

info/magnolia/ui/admincentral/shellapp/pulse/item/NestedMapProperty.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 119
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.NoSuchMethodException' due to existing implicit import 'java.lang.*' 4 167
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.NoSuchMethodException' due to existing implicit import 'java.lang.*' 4 171

info/magnolia/ui/admincentral/shellapp/pulse/item/detail/PulseItemCategoryNavigator.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.NoSuchMethodException' due to existing implicit import 'java.lang.*' 4 131
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.RuntimeException' due to existing implicit import 'java.lang.*' 4 132
UnnecessaryModifier Unnecessary modifier 'public' on method 'itemCategoryChanged': the method is declared in an interface type 3 153

info/magnolia/ui/admincentral/shellapp/pulse/task/TaskTypeHelper.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 91

info/magnolia/ui/admincentral/shellapp/pulse/task/action/availability/TaskAvailabilityRule.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 81

info/magnolia/ui/admincentral/usermenu/action/EditUserProfileDialogAction.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'eventBus'. 3 65

info/magnolia/ui/admincentral/usermenu/field/factory/TimeZoneFieldFactory.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 102–104