PMD Results

The following document contains the results of PMD 6.21.0.

Violations By Priority

Priority 2

com/vaadin/v7/client/ui/VScrollTablePatched.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 6796

com/vaadin/v7/client/ui/VTreeTablePatched.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 357

Priority 3

com/googlecode/mgwt/collection/client/JsLightMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'clearData': private methods cannot be overridden 56–58

com/googlecode/mgwt/collection/shared/LightArray.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'get': the method is declared in an interface type 33
UnnecessaryModifier Unnecessary modifier 'public' on method 'set': the method is declared in an interface type 41
UnnecessaryModifier Unnecessary modifier 'public' on method 'length': the method is declared in an interface type 48
UnnecessaryModifier Unnecessary modifier 'public' on method 'shift': the method is declared in an interface type 62
UnnecessaryModifier Unnecessary modifier 'public' on method 'unshift': the method is declared in an interface type 69

com/googlecode/mgwt/collection/shared/LightArrayBoolean.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'shift': the method is declared in an interface type 30
UnnecessaryModifier Unnecessary modifier 'public' on method 'get': the method is declared in an interface type 38
UnnecessaryModifier Unnecessary modifier 'public' on method 'set': the method is declared in an interface type 46
UnnecessaryModifier Unnecessary modifier 'public' on method 'length': the method is declared in an interface type 53
UnnecessaryModifier Unnecessary modifier 'public' on method 'unshift': the method is declared in an interface type 60
UnnecessaryModifier Unnecessary modifier 'public' on method 'push': the method is declared in an interface type 67

com/googlecode/mgwt/collection/shared/LightArrayInt.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'shift': the method is declared in an interface type 30
UnnecessaryModifier Unnecessary modifier 'public' on method 'get': the method is declared in an interface type 38
UnnecessaryModifier Unnecessary modifier 'public' on method 'set': the method is declared in an interface type 46
UnnecessaryModifier Unnecessary modifier 'public' on method 'length': the method is declared in an interface type 53
UnnecessaryModifier Unnecessary modifier 'public' on method 'unshift': the method is declared in an interface type 60
UnnecessaryModifier Unnecessary modifier 'public' on method 'push': the method is declared in an interface type 67

com/googlecode/mgwt/collection/shared/LightMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'clear': the method is declared in an interface type 31
UnnecessaryModifier Unnecessary modifier 'public' on method 'containsKey': the method is declared in an interface type 39
UnnecessaryModifier Unnecessary modifier 'public' on method 'getKeys': the method is declared in an interface type 46
UnnecessaryModifier Unnecessary modifier 'public' on method 'remove': the method is declared in an interface type 53
UnnecessaryModifier Unnecessary modifier 'public' on method 'get': the method is declared in an interface type 61
UnnecessaryModifier Unnecessary modifier 'public' on method 'put': the method is declared in an interface type 69

com/googlecode/mgwt/dom/client/event/EventTypes.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getAnimationEnd': the method is declared in an interface type 4
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTransistionEnd': the method is declared in an interface type 6

com/googlecode/mgwt/dom/client/event/mouse/SimulatedTouchEndEvent.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'x'. 34
UnusedPrivateField Avoid unused private fields such as 'y'. 35
UnusedPrivateField Avoid unused private fields such as 'x_start'. 36
UnusedPrivateField Avoid unused private fields such as 'y_start'. 37
UnusedPrivateField Avoid unused private fields such as 'multiTouch'. 38

com/googlecode/mgwt/dom/client/event/mouse/SimulatedTouchMoveEvent.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'x'. 34
UnusedPrivateField Avoid unused private fields such as 'y'. 35
UnusedPrivateField Avoid unused private fields such as 'x_start'. 37
UnusedPrivateField Avoid unused private fields such as 'y_start'. 38
UnusedPrivateField Avoid unused private fields such as 'multiTouch'. 39

com/googlecode/mgwt/dom/client/event/tap/HasTapHandlers.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTapHandler': the method is declared in an interface type 34

com/googlecode/mgwt/dom/client/event/tap/TapHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onTap': the method is declared in an interface type 27

com/googlecode/mgwt/dom/client/event/touch/HasTouchHandlers.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchStartHandler': the method is declared in an interface type 39
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchMoveHandler': the method is declared in an interface type 51
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchCancelHandler': the method is declared in an interface type 63
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchEndHandler': the method is declared in an interface type 75
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchHandler': the method is declared in an interface type 87

com/googlecode/mgwt/dom/client/event/touch/JsTouch.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getPageX': the method is already in a final class 34–36
UnnecessaryModifier Unnecessary modifier 'final' on method 'getPageY': the method is already in a final class 43–45

com/googlecode/mgwt/dom/client/event/touch/Touch.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPageX': the method is declared in an interface type 31
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPageY': the method is declared in an interface type 38
UnnecessaryModifier Unnecessary modifier 'public' on method 'getIdentifier': the method is declared in an interface type 40

com/googlecode/mgwt/dom/client/event/touch/TouchCancelHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onTouchCanceled': the method is declared in an interface type 32

com/googlecode/mgwt/dom/client/event/touch/TouchEndHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onTouchEnd': the method is declared in an interface type 32

com/googlecode/mgwt/dom/client/event/touch/TouchMoveHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onTouchMove': the method is declared in an interface type 32

com/googlecode/mgwt/dom/client/event/touch/TouchStartHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onTouchStart': the method is declared in an interface type 32

com/googlecode/mgwt/dom/client/recognizer/EventPropagator.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'fireEvent': the method is declared in an interface type 34

com/googlecode/mgwt/dom/client/recognizer/TimeProvider.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTime': the method is declared in an interface type 26

com/googlecode/mgwt/dom/client/recognizer/TimerExecutor.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'execute': the method is declared in an interface type 26
UnnecessaryModifier Unnecessary modifier 'public' on interface 'CodeToRun': members of interface types are implicitly public 28–30
UnnecessaryModifier Unnecessary modifier 'public' on method 'onExecution': the method is declared in an interface type 29

com/googlecode/mgwt/dom/client/recognizer/longtap/HasLongTapHandlers.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'addLongTapHandler': the method is declared in an interface type 34

com/googlecode/mgwt/dom/client/recognizer/longtap/LongTapHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onLongTap': the method is declared in an interface type 32

com/googlecode/mgwt/dom/client/recognizer/longtap/LongTapRecognizer.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 202–205

com/googlecode/mgwt/dom/client/recognizer/pinch/HasPinchHandlers.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'addPinchHandler': the method is declared in an interface type 33

com/googlecode/mgwt/dom/client/recognizer/pinch/OffsetProvider.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLeft': the method is declared in an interface type 32
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTop': the method is declared in an interface type 39

com/googlecode/mgwt/dom/client/recognizer/pinch/PinchHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onPinch': the method is declared in an interface type 33

com/googlecode/mgwt/dom/client/recognizer/swipe/HasSwipeHandlers.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'addSwipeStartHandler': the method is declared in an interface type 34
UnnecessaryModifier Unnecessary modifier 'public' on method 'addSwipeMoveHandler': the method is declared in an interface type 42
UnnecessaryModifier Unnecessary modifier 'public' on method 'addSwipeEndHandler': the method is declared in an interface type 50

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeEndHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onSwipeEnd': the method is declared in an interface type 32

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeMoveHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onSwipeMove': the method is declared in an interface type 32

com/googlecode/mgwt/dom/client/recognizer/tap/MultiTapHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onMultiTap': the method is declared in an interface type 32

com/googlecode/mgwt/dom/client/recognizer/tap/MultiTapRecognizer.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 191–194
CollapsibleIfStatements These nested if statements could be combined 265–269

com/googlecode/mgwt/ui/client/widget/touch/TouchWidgetImpl.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchStartHandler': the method is declared in an interface type 40
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchMoveHandler': the method is declared in an interface type 49
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchCancelHandler': the method is declared in an interface type 58
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchEndHandler': the method is declared in an interface type 67

com/vaadin/client/ui/VSliderPatched.java

Rule Violation Line
EmptyIfStmt Avoid empty if statements 255–256
EmptyIfStmt Avoid empty if statements 257–258
EmptyIfStmt Avoid empty if statements 258–259
UselessQualifiedThis Useless qualified this usage in the same class. 415

com/vaadin/v7/client/ui/VScrollTablePatched.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'showContextMenu': the method is declared in an interface type 171
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'SelectMode(int)': enum constructors are implicitly private 301–303
UnusedPrivateField Avoid unused private fields such as 'detachedScrollPosition'. 450
UnusedPrivateField Avoid unused private fields such as 'initialContentReceived'. 703
UnusedPrivateField Avoid unused private fields such as 'touchScrollDelegate'. 744
SimplifiedTernary Ternary operators that can be simplified with || or && 1533–1535
UselessOverridingMethod Overriding method merely calls super 2230–2233
EmptyIfStmt Avoid empty if statements 2468–2470
UnusedLocalVariable Avoid unused local variables such as 'hCell'. 2476
CollapsibleIfStatements These nested if statements could be combined 2537–2550
CollapsibleIfStatements These nested if statements could be combined 2539–2549
CollapsibleIfStatements These nested if statements could be combined 3333–3378
CollapsibleIfStatements These nested if statements could be combined 3802–3805
CollapsibleIfStatements These nested if statements could be combined 3984–3992
CollapsibleIfStatements These nested if statements could be combined 4690–4693
SimplifiedTernary Ternary operators that can be simplified with || or && 5490–5492
CollapsibleIfStatements These nested if statements could be combined 6179–6292
UnusedFormalParameter Avoid unused method parameters such as 'rowUidl'. 6804
UnusedFormalParameter Avoid unused method parameters such as 'rowUidl'. 6811
CollapsibleIfStatements These nested if statements could be combined 7373–7382

com/vaadin/v7/client/ui/table/TableConnectorPatched.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'totalRowsHaveChanged'. 184
CollapsibleIfStatements These nested if statements could be combined 325–343

com/vaadin/v7/client/ui/treetable/TreeTableConnectorPatched.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 61–69

info/magnolia/ui/vaadin/actionbar/Actionbar.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'EVENT_ID': the field is declared in an interface type 216
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'EVENT_METHOD': the field is declared in an interface type 217
UnnecessaryModifier Unnecessary modifier 'public' on method 'actionTrigger': the method is declared in an interface type 219

info/magnolia/ui/vaadin/ckeditor/MagnoliaCKEditorConfig.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 104–106
UselessOverridingMethod Overriding method merely calls super 109–111

info/magnolia/ui/vaadin/dialog/ConfirmationDialog.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 112
UselessQualifiedThis Useless qualified this usage in the same class. 116
UselessOverridingMethod Overriding method merely calls super 131–133

info/magnolia/ui/vaadin/editor/CroppableImage.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 62–64
UnnecessaryModifier Unnecessary modifiers 'public static' on field 'EVENT_ID': the field is declared in an interface type 151
UnnecessaryModifier Unnecessary modifiers 'public static' on field 'EVENT_METHOD': the field is declared in an interface type 152–153
UnnecessaryModifier Unnecessary modifiers 'public static' on field 'EVENT_ID': the field is declared in an interface type 161
UnnecessaryModifier Unnecessary modifiers 'public static' on field 'EVENT_METHOD': the field is declared in an interface type 162–163

info/magnolia/ui/vaadin/editor/JCrop.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'handler'. 65

info/magnolia/ui/vaadin/form/field/FieldLayout.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 126–128

info/magnolia/ui/vaadin/grid/MagnoliaTreeTable.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'log'. 56
UselessOverridingMethod Overriding method merely calls super 74–76
UselessOverridingMethod Overriding method merely calls super 115–117

info/magnolia/ui/vaadin/gwt/client/applauncher/connector/AppLauncherConnector.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 145–147

info/magnolia/ui/vaadin/gwt/client/applauncher/widget/AppLauncherView.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Presenter': members of interface types are implicitly public 52–57

info/magnolia/ui/vaadin/gwt/client/applauncher/widget/VPermanentAppTileGroup.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 87–89

info/magnolia/ui/vaadin/gwt/client/ckeditor/VMagnoliaCKEditorTextField.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 158–160

info/magnolia/ui/vaadin/gwt/client/dialog/widget/DialogHeaderWidget.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 124–126

info/magnolia/ui/vaadin/gwt/client/form/connector/FormConnector.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 121

info/magnolia/ui/vaadin/gwt/client/form/tab/connector/FormTabConnector.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 48–50

info/magnolia/ui/vaadin/gwt/client/grid/VMagnoliaTable.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 176–178

info/magnolia/ui/vaadin/gwt/client/jquerywrapper/Callbacks.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'doRemove': private methods cannot be overridden 66–68
UnnecessaryModifier Unnecessary modifier 'final' on method 'doAdd': private methods cannot be overridden 70–72

info/magnolia/ui/vaadin/gwt/client/jquerywrapper/JQueryCallback.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'execute': the method is declared in an interface type 40

info/magnolia/ui/vaadin/gwt/client/jquerywrapper/JQueryFunction.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'create': the method is already in a final class 46–50
EmptyStatementNotInLoop An empty statement (semicolon) not part of a loop 51

info/magnolia/ui/vaadin/gwt/client/layout/lazylayout/widget/EscalatorPanel.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 232
UselessQualifiedThis Useless qualified this usage in the same class. 242
UselessQualifiedThis Useless qualified this usage in the same class. 254

info/magnolia/ui/vaadin/gwt/client/layout/lazylayout/widget/LazyThumbnailLayoutImageBundle.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'imgPath': the field is declared in an interface type 45
UnnecessaryModifier Unnecessary modifiers 'public static' on field 'INSTANCE': the field is declared in an interface type 47

info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/MagnoliaShellConnector.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 114–116

info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/MagnoliaShellViewImpl.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 231–233

info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/VShellImageBundle.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'imgPath': the field is declared in an interface type 45
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'BUNDLE': the field is declared in an interface type 47
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLogo': the method is declared in an interface type 50

info/magnolia/ui/vaadin/gwt/client/magnoliashell/viewport/animation/ZoomAnimation.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 73

info/magnolia/ui/vaadin/gwt/client/magnoliashell/viewport/connector/AppsViewportConnector.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 162

info/magnolia/ui/vaadin/gwt/client/magnoliashell/viewport/widget/AppsViewportWidget.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'style'. 196

info/magnolia/ui/vaadin/gwt/client/richtext/TextAreaStretcherConnector.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 115–118

info/magnolia/ui/vaadin/gwt/client/richtext/VMagnoliaRichTextField.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 165–167

info/magnolia/ui/vaadin/gwt/client/shared/icon/IconParameters.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'DEFAULT_SIZE': the field is declared in an interface type 41

info/magnolia/ui/vaadin/gwt/client/shared/magnoliashell/ViewportType.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ViewportType(String)': enum constructors are implicitly private 45–47

info/magnolia/ui/vaadin/gwt/client/shared/messagebubble/MessageBubbleAlignment.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'MessageBubbleAlignment(String)': enum constructors are implicitly private 44–46

info/magnolia/ui/vaadin/gwt/client/tabsheet/tab/widget/MagnoliaTabWidget.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'connector'. 51

info/magnolia/ui/vaadin/overlay/MessageStyleTypeEnum.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'MessageStyleTypeEnum(String, String, Class)': enum constructors are implicitly private 57–61

org/vaadin/alump/ckeditor/client/VCKEditorTextField.java

Rule Violation Line
UselessQualifiedThis Useless qualified this usage in the same class. 125
UselessQualifiedThis Useless qualified this usage in the same class. 127
UselessQualifiedThis Useless qualified this usage in the same class. 128
CollapsibleIfStatements These nested if statements could be combined 348–350
CollapsibleIfStatements These nested if statements could be combined 447–457
UnnecessaryReturn Avoid unnecessary return statements 522

Priority 4

com/googlecode/mgwt/dom/client/event/tap/TapEvent.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 56

com/googlecode/mgwt/dom/client/recognizer/longtap/LongTapEvent.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 67

com/googlecode/mgwt/dom/client/recognizer/pinch/PinchEvent.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 64

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeEndEvent.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 54

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeMoveEvent.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 60

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeStartEvent.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 58

com/googlecode/mgwt/dom/client/recognizer/tap/MultiTapEvent.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 85

com/vaadin/v7/client/ui/VScrollTablePatched.java

Rule Violation Line
UselessParentheses Useless parentheses. 2392–2394
UselessParentheses Useless parentheses. 2420–2421
UselessParentheses Useless parentheses. 2521
UselessParentheses Useless parentheses. 2601
UselessParentheses Useless parentheses. 2657–2658
UselessParentheses Useless parentheses. 2659–2660
UselessParentheses Useless parentheses. 2712
UselessParentheses Useless parentheses. 2762–2763
UselessParentheses Useless parentheses. 2783–2785
UselessParentheses Useless parentheses. 3519
UselessParentheses Useless parentheses. 4472
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' 5496
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' 5980
UselessParentheses Useless parentheses. 6220–6221
UselessParentheses Useless parentheses. 6318–6319
UselessParentheses Useless parentheses. 6414–6415
UselessParentheses Useless parentheses. 6843
UselessParentheses Useless parentheses. 6916
UselessParentheses Useless parentheses. 6916
UselessParentheses Useless parentheses. 7150–7151
UselessParentheses Useless parentheses. 7208
UselessParentheses Useless parentheses. 7512
UselessParentheses Useless parentheses. 7537–7538
UselessParentheses Useless parentheses. 7547–7549
UselessParentheses Useless parentheses. 7572
UselessParentheses Useless parentheses. 7573

com/vaadin/v7/client/ui/VTreeTablePatched.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' 153
UselessParentheses Useless parentheses. 410
UselessParentheses Useless parentheses. 800–801
UselessParentheses Useless parentheses. 802

com/vaadin/v7/client/ui/table/TableConnectorPatched.java

Rule Violation Line
UselessParentheses Useless parentheses. 184

com/vaadin/v7/client/ui/treetable/TreeTableConnectorPatched.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'com.vaadin.shared.ui.Connect' 24
UnusedImports Avoid unused imports such as 'com.vaadin.v7.ui.TreeTable' 32
UselessParentheses Useless parentheses. 84–85

info/magnolia/ui/vaadin/dialog/BaseDialog.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' 242
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.NoSuchMethodException' due to existing implicit import 'java.lang.*' 258
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.RuntimeException' due to existing implicit import 'java.lang.*' 259
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' 276
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.NoSuchMethodException' due to existing implicit import 'java.lang.*' 291
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.RuntimeException' due to existing implicit import 'java.lang.*' 292
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' 309
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.NoSuchMethodException' due to existing implicit import 'java.lang.*' 324
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.RuntimeException' due to existing implicit import 'java.lang.*' 325

info/magnolia/ui/vaadin/dialog/ConfirmationDialog.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.NoSuchMethodException' due to existing implicit import 'java.lang.*' 165
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.RuntimeException' due to existing implicit import 'java.lang.*' 166

info/magnolia/ui/vaadin/editor/JCropField.java

Rule Violation Line
UselessParentheses Useless parentheses. 146
UselessParentheses Useless parentheses. 146

info/magnolia/ui/vaadin/gwt/client/actionbar/connector/ActionbarConnector.java

Rule Violation Line
UselessParentheses Useless parentheses. 74

info/magnolia/ui/vaadin/gwt/client/actionbar/widget/ActionbarWidgetViewImpl.java

Rule Violation Line
UselessParentheses Useless parentheses. 353
UselessParentheses Useless parentheses. 381
UselessParentheses Useless parentheses. 384

info/magnolia/ui/vaadin/gwt/client/applauncher/connector/AppLauncherConnector.java

Rule Violation Line
UselessParentheses Useless parentheses. 125

info/magnolia/ui/vaadin/gwt/client/ckeditor/VMagnoliaCKEditorTextField.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'VMagnoliaCKEditorTextEvents.Listener' due to existing static import 'info.magnolia.ui.vaadin.gwt.client.ckeditor.VMagnoliaCKEditorTextEvents.*' 55

info/magnolia/ui/vaadin/gwt/client/dialog/connector/DialogContainingFormConnector.java

Rule Violation Line
UselessParentheses Useless parentheses. 117

info/magnolia/ui/vaadin/gwt/client/form/formsection/widget/FormSectionWidget.java

Rule Violation Line
UselessParentheses Useless parentheses. 78

info/magnolia/ui/vaadin/gwt/client/form/widget/FormViewImpl.java

Rule Violation Line
UselessParentheses Useless parentheses. 181

info/magnolia/ui/vaadin/gwt/client/grid/VMagnoliaTable.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.user.client.Element' due to existing import 'com.google.gwt.user.client.Element' 222

info/magnolia/ui/vaadin/gwt/client/grid/VMagnoliaTreeTable.java

Rule Violation Line
UselessParentheses Useless parentheses. 60

info/magnolia/ui/vaadin/gwt/client/richtext/VMagnoliaRichTextField.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'VMagnoliaCKEditorTextEvents.Listener' due to existing static import 'info.magnolia.ui.vaadin.gwt.client.ckeditor.VMagnoliaCKEditorTextEvents.*' 56

info/magnolia/ui/vaadin/gwt/client/tabsheet/widget/TabBarWidget.java

Rule Violation Line
UselessParentheses Useless parentheses. 146
UselessParentheses Useless parentheses. 149

info/magnolia/ui/vaadin/layout/CompatibilityThumbnailLayout.java

Rule Violation Line
UselessParentheses Useless parentheses. 106

Files

com/googlecode/mgwt/collection/client/JsLightMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'clearData': private methods cannot be overridden 3 56–58

com/googlecode/mgwt/collection/shared/LightArray.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'get': the method is declared in an interface type 3 33
UnnecessaryModifier Unnecessary modifier 'public' on method 'set': the method is declared in an interface type 3 41
UnnecessaryModifier Unnecessary modifier 'public' on method 'length': the method is declared in an interface type 3 48
UnnecessaryModifier Unnecessary modifier 'public' on method 'shift': the method is declared in an interface type 3 62
UnnecessaryModifier Unnecessary modifier 'public' on method 'unshift': the method is declared in an interface type 3 69

com/googlecode/mgwt/collection/shared/LightArrayBoolean.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'shift': the method is declared in an interface type 3 30
UnnecessaryModifier Unnecessary modifier 'public' on method 'get': the method is declared in an interface type 3 38
UnnecessaryModifier Unnecessary modifier 'public' on method 'set': the method is declared in an interface type 3 46
UnnecessaryModifier Unnecessary modifier 'public' on method 'length': the method is declared in an interface type 3 53
UnnecessaryModifier Unnecessary modifier 'public' on method 'unshift': the method is declared in an interface type 3 60
UnnecessaryModifier Unnecessary modifier 'public' on method 'push': the method is declared in an interface type 3 67

com/googlecode/mgwt/collection/shared/LightArrayInt.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'shift': the method is declared in an interface type 3 30
UnnecessaryModifier Unnecessary modifier 'public' on method 'get': the method is declared in an interface type 3 38
UnnecessaryModifier Unnecessary modifier 'public' on method 'set': the method is declared in an interface type 3 46
UnnecessaryModifier Unnecessary modifier 'public' on method 'length': the method is declared in an interface type 3 53
UnnecessaryModifier Unnecessary modifier 'public' on method 'unshift': the method is declared in an interface type 3 60
UnnecessaryModifier Unnecessary modifier 'public' on method 'push': the method is declared in an interface type 3 67

com/googlecode/mgwt/collection/shared/LightMap.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'clear': the method is declared in an interface type 3 31
UnnecessaryModifier Unnecessary modifier 'public' on method 'containsKey': the method is declared in an interface type 3 39
UnnecessaryModifier Unnecessary modifier 'public' on method 'getKeys': the method is declared in an interface type 3 46
UnnecessaryModifier Unnecessary modifier 'public' on method 'remove': the method is declared in an interface type 3 53
UnnecessaryModifier Unnecessary modifier 'public' on method 'get': the method is declared in an interface type 3 61
UnnecessaryModifier Unnecessary modifier 'public' on method 'put': the method is declared in an interface type 3 69

com/googlecode/mgwt/dom/client/event/EventTypes.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getAnimationEnd': the method is declared in an interface type 3 4
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTransistionEnd': the method is declared in an interface type 3 6

com/googlecode/mgwt/dom/client/event/mouse/SimulatedTouchEndEvent.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'x'. 3 34
UnusedPrivateField Avoid unused private fields such as 'y'. 3 35
UnusedPrivateField Avoid unused private fields such as 'x_start'. 3 36
UnusedPrivateField Avoid unused private fields such as 'y_start'. 3 37
UnusedPrivateField Avoid unused private fields such as 'multiTouch'. 3 38

com/googlecode/mgwt/dom/client/event/mouse/SimulatedTouchMoveEvent.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'x'. 3 34
UnusedPrivateField Avoid unused private fields such as 'y'. 3 35
UnusedPrivateField Avoid unused private fields such as 'x_start'. 3 37
UnusedPrivateField Avoid unused private fields such as 'y_start'. 3 38
UnusedPrivateField Avoid unused private fields such as 'multiTouch'. 3 39

com/googlecode/mgwt/dom/client/event/tap/HasTapHandlers.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTapHandler': the method is declared in an interface type 3 34

com/googlecode/mgwt/dom/client/event/tap/TapEvent.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 4 56

com/googlecode/mgwt/dom/client/event/tap/TapHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onTap': the method is declared in an interface type 3 27

com/googlecode/mgwt/dom/client/event/touch/HasTouchHandlers.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchStartHandler': the method is declared in an interface type 3 39
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchMoveHandler': the method is declared in an interface type 3 51
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchCancelHandler': the method is declared in an interface type 3 63
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchEndHandler': the method is declared in an interface type 3 75
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchHandler': the method is declared in an interface type 3 87

com/googlecode/mgwt/dom/client/event/touch/JsTouch.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getPageX': the method is already in a final class 3 34–36
UnnecessaryModifier Unnecessary modifier 'final' on method 'getPageY': the method is already in a final class 3 43–45

com/googlecode/mgwt/dom/client/event/touch/Touch.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPageX': the method is declared in an interface type 3 31
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPageY': the method is declared in an interface type 3 38
UnnecessaryModifier Unnecessary modifier 'public' on method 'getIdentifier': the method is declared in an interface type 3 40

com/googlecode/mgwt/dom/client/event/touch/TouchCancelHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onTouchCanceled': the method is declared in an interface type 3 32

com/googlecode/mgwt/dom/client/event/touch/TouchEndHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onTouchEnd': the method is declared in an interface type 3 32

com/googlecode/mgwt/dom/client/event/touch/TouchMoveHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onTouchMove': the method is declared in an interface type 3 32

com/googlecode/mgwt/dom/client/event/touch/TouchStartHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onTouchStart': the method is declared in an interface type 3 32

com/googlecode/mgwt/dom/client/recognizer/EventPropagator.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'fireEvent': the method is declared in an interface type 3 34

com/googlecode/mgwt/dom/client/recognizer/TimeProvider.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTime': the method is declared in an interface type 3 26

com/googlecode/mgwt/dom/client/recognizer/TimerExecutor.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'execute': the method is declared in an interface type 3 26
UnnecessaryModifier Unnecessary modifier 'public' on interface 'CodeToRun': members of interface types are implicitly public 3 28–30
UnnecessaryModifier Unnecessary modifier 'public' on method 'onExecution': the method is declared in an interface type 3 29

com/googlecode/mgwt/dom/client/recognizer/longtap/HasLongTapHandlers.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'addLongTapHandler': the method is declared in an interface type 3 34

com/googlecode/mgwt/dom/client/recognizer/longtap/LongTapEvent.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 4 67

com/googlecode/mgwt/dom/client/recognizer/longtap/LongTapHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onLongTap': the method is declared in an interface type 3 32

com/googlecode/mgwt/dom/client/recognizer/longtap/LongTapRecognizer.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 202–205

com/googlecode/mgwt/dom/client/recognizer/pinch/HasPinchHandlers.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'addPinchHandler': the method is declared in an interface type 3 33

com/googlecode/mgwt/dom/client/recognizer/pinch/OffsetProvider.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLeft': the method is declared in an interface type 3 32
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTop': the method is declared in an interface type 3 39

com/googlecode/mgwt/dom/client/recognizer/pinch/PinchEvent.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 4 64

com/googlecode/mgwt/dom/client/recognizer/pinch/PinchHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onPinch': the method is declared in an interface type 3 33

com/googlecode/mgwt/dom/client/recognizer/swipe/HasSwipeHandlers.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'addSwipeStartHandler': the method is declared in an interface type 3 34
UnnecessaryModifier Unnecessary modifier 'public' on method 'addSwipeMoveHandler': the method is declared in an interface type 3 42
UnnecessaryModifier Unnecessary modifier 'public' on method 'addSwipeEndHandler': the method is declared in an interface type 3 50

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeEndEvent.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 4 54

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeEndHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onSwipeEnd': the method is declared in an interface type 3 32

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeMoveEvent.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 4 60

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeMoveHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onSwipeMove': the method is declared in an interface type 3 32

com/googlecode/mgwt/dom/client/recognizer/swipe/SwipeStartEvent.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 4 58

com/googlecode/mgwt/dom/client/recognizer/tap/MultiTapEvent.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.event.shared.GwtEvent.Type' due to existing import 'com.google.gwt.event.shared.GwtEvent' 4 85

com/googlecode/mgwt/dom/client/recognizer/tap/MultiTapHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onMultiTap': the method is declared in an interface type 3 32

com/googlecode/mgwt/dom/client/recognizer/tap/MultiTapRecognizer.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 191–194
CollapsibleIfStatements These nested if statements could be combined 3 265–269

com/googlecode/mgwt/ui/client/widget/touch/TouchWidgetImpl.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchStartHandler': the method is declared in an interface type 3 40
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchMoveHandler': the method is declared in an interface type 3 49
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchCancelHandler': the method is declared in an interface type 3 58
UnnecessaryModifier Unnecessary modifier 'public' on method 'addTouchEndHandler': the method is declared in an interface type 3 67

com/vaadin/client/ui/VSliderPatched.java

Rule Violation Priority Line
EmptyIfStmt Avoid empty if statements 3 255–256
EmptyIfStmt Avoid empty if statements 3 257–258
EmptyIfStmt Avoid empty if statements 3 258–259
UselessQualifiedThis Useless qualified this usage in the same class. 3 415

com/vaadin/v7/client/ui/VScrollTablePatched.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'showContextMenu': the method is declared in an interface type 3 171
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'SelectMode(int)': enum constructors are implicitly private 3 301–303
UnusedPrivateField Avoid unused private fields such as 'detachedScrollPosition'. 3 450
UnusedPrivateField Avoid unused private fields such as 'initialContentReceived'. 3 703
UnusedPrivateField Avoid unused private fields such as 'touchScrollDelegate'. 3 744
SimplifiedTernary Ternary operators that can be simplified with || or && 3 1533–1535
UselessOverridingMethod Overriding method merely calls super 3 2230–2233
UselessParentheses Useless parentheses. 4 2392–2394
UselessParentheses Useless parentheses. 4 2420–2421
EmptyIfStmt Avoid empty if statements 3 2468–2470
UnusedLocalVariable Avoid unused local variables such as 'hCell'. 3 2476
UselessParentheses Useless parentheses. 4 2521
CollapsibleIfStatements These nested if statements could be combined 3 2537–2550
CollapsibleIfStatements These nested if statements could be combined 3 2539–2549
UselessParentheses Useless parentheses. 4 2601
UselessParentheses Useless parentheses. 4 2657–2658
UselessParentheses Useless parentheses. 4 2659–2660
UselessParentheses Useless parentheses. 4 2712
UselessParentheses Useless parentheses. 4 2762–2763
UselessParentheses Useless parentheses. 4 2783–2785
CollapsibleIfStatements These nested if statements could be combined 3 3333–3378
UselessParentheses Useless parentheses. 4 3519
CollapsibleIfStatements These nested if statements could be combined 3 3802–3805
CollapsibleIfStatements These nested if statements could be combined 3 3984–3992
UselessParentheses Useless parentheses. 4 4472
CollapsibleIfStatements These nested if statements could be combined 3 4690–4693
SimplifiedTernary Ternary operators that can be simplified with || or && 3 5490–5492
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' 4 5496
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' 4 5980
CollapsibleIfStatements These nested if statements could be combined 3 6179–6292
UselessParentheses Useless parentheses. 4 6220–6221
UselessParentheses Useless parentheses. 4 6318–6319
UselessParentheses Useless parentheses. 4 6414–6415
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 6796
UnusedFormalParameter Avoid unused method parameters such as 'rowUidl'. 3 6804
UnusedFormalParameter Avoid unused method parameters such as 'rowUidl'. 3 6811
UselessParentheses Useless parentheses. 4 6843
UselessParentheses Useless parentheses. 4 6916
UselessParentheses Useless parentheses. 4 6916
UselessParentheses Useless parentheses. 4 7150–7151
UselessParentheses Useless parentheses. 4 7208
CollapsibleIfStatements These nested if statements could be combined 3 7373–7382
UselessParentheses Useless parentheses. 4 7512
UselessParentheses Useless parentheses. 4 7537–7538
UselessParentheses Useless parentheses. 4 7547–7549
UselessParentheses Useless parentheses. 4 7572
UselessParentheses Useless parentheses. 4 7573

com/vaadin/v7/client/ui/VTreeTablePatched.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.dom.client.Element' due to existing import 'com.google.gwt.dom.client.Element' 4 153
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 357
UselessParentheses Useless parentheses. 4 410
UselessParentheses Useless parentheses. 4 800–801
UselessParentheses Useless parentheses. 4 802

com/vaadin/v7/client/ui/table/TableConnectorPatched.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'totalRowsHaveChanged'. 3 184
UselessParentheses Useless parentheses. 4 184
CollapsibleIfStatements These nested if statements could be combined 3 325–343

com/vaadin/v7/client/ui/treetable/TreeTableConnectorPatched.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'com.vaadin.shared.ui.Connect' 4 24
UnusedImports Avoid unused imports such as 'com.vaadin.v7.ui.TreeTable' 4 32
CollapsibleIfStatements These nested if statements could be combined 3 61–69
UselessParentheses Useless parentheses. 4 84–85

info/magnolia/ui/vaadin/actionbar/Actionbar.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'EVENT_ID': the field is declared in an interface type 3 216
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'EVENT_METHOD': the field is declared in an interface type 3 217
UnnecessaryModifier Unnecessary modifier 'public' on method 'actionTrigger': the method is declared in an interface type 3 219

info/magnolia/ui/vaadin/ckeditor/MagnoliaCKEditorConfig.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 104–106
UselessOverridingMethod Overriding method merely calls super 3 109–111

info/magnolia/ui/vaadin/dialog/BaseDialog.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' 4 242
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.NoSuchMethodException' due to existing implicit import 'java.lang.*' 4 258
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.RuntimeException' due to existing implicit import 'java.lang.*' 4 259
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' 4 276
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.NoSuchMethodException' due to existing implicit import 'java.lang.*' 4 291
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.RuntimeException' due to existing implicit import 'java.lang.*' 4 292
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.vaadin.ui.Component.Event' due to existing import 'com.vaadin.ui.Component' 4 309
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.NoSuchMethodException' due to existing implicit import 'java.lang.*' 4 324
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.RuntimeException' due to existing implicit import 'java.lang.*' 4 325

info/magnolia/ui/vaadin/dialog/ConfirmationDialog.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 112
UselessQualifiedThis Useless qualified this usage in the same class. 3 116
UselessOverridingMethod Overriding method merely calls super 3 131–133
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.NoSuchMethodException' due to existing implicit import 'java.lang.*' 4 165
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.RuntimeException' due to existing implicit import 'java.lang.*' 4 166

info/magnolia/ui/vaadin/editor/CroppableImage.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 62–64
UnnecessaryModifier Unnecessary modifiers 'public static' on field 'EVENT_ID': the field is declared in an interface type 3 151
UnnecessaryModifier Unnecessary modifiers 'public static' on field 'EVENT_METHOD': the field is declared in an interface type 3 152–153
UnnecessaryModifier Unnecessary modifiers 'public static' on field 'EVENT_ID': the field is declared in an interface type 3 161
UnnecessaryModifier Unnecessary modifiers 'public static' on field 'EVENT_METHOD': the field is declared in an interface type 3 162–163

info/magnolia/ui/vaadin/editor/JCrop.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'handler'. 3 65

info/magnolia/ui/vaadin/editor/JCropField.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 146
UselessParentheses Useless parentheses. 4 146

info/magnolia/ui/vaadin/form/field/FieldLayout.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 126–128

info/magnolia/ui/vaadin/grid/MagnoliaTreeTable.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'log'. 3 56
UselessOverridingMethod Overriding method merely calls super 3 74–76
UselessOverridingMethod Overriding method merely calls super 3 115–117

info/magnolia/ui/vaadin/gwt/client/actionbar/connector/ActionbarConnector.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 74

info/magnolia/ui/vaadin/gwt/client/actionbar/widget/ActionbarWidgetViewImpl.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 353
UselessParentheses Useless parentheses. 4 381
UselessParentheses Useless parentheses. 4 384

info/magnolia/ui/vaadin/gwt/client/applauncher/connector/AppLauncherConnector.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 125
UselessOverridingMethod Overriding method merely calls super 3 145–147

info/magnolia/ui/vaadin/gwt/client/applauncher/widget/AppLauncherView.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on interface 'Presenter': members of interface types are implicitly public 3 52–57

info/magnolia/ui/vaadin/gwt/client/applauncher/widget/VPermanentAppTileGroup.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 87–89

info/magnolia/ui/vaadin/gwt/client/ckeditor/VMagnoliaCKEditorTextField.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'VMagnoliaCKEditorTextEvents.Listener' due to existing static import 'info.magnolia.ui.vaadin.gwt.client.ckeditor.VMagnoliaCKEditorTextEvents.*' 4 55
UselessOverridingMethod Overriding method merely calls super 3 158–160

info/magnolia/ui/vaadin/gwt/client/dialog/connector/DialogContainingFormConnector.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 117

info/magnolia/ui/vaadin/gwt/client/dialog/widget/DialogHeaderWidget.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 124–126

info/magnolia/ui/vaadin/gwt/client/form/connector/FormConnector.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 121

info/magnolia/ui/vaadin/gwt/client/form/formsection/widget/FormSectionWidget.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 78

info/magnolia/ui/vaadin/gwt/client/form/tab/connector/FormTabConnector.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 48–50

info/magnolia/ui/vaadin/gwt/client/form/widget/FormViewImpl.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 181

info/magnolia/ui/vaadin/gwt/client/grid/VMagnoliaTable.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 176–178
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'com.google.gwt.user.client.Element' due to existing import 'com.google.gwt.user.client.Element' 4 222

info/magnolia/ui/vaadin/gwt/client/grid/VMagnoliaTreeTable.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 60

info/magnolia/ui/vaadin/gwt/client/jquerywrapper/Callbacks.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'doRemove': private methods cannot be overridden 3 66–68
UnnecessaryModifier Unnecessary modifier 'final' on method 'doAdd': private methods cannot be overridden 3 70–72

info/magnolia/ui/vaadin/gwt/client/jquerywrapper/JQueryCallback.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'execute': the method is declared in an interface type 3 40

info/magnolia/ui/vaadin/gwt/client/jquerywrapper/JQueryFunction.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'create': the method is already in a final class 3 46–50
EmptyStatementNotInLoop An empty statement (semicolon) not part of a loop 3 51

info/magnolia/ui/vaadin/gwt/client/layout/lazylayout/widget/EscalatorPanel.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 232
UselessQualifiedThis Useless qualified this usage in the same class. 3 242
UselessQualifiedThis Useless qualified this usage in the same class. 3 254

info/magnolia/ui/vaadin/gwt/client/layout/lazylayout/widget/LazyThumbnailLayoutImageBundle.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'imgPath': the field is declared in an interface type 3 45
UnnecessaryModifier Unnecessary modifiers 'public static' on field 'INSTANCE': the field is declared in an interface type 3 47

info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/MagnoliaShellConnector.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 114–116

info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/MagnoliaShellViewImpl.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 231–233

info/magnolia/ui/vaadin/gwt/client/magnoliashell/shell/VShellImageBundle.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'imgPath': the field is declared in an interface type 3 45
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'BUNDLE': the field is declared in an interface type 3 47
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLogo': the method is declared in an interface type 3 50

info/magnolia/ui/vaadin/gwt/client/magnoliashell/viewport/animation/ZoomAnimation.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 73

info/magnolia/ui/vaadin/gwt/client/magnoliashell/viewport/connector/AppsViewportConnector.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 162

info/magnolia/ui/vaadin/gwt/client/magnoliashell/viewport/widget/AppsViewportWidget.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'style'. 3 196

info/magnolia/ui/vaadin/gwt/client/richtext/TextAreaStretcherConnector.java

Rule Violation Priority Line
CollapsibleIfStatements These nested if statements could be combined 3 115–118

info/magnolia/ui/vaadin/gwt/client/richtext/VMagnoliaRichTextField.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'VMagnoliaCKEditorTextEvents.Listener' due to existing static import 'info.magnolia.ui.vaadin.gwt.client.ckeditor.VMagnoliaCKEditorTextEvents.*' 4 56
UselessOverridingMethod Overriding method merely calls super 3 165–167

info/magnolia/ui/vaadin/gwt/client/shared/icon/IconParameters.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'DEFAULT_SIZE': the field is declared in an interface type 3 41

info/magnolia/ui/vaadin/gwt/client/shared/magnoliashell/ViewportType.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ViewportType(String)': enum constructors are implicitly private 3 45–47

info/magnolia/ui/vaadin/gwt/client/shared/messagebubble/MessageBubbleAlignment.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'MessageBubbleAlignment(String)': enum constructors are implicitly private 3 44–46

info/magnolia/ui/vaadin/gwt/client/tabsheet/tab/widget/MagnoliaTabWidget.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'connector'. 3 51

info/magnolia/ui/vaadin/gwt/client/tabsheet/widget/TabBarWidget.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 146
UselessParentheses Useless parentheses. 4 149

info/magnolia/ui/vaadin/layout/CompatibilityThumbnailLayout.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 106

info/magnolia/ui/vaadin/overlay/MessageStyleTypeEnum.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'MessageStyleTypeEnum(String, String, Class)': enum constructors are implicitly private 3 57–61

org/vaadin/alump/ckeditor/client/VCKEditorTextField.java

Rule Violation Priority Line
UselessQualifiedThis Useless qualified this usage in the same class. 3 125
UselessQualifiedThis Useless qualified this usage in the same class. 3 127
UselessQualifiedThis Useless qualified this usage in the same class. 3 128
CollapsibleIfStatements These nested if statements could be combined 3 348–350
CollapsibleIfStatements These nested if statements could be combined 3 447–457
UnnecessaryReturn Avoid unnecessary return statements 3 522