PMD Results

The following document contains the results of PMD 6.4.0.

Files

info/magnolia/channel/ChannelResolver.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 46
Avoid modifiers which are implied by the context 3 51

info/magnolia/cms/beans/config/ConfigLoader.java

Violation Priority Line
Avoid unused constructor parameters such as 'context'. 3 84

info/magnolia/cms/beans/config/ConfigurationException.java

Violation Priority Line
Useless parentheses. 4 46

info/magnolia/cms/beans/config/HostBasedVirtualURIMapping.java

Violation Priority Line
Useless parentheses. 4 171

info/magnolia/cms/beans/config/MIMEMapping.java

Violation Priority Line
Useless parentheses. 4 222

info/magnolia/cms/beans/config/ObservedManager.java

Violation Priority Line
Avoid unnecessary return statements 3 133

info/magnolia/cms/beans/config/VirtualURIMapping.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 6892

info/magnolia/cms/beans/runtime/Document.java

Violation Priority Line
Useless parentheses. 4 206
Useless parentheses. 4 206

info/magnolia/cms/beans/runtime/File.java

Violation Priority Line
Avoid empty catch blocks 3 172174

info/magnolia/cms/beans/runtime/MultipartForm.java

Violation Priority Line
Useless parentheses. 4 116

info/magnolia/cms/core/AbstractContent.java

Violation Priority Line
Useless parentheses. 4 340
Useless parentheses. 4 345
Avoid empty catch blocks 3 409411

info/magnolia/cms/core/AbstractNodeData.java

Violation Priority Line
Avoid empty catch blocks 3 136138
Avoid empty catch blocks 3 207209

info/magnolia/cms/core/BinaryNodeData.java

Violation Priority Line
These nested if statements could be combined 3 7682

info/magnolia/cms/core/Content.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 762
Avoid modifiers which are implied by the context 3 770779
Avoid modifiers which are implied by the context 3 777

info/magnolia/cms/core/DefaultACLBasedPermissions.java

Violation Priority Line
Avoid unused constructor parameters such as 'configuration'. 3 107
Useless parentheses. 4 117
Useless parentheses. 4 117

info/magnolia/cms/core/DefaultContent.java

Violation Priority Line
Avoid empty catch blocks 3 341343
Avoid empty catch blocks 3 384386
Avoid empty catch blocks 3 554556
Ensure you override both equals() and hashCode() 3 678
Useless parentheses. 4 696

info/magnolia/cms/core/DefaultHierarchyManager.java

Violation Priority Line
Avoid unused private fields such as 'repositoryManager'. 3 84
Avoid unused constructor parameters such as 'ignoredAccessManager'. 3 95
Avoid unused constructor parameters such as 'userId'. 3 95
Avoid unused constructor parameters such as 'ignoredUserId'. 3 103
Avoid unused constructor parameters such as 'ignored'. 3 112
Useless parentheses. 4 193
Avoid unused local variables such as 'type'. 3 328
Useless parentheses. 4 351
Avoid empty catch blocks 3 403405

info/magnolia/cms/core/MetaData.java

Violation Priority Line
Avoid unused constructor parameters such as 'ignoredAccessManager'. 3 153

info/magnolia/cms/core/NodeTypeBasedPermissions.java

Violation Priority Line
Useless parentheses. 4 112
Useless parentheses. 4 112

info/magnolia/cms/core/Path.java

Violation Priority Line
Useless parentheses. 4 243
Useless parentheses. 4 243
Useless parentheses. 4 243
Useless parentheses. 4 244
Useless parentheses. 4 244
Useless parentheses. 4 244
Useless parentheses. 4 245
Useless parentheses. 4 245
Useless parentheses. 4 245

info/magnolia/cms/core/search/QueryManagerImpl.java

Violation Priority Line
Useless parentheses. 4 94
Useless parentheses. 4 100

info/magnolia/cms/core/search/QueryResultImpl.java

Violation Priority Line
Useless parentheses. 4 132

info/magnolia/cms/core/version/ContentVersion.java

Violation Priority Line
Useless parentheses. 4 405
Useless parentheses. 4 414

info/magnolia/cms/core/version/CopyUtil.java

Violation Priority Line
Avoid empty catch blocks 3 378380

info/magnolia/cms/core/version/MgnlVersioningNodeWrapper.java

Violation Priority Line
Avoid unused constructor parameters such as 'repositoryManager'. 3 76

info/magnolia/cms/exchange/ActivationManager.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 46
Avoid modifiers which are implied by the context 3 52
Avoid modifiers which are implied by the context 3 58
Avoid modifiers which are implied by the context 3 66
Avoid modifiers which are implied by the context 3 68
Avoid modifiers which are implied by the context 3 73

info/magnolia/cms/exchange/ExchangeException.java

Violation Priority Line
Useless parentheses. 4 57

info/magnolia/cms/exchange/Subscriber.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 45
Avoid modifiers which are implied by the context 3 47
Avoid modifiers which are implied by the context 3 49
Avoid modifiers which are implied by the context 3 51
Avoid modifiers which are implied by the context 3 53
Avoid modifiers which are implied by the context 3 55
Avoid modifiers which are implied by the context 3 57
Avoid modifiers which are implied by the context 3 59
Avoid modifiers which are implied by the context 3 61
Avoid modifiers which are implied by the context 3 63
Avoid modifiers which are implied by the context 3 65
Avoid modifiers which are implied by the context 3 67
Avoid modifiers which are implied by the context 3 69
Avoid modifiers which are implied by the context 3 71
Avoid modifiers which are implied by the context 3 73

info/magnolia/cms/exchange/Subscription.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 45
Avoid modifiers which are implied by the context 3 47
Avoid modifiers which are implied by the context 3 49
Avoid modifiers which are implied by the context 3 51
Avoid modifiers which are implied by the context 3 53
Avoid modifiers which are implied by the context 3 55
Avoid modifiers which are implied by the context 3 57
Avoid modifiers which are implied by the context 3 59

info/magnolia/cms/exchange/Syndicator.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 62
Avoid modifiers which are implied by the context 3 70
Avoid modifiers which are implied by the context 3 79
Avoid modifiers which are implied by the context 3 87
Avoid modifiers which are implied by the context 3 96
Avoid modifiers which are implied by the context 3 101
Avoid modifiers which are implied by the context 3 106

info/magnolia/cms/filters/AggregatorFilter.java

Violation Priority Line
Useless parentheses. 4 228

info/magnolia/cms/filters/CosMultipartRequestFilter.java

Violation Priority Line
Useless parentheses. 4 98
Useless parentheses. 4 100

info/magnolia/cms/filters/FilterManager.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 52

info/magnolia/cms/filters/ServletDispatchingFilter.java

Violation Priority Line
Useless parentheses. 4 220

info/magnolia/cms/filters/WebContainerResources.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 49

info/magnolia/cms/i18n/AbstractI18nContentSupport.java

Violation Priority Line
Useless parentheses. 4 341

info/magnolia/cms/i18n/AbstractMessagesImpl.java

Violation Priority Line
Ensure you override both equals() and hashCode() 3 140

info/magnolia/cms/i18n/I18nContentSupport.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 52
Avoid modifiers which are implied by the context 3 54
Avoid modifiers which are implied by the context 3 59
Avoid modifiers which are implied by the context 3 61
Avoid modifiers which are implied by the context 3 66
Avoid modifiers which are implied by the context 3 71
Avoid modifiers which are implied by the context 3 76
Avoid modifiers which are implied by the context 3 81
Avoid modifiers which are implied by the context 3 86
Avoid modifiers which are implied by the context 3 91
Avoid modifiers which are implied by the context 3 96
Avoid modifiers which are implied by the context 3 101
Avoid modifiers which are implied by the context 3 103
Avoid modifiers which are implied by the context 3 105

info/magnolia/cms/i18n/Messages.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 48
Avoid modifiers which are implied by the context 3 55
Avoid modifiers which are implied by the context 3 63
Avoid modifiers which are implied by the context 3 70
Avoid modifiers which are implied by the context 3 79
Avoid modifiers which are implied by the context 3 89
Avoid modifiers which are implied by the context 3 94
Avoid modifiers which are implied by the context 3 99

info/magnolia/cms/security/AccessDeniedException.java

Violation Priority Line
Useless parentheses. 4 53

info/magnolia/cms/security/AccessManagerImpl.java

Violation Priority Line
Useless parentheses. 4 83

info/magnolia/cms/security/CsrfTokenSecurityFilter.java

Violation Priority Line
Avoid unused method parameters such as 'response'. 3 137

info/magnolia/cms/security/DelegatingUserManager.java

Violation Priority Line
Avoid empty catch blocks 3 163165
Avoid empty catch blocks 3 187189
Avoid empty catch blocks 3 206208

info/magnolia/cms/security/Digester.java

Violation Priority Line
Avoid unused private fields such as 'log'. 3 76

info/magnolia/cms/security/ExternalUser.java

Violation Priority Line
Avoid unused private fields such as 'userDetails'. 3 62

info/magnolia/cms/security/ExternalUserManager.java

Violation Priority Line
Avoid unused private fields such as 'log'. 3 58

info/magnolia/cms/security/Group.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 44
Avoid modifiers which are implied by the context 3 50
Avoid modifiers which are implied by the context 3 56
Avoid modifiers which are implied by the context 3 62
Avoid modifiers which are implied by the context 3 68
Avoid modifiers which are implied by the context 3 70
Avoid modifiers which are implied by the context 3 85
Avoid modifiers which are implied by the context 3 90
Avoid modifiers which are implied by the context 3 95
Avoid modifiers which are implied by the context 3 100

info/magnolia/cms/security/IPSecurityManager.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 5155

info/magnolia/cms/security/IPSecurityManagerImpl.java

Violation Priority Line
Useless parentheses. 4 85

info/magnolia/cms/security/Lock.java

Violation Priority Line
Useless parentheses. 4 87

info/magnolia/cms/security/LogoutFilter.java

Violation Priority Line
Avoid unused private fields such as 'log'. 3 59
Avoid unused private fields such as 'servletContext'. 3 63

info/magnolia/cms/security/MgnlGroup.java

Violation Priority Line
Avoid unused private fields such as 'log'. 3 47

info/magnolia/cms/security/MgnlRole.java

Violation Priority Line
Avoid unused private fields such as 'log'. 3 48
Avoid unused private fields such as 'acls'. 3 56

info/magnolia/cms/security/MgnlRoleManager.java

Violation Priority Line
These nested if statements could be combined 3 149151
These nested if statements could be combined 3 187190

info/magnolia/cms/security/MgnlUser.java

Violation Priority Line
Ternary operators that can be simplified with || or && 3 89

info/magnolia/cms/security/MgnlUserManager.java

Violation Priority Line
Useless parentheses. 4 319
Avoid unnecessary return statements 3 513

info/magnolia/cms/security/Realm.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 47
Avoid modifiers which are implied by the context 3 52
Avoid modifiers which are implied by the context 3 57
Avoid modifiers which are implied by the context 3 62
Avoid modifiers which are implied by the context 3 99106

info/magnolia/cms/security/RepositoryBackedSecurityManager.java

Violation Priority Line
Useless parentheses. 4 112
Useless parentheses. 4 167

info/magnolia/cms/security/Role.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 43
Avoid modifiers which are implied by the context 3 49
Avoid modifiers which are implied by the context 3 55
Avoid modifiers which are implied by the context 3 61
Avoid modifiers which are implied by the context 3 66

info/magnolia/cms/security/RoleManager.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 54
Avoid modifiers which are implied by the context 3 56
Avoid modifiers which are implied by the context 3 63
Avoid modifiers which are implied by the context 3 70
Avoid modifiers which are implied by the context 3 75
Avoid modifiers which are implied by the context 3 80
Avoid modifiers which are implied by the context 3 85

info/magnolia/cms/security/SecurityCallbackFilter.java

Violation Priority Line
Unnecessary use of fully qualified name 'HttpServletResponse.SC_UNAUTHORIZED' due to existing static import 'javax.servlet.http.HttpServletResponse.*' 4 91

info/magnolia/cms/security/SecuritySupport.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 7074

info/magnolia/cms/security/SystemUserManager.java

Violation Priority Line
Avoid unused method parameters such as 'password'. 3 166

info/magnolia/cms/security/URISecurityFilter.java

Violation Priority Line
Useless parentheses. 4 108

info/magnolia/cms/security/UserManager.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 53
Avoid modifiers which are implied by the context 3 58
Avoid modifiers which are implied by the context 3 63
Avoid modifiers which are implied by the context 3 71
Avoid modifiers which are implied by the context 3 79
Avoid modifiers which are implied by the context 3 88
Avoid modifiers which are implied by the context 3 95
Avoid modifiers which are implied by the context 3 102
Avoid modifiers which are implied by the context 3 110
Avoid modifiers which are implied by the context 3 117
Avoid modifiers which are implied by the context 3 124
Avoid modifiers which are implied by the context 3 132
Avoid modifiers which are implied by the context 3 144
Avoid modifiers which are implied by the context 3 149
Avoid modifiers which are implied by the context 3 158
Avoid modifiers which are implied by the context 3 165
Avoid modifiers which are implied by the context 3 172
Avoid modifiers which are implied by the context 3 179
Avoid modifiers which are implied by the context 3 186
Avoid modifiers which are implied by the context 3 193
Avoid modifiers which are implied by the context 3 200
Avoid modifiers which are implied by the context 3 208
Avoid modifiers which are implied by the context 3 213
Avoid modifiers which are implied by the context 3 220
Avoid modifiers which are implied by the context 3 227
Avoid modifiers which are implied by the context 3 235
Avoid modifiers which are implied by the context 3 244
Avoid modifiers which are implied by the context 3 250

info/magnolia/cms/security/auth/Entity.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 46
Avoid modifiers which are implied by the context 3 48
Avoid modifiers which are implied by the context 3 50
Avoid modifiers which are implied by the context 3 52
Avoid modifiers which are implied by the context 3 54
Avoid modifiers which are implied by the context 3 56
Avoid modifiers which are implied by the context 3 58
Avoid modifiers which are implied by the context 3 64
Avoid modifiers which are implied by the context 3 70
Avoid modifiers which are implied by the context 3 72
Avoid modifiers which are implied by the context 3 77

info/magnolia/cms/security/auth/PrincipalCollection.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 48
Avoid modifiers which are implied by the context 3 50
Avoid modifiers which are implied by the context 3 52
Avoid modifiers which are implied by the context 3 54
Avoid modifiers which are implied by the context 3 56
Avoid modifiers which are implied by the context 3 58
Avoid modifiers which are implied by the context 3 60
Avoid modifiers which are implied by the context 3 62
Avoid modifiers which are implied by the context 3 65
Avoid modifiers which are implied by the context 3 70
Avoid modifiers which are implied by the context 3 75
Avoid modifiers which are implied by the context 3 77

info/magnolia/cms/security/auth/callback/Base64CallbackHandler.java

Violation Priority Line
Useless parentheses. 4 63

info/magnolia/cms/security/auth/login/BasicLogin.java

Violation Priority Line
Avoid unused private fields such as 'log'. 3 50

info/magnolia/cms/security/auth/login/LoginHandler.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 48

info/magnolia/cms/security/operations/ConfiguredOperationPermissionDefinition.java

Violation Priority Line
Ternary operators that can be simplified with || or && 3 131

info/magnolia/cms/security/operations/OperationPermissionDefinition.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 43
Avoid modifiers which are implied by the context 3 44
Avoid modifiers which are implied by the context 3 45
Avoid modifiers which are implied by the context 3 47
Avoid modifiers which are implied by the context 3 48
Avoid modifiers which are implied by the context 3 49
Avoid modifiers which are implied by the context 3 51
Avoid modifiers which are implied by the context 3 53
Avoid modifiers which are implied by the context 3 55
Avoid modifiers which are implied by the context 3 57
Avoid modifiers which are implied by the context 3 59
Avoid modifiers which are implied by the context 3 61
Avoid modifiers which are implied by the context 3 63
Avoid modifiers which are implied by the context 3 65
Avoid modifiers which are implied by the context 3 67
Avoid modifiers which are implied by the context 3 69
Avoid modifiers which are implied by the context 3 71
Avoid modifiers which are implied by the context 3 73

info/magnolia/cms/servlets/ClasspathSpool.java

Violation Priority Line
Avoid empty catch blocks 3 98100

info/magnolia/cms/util/ClasspathResourcesUtil.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 7274
Avoid modifiers which are implied by the context 3 73
Avoid empty catch blocks 3 155157
These nested if statements could be combined 3 276278

info/magnolia/cms/util/ContentUtil.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 134136
Avoid modifiers which are implied by the context 3 141143
Avoid empty catch blocks 3 457459
Avoid empty catch blocks 3 471473
These nested if statements could be combined 3 519522
Useless parentheses. 4 593

info/magnolia/cms/util/DateUtil.java

Violation Priority Line
Useless parentheses. 4 204

info/magnolia/cms/util/DelayedExecutor.java

Violation Priority Line
Useless parentheses. 4 82

info/magnolia/cms/util/DeprecationUtil.java

Violation Priority Line
Useless parentheses. 4 64

info/magnolia/cms/util/InheritanceContentWrapper.java

Violation Priority Line
Avoid unused private fields such as 'log'. 3 76

info/magnolia/cms/util/LazyNodeDataWrapper.java

Violation Priority Line
Useless parentheses. 4 77

info/magnolia/cms/util/NodeDataUtil.java

Violation Priority Line
Useless parentheses. 4 111
Useless parentheses. 4 113
Useless parentheses. 4 115
Useless parentheses. 4 117
Useless parentheses. 4 119
Useless parentheses. 4 122
Useless parentheses. 4 196
Useless parentheses. 4 198
Useless parentheses. 4 200
Useless parentheses. 4 202
Useless parentheses. 4 204
Useless parentheses. 4 206
Useless parentheses. 4 236
Useless parentheses. 4 241

info/magnolia/cms/util/NodeMapWrapper.java

Violation Priority Line
Useless parentheses. 4 247

info/magnolia/cms/util/PathUtil.java

Violation Priority Line
Useless parentheses. 4 46

info/magnolia/cms/util/QueryUtil.java

Violation Priority Line
Unnecessary use of fully qualified name 'javax.jcr.query.Query.JCR_SQL2' due to existing import 'javax.jcr.query.Query' 4 168

info/magnolia/cms/util/RequestDispatchUtil.java

Violation Priority Line
Useless parentheses. 4 129
Useless parentheses. 4 129

info/magnolia/cms/util/SearchReplace.java

Violation Priority Line
Avoid unused local variables such as 'group'. 3 90

info/magnolia/cms/util/ServletUtil.java

Violation Priority Line
Useless parentheses. 4 99
Avoid empty if statements 3 178180
Useless parentheses. 4 178
Useless parentheses. 4 178

info/magnolia/cms/util/UnicodeNormalizer.java

Violation Priority Line
Avoid unused private fields such as 'log'. 3 55

info/magnolia/cms/util/UrlPattern.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 7497

info/magnolia/commands/MgnlCatalog.java

Violation Priority Line
Useless parentheses. 4 75

info/magnolia/commands/chain/ChainBase.java

Violation Priority Line
Avoid unused private fields such as 'log'. 3 51
Avoid empty catch blocks 3 123125
Useless parentheses. 4 129
Useless parentheses. 4 132

info/magnolia/commands/chain/Command.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 45
Avoid modifiers which are implied by the context 3 46
Avoid modifiers which are implied by the context 3 58

info/magnolia/commands/impl/ExportCommand.java

Violation Priority Line
These nested if statements could be combined 3 131133

info/magnolia/commands/impl/VersionCommand.java

Violation Priority Line
Useless parentheses. 4 95
Useless parentheses. 4 136

info/magnolia/content2bean/Bean2ContentProcessor.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 47
Avoid modifiers which are implied by the context 3 49

info/magnolia/content2bean/Bean2ContentTransformer.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 50
Avoid modifiers which are implied by the context 3 55
Avoid modifiers which are implied by the context 3 60
Avoid modifiers which are implied by the context 3 65
Avoid modifiers which are implied by the context 3 70
Avoid modifiers which are implied by the context 3 75
Avoid modifiers which are implied by the context 3 80
Avoid modifiers which are implied by the context 3 85

info/magnolia/content2bean/Content2BeanProcessor.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 5253
Avoid modifiers which are implied by the context 3 58

info/magnolia/content2bean/Content2BeanTransformer.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 54
Avoid modifiers which are implied by the context 3 59
Avoid modifiers which are implied by the context 3 64
Avoid modifiers which are implied by the context 3 69
Avoid modifiers which are implied by the context 3 74
Avoid modifiers which are implied by the context 3 79
Avoid modifiers which are implied by the context 3 84
Avoid modifiers which are implied by the context 3 89
Avoid modifiers which are implied by the context 3 94
Avoid modifiers which are implied by the context 3 101

info/magnolia/content2bean/TransformationState.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 49
Avoid modifiers which are implied by the context 3 51
Avoid modifiers which are implied by the context 3 53
Avoid modifiers which are implied by the context 3 55
Avoid modifiers which are implied by the context 3 57
Avoid modifiers which are implied by the context 3 59
Avoid modifiers which are implied by the context 3 61
Avoid modifiers which are implied by the context 3 63
Avoid modifiers which are implied by the context 3 65
Avoid modifiers which are implied by the context 3 67
Avoid modifiers which are implied by the context 3 69
Avoid modifiers which are implied by the context 3 71
Avoid modifiers which are implied by the context 3 73
Avoid modifiers which are implied by the context 3 78

info/magnolia/content2bean/impl/CollectionPropertyHidingTransformer.java

Violation Priority Line
These nested if statements could be combined 3 98102

info/magnolia/content2bean/impl/Content2BeanTransformerImpl.java

Violation Priority Line
These nested if statements could be combined 3 349354

info/magnolia/content2bean/impl/TypeMappingImpl.java

Violation Priority Line
These nested if statements could be combined 3 141153
These nested if statements could be combined 3 254256

info/magnolia/context/Context.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 59
Avoid modifiers which are implied by the context 3 64
Avoid modifiers which are implied by the context 3 69
Avoid modifiers which are implied by the context 3 71
Avoid modifiers which are implied by the context 3 73
Avoid modifiers which are implied by the context 3 75
Avoid modifiers which are implied by the context 3 77
Avoid modifiers which are implied by the context 3 79
Avoid modifiers which are implied by the context 3 81
Avoid modifiers which are implied by the context 3 83
Avoid modifiers which are implied by the context 3 85
Avoid modifiers which are implied by the context 3 87
Avoid modifiers which are implied by the context 3 94
Avoid modifiers which are implied by the context 3 99
Avoid modifiers which are implied by the context 3 104
Avoid modifiers which are implied by the context 3 106
Avoid modifiers which are implied by the context 3 108
Avoid modifiers which are implied by the context 3 113
Avoid modifiers which are implied by the context 3 115
Avoid modifiers which are implied by the context 3 120
Avoid modifiers which are implied by the context 3 128
Avoid modifiers which are implied by the context 3 137
Avoid modifiers which are implied by the context 3 146
Avoid modifiers which are implied by the context 3 153
Avoid modifiers which are implied by the context 3 158
Avoid modifiers which are implied by the context 3 165
Avoid modifiers which are implied by the context 3 171
Avoid modifiers which are implied by the context 3 179
Avoid modifiers which are implied by the context 3 184

info/magnolia/context/MgnlContext.java

Violation Priority Line
Useless parentheses. 4 376
Avoid modifiers which are implied by the context 3 397399

info/magnolia/context/SingleJCRSessionSystemContext.java

Violation Priority Line
Avoid unused private fields such as 'log'. 3 49

info/magnolia/context/ThreadDependentSystemContext.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 45

info/magnolia/context/WebContext.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 60
Avoid modifiers which are implied by the context 3 68
Avoid modifiers which are implied by the context 3 73
Avoid modifiers which are implied by the context 3 78
Avoid modifiers which are implied by the context 3 90
Avoid modifiers which are implied by the context 3 97
Avoid modifiers which are implied by the context 3 104
Avoid modifiers which are implied by the context 3 109
Avoid modifiers which are implied by the context 3 116
Avoid modifiers which are implied by the context 3 121
Avoid modifiers which are implied by the context 3 138
Avoid modifiers which are implied by the context 3 143
Avoid modifiers which are implied by the context 3 150

info/magnolia/debug/PerformanceTestStatus.java

Violation Priority Line
Useless parentheses. 4 72

info/magnolia/event/SystemEventBus.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 41

info/magnolia/importexport/BootstrapFilesComparator.java

Violation Priority Line
Useless parentheses. 4 73
Useless parentheses. 4 73

info/magnolia/importexport/DataTransporter.java

Violation Priority Line
Useless parentheses. 4 433
Useless parentheses. 4 435

info/magnolia/importexport/PropertiesImportExport.java

Violation Priority Line
Avoid empty if statements 3 143145
Avoid unused method parameters such as 'dumpMetaData'. 3 250
Useless parentheses. 4 288
Useless parentheses. 4 291
Useless parentheses. 4 294
Useless parentheses. 4 297
Useless parentheses. 4 300
Useless parentheses. 4 303
Useless parentheses. 4 306

info/magnolia/importexport/filters/MetadataUuidFilter.java

Violation Priority Line
Useless parentheses. 4 136

info/magnolia/importexport/filters/SkipNodePropertyFilter.java

Violation Priority Line
Useless parentheses. 4 134

info/magnolia/importexport/outputter/DocumentViewOutputter.java

Violation Priority Line
Useless parentheses. 4 113
Useless parentheses. 4 113

info/magnolia/init/DefaultMagnoliaInitPaths.java

Violation Priority Line
Avoid unused constructor parameters such as 'magnoliaServletContextListener'. 3 77

info/magnolia/jackrabbit/ProviderImpl.java

Violation Priority Line
Avoid empty catch blocks 3 214216
Avoid empty catch blocks 3 491493

info/magnolia/jcr/node2bean/impl/CollectionPropertyHidingTransformer.java

Violation Priority Line
These nested if statements could be combined 3 101105

info/magnolia/jcr/node2bean/impl/Node2BeanTransformerImpl.java

Violation Priority Line
These nested if statements could be combined 3 319324
Useless parentheses. 4 526

info/magnolia/jcr/node2bean/impl/TypeMappingImpl.java

Violation Priority Line
These nested if statements could be combined 3 309311

info/magnolia/jcr/nodebuilder/Ops.java

Violation Priority Line
Useless parentheses. 4 202

info/magnolia/jcr/util/ContentMap.java

Violation Priority Line
Avoid empty catch blocks 3 112114
Avoid empty if statements 3 196199
Unnecessary use of fully qualified name 'info.magnolia.link.LinkUtil.convertLinksFromUUIDPattern' due to existing import 'info.magnolia.link.LinkUtil' 4 222
Avoid empty catch blocks 3 236238
Avoid empty catch blocks 3 249251
Avoid empty catch blocks 3 263265
Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map' 4 273

info/magnolia/jcr/util/MetaDataUtil.java

Violation Priority Line
Useless parentheses. 4 80

info/magnolia/jcr/util/NodeNameHelper.java

Violation Priority Line
Useless parentheses. 4 237
Useless parentheses. 4 237
Useless parentheses. 4 237
Useless parentheses. 4 238
Useless parentheses. 4 238
Useless parentheses. 4 238
Useless parentheses. 4 239
Useless parentheses. 4 239
Useless parentheses. 4 239
These nested if statements could be combined 3 261263
Useless parentheses. 4 277

info/magnolia/jcr/util/NodeUtil.java

Violation Priority Line
Useless parentheses. 4 936

info/magnolia/jcr/util/PropertiesImportExport.java

Violation Priority Line
Avoid empty if statements 3 154156
Useless parentheses. 4 261
Useless parentheses. 4 264
Useless parentheses. 4 267
Useless parentheses. 4 270
Useless parentheses. 4 273
Useless parentheses. 4 276
Useless parentheses. 4 279

info/magnolia/jcr/util/PropertyUtil.java

Violation Priority Line
Useless parentheses. 4 93
Useless parentheses. 4 118
Useless parentheses. 4 120
Avoid empty catch blocks 3 191193
Useless parentheses. 4 295
Useless parentheses. 4 297
Useless parentheses. 4 299
Useless parentheses. 4 301
Useless parentheses. 4 303
Useless parentheses. 4 306
Useless parentheses. 4 341
Useless parentheses. 4 491
Useless parentheses. 4 493
Useless parentheses. 4 495
Useless parentheses. 4 497
Useless parentheses. 4 499
Useless parentheses. 4 501
Useless parentheses. 4 503
Useless parentheses. 4 505

info/magnolia/jcr/wrapper/ChannelVisibilityContentDecorator.java

Violation Priority Line
These nested if statements could be combined 3 7690

info/magnolia/jcr/wrapper/DelegateNodeWrapper.java

Violation Priority Line
Useless parentheses. 4 576
Overriding method merely calls super 3 589592

info/magnolia/jcr/wrapper/DelegateSessionWrapper.java

Violation Priority Line
Useless parentheses. 4 341
Overriding method merely calls super 3 354357
Ensure you override both equals() and hashCode() 3 360

info/magnolia/jcr/wrapper/HTMLEscapingPropertyWrapper.java

Violation Priority Line
Avoid unused private fields such as 'transformLineBreaks'. 3 49

info/magnolia/jcr/wrapper/MgnlPropertySettingContentDecorator.java

Violation Priority Line
These nested if statements could be combined 3 209219
Useless parentheses. 4 703

info/magnolia/jcr/wrapper/MgnlPropertySettingNodeWrapper.java

Violation Priority Line
Avoid empty if statements 3 211213

info/magnolia/link/Link.java

Violation Priority Line
Avoid empty catch blocks 3 105107
Avoid empty catch blocks 3 121123
Avoid empty catch blocks 3 123124
Avoid empty catch blocks 3 145147

info/magnolia/link/LinkTransformerManager.java

Violation Priority Line
Avoid unused private fields such as 'log'. 3 53

info/magnolia/link/LinkUtil.java

Violation Priority Line
Avoid empty catch blocks 3 477479

info/magnolia/module/ModuleLifecycleContext.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 49
Avoid modifiers which are implied by the context 3 54
Avoid modifiers which are implied by the context 3 59

info/magnolia/module/ModuleManager.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 9199
Avoid modifiers which are implied by the context 3 104167
These nested if statements could be combined 3 148150
Avoid modifiers which are implied by the context 3 172212

info/magnolia/module/ModuleManagerImpl.java

Violation Priority Line
Useless parentheses. 4 523

info/magnolia/module/ModuleRegistry.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 101109

info/magnolia/module/delta/BootstrapConditionally.java

Violation Priority Line
Useless parentheses. 4 88

info/magnolia/module/delta/ChangeAllPropertiesWithCertainValueTask.java

Violation Priority Line
These nested if statements could be combined 3 106108
These nested if statements could be combined 3 129131

info/magnolia/module/delta/MoveAndRenamePropertyTask.java

Violation Priority Line
Useless parentheses. 4 70

info/magnolia/module/delta/RemoveDuplicatePermissionTask.java

Violation Priority Line
These nested if statements could be combined 3 9195

info/magnolia/module/delta/RenamePropertyTask.java

Violation Priority Line
Avoid unused constructor parameters such as 'name'. 3 43

info/magnolia/module/files/MD5CheckingFileExtractorOperation.java

Violation Priority Line
Avoid empty if statements 3 107109
Avoid empty while statements 3 165166

info/magnolia/module/model/VersionRange.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 183
Avoid modifiers which are implied by the context 3 185207

info/magnolia/module/model/reader/DependencyLevelComparator.java

Violation Priority Line
Useless parentheses. 4 111

info/magnolia/module/model/reader/LightModuleDefinitionReader.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 123

info/magnolia/module/ui/InstallationResourcesServlet.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 74
Avoid modifiers which are implied by the context 3 75

info/magnolia/module/webapp/WebappVersionHandler.java

Violation Priority Line
Useless parentheses. 4 81
Useless parentheses. 4 81

info/magnolia/objectfactory/CandidateParameterResolver.java

Violation Priority Line
Unnecessary use of fully qualified name 'javax.inject.Provider' due to existing import 'javax.inject.Provider' 4 62

info/magnolia/objectfactory/DefaultClassFactory.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 102104

info/magnolia/objectfactory/ObjectManufacturer.java

Violation Priority Line
Useless parentheses. 4 165

info/magnolia/objectfactory/ParameterResolver.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 41

info/magnolia/objectfactory/guice/GuicePropertyConfigurer.java

Violation Priority Line
Avoid empty catch blocks 3 5558

info/magnolia/repository/DefaultRepositoryManager.java

Violation Priority Line
Useless parentheses. 4 171

info/magnolia/repository/RepositoryConstants.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 45
Avoid modifiers which are implied by the context 3 46
Avoid modifiers which are implied by the context 3 47
Avoid modifiers which are implied by the context 3 48
Avoid modifiers which are implied by the context 3 49
Avoid modifiers which are implied by the context 3 50
Avoid modifiers which are implied by the context 3 51
Avoid modifiers which are implied by the context 3 56
Avoid modifiers which are implied by the context 3 57

info/magnolia/repository/RepositoryNotInitializedException.java

Violation Priority Line
Useless parentheses. 4 49

info/magnolia/setup/CoreModule.java

Violation Priority Line
Avoid unused constructor parameters such as 'commandsManager'. 3 56
Avoid unused constructor parameters such as 'virtualURIManager'. 3 56

info/magnolia/setup/CoreModuleVersionHandler.java

Violation Priority Line
Useless parentheses. 4 163
Useless parentheses. 4 174
Useless parentheses. 4 177
Useless parentheses. 4 179
Useless parentheses. 4 182
Useless parentheses. 4 195
Useless parentheses. 4 199
Useless parentheses. 4 202
Useless parentheses. 4 205
Useless parentheses. 4 208
Useless parentheses. 4 221
Useless parentheses. 4 225
Useless parentheses. 4 228
Useless parentheses. 4 232
Useless parentheses. 4 235
Useless parentheses. 4 243

info/magnolia/setup/MigrateVersionWorkspacesToNewStructureTask.java

Violation Priority Line
Avoid empty catch blocks 3 138140

info/magnolia/setup/for4_5/UpdateSecurityFilterClientCallbacksConfiguration.java

Violation Priority Line
Avoid unused method parameters such as 'ctx'. 3 194
Avoid unused method parameters such as 'ctx'. 3 208
Unnecessary use of fully qualified name 'ArrayUtils.contains' due to existing static import 'org.apache.commons.lang3.ArrayUtils.contains' 4 211

info/magnolia/setup/for5_2/IsNotAProblematicEnvironmentCondition.java

Violation Priority Line
Useless parentheses. 4 84
Useless parentheses. 4 84

info/magnolia/setup/initial/LoginAuthTypePropertyMovedToFilter.java

Violation Priority Line
Useless parentheses. 4 48

info/magnolia/stats/JCRStatsMBean.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 40

info/magnolia/voting/Voting.java

Violation Priority Line
Avoid modifiers which are implied by the context 3 47
Avoid modifiers which are implied by the context 3 48
Avoid modifiers which are implied by the context 3 49
Avoid modifiers which are implied by the context 3 5963

info/magnolia/voting/voters/RequestExtensionVoter.java

Violation Priority Line
Useless parentheses. 4 92

info/magnolia/voting/voters/RequestParametersVoter.java

Violation Priority Line
These nested if statements could be combined 3 6167

info/magnolia/voting/voters/RoleBaseVoter.java

Violation Priority Line
Useless parentheses. 4 53