PMD Results
The following document contains the results of PMD 5.1.2.
Files
info/magnolia/ui/form/field/AbstractCustomMultiField.java
Violation |
Line |
Avoid unused constructor parameters such as 'i18nAuthoringSupport'. |
96 |
Avoid unused constructor parameters such as 'i18nContentSupport'. |
107 |
Unnecessary use of fully qualified name 'com.vaadin.data.Property.ValueChangeEvent' due to existing import 'com.vaadin.data.Property' |
214 |
Useless parentheses. |
235 |
info/magnolia/ui/form/field/CompositeField.java
Violation |
Line |
Avoid unused constructor parameters such as 'i18nContentSupport'. |
67 |
info/magnolia/ui/form/field/LinkField.java
Violation |
Line |
Avoid unused constructor parameters such as 'linkFieldDefinition'. |
79 |
Avoid unused constructor parameters such as 'componentProvider'. |
79 |
Avoid unused constructor parameters such as 'componentProvider'. |
84 |
Avoid unused constructor parameters such as 'appController'. |
84 |
Avoid unused constructor parameters such as 'linkFieldDefinition'. |
84 |
Avoid unused constructor parameters such as 'uiContext'. |
84 |
info/magnolia/ui/form/field/MultiField.java
Violation |
Line |
Avoid unused constructor parameters such as 'i18nContentSupport'. |
101 |
Avoid unused private methods such as 'removeValueProperty(int)'. |
272 |
Avoid unused private methods such as 'onDelete(Component,Property)'. |
314 |
Avoid unused private methods such as 'onMove(Component,Property,boolean)'. |
337 |
Useless parentheses. |
354 |
info/magnolia/ui/form/field/PasswordFields.java
Violation |
Line |
Avoid unused constructor parameters such as 'verificationErrorMessage'. |
100 |
Avoid unused constructor parameters such as 'verification'. |
100 |
Avoid unused constructor parameters such as 'verificationMessage'. |
100 |
These nested if statements could be combined |
136–138 |
info/magnolia/ui/form/field/SwitchableField.java
Violation |
Line |
Avoid unused constructor parameters such as 'i18nContentSupport'. |
81 |
info/magnolia/ui/form/field/component/ContentPreviewComponent.java
Violation |
Line |
Avoid modifiers which are implied by the context |
53 |
info/magnolia/ui/form/field/converter/IdentifierToPathConverter.java
Violation |
Line |
Avoid modifiers which are implied by the context |
46 |
info/magnolia/ui/form/field/converter/NonRoundingConverterFactory.java
Violation |
Line |
Avoid unused private methods such as 'amendMaximumFractionDigits(NumberFormat)'. |
81 |
info/magnolia/ui/form/field/factory/AbstractFieldFactory.java
Violation |
Line |
These nested if statements could be combined |
136–139 |
Useless parentheses. |
200 |
Useless parentheses. |
200 |
info/magnolia/ui/form/field/factory/BasicUploadFieldFactory.java
Violation |
Line |
Avoid unused constructor parameters such as 'admincentralEventBus'. |
76 |
info/magnolia/ui/form/field/factory/CompositeFieldFactory.java
Violation |
Line |
Avoid unused constructor parameters such as 'i18nContentSupport'. |
87 |
info/magnolia/ui/form/field/factory/MultiValueFieldFactory.java
Violation |
Line |
Avoid unused constructor parameters such as 'i18nContentSupport'. |
84 |
info/magnolia/ui/form/field/factory/SelectFieldFactory.java
Violation |
Line |
These nested if statements could be combined |
261–263 |
info/magnolia/ui/form/field/factory/SwitchableFieldFactory.java
Violation |
Line |
Avoid unused constructor parameters such as 'i18nContentSupport'. |
106 |
info/magnolia/ui/form/field/transformer/TransformedProperty.java
Violation |
Line |
Useless parentheses. |
78 |
info/magnolia/ui/form/field/transformer/basic/BasicTransformer.java
Violation |
Line |
Useless parentheses. |
166 |
Avoid empty catch blocks |
173–175 |
info/magnolia/ui/form/field/transformer/basic/NotNullInitialStringValueTransformer.java
Violation |
Line |
Useless parentheses. |
61 |
info/magnolia/ui/form/field/transformer/composite/SwitchableTransformer.java
Violation |
Line |
Overriding method merely calls super |
90–92 |
info/magnolia/ui/form/field/transformer/item/FileTransformer.java
Violation |
Line |
These nested if statements could be combined |
175–177 |
info/magnolia/ui/form/field/transformer/multi/DelegatingMultiValueFieldTransformer.java
Violation |
Line |
Avoid unused constructor parameters such as 'i18nContentSupport'. |
94 |
Avoid unused private methods such as 'reorganizeIndex(int)'. |
193 |
info/magnolia/ui/form/field/transformer/multi/MultiTransformer.java
Violation |
Line |
Avoid modifiers which are implied by the context |
52 |
Avoid modifiers which are implied by the context |
59 |
info/magnolia/ui/form/field/upload/UploadField.java
Violation |
Line |
Avoid modifiers which are implied by the context |
45 |
Avoid modifiers which are implied by the context |
51 |
info/magnolia/ui/form/field/upload/UploadProgressIndicator.java
Violation |
Line |
Avoid modifiers which are implied by the context |
46 |
Avoid modifiers which are implied by the context |
51 |
Avoid modifiers which are implied by the context |
56 |
Avoid modifiers which are implied by the context |
61 |
info/magnolia/ui/form/field/upload/basic/BasicUploadField.java
Violation |
Line |
Useless parentheses. |
325 |
info/magnolia/ui/form/field/upload/basic/BasicUploadProgressIndicator.java
Violation |
Line |
Useless parentheses. |
153 |
info/magnolia/ui/form/validator/registry/FieldValidatorFactoryFactory.java
Violation |
Line |
Unnecessary use of fully qualified name 'info.magnolia.ui.form.validator.factory.FieldValidatorFactory' due to existing import 'info.magnolia.ui.form.validator.factory.FieldValidatorFactory' |
66 |